cenarium [Tue, 20 Sep 2016 17:21:36 +0000 (19:21 +0200)]
Support multiple limits and arbitrary periods in account creation throttle
This adds support for multiple count-per-period limits and arbitrary
period durations in the AuthManager account creation throttle in the
wiki settings. The $wgAccountCreationThrottle config variable becomes
an array like $wgPasswordAttemptThrottle.
Bug: T146290
Change-Id: Iea182a92a1199b0ce7103ab9ae24f1c87b01985c
Kunal Mehta [Wed, 21 Sep 2016 08:25:06 +0000 (01:25 -0700)]
Fix @return of LBFactorySimple::getExternalLB()
Change-Id: If5353af7c4ec3781597159c12481444159c463f3
jenkins-bot [Wed, 21 Sep 2016 08:21:38 +0000 (08:21 +0000)]
Merge "ChronologyProtector: Remove unused 'use MediaWiki\Logger\LoggerFactory'"
jenkins-bot [Wed, 21 Sep 2016 08:08:27 +0000 (08:08 +0000)]
Merge "Use getConnectionRef() in ExternalStoreDB to avoid connection leaks"
Kunal Mehta [Wed, 21 Sep 2016 08:02:09 +0000 (01:02 -0700)]
ChronologyProtector: Remove unused 'use MediaWiki\Logger\LoggerFactory'
Change-Id: I54a0d17605d3bc25c1d78a3a606e371fa74eaab0
Aaron Schulz [Wed, 21 Sep 2016 07:58:14 +0000 (00:58 -0700)]
Use getConnectionRef() in ExternalStoreDB to avoid connection leaks
Change-Id: I3df270241653841a4fb2f65e240aae9d2e0b650f
Aaron Schulz [Wed, 21 Sep 2016 07:34:23 +0000 (00:34 -0700)]
Add some missing reuseConnection() to LoadBalancer
Change-Id: I99099f909e7759c061d44ad4e1ed049e038a4d7d
Kunal Mehta [Wed, 21 Sep 2016 06:10:54 +0000 (23:10 -0700)]
MultiHttpClient: Don't use wfArrayToCgi()
http_build_query() should be functionally identical.
Change-Id: Ia7d909e97a89d66dbe5187e9a0423e2ecf8561e8
Kunal Mehta [Wed, 21 Sep 2016 06:00:54 +0000 (23:00 -0700)]
Avoid Wikimedia\Assert in HashBagOStuff
This is the only usage of wikimedia/assert in the planned objectcache
library, so it doesn't make much sense to have a dependency upon the
entire library just for one usage that is trivially replaced.
Change-Id: I8f967fb2b861852c7fc74f7d42e2cbab1df05bc4
jenkins-bot [Wed, 21 Sep 2016 04:45:04 +0000 (04:45 +0000)]
Merge "Fix importation of weird file names in importTextFiles.php"
This, that and the other [Fri, 12 Aug 2016 01:17:02 +0000 (11:17 +1000)]
Fix importation of weird file names in importTextFiles.php
When importing a file whose name contains a #, the script would call
e.g. Title::newFromText( '#foo' ), which succeeds (because titles
are allowed to contain fragments) but causes problems when trying
to create the revision.
Also avoid fatals on actual invalid titles.
Bug: T142675
Change-Id: I6b4c8fd8dd09db14c0704c74137e112b292c964a
jenkins-bot [Wed, 21 Sep 2016 03:57:31 +0000 (03:57 +0000)]
Merge "Move XMP* classes to includes/libs"
jenkins-bot [Wed, 21 Sep 2016 03:53:37 +0000 (03:53 +0000)]
Merge "XMPValidate: Use ConvertibleTimestamp instead of wfTimestamp()"
jenkins-bot [Wed, 21 Sep 2016 03:36:23 +0000 (03:36 +0000)]
Merge "mediawiki.requestIdleCallback: Avoid native window.requestIdleCallback"
Kunal Mehta [Wed, 21 Sep 2016 03:20:10 +0000 (20:20 -0700)]
Move XMP* classes to includes/libs
These no longer have any dependencies upon MediaWiki and can be split
out into a separate library.
Tests were updated for the new location and to no longer depend upon
MediaWikiTestCase.
Bug: T100922
Change-Id: I6ad507fa883d5934b807f9e31c507659d0730b52
Kunal Mehta [Wed, 21 Sep 2016 03:09:03 +0000 (20:09 -0700)]
XMPValidate: Use ConvertibleTimestamp instead of wfTimestamp()
This removes the last MediaWiki dependency in the XMP* classes, and they
can now be moved to libs/ (in a follow up patch).
Change-Id: Iee509fce0e44ec0697e1cdd4cd711846cf35e1e6
jenkins-bot [Wed, 21 Sep 2016 01:37:43 +0000 (01:37 +0000)]
Merge "Toolbox: Mark RecentChangesLinked link as nofollow"
jenkins-bot [Wed, 21 Sep 2016 01:22:21 +0000 (01:22 +0000)]
Merge "Improve lag/flag behavior and docs in LoadBalancer"
James D. Forrester [Wed, 21 Sep 2016 00:45:31 +0000 (17:45 -0700)]
Toolbox: Mark RecentChangesLinked link as nofollow
Bug: T146233
Change-Id: I2dd0b3a179dc0d1d7210d98748f45e75f953d2bf
jenkins-bot [Wed, 21 Sep 2016 00:19:11 +0000 (00:19 +0000)]
Merge "Use Status::isOK() method in FileDeleteForm"
jenkins-bot [Wed, 21 Sep 2016 00:04:56 +0000 (00:04 +0000)]
Merge "jsduck: Remove custom @source tag"
Aaron Schulz [Tue, 20 Sep 2016 19:57:50 +0000 (12:57 -0700)]
Improve lag/flag behavior and docs in LoadBalancer
* Set DBO_DEFAULT if "flags" is not set. MediaWiki config bootstrapping
does this, but for outside users, it should still be the default too.
* Make "is static" do more than no-oping DatabaseMysqlBase::masterPosWait().
It now also treats servers with this flag as having 0 lag at all times.
This makes it far more useful, as the point of the flag is to mark DBs
that are archival clones of each other and may not even replicate.
* Add more ILoadBalancer usage documentation.
Change-Id: Ib0b44e42e9f4c57a292d6a6ea17beb454db464bc
jenkins-bot [Tue, 20 Sep 2016 23:51:30 +0000 (23:51 +0000)]
Merge "Mention the lock name in DatabaseMysqlBase lock() errors"
jenkins-bot [Tue, 20 Sep 2016 23:50:01 +0000 (23:50 +0000)]
Merge "Remove Database clone call from DatabaseTests.php"
Timo Tijhof [Tue, 20 Sep 2016 23:44:39 +0000 (00:44 +0100)]
jsduck: Remove custom @source tag
Only used in external.js to render a simple link. These methods
don't have a regular description and as such the link renders
effectively the same way in the same place without `@source`.
Change-Id: I83cd524b6b53e67c5c2d18258c804ebd49a29b74
Aaron Schulz [Tue, 20 Sep 2016 23:34:09 +0000 (16:34 -0700)]
Mention the lock name in DatabaseMysqlBase lock() errors
Also use warning() instead of debug()
Change-Id: I9f5b331072caf29985bfb4319786cc2c5cddf5dd
Timo Tijhof [Tue, 20 Sep 2016 23:01:16 +0000 (00:01 +0100)]
mediawiki.requestIdleCallback: Avoid native window.requestIdleCallback
Follows-up
482ad8d9fb.
This currently has bugs in Chrome that can cause it to not get called
for up to 30 seconds.
https://bugs.chromium.org/p/chromium/issues/detail?id=647870
Change-Id: I221cd6c2bcdbee89bc7401c071f2ab1865a738ed
Aaron Schulz [Tue, 20 Sep 2016 23:24:16 +0000 (16:24 -0700)]
Remove Database clone call from DatabaseTests.php
Change-Id: I60a22de9ccc7253abc9bbefe2a4f38675655ee4f
jenkins-bot [Tue, 20 Sep 2016 23:21:30 +0000 (23:21 +0000)]
Merge "FSFile and TempFSFile cleanups"
jenkins-bot [Tue, 20 Sep 2016 23:17:08 +0000 (23:17 +0000)]
Merge "Move some FileBackend related classes to /libs"
Aaron Schulz [Tue, 20 Sep 2016 22:57:35 +0000 (15:57 -0700)]
Use Status::isOK() method in FileDeleteForm
Change-Id: I3c21ee1f0ecc4077772ddba6e740a67ed143ece0
jenkins-bot [Tue, 20 Sep 2016 22:53:47 +0000 (22:53 +0000)]
Merge "Only send DB query profiling to MWDebug::query"
jenkins-bot [Tue, 20 Sep 2016 22:45:17 +0000 (22:45 +0000)]
Merge "Avoid TransactionProfiler notices for TEMPORARY table writes"
Aaron Schulz [Tue, 20 Sep 2016 22:42:00 +0000 (15:42 -0700)]
Only send DB query profiling to MWDebug::query
This should avoid massive dberror log spam in jenkins.
Change-Id: Ifa60843e78b99921768e7a62109c505ff9330e41
This, that and the other [Sun, 7 Aug 2016 06:12:52 +0000 (16:12 +1000)]
Add GENDER support to email and user rights toolbox links
Also rephrasing the "User rights management" link to an action-based
phrase, using the more correct term "user groups" rather than "user
rights".
I filed T142322 about the inconsistent use of terminology in regards to
Special:UserRights.
Bug: T142316
Change-Id: I43c3fbe55e0065eee23294738745aa69d3f05202
jenkins-bot [Tue, 20 Sep 2016 22:24:03 +0000 (22:24 +0000)]
Merge "Improve Database::__destruct() and add a __clone() method too"
jenkins-bot [Tue, 20 Sep 2016 22:10:07 +0000 (22:10 +0000)]
Merge "Remove OutputPage->mDebugtext"
jenkins-bot [Tue, 20 Sep 2016 22:09:28 +0000 (22:09 +0000)]
Merge "Fix variable name in release notes"
jenkins-bot [Tue, 20 Sep 2016 22:08:04 +0000 (22:08 +0000)]
Merge "Emit deprecation warnings from Article::fetchContent"
Aaron Schulz [Tue, 20 Sep 2016 16:17:14 +0000 (09:17 -0700)]
Improve Database::__destruct() and add a __clone() method too
* Close dangling connections in LoadBalancer/Database destructors.
* When DBs are cloned, create new connection resources for the clone
so the two do Database objects don't clobber each other.
Change-Id: I3adb57cbb1fdc2a17e6d95389d0562ef22701576
Max Semenik [Tue, 20 Sep 2016 22:00:05 +0000 (15:00 -0700)]
Fix variable name in release notes
Change-Id: I7da512f4aa68c80dd08d93910888be1b49783912
Max Semenik [Tue, 20 Sep 2016 21:58:04 +0000 (14:58 -0700)]
Remove OutputPage->mDebugtext
Deprecated since 1.20, unused anywhere.
Change-Id: I4316b77c48e65faf788de60be28fc9cf65c785f1
Brad Jorsch [Tue, 20 Sep 2016 20:25:29 +0000 (16:25 -0400)]
API: Remove deprecated methods
All deprecated ApiResult methods are removed. These have been deprecated
since 1.24 or 1.25, and the only users remaining in Gerrit are wrapped
in backwards-compatibility checks and so should not be being called.
ApiBase, ApiFormatBase, ApiMain, and ApiQuery methods for generating the
pre-Ib14c00df help text are removed. Nothing has called these for a long
time, and only Flow implemented them in any way. Deprecated methods for
providing the text for such help, such as getDescription(), haven't been
removed yet, though, since some extensions still call some of them.
Change-Id: I3ca7c98174b4a3f6f67f2b023e0f4446637e7a84
jenkins-bot [Tue, 20 Sep 2016 20:30:36 +0000 (20:30 +0000)]
Merge "Pass User to SearchEngine::getProfiles"
dcausse [Tue, 20 Sep 2016 10:07:35 +0000 (12:07 +0200)]
Pass User to SearchEngine::getProfiles
Useful for search engines that allow users to customize search profiles.
Depends-On: Icd577c8ebc6e162befe30bde4fe276e633d2e434
Change-Id: I471cd090730d2a25cb70d622ec3bebbe9583118c
Translation updater bot [Tue, 20 Sep 2016 19:54:52 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I83c8f60a9022018fae1996910242f4514cf8cd3f
jenkins-bot [Tue, 20 Sep 2016 19:27:55 +0000 (19:27 +0000)]
Merge "Fix minor SqliteInstaller IDEA warning"
jenkins-bot [Tue, 20 Sep 2016 19:23:12 +0000 (19:23 +0000)]
Merge "Set an initial dummy domain in Database::__construct()"
jenkins-bot [Tue, 20 Sep 2016 18:58:22 +0000 (18:58 +0000)]
Merge "Deprecfate WikiRevision::getText"
jenkins-bot [Tue, 20 Sep 2016 18:51:42 +0000 (18:51 +0000)]
Merge "Clean up redundant defaults in Database::__construct()"
Aaron Schulz [Tue, 20 Sep 2016 18:28:51 +0000 (11:28 -0700)]
Clean up redundant defaults in Database::__construct()
* This are already (or now) managed by Database::factory().
* Also remove unused "foreign" parameter.
Change-Id: I9161b9f158b656fd10b1506ecb82bf42ab94ea43
jenkins-bot [Tue, 20 Sep 2016 18:25:20 +0000 (18:25 +0000)]
Merge "Fix IDEA Ultimate warnings in ChangeTags"
Aaron Schulz [Tue, 20 Sep 2016 18:12:26 +0000 (11:12 -0700)]
Fix IDEA Ultimate warnings in ChangeTags
Change-Id: Ie0778e5e32be81bda246d231526630db700b8538
Aaron Schulz [Tue, 20 Sep 2016 18:06:59 +0000 (11:06 -0700)]
Add debugging logging to LoadBalancer connection closes
This matches the logging used for opening new connections and can be
useful for seeing connection leakage.
Change-Id: I8d24d059062f3b698e64751b46542eb1fa78bb36
Aaron Schulz [Tue, 20 Sep 2016 15:15:39 +0000 (08:15 -0700)]
Set an initial dummy domain in Database::__construct()
This avoids errors when LoadBalancer calls getWikiId() in
reallyOpenConnection() after a failed connection.
Change-Id: Idc3d93ae39be09f2da277df57cdc5a564cb3408d
jenkins-bot [Tue, 20 Sep 2016 17:54:42 +0000 (17:54 +0000)]
Merge "Improve tableExists() for MySQL"
Aaron Schulz [Tue, 20 Sep 2016 17:30:00 +0000 (10:30 -0700)]
Improve tableExists() for MySQL
Use SHOW TABLES to avoid log spam when the table does not exist.
This should make the CLI jenkins log a bit more readable.
Change-Id: I027a9d0af0e42959e9f03cebb295218068a263d3
daniel [Tue, 20 Sep 2016 16:57:49 +0000 (18:57 +0200)]
Emit deprecation warnings from Article::fetchContent
Bug: T145734
Change-Id: Ia70dedc729fc4724b773a29d8789ace344ae0df9
jenkins-bot [Tue, 20 Sep 2016 16:38:11 +0000 (16:38 +0000)]
Merge "Extract replacePrefixes into a static method"
daniel [Tue, 20 Sep 2016 16:35:26 +0000 (18:35 +0200)]
Deprecfate WikiRevision::getText
Bug: T146162
Change-Id: I60249d687ac74baca146ed28d57c9a8ebcd79fba
jenkins-bot [Tue, 20 Sep 2016 13:56:21 +0000 (13:56 +0000)]
Merge "WikiPage::getDeletionUpdates returns DeferrableUpdates"
jenkins-bot [Tue, 20 Sep 2016 13:54:09 +0000 (13:54 +0000)]
Merge "phpdoc Title::inNamespaces also allows array"
addshore [Tue, 20 Sep 2016 12:34:14 +0000 (13:34 +0100)]
phpdoc Title::inNamespaces also allows array
Change-Id: I201dbaf9c0dee5b47c4edde73ff68b88560e8a0f
addshore [Tue, 20 Sep 2016 12:09:09 +0000 (13:09 +0100)]
WikiPage::getDeletionUpdates returns DeferrableUpdates
This means the hook also only needs to add
DeferrableUpdate object rather than DataUpdate objects
Change-Id: Ic19c93860aa364d4e1b69a20ed6bbcd61f6f4979
jenkins-bot [Tue, 20 Sep 2016 08:26:06 +0000 (08:26 +0000)]
Merge "Replace $wiki with $domain in ILoadBalancer"
jenkins-bot [Tue, 20 Sep 2016 08:10:56 +0000 (08:10 +0000)]
Merge "Make rebuildFileCache cover ?action=history"
Aaron Schulz [Wed, 14 Sep 2016 20:36:34 +0000 (13:36 -0700)]
Make rebuildFileCache cover ?action=history
Also simplified the logic slightly
Change-Id: I6145d52b6b701735fa4bd8e41e07fb2bf6fdcee3
Aaron Schulz [Tue, 20 Sep 2016 07:32:06 +0000 (00:32 -0700)]
Replace $wiki with $domain in ILoadBalancer
Change-Id: I1752d3358a8fc4314dfd497f3e08d3d5a6bfdd39
jenkins-bot [Tue, 20 Sep 2016 06:43:04 +0000 (06:43 +0000)]
Merge "Include setTableAliases/setDomainPrefix in ILoadBalancer"
jenkins-bot [Tue, 20 Sep 2016 06:41:32 +0000 (06:41 +0000)]
Merge "Database class parameter and documentation cleanups"
Aaron Schulz [Tue, 20 Sep 2016 06:33:30 +0000 (23:33 -0700)]
Include setTableAliases/setDomainPrefix in ILoadBalancer
Also remove redundant LoadBalancer documentation.
Change-Id: Ib9a678349cf850f1cec498a8534e546bf9f41386
Aaron Schulz [Mon, 19 Sep 2016 23:34:32 +0000 (16:34 -0700)]
Database class parameter and documentation cleanups
* Document various parameter arrays.
* Fix $user = false loophole in Database::__construct().
* Set the Postgres port *before* calling super, as it is
needed by open().
* Remove 'chronProt' parameter as it is lazy-loaded.
Change-Id: Icc1037efa1eee7ae6fdd2919f60001e6e29ae55c
jenkins-bot [Tue, 20 Sep 2016 00:51:35 +0000 (00:51 +0000)]
Merge "mediawiki.UI: Make colors' contrast compliant to WCAG 2.0 level AA"
Aaron Schulz [Mon, 19 Sep 2016 21:15:05 +0000 (14:15 -0700)]
Avoid TransactionProfiler notices for TEMPORARY table writes
* Make Database detect and track temporary tables for the session.
Creating, dropping, and updating them do not count as "write" queries.
Even a read-only mysql slave can have these operations performed on it
and it can be useful for complex read queries that need temporary results.
* Rename handleTransactionLoss() to handleSessionLoss() and cover named locks too.
Bug: T145947
Change-Id: I826439e9e9f550f32a9c46b3dd60e8e8015aa274
jenkins-bot [Mon, 19 Sep 2016 23:49:02 +0000 (23:49 +0000)]
Merge "Fix undefined getDelimiter() call in sql.php"
Aaron Schulz [Mon, 19 Sep 2016 20:00:19 +0000 (13:00 -0700)]
Change DatabaseBase::factory call to Database::factory in LoadBalancer
Change-Id: Id4bbc08b5aa913e2e3e47a7873db600fe957c985
jenkins-bot [Mon, 19 Sep 2016 22:40:18 +0000 (22:40 +0000)]
Merge "Remove unused DatabaseBase::debug() method"
jenkins-bot [Mon, 19 Sep 2016 22:32:26 +0000 (22:32 +0000)]
Merge "Fix broken $wgExternalServers example setting"
Aaron Schulz [Mon, 19 Sep 2016 21:17:19 +0000 (14:17 -0700)]
Fix undefined getDelimiter() call in sql.php
* Fixes regression from
4ef4438739.
* Also fixed numerous IDEA warnings.
Change-Id: Id41faff835ca25399ce1ceb10a19d19ffc914689
jenkins-bot [Mon, 19 Sep 2016 22:23:51 +0000 (22:23 +0000)]
Merge "Fix "externalCluster" LBFactorySimple setting in LBFactoryMW"
Aaron Schulz [Mon, 19 Sep 2016 22:16:29 +0000 (15:16 -0700)]
Fix broken $wgExternalServers example setting
Just reference $wgDBservers instead, which uses the same format.
Change-Id: Iaa32cb067f9487b459925310ac4c52efe3f4a3f1
Aaron Schulz [Mon, 19 Sep 2016 22:13:43 +0000 (15:13 -0700)]
Fix "externalCluster" LBFactorySimple setting in LBFactoryMW
Fixes regression from
d175b391ae2a
Change-Id: I4bbc875e2fcd021e342959a37475ec356cb58cce
Volker E [Fri, 15 Jan 2016 03:07:10 +0000 (19:07 -0800)]
mediawiki.UI: Make colors' contrast compliant to WCAG 2.0 level AA
Establishing Web Accessibility Guidelines level AA color contrast
compliance by aligning to improved color palette, similar to
I6fdb90af8b9dc5e5e026eb0c1bd13138c73da4cd
Bug: T109915
Change-Id: I191f8ec731eeef0827124741200c51cb42ba99f8
Aaron Schulz [Mon, 19 Sep 2016 17:37:57 +0000 (10:37 -0700)]
Move DatabasePostgres to /libs/rdbms
Fixed all IDEA warnings in the postgres classes too.
Change-Id: I06b4c5b2c581fb65552d980cc106aa10fed40285
Aaron Schulz [Mon, 19 Sep 2016 21:25:35 +0000 (14:25 -0700)]
Remove unused DatabaseBase::debug() method
This just trivially wrapped getFlags()/setFlags() anyway
Change-Id: Iab5b508f6746098b66da00c8bf038215cb2359ef
jenkins-bot [Mon, 19 Sep 2016 20:21:16 +0000 (20:21 +0000)]
Merge "Remove strictIPs(), cascadingDeletes(), and cleanupTriggers()"
L10n-bot [Mon, 19 Sep 2016 20:17:20 +0000 (20:17 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Aaron Schulz [Fri, 16 Sep 2016 05:37:29 +0000 (22:37 -0700)]
Remove strictIPs(), cascadingDeletes(), and cleanupTriggers()
These DatabaseBase methods have no callers are were a mistake to
begin with. They only encouraged code forking and incompatibilities
among different backing DB types.
Also removed stray realTimestamps() method that was left over
from prior removals.
Change-Id: I37bef8585151e2782d2c88b5ae1e6752109c6ac7
Translation updater bot [Mon, 19 Sep 2016 20:06:14 +0000 (22:06 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ia226031f53b3b32abf5cec62bda2c90548ee940b
jenkins-bot [Mon, 19 Sep 2016 20:04:28 +0000 (20:04 +0000)]
Merge "Fix SQLite $wgObjectCaches definition + b/c handling"
Aaron Schulz [Mon, 19 Sep 2016 00:22:36 +0000 (17:22 -0700)]
FSFile and TempFSFile cleanups
* Remove wf* function dependencies. This includes wfTempDir().
Callers now should specify the directory, though it will try to do
most of the wfTempDir() logic anyway if they do not.
* Update callers to inject wfTempDir() so $wgTmpDirectory is used by
TempFSFile instead of it probing to find a valid directory itself.
* Move most of the wfTempDir() logic to TempFSFile::getUsableTempDirectory().
* Remove unused getMimeType() method.
Change-Id: Idd55936b07f9448a6c90577708722b7b52b8fe66
Marius Hoch [Mon, 19 Sep 2016 19:01:56 +0000 (21:01 +0200)]
Fix SQLite $wgObjectCaches definition + b/c handling
Follow-up to
47e816c69c197fec86c344256d81d7c8f781b880
Change-Id: Id94857a7c8726871cf826a34b5cf10cb465b7125
jenkins-bot [Mon, 19 Sep 2016 19:40:17 +0000 (19:40 +0000)]
Merge "Clarify comment in traditional gallery"
jenkins-bot [Mon, 19 Sep 2016 19:31:44 +0000 (19:31 +0000)]
Merge "Avoid using cascadingDeletes()/cleanupTriggers()"
Arlo Breault [Mon, 19 Sep 2016 19:23:50 +0000 (12:23 -0700)]
Clarify comment in traditional gallery
Change-Id: I13aa2132d64a1dca8a5ab867fdffc48aca2cf9d1
jenkins-bot [Mon, 19 Sep 2016 19:02:04 +0000 (19:02 +0000)]
Merge "Avoid calling awful DatabaseBase::strictIPs() method"
jenkins-bot [Mon, 19 Sep 2016 18:32:09 +0000 (18:32 +0000)]
Merge "Fix SqliteInstaller DatabaseSqlite creation"
Marius Hoch [Mon, 19 Sep 2016 18:11:33 +0000 (20:11 +0200)]
Fix SqliteInstaller DatabaseSqlite creation
Follow-up to
47e816c69c197fec86c344256d81d7c8f781b880
Change-Id: I1612b0a187ea1df272bdd304ffb2bafbc006b2e4
Aaron Schulz [Mon, 19 Sep 2016 18:19:04 +0000 (11:19 -0700)]
Fix minor SqliteInstaller IDEA warning
Change-Id: I13f6adebf436c40c3c8555fd2fe95db161ab1a8b
Aaron Schulz [Mon, 19 Sep 2016 17:55:07 +0000 (10:55 -0700)]
Fix "MWExceptionRenderer::getText() should not be called statically" errors
Change-Id: Icfb65795b1455217ca9bc2c1f7cd453144ad5106