From: Fomafix <fomafix@googlemail.com>
Date: Mon, 8 Apr 2019 16:41:45 +0000 (+0200)
Subject: Fix IE conditional comment
X-Git-Tag: 1.34.0-rc.0~2098^2
X-Git-Url: https://git.cyclocoop.org/%7B%7B%20url_for%28%27user%27%2C%20userid=session.user.id%29%20%7D%7D?a=commitdiff_plain;h=f8ffc44c98b17f281463752cee5ed92c83cbb187;p=lhc%2Fweb%2Fwiklou.git

Fix IE conditional comment

47422fabe2813fb12b7663257924fdf4cd7cd0d1 broke the IE conditional
comment. This is change restores them.

Change-Id: I397434e9c23506080fe5507b29c2cc48e2f078c7
---

diff --git a/includes/OutputPage.php b/includes/OutputPage.php
index cb3f1ad203..b0000ab027 100644
--- a/includes/OutputPage.php
+++ b/includes/OutputPage.php
@@ -3223,7 +3223,10 @@ class OutputPage extends ContextSource {
 		// Use an IE conditional comment to serve the script only to old IE
 		$pieces[] = '<!--[if lt IE 9]>' .
 			ResourceLoaderClientHtml::makeLoad(
-				ResourceLoaderContext::newDummyContext(),
+				new ResourceLoaderContext(
+					$this->getResourceLoader(),
+					new FauxRequest( [] )
+				),
 				[ 'html5shiv' ],
 				ResourceLoaderModule::TYPE_SCRIPTS,
 				[ 'sync' => true ],
diff --git a/includes/resourceloader/ResourceLoaderContext.php b/includes/resourceloader/ResourceLoaderContext.php
index f11f294f9b..372d12dd85 100644
--- a/includes/resourceloader/ResourceLoaderContext.php
+++ b/includes/resourceloader/ResourceLoaderContext.php
@@ -132,7 +132,6 @@ class ResourceLoaderContext implements MessageLocalizer {
 	 * things that don't "really" need a context.
 	 *
 	 * Use cases:
-	 * - Creating html5shiv script tag in OutputPage.
 	 * - Unit tests (deprecated, create empty instance directly or use RLTestCase).
 	 *
 	 * @return ResourceLoaderContext