Merge "Update OOUI to v0.33.0"

diff --combined RELEASE-NOTES-1.34
index 0d9bf9a,99c8d4b..fdc9e05
--- 1/RELEASE-NOTES-1.34
--- 2/RELEASE-NOTES-1.34
+++ b/RELEASE-NOTES-1.34
@@@ -74,7 -74,7 +74,7 @@@ For notes on 1.33.x and older releases
  
  ==== Changed external libraries ====
  * Updated Mustache from 1.0.0 to v3.0.1.
- * Updated OOUI from v0.31.3 to v0.32.1.
+ * Updated OOUI from v0.31.3 to v0.33.0.
  * Updated composer/semver from 1.4.2 to 1.5.0.
  * Updated composer/spdx-licenses from 1.4.0 to 1.5.1 (dev-only).
  * Updated mediawiki/codesniffer from 25.0.0 to 26.0.0 (dev-only).
@@@ -247,11 -247,6 +247,11 @@@ because of Phabricator reports
    Use MediaWiki\Session\SessionManager instead.
  * The wfGetLBFactory global function, deprecated in 1.27, has been removed.
    Use MediaWikiServices::getInstance()->getDBLoadBalancerFactory().
 +* The internal method OutputPage->addScriptFile() will no longer silently drop
 +  calls that use an invalid path (i.e., something other than an absolute path,
 +  protocol-relative URL, or full scheme URL), and will instead pass them to the
 +  client where they will likely 404. This usage was deprecated in 1.24.
 +* Database::reportConnectionError, deprecated in 1.32, has been removed.
  * …
  
  === Deprecations in 1.34 ===
@@@ -313,20 -308,6 +313,20 @@@
    instead.
  * Sanitizer::attributeWhitelist() and Sanitizer::setupAttributeWhitelist()
    have been deprecated; they will be made private in the future.
 +* SearchResult::termMatches() method is deprecated. It was unreliable because
 +  only populated by few search engine implementations. Use
 +  SqlSearchResult::getTermMatches() if really needed.
 +* SearchResult::getTextSnippet( $terms ) the $terms param is being deprecated
 +  and should no longer be passed. Search engine implemenations should be
 +  responsible for carrying relevant information needed for highlighting with
 +  their own SearchResultSet/SearchResult sub-classes.
 +* SearchEngine::$searchTerms protected field is deprecated. Moved to
 +  SearchDatabase.
 +* The use of the $terms param in the ShowSearchHit and ShowSearchHitTitle
 +  hooks is highly discouraged as it's only populated by SearchDatabase search
 +  engines.
 +* Skin::escapeSearchLink() is deprecated. Use Skin::getSearchLink() or the skin
 +  template option 'searchaction' instead.
  
  === Other changes in 1.34 ===
  * …

diff --combined includes/OutputPage.php
index e0ca258,6efe2d4..ad375fa
--- 1/includes/OutputPage.php
--- 2/includes/OutputPage.php
+++ b/includes/OutputPage.php
@@@ -459,6 -459,13 +459,6 @@@ class OutputPage extends ContextSource 
         * @param string|null $unused Previously used to change the cache-busting query parameter
         */
        public function addScriptFile( $file, $unused = null ) {
 -              if ( substr( $file, 0, 1 ) !== '/' && !preg_match( '#^[a-z]*://#i', $file ) ) {
 -                      // This is not an absolute path, protocol-relative url, or full scheme url,
 -                      // presumed to be an old call intended to include a file from /w/skins/common,
 -                      // which doesn't exist anymore as of MediaWiki 1.24 per T71277. Ignore.
 -                      wfDeprecated( __METHOD__, '1.24' );
 -                      return;
 -              }
                $this->addScript( Html::linkedScript( $file, $this->getCSPNonce() ) );
        }
  
@@@ -4033,7 -4040,6 +4033,6 @@@
                $this->addModuleStyles( [
                        'oojs-ui-core.styles',
                        'oojs-ui.styles.indicators',
-                       'oojs-ui.styles.textures',
                        'mediawiki.widgets.styles',
                        'oojs-ui-core.icons',
                ] );

diff --combined resources/Resources.php
index 4446d0d,41c36ad..b228b96
--- 1/resources/Resources.php
--- 2/resources/Resources.php
+++ b/resources/Resources.php
@@@ -2825,6 -2825,7 +2825,6 @@@ return 
                'scripts' => [
                        'resources/lib/html5shiv/html5shiv.js'
                ],
 -              'raw' => true,
        ],
  
        /* EasyDeflate */
@@@ -2901,7 -2902,6 +2901,6 @@@
                        'oojs-ui-core.styles',
                        'oojs-ui-core.icons',
                        'oojs-ui.styles.indicators',
-                       'oojs-ui.styles.textures',
                        'mediawiki.language',
                ],
                'messages' => [
@@@ -3011,10 -3011,6 +3010,6 @@@
                'class' => ResourceLoaderOOUIImageModule::class,
                'themeImages' => 'indicators',
        ],
-       'oojs-ui.styles.textures' => [
-               'class' => ResourceLoaderOOUIImageModule::class,
-               'themeImages' => 'textures',
-       ],
        'oojs-ui.styles.icons-accessibility' => [
                'class' => ResourceLoaderOOUIImageModule::class,
                'themeImages' => 'icons-accessibility',