The second removal also didn't remove the right thing.
Change-Id: Iab32ae2e19e2b19995b88fbfd2e84a36dbda1bac
*/
mw.rcfilters.ui.SavedLinksListWidget.prototype.onMenuItemRemove = function ( item ) {
this.controller.removeSavedQuery( item.getID() );
- this.menu.removeItems( [ item ] );
};
/**
* @param {mw.rcfilters.ui.SavedLinksListItemWidget} item Menu item
*/
mw.rcfilters.ui.SavedLinksListWidget.prototype.onModelRemoveItem = function ( item ) {
- this.menu.removeItems( [ this.model.getItemByID( item.getID() ) ] );
+ this.menu.removeItems( [ this.menu.getItemFromData( item.getID() ) ] );
this.button.toggle( !this.menu.isEmpty() );
};
}( mediaWiki ) );