Merge "Fix undefined $ok in DatabaseUpdater::migrateComments"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Fri, 2 Mar 2018 16:36:26 +0000 (16:36 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Fri, 2 Mar 2018 16:36:26 +0000 (16:36 +0000)
1  2 
includes/installer/DatabaseUpdater.php

@@@ -1047,7 -1047,7 +1047,7 @@@ abstract class DatabaseUpdater 
         * Sets the number of active users in the site_stats table
         */
        protected function doActiveUsersInit() {
 -              $activeUsers = $this->db->selectField( 'site_stats', 'ss_active_users', false, __METHOD__ );
 +              $activeUsers = $this->db->selectField( 'site_stats', 'ss_active_users', '', __METHOD__ );
                if ( $activeUsers == -1 ) {
                        $activeUsers = $this->db->selectField( 'recentchanges',
                                'COUNT( DISTINCT rc_user_text )',
                                "maintenance/migrateComments.php.\n"
                        );
                        $task = $this->maintenance->runChild( MigrateComments::class, 'migrateComments.php' );
-                       $task->execute();
+                       $ok = $task->execute();
                        $this->output( $ok ? "done.\n" : "errors were encountered.\n" );
                }
        }