Alexandre Emsenhuber [Thu, 12 Jul 2012 19:58:30 +0000 (21:58 +0200)]
Documentation improvements in Exception.php.
Change-Id: I645025c9acbb91df48bb0f1ee3859840195c5e56
Aaron Schulz [Thu, 12 Jul 2012 18:21:43 +0000 (18:21 +0000)]
Merge "[FileBackend] Tweaks to speed up backend copy script."
Aaron Schulz [Thu, 12 Jul 2012 17:14:08 +0000 (10:14 -0700)]
[FileBackend] Tweaks to speed up backend copy script.
* Added 'missingonly' option to copy based only on a listing comparison.
* Made copy operation batches use doQuickOperations().
Change-Id: If5657a4c4d895980e27776357bb408b350727382
Aaron Schulz [Sat, 30 Jun 2012 03:08:06 +0000 (20:08 -0700)]
[FileBackend] Factored out code into ProcessCacheLRU class.
Factor out duplicated code into the new ProcessCacheLRU. It is a fixed
size an per process cache which invalidate the least recently used cache
key.
Change-Id: Ib4475f21879ef6286ce2a28f248acd296fdbd45d
Aaron [Thu, 12 Jul 2012 00:03:57 +0000 (17:03 -0700)]
[FileBackend] More Swift ACL documentation.
Change-Id: If6a3f70824b05545e5ee5b406cd66fa2b046c981
Aaron [Wed, 11 Jul 2012 23:34:43 +0000 (16:34 -0700)]
[FileBackend] Added hash skipping option to speed up script.
Change-Id: If810bbdeffdbfa37a3609992c3e8038ee4deebe6
Aaron Schulz [Wed, 11 Jul 2012 20:06:00 +0000 (20:06 +0000)]
Merge "fix problem with retriving fresh LatestRevID when GAID_FOR_UPDATE"
tomek [Tue, 10 Jul 2012 19:11:26 +0000 (15:11 -0400)]
fix problem with retriving fresh LatestRevID when GAID_FOR_UPDATE
Change-Id: Idff009752da3336383a20581d79ffd231332f463
Alexandre Emsenhuber [Wed, 11 Jul 2012 07:18:07 +0000 (09:18 +0200)]
Use Linker::linkKnown() instead of Linker::link() with options at the end in ImagePage.php
Change-Id: I15848983bb675aac4cd017ab7712f884b928d708
Translation updater bot [Wed, 11 Jul 2012 06:49:57 +0000 (06:49 +0000)]
Localisation updates from translatewiki.net.
Change-Id: If21a94598bfd4477ca696759eb71eafac0548df1
Aaron Schulz [Wed, 11 Jul 2012 05:07:10 +0000 (22:07 -0700)]
[FileBackend] More documentation fixes.
Change-Id: I0841e66018522df18ad06a0ac075eb0fbab16e40
Aaron Schulz [Wed, 11 Jul 2012 04:59:23 +0000 (21:59 -0700)]
[FileBackend] Documentation fixes.
Change-Id: Id98c2001c01ab03f63e85f4e08ea14f1750dd9ed
Aaron [Mon, 21 May 2012 22:19:06 +0000 (15:19 -0700)]
[FileBackend] Refactored backend access control functions.
* Made secure() no longer create the container/directories.
* Added a new publish() function, which is the reverse of secure().
It's seems reasonable to be able to reverse secure() if needed.
* Added the ability to call prepare() with the secure() parameters.
The "securing" will only be done if the container had to be created.
This kills a bunch of slow RTTs with setContainerAccess() in Swift.
* Also made the Swift doSecureInternal() function respect the arguments
and set 'r:*' to properly make containers public.
* Consolidated FileRepo directory creation into an initDirectory() function.
This uses the new prepare() arguments.
Change-Id: Ie16331ebf26c99295f60b266e07a4727228f53f2
Antoine Musso [Tue, 10 Jul 2012 15:19:07 +0000 (17:19 +0200)]
OutputPage::setRevisionTimestamp typo in parameter
'stmap' instead of 'stamp'. I have updated:
- doc block
- function argument
- inner use of the argument
Change-Id: Ie7b663372632e4044464ae49ab42dce500838985
Trevor Parscal [Tue, 10 Jul 2012 20:24:38 +0000 (20:24 +0000)]
Merge "(bug 36783) Implement Promise interface in mediawiki.api module."
Translation updater bot [Tue, 10 Jul 2012 19:46:43 +0000 (19:46 +0000)]
Merge "Localisation updates from translatewiki.net."
Translation updater bot [Tue, 10 Jul 2012 19:35:35 +0000 (19:35 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I3ccfbf0f3d1d8dbe5ae3f05210a153d42b2042d1
Brion VIBBER [Tue, 10 Jul 2012 19:32:38 +0000 (19:32 +0000)]
Merge "[FileBackend] Only show "copied file(s)" for files the script had to copy."
Aaron [Tue, 10 Jul 2012 19:20:55 +0000 (12:20 -0700)]
[FileBackend] Only show "copied file(s)" for files the script had to copy.
Change-Id: I22741303e05d6ea50d33875d9f7438d2b3905b18
Nikerabbit [Tue, 10 Jul 2012 19:19:01 +0000 (19:19 +0000)]
Merge "Use Xml::languageSelector in SpecialAllmessages"
Brion VIBBER [Tue, 10 Jul 2012 18:41:14 +0000 (18:41 +0000)]
Merge "[FileBackend] Improved copy/sync script output."
Siebrand [Tue, 10 Jul 2012 18:38:09 +0000 (18:38 +0000)]
Merge "(bug 38281) Fix grammar in the UPGRADE file"
Aaron [Tue, 10 Jul 2012 18:33:24 +0000 (11:33 -0700)]
[FileBackend] Improved copy/sync script output.
Change-Id: I5f76fdb579cf17959093e7a8659839e8b8829b1c
Siebrand [Tue, 10 Jul 2012 18:18:57 +0000 (18:18 +0000)]
Merge "Drop characters in Unicode Private Use Area in conversion tables."
Catrope [Tue, 10 Jul 2012 18:15:10 +0000 (11:15 -0700)]
(bug 38281) Fix grammar in the UPGRADE file
Change-Id: Idc95c9b394ae7f92e7cfd417b8eee4a5d277fa03
Brion VIBBER [Tue, 10 Jul 2012 17:58:13 +0000 (17:58 +0000)]
Merge "[FileBackend] Added "ratefile" option for backend copy script."
robin [Thu, 10 May 2012 19:46:14 +0000 (21:46 +0200)]
Use Xml::languageSelector in SpecialAllmessages
Improve Xml::languageSelector: add parameters to change label message and id/name of the select tag.
Use languageSelector in SpecialAllmessages (less code duplication)
Patchset 10 July: add tests per MaxSem; add version for new parameters and change the message parameter to require a Message object per Nikerabbit
Change-Id: I7fbb29ee2dc37a2b6a5e2cfc88207a0b47b83e9b
Aaron [Mon, 9 Jul 2012 23:30:44 +0000 (16:30 -0700)]
[FileBackend] Added "ratefile" option for backend copy script.
* This can be used to control the concurrency dynamically.
Change-Id: I7ebdbffa144928f559c34c4a4684b03597f616ce
Alexandre Emsenhuber [Tue, 10 Jul 2012 16:50:19 +0000 (18:50 +0200)]
Improve documentation of maintenance scripts.
Change-Id: I0e2869970c46f4fd14b792f2978cc1ba9d8550be
Reedy [Tue, 10 Jul 2012 16:12:55 +0000 (16:12 +0000)]
Merge changes Icfd267a9,If956c0a1,I0e232273,Ia84494c8,Ib70e0046,If2c01a11,I40196371
* changes:
prettify documentation
converts '@fixme' to '@todo FIXME'
update @param @return doc in several files
prettify filerepo documentation
prettify SkinTemplate:makeLink documentation
move parameter doc under @param
escape tags and entity in doxygen comments
Antoine Musso [Tue, 10 Jul 2012 11:14:07 +0000 (13:14 +0200)]
ChannelFeed now marked as an abstract class
The ChannelFeed class has always been considered as an abstract class.
Looks like we forgot to update its definition since PHP switched to
support class abstractions.
Also marked abstract the three inner methods that must be extended:
ChannelFeed::outHeader()
ChannelFeed::outItem()
ChannelFeed::outFooter()
Change-Id: Ie0111786af37531d53ee3fc845e0125136ca298f
Antoine Musso [Tue, 10 Jul 2012 15:23:20 +0000 (17:23 +0200)]
remove unneeded @abstract
Doxygen does recognize abstract methods when it is properly marked as
abstracted. That keyword is a left.
Change-Id: I7df790058edf0eefb07eb4c37a2586b5c16898e3
Liangent [Tue, 10 Jul 2012 15:33:26 +0000 (23:33 +0800)]
Drop characters in Unicode Private Use Area in conversion tables.
Change-Id: I635f3a45d13c82342c70490231e2c77cb2d96e2e
Antoine Musso [Tue, 10 Jul 2012 15:18:20 +0000 (17:18 +0200)]
prettify documentation
Change-Id: Icfd267a94ac981b4c15e51add18c6d8ceb68454e
Antoine Musso [Tue, 10 Jul 2012 15:16:46 +0000 (17:16 +0200)]
converts '@fixme' to '@todo FIXME'
@fixme is simply not recognized by doxygen whereas @todo is used to
generate a nice ... todo list!!
Change-Id: If956c0a164373126ce48b791d45c56962034eecd
Antoine Musso [Tue, 10 Jul 2012 14:58:52 +0000 (16:58 +0200)]
update @param @return doc in several files
Change-Id: I0e23227330f90dc4121fd2a313d2e9a33c3c97a7
Antoine Musso [Tue, 10 Jul 2012 14:46:22 +0000 (16:46 +0200)]
prettify filerepo documentation
Change-Id: Ia84494c8c0c09a3d509975d63ab698e0a35c4631
Antoine Musso [Tue, 10 Jul 2012 14:45:44 +0000 (16:45 +0200)]
prettify SkinTemplate:makeLink documentation
Change-Id: Ib70e00460c8e01ec810a4123b7eec52c3632b99d
Antoine Musso [Tue, 10 Jul 2012 13:12:30 +0000 (15:12 +0200)]
move parameter doc under @param
The description of an array of parameter really belong under @param,
makes doxygen HTML documentation nicer.
Change-Id: If2c01a11b8dbf02b272b7ccce591a92293346731
Antoine Musso [Tue, 10 Jul 2012 12:48:06 +0000 (14:48 +0200)]
escape tags and entity in doxygen comments
When inserting XML elements inline <such as this one>, doxygen chokes
about it not being known. Simply enclosing the tag in double quotes
prevents doxygen from emitting a warning.
Also enclosed a few invalid functions calls such as \. and double quoted
the HTML entities such as &foobar;
Change-Id: I4019637145e683c2bec3d17b2fd98b0c50a932f1
Reedy [Mon, 9 Jul 2012 20:40:32 +0000 (20:40 +0000)]
Merge "Fixed Language::isValidBuiltInCode exception."
Aaron Schulz [Mon, 9 Jul 2012 20:25:37 +0000 (20:25 +0000)]
Merge "adjust method comment for Ia19f1011"
Aaron [Mon, 9 Jul 2012 20:10:05 +0000 (13:10 -0700)]
Fixed Language::isValidBuiltInCode exception.
Change-Id: Ib7c7c0f3ed9382beea5fb0a9b2aa1809f75a8e1c
Translation updater bot [Mon, 9 Jul 2012 20:01:49 +0000 (20:01 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Ibee3987c8a3848e94975a63ecfa832f601b86347
Aaron [Mon, 9 Jul 2012 17:27:53 +0000 (10:27 -0700)]
Prevent duplicate edits due to failure to load the current revision.
* This works via throwing an exception. Ideally, a deeper fix can be
made so the exception stops getting triggered anymore.
Change-Id: Ie6a11016be9f9e5a76e2f6f369bc3aac42d78c2d
MaxSem [Mon, 9 Jul 2012 14:31:00 +0000 (14:31 +0000)]
Merge "(bug 36819) Lowercase ba,bat-smg,bxr,crh,krc,kv,mdf,mhr,mrj,myv,tyv,vep,xal"
MaxSem [Mon, 9 Jul 2012 14:30:11 +0000 (14:30 +0000)]
Merge "(bug 36819) Lowercase Kazakh and Uzbek"
Viačeslav [Sun, 8 Jul 2012 16:30:24 +0000 (18:30 +0200)]
(bug 36819) Lowercase av,ce,lbe and lez
Follow up to gerrit change 7306:
https://gerrit.wikimedia.org/r/#/c/7306/
Lowercase some language names from Caucasus
'av' => 'авар', # Avar
'ce' => 'нохчийн', # Chechen
'lbe' => 'лакку', # Lak
'lez' => 'лезги', # Lezgi
Change-Id: Ia5a8a28c6cc0159898469cc458dd366886916c86
Reedy [Wed, 20 Jun 2012 21:45:21 +0000 (22:45 +0100)]
Flesh out parameter documentation etc
Remove some trailing whitespace
A bit of code simplification
Change-Id: Iea96a2482c53868713a43569be4e5de4c9edb2a2
Hashar [Mon, 9 Jul 2012 12:41:26 +0000 (12:41 +0000)]
Merge "pass Language to wfMessage() calls"
Alexandre Emsenhuber [Sat, 7 Jul 2012 16:37:31 +0000 (18:37 +0200)]
pass Language to wfMessage() calls
Pass the Language object to the wfMessage calls in
LogPage::getTitleLink() and LogPage::formatBlockFlags().
Change-Id: I4f8347d6616ee0e6be31b268679b398e108680c0
Reedy [Sun, 8 Jul 2012 22:55:57 +0000 (22:55 +0000)]
Merge "Improve documentation of maintenance scripts."
Krinkle [Sun, 8 Jul 2012 21:27:16 +0000 (21:27 +0000)]
Merge "Add some trailing full stops"
Alexandre Emsenhuber [Sun, 8 Jul 2012 20:47:27 +0000 (22:47 +0200)]
Improve documentation of maintenance scripts.
Change-Id: I2433d23544e808e16f28805f93183b1af2409c94
Translation updater bot [Sun, 8 Jul 2012 19:48:58 +0000 (19:48 +0000)]
Merge "Localisation updates from translatewiki.net."
Kaldari [Sun, 8 Jul 2012 04:58:30 +0000 (21:58 -0700)]
mediawiki.api.edit: Use the new 'tokens' api action
Use action=tokens instead of the old way with info properties
for a fake title.
Change-Id: I35cd26180e7af7122ff64ce146199cdaa5f7d88b
Translation updater bot [Sun, 8 Jul 2012 19:11:42 +0000 (19:11 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Ifbcaa781fc601b7887525fe83a93d8148569b624
Timo Tijhof [Thu, 7 Jun 2012 20:45:53 +0000 (22:45 +0200)]
(bug 36783) Implement Promise interface in mediawiki.api module.
- Deprecates 'ok'/'err' properties.
They still work, but are no longer mandatory.
Instead the Promise interface should used.
- See unit tests for good examples of how it works.
http://alpha.dev/mediawiki/core/wiki/Special:JavaScriptTest/qunit?module=mediawiki.api
- Migrated submodule "mediawiki.api.parse" as example.
Other mediawiki.api.* submodules will be migrated later.
Change-Id: I4d8428124598093f220dd28a8cbf861686ab61a7
Viačeslav [Sun, 8 Jul 2012 16:30:24 +0000 (18:30 +0200)]
(bug 36819) Lowercase Kazakh and Uzbek
Follow up to gerrit change 7306:
https://gerrit.wikimedia.org/r/#/c/7306/
Lowercase some Central Asian language names.
'kk' => 'қазақша', # Kazakh (multiple scripts - defaults to Cyrillic)
'kk-cyrl' => "\xE2\x80\xAAқазақша (кирил)\xE2\x80\xAC", # Kazakh Cyrillic
'kk-latn' => "\xE2\x80\xAAqazaqşa (latın)\xE2\x80\xAC", # Kazakh Latin
'kk-kz' => "\xE2\x80\xAAқазақша (Қазақстан)\xE2\x80\xAC", # Kazakh (Kazakhstan)
'kk-tr' => "\xE2\x80\xAAqazaqşa (Türkïya)\xE2\x80\xAC", # Kazakh (Turkey)
'uz' => 'oʻzbekcha', # Uzbek
Change-Id: Ieb56ff2854464ea57169985b40fb7f6fdcfacc33
Viačeslav [Sun, 8 Jul 2012 16:30:24 +0000 (18:30 +0200)]
(bug 36819) Lowercase ba,bat-smg,bxr,crh,krc,kv,mdf,mhr,mrj,myv,tyv,vep,xal
Follow up to gerrit change 7306:
https://gerrit.wikimedia.org/r/#/c/7306/
Lowercase some Eastern European and Central Asian
language names.
'ba' => 'башҡортса', # Bashkir
'bat-smg' => 'žemaitėška', # Samogitian (deprecated code, 'sgs' in ISO 693-3 since 2010-06-30 )
'bxr' => 'буряад', # Buryat (Russia)
'crh' => 'qırımtatarca', # Crimean Tatar (multiple scripts - defaults to Latin)
'crh-latn' => "\xE2\x80\xAAqırımtatarca (Latin)\xE2\x80\xAC", # Crimean Tatar (Latin)
'crh-cyrl' => "\xE2\x80\xAAкъырымтатарджа (Кирилл)\xE2\x80\xAC", # Crimean Tatar (Cyrillic)
'krc' => 'къарачай-малкъар', # Karachay-Balkar
'kv' => 'коми', # Komi-Zyrian (Cyrillic is common script but also written in Latin script)
'mdf' => 'мокшень', # Moksha
'mhr' => 'олык марий', # Eastern Mari
'mrj' => 'кырык мары', # Hill Mari
'myv' => 'эрзянь', # Erzya
'tyv' => 'тыва дыл', # Tyvan
'udm' => 'удмурт', # Udmurt
'vep' => 'vepsän kel’', # Veps
'xal' => 'хальмг', # Kalmyk-Oirat (Kalmuk, Kalmuck, Kalmack, Qalmaq, Kalmytskii Jazyk, Khal:mag, Oirat, Volga Oirat, European Oirat, Western Mongolian)
Change-Id: I47ad9b05eca9f5c2fe69ef2e8f5325371b0f9e89
Reedy [Sat, 7 Jul 2012 21:31:00 +0000 (21:31 +0000)]
Merge "(bug 38237) Add missing parentheses around diff links on Special:Undelete"
Reedy [Sat, 7 Jul 2012 21:29:18 +0000 (21:29 +0000)]
Merge "CLI install exited with 0 status code"
Aaron Schulz [Sat, 7 Jul 2012 21:28:10 +0000 (21:28 +0000)]
Merge "Send correct HTML when reporting a MWException object and the OuputPage object cannot be used."
Reedy [Sat, 7 Jul 2012 21:27:42 +0000 (21:27 +0000)]
Merge "Use Revision::getParentLengths in history"
Aaron Schulz [Sat, 7 Jul 2012 21:25:33 +0000 (21:25 +0000)]
Merge "Added assertArrayEquals method to MediaWikiTestCase to avoid duplicating asort and array_values all over the place"
Reedy [Sat, 7 Jul 2012 21:23:42 +0000 (21:23 +0000)]
Merge "Added SpecialPageAfterExecute and SpecialPageBeforeExecute hooks"
Reedy [Sat, 7 Jul 2012 21:03:24 +0000 (21:03 +0000)]
Merge "Improve documentation of maintenance scripts."
Reedy [Sat, 7 Jul 2012 20:56:35 +0000 (20:56 +0000)]
Merge "(bug 31313) Clarify watchlist preference messages"
Alex Monk [Sat, 7 Jul 2012 20:41:47 +0000 (21:41 +0100)]
(bug 38237) Add missing parentheses around diff links on Special:Undelete
Change-Id: Id6846abd42f3c3e1210e760a583b3180d1aab18d
Translation updater bot [Sat, 7 Jul 2012 19:24:47 +0000 (19:24 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Ia7d6bf5c1515498956cb4b06745a2b1ce5700d15
Antoine Musso [Sat, 7 Jul 2012 18:09:45 +0000 (20:09 +0200)]
CLI install exited with 0 status code
The CliInstaller used the '0' exit code whenever the status was not OK.
That makes third party script assuming the install actually ran fine
since a 0 exit code is mostly considered as a success. By sending an
error code > 0 (here 1), our automatic installers will be able to catch
the failure and stop proceeding.
I had that issue with a Jenkins job which ran the CLI installer and kept
continuing although there was an error about LocalSettings.php already
existing.
Change-Id: I4f4727df85c09c0a04e4630df91c6213dfce6e9a
Reedy [Sat, 7 Jul 2012 15:19:58 +0000 (16:19 +0100)]
Remove BOM from cleanupPreferences
Change-Id: I3c049c0229bb9ed1365f2781baa44b4c8e1e1e18
Reedy [Sat, 7 Jul 2012 15:09:47 +0000 (16:09 +0100)]
Add some trailing full stops
Change-Id: I878b24102a4de0c5a5fc1c1b1f9d52b053595002
umherirrender [Sat, 7 Jul 2012 14:45:24 +0000 (16:45 +0200)]
Use Revision::getParentLengths in history
Using new method from I6e388e75
Change-Id: I902dd1e2699c7291c49cd68fce271941ff4c6e34
Brad Jorsch [Fri, 1 Jun 2012 21:46:40 +0000 (23:46 +0200)]
(bug 35980) drcontinue should pay attention to drdir in "all" mode
In "all" mode (mode #3 in the module's documentation), the drdir
parameter is treated by the result ordering as if it were always
drdir=newer; drcontinue, on the other hand, always tries to honor drdir
correctly, leading to the drcontinue not actually working unless drdir
is specifically given.
This fixes that.
Change-Id: Icf6982d0ba55490b7a7ae3a1ee6c94c40f1c3c64
MaxSem [Fri, 6 Jul 2012 22:41:41 +0000 (22:41 +0000)]
Merge "(bug 30836) API siteinfo specialpagealiases should not return nonexistent special pages"
Brad Jorsch [Sat, 2 Jun 2012 20:20:14 +0000 (22:20 +0200)]
(bug 30836) API siteinfo specialpagealiases should not return nonexistent special pages
Some special pages are conditionally registered (e.g.
Special:Popularpages only exists when $wgDisableCounters is false), or
sometimes an alias exists for a special page that does not. The API
should probably not return entries for these from
meta=siteinfo&siprop=specialpagealiases.
Change-Id: I59eb82eae45fb47c6a769195cc1bd28711b4fcac
Translation updater bot [Fri, 6 Jul 2012 21:12:53 +0000 (21:12 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Ic30774dd104bf2b329e3682312c8badc54b99ecc
MaxSem [Fri, 6 Jul 2012 20:30:25 +0000 (20:30 +0000)]
Merge "I18n of display of change tags"
Alexandre Emsenhuber [Thu, 28 Jun 2012 09:52:43 +0000 (11:52 +0200)]
Send correct HTML when reporting a MWException object and the OuputPage object cannot be used.
Currently only the body was sent, without doc type, <html>, <head> or <body> items.
Change-Id: I2d5cc3f69f55d0e1b212148f57f736f100bd2554
Antoine Musso [Fri, 6 Jul 2012 18:22:00 +0000 (20:22 +0200)]
parse.php Windows uses CTRL+Z as a EOF sequence
Follow up:
1fc2bb9 - parse.php note about using ^D to end output
The previous patch assumed ^D to be the standard.
Change-Id: If573c1a03eb9679d74fcb24c1be6931eee361158
Reedy [Fri, 6 Jul 2012 18:18:11 +0000 (18:18 +0000)]
Merge "Pass the full context to the ApiMain instance from api.php."
Alexandre Emsenhuber [Fri, 6 Jul 2012 08:41:17 +0000 (10:41 +0200)]
Pass the full context to the ApiMain instance from api.php.
Passing only the WebRequest instance is not the best
thing when it accepts a complete context.
Change-Id: If02148c850b395a2382f87cbeafbc25887ce8728
Reedy [Fri, 6 Jul 2012 16:57:40 +0000 (17:57 +0100)]
Use estimateRowPage if wiki is using wgMiserMode
Change-Id: I59404e9514a87f65faf3eb865fafe358d9f01079
jeroendedauw [Fri, 6 Jul 2012 11:36:01 +0000 (13:36 +0200)]
Added SpecialPageAfterExecute and SpecialPageBeforeExecute hooks
Danwe apparently needs them :)
Change-Id: Ic74c7ba7f4168d2b0cfbd3c4e551218f6cb2693a
MaxSem [Fri, 6 Jul 2012 13:45:15 +0000 (13:45 +0000)]
Merge "Tweaked mysql_affected_rows() check in WikiPage since it can return -1."
MaxSem [Fri, 6 Jul 2012 13:03:07 +0000 (13:03 +0000)]
Merge "Simplify factory methods of RecentChange."
MaxSem [Fri, 6 Jul 2012 12:51:53 +0000 (12:51 +0000)]
Merge "Fixed cp error in method name"
Antoine Musso [Fri, 6 Jul 2012 12:20:57 +0000 (14:20 +0200)]
rm duplicate "Antoine Musso" in README
Change-Id: I8051199582955b95542f0a258d57a80668f070d5
jeroendedauw [Fri, 6 Jul 2012 11:10:47 +0000 (13:10 +0200)]
Fixed cp error in method name
Change-Id: Idf5a397773418ee85ea17bcd3e3cbbf16d1a57b5
Alexandre Emsenhuber [Fri, 29 Jun 2012 09:51:55 +0000 (11:51 +0200)]
Simplify factory methods of RecentChange.
* Make RecentChange::newFromId() use RecentChange::newFromConds()
* We have DatabaseBase::selectRow() for the purpose of selecting
a single row.
Change-Id: Ie818205437ecea6a4860b74f49b2940c91132a66
Reedy [Wed, 4 Jul 2012 22:27:30 +0000 (23:27 +0100)]
Add some explicit member variable definitions
Bits of parameter documentation
Change-Id: If99a344222900a6715114fa61eadcd4dd3e13db6
Reedy [Thu, 5 Jul 2012 22:53:57 +0000 (23:53 +0100)]
Minor stylize, add some braces
Couple of bits of member variable docs
Change-Id: Iccf861b1b93543f21f43c50864107ec6bb233bd1
Aaron Schulz [Thu, 5 Jul 2012 21:42:39 +0000 (21:42 +0000)]
Merge "Use Linker::getInvalidTitleDescription() to display invalid title entries in Special:Undelete."
Alexandre Emsenhuber [Thu, 5 Jul 2012 21:07:58 +0000 (23:07 +0200)]
Add a context parameter to Liker::generateRollback() and Linker::buildRollbackLink() and updated callers.
This allows both methods to not always rely on global object, but also to use the local context when possible.
Change-Id: Id10f55ed9b18c889afd8d9937d9f35acb376cce4
Aaron [Thu, 5 Jul 2012 20:54:33 +0000 (13:54 -0700)]
Tweaked mysql_affected_rows() check in WikiPage since it can return -1.
In theory, a DBError or something should be thrown already; this is just for sanity.
Change-Id: Ie54dc764ee4d4c6e450b7bcff5663c1707027c6d
jeroendedauw [Thu, 5 Jul 2012 20:47:15 +0000 (22:47 +0200)]
Change entry point of SpecialPage
The old entry point is the execute method, which clearly is not meant to be an entry point,
as it's overloaded in most subclasses, making it impossible for the deriving classes to do anything
before or after (which for instance sucks big time in SpecialCachedPage).
Change-Id: I74c22a1dc3b1a9d062295d5fb709fb87577810ae
Reedy [Thu, 5 Jul 2012 20:31:39 +0000 (20:31 +0000)]
Merge "Reimplement CORS properly, addressing Tim's concerns"
Catrope [Fri, 1 Jun 2012 12:14:47 +0000 (05:14 -0700)]
Reimplement CORS properly, addressing Tim's concerns
Tim's concerns (listed at
https://bugzilla.wikimedia.org/show_bug.cgi?id=20814#c6) were:
* Lack of Vary: Origin breaks Squid caching
* Vary: Origin on everything would be disastrous, so add an origin param
* Origin header is space-separated list, wasn't treated as such
This commit:
* Remove CORS code from api.php and reimplement it in ApiMain.php
* Add 'origin' parameter to ApiMain
* If 'origin' parameter doesn't match Origin header, send a 403
* If origin is whitelisted, set CORS headers and set Vary: Origin
* Add https?:// to wildcard matching logic, wasn't there but is needed
CORS now works :) you can test it locally as follows:
Set $wgCrossSiteAJAXdomains[] = '*.wikipedia.org';
Log into MediaWiki on localhost
Go to Wikipedia, open a JS console, and run:
$.ajax( {
'url': 'http://localhost/w/api.php',
'data': {
'action': 'query',
'meta': 'userinfo',
'format': 'json',
'origin': 'https://en.wikipedia.org'
// or whichever domain you're on; must be correct!
},
'xhrFields': {
'withCredentials': true
},
'success': function( data ) {
alert( 'Foreign user ' + data.query.userinfo.name +
' (ID ' + data.query.userinfo.id + ')' );
}
} );
Change-Id: I725ce176866d7c81dd9ad6d7bc4a86b7160f2458
Catrope [Fri, 1 Jun 2012 11:11:32 +0000 (04:11 -0700)]
In ApiMain, gather Vary headers in OutputPage
Using OutputPage for this rather than something like WebResponse
probably isn't optimal, but it's a lot nicer than the mess we had
before.
Change-Id: I9dce06d3eb69dd7952eafc6c94ead2ad5ad88792