From c1e9a7c6df6f920345c9f120291047906e3a3d12 Mon Sep 17 00:00:00 2001 From: Derick Alangi Date: Mon, 11 Mar 2019 10:34:23 +0100 Subject: [PATCH] ProtectionForm: Follow up on I167ae6300b37d4e9292 Per code search string "\$this\-\>showLogExtract\( \$ou", method is only called within the ProtectionForm class so can be safely made private but there are methods with the same name in a class like LogEventsList but do different things. Inspired by @Thiemo's comment on I167ae6300b37d4e9292. Change-Id: Ic4983ccffecc6285f848d6e926017c4c6df4855f --- includes/ProtectionForm.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/includes/ProtectionForm.php b/includes/ProtectionForm.php index 0e18e46a3b..7972a1ebe4 100644 --- a/includes/ProtectionForm.php +++ b/includes/ProtectionForm.php @@ -623,9 +623,8 @@ class ProtectionForm { * Show protection long extracts for this page * * @param OutputPage $out - * @private */ - function showLogExtract( OutputPage $out ) { + private function showLogExtract( OutputPage $out ) { # Show relevant lines from the protection log: $protectLogPage = new LogPage( 'protect' ); $out->addHTML( Xml::element( 'h2', null, $protectLogPage->getName()->text() ) ); -- 2.20.1