Sam Reed [Thu, 9 Feb 2012 01:06:57 +0000 (01:06 +0000)]
Documentation and whitespace
Sam Reed [Thu, 9 Feb 2012 01:05:59 +0000 (01:05 +0000)]
Add 1.18 to HISTORY
Roan Kattouw [Thu, 9 Feb 2012 01:02:39 +0000 (01:02 +0000)]
Followup r110999: remove 1.19-specific stuff from the 1.20 release notes
Sam Reed [Thu, 9 Feb 2012 00:59:56 +0000 (00:59 +0000)]
Bump 1.20alpha
Sam Reed [Thu, 9 Feb 2012 00:24:11 +0000 (00:24 +0000)]
Blacklist | in windows paths too
Ping r110922
Roan Kattouw [Thu, 9 Feb 2012 00:10:50 +0000 (00:10 +0000)]
(bug 31676) Group dynamically inserted CSS into a single <style> tag, because IE limits the number of styles it'll apply to 32 (seriously?!?). 3rd party users were complaining about IE not applying some modules' CSS when many modules were loaded; this wasn't a problem on WMF wikis as far as I know
Aaron Schulz [Wed, 8 Feb 2012 23:25:58 +0000 (23:25 +0000)]
r110979: removed implode() call and format the message as plaintext, as any HTML will be escaped anyway for such exceptions.
Ian Baker [Wed, 8 Feb 2012 23:09:19 +0000 (23:09 +0000)]
Properly expand the "error storing file" message. Fixes bug 33846
Alexandre Emsenhuber [Wed, 8 Feb 2012 22:41:11 +0000 (22:41 +0000)]
Fix typo so that the key is set with correct value instead of a boolean with key "0"
Aaron Schulz [Wed, 8 Feb 2012 22:13:03 +0000 (22:13 +0000)]
* Corrected and improved FileBackend::getFileList() comments.
* Added unit tests for using getFileList() iterators twice.
Raimond Spekking [Wed, 8 Feb 2012 20:51:14 +0000 (20:51 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Aaron Schulz [Wed, 8 Feb 2012 20:34:24 +0000 (20:34 +0000)]
Bumped $maxContCacheSize to handle container sharding a bit better. However, wikis large enough to need sharding would probably have sane 404 handling anyway, which avoids the need to hit a bunch of containers in one request anyway (like rendering thumbnails on parse).
Sam Reed [Wed, 8 Feb 2012 20:20:13 +0000 (20:20 +0000)]
Gearman stuff hasn't been touched in 3 years
Aaron Schulz [Wed, 8 Feb 2012 19:53:55 +0000 (19:53 +0000)]
(bug 33374) - 'Deletion log summary not properly truncated'
Aaron Schulz [Wed, 8 Feb 2012 19:52:04 +0000 (19:52 +0000)]
Fixes for r96546 (bug 33167):
* Made LegacyLogFormatter try to respect the 'plaintext' parameter.
* Changed LogPage::addEntry() to use LogFormatter to get the action text as such calls to LogPage::actionText() are broken.
* Added comment to LogPage::actionText(). It's only OK to call this from the legacy log formatter, fetched via the proper factory functions.
* Converted CheckUser to using LogFormatter so that cuc_actiontext values work. Eventually, cuc_actiontext should be replaced with new cuc_params, cuc_log_type, and cuc_log_action fields, similar to the RC table.
Sam Reed [Wed, 8 Feb 2012 19:37:34 +0000 (19:37 +0000)]
Bug 34273 - get rid of dtrace example scripts
diediediediediediediediediediediediediediediedie
Max Semenik [Wed, 8 Feb 2012 18:07:41 +0000 (18:07 +0000)]
Fix my stupid mistake in r110750 that resulted in fake "can't delete page" errors (bug 34245)
Antoine Musso [Wed, 8 Feb 2012 17:03:43 +0000 (17:03 +0000)]
Fix doc for includes/upload
Antoine Musso [Wed, 8 Feb 2012 16:58:49 +0000 (16:58 +0000)]
fix doc grouping for actions
Antoine Musso [Wed, 8 Feb 2012 16:55:54 +0000 (16:55 +0000)]
Fix doc for maintenance/
Antoine Musso [Wed, 8 Feb 2012 16:49:53 +0000 (16:49 +0000)]
Fix doc for maintenance/benchmarks
Antoine Musso [Wed, 8 Feb 2012 15:51:16 +0000 (15:51 +0000)]
enhance filerepo doc structure
Alexandre Emsenhuber [Wed, 8 Feb 2012 15:23:09 +0000 (15:23 +0000)]
Fix comment, Profiler::getFunctionReport() no longer logs data itself.
Max Semenik [Wed, 8 Feb 2012 14:59:22 +0000 (14:59 +0000)]
Sort extension names on those lame Linux file systems:)
Antoine Musso [Wed, 8 Feb 2012 14:30:17 +0000 (14:30 +0000)]
rtrim() call does not pass by reference!
fix r110923
Antoine Musso [Wed, 8 Feb 2012 12:58:27 +0000 (12:58 +0000)]
debug messages for getFileListInternal() returns
Antoine Musso [Wed, 8 Feb 2012 12:16:32 +0000 (12:16 +0000)]
align variables / enhance comment
Antoine Musso [Wed, 8 Feb 2012 10:00:02 +0000 (10:00 +0000)]
debug statement for FileRepo::storeBatch()
also nicely align some variable assignements
Antoine Musso [Wed, 8 Feb 2012 09:54:44 +0000 (09:54 +0000)]
r110923 made basePath always null!
Antoine Musso [Wed, 8 Feb 2012 09:28:14 +0000 (09:28 +0000)]
align and sort class properties
Antoine Musso [Wed, 8 Feb 2012 09:21:19 +0000 (09:21 +0000)]
fix notice on construction without 'containerPaths'
The comment block seems to indicate that containerPaths should only be used
for backwards-compatibility, which implies it is optional.
The following code generated a notice:
$fsBackend = new FSFileBackend( array(
'name' => 'foo',
'lockManager' => 'fsLockManager',
'basePath' => '/tmp/foo',
);
Antoine Musso [Wed, 8 Feb 2012 09:16:19 +0000 (09:16 +0000)]
use rtrim() to strip trailing slashes
rtrim() can be given a list of character to strip from a given string.
Aaron Schulz [Wed, 8 Feb 2012 09:00:31 +0000 (09:00 +0000)]
Added some simple path validation to resolveContainerPath() in FSFileBackend. This makes file op batches a bit more robust.
Antoine Musso [Wed, 8 Feb 2012 07:03:20 +0000 (07:03 +0000)]
make gzopen() portable by using binary flag
r110871 forgot the 'b' flag which make sure gzopen handle file
content in binary form. That is for portability accross platforms.
Tim Starling [Wed, 8 Feb 2012 06:09:58 +0000 (06:09 +0000)]
* Optimise {{GENDER}} so that it doesn't need to load the user options if only one form is given. For some reason (presumably some detail of how translatewiki.net works) such {{GENDER}} invocations are extremely common.
* Updated Language::gender() documentation accordingly
Tim Starling [Wed, 8 Feb 2012 05:25:19 +0000 (05:25 +0000)]
Fixed a bug in User::loadOptions(), probably introduced in r49925, causing the User::loadOptions() query to be done after a cache load if the user had no option overrides at the time of cache save. Store an empty array to the cache's mOptionOverrides instead of null.
Tim Starling [Wed, 8 Feb 2012 03:27:49 +0000 (03:27 +0000)]
* Fix for r96546 etc.: due to a severe performance regression in log lists, removed {{GENDER}} invocations in logentry messages, replacing them with the default case.
* Manually fixed broken {{GENDER}} invocations in vi, eo, gu and ksh. Some amount of creativity was needed in the gu and ksh cases, these should be checked by translators.
* Fixed invocations of non-existent parser function "બહુવચન" in MessagesGu.php
* Apparently in the ksh case, the translator was confused between {{GRAMMAR}} and {{GENDER}}. Removed most instances pending translator review.
Tim Starling [Wed, 8 Feb 2012 00:03:16 +0000 (00:03 +0000)]
Revert r110321: introduces an XSS vulnerability because FormatJson::encode() does not prevent the termination of CDATA sections when JavaScript is embedded in HTML.
Aaron Schulz [Tue, 7 Feb 2012 23:57:33 +0000 (23:57 +0000)]
r96546: Made FeedUtils::formatDiff() use the new LogFormatter class rather than a broken LogPage::actionText() call (the <summary> tag only had the log action name in it). This change means that log actions in feeds now have the user name in them, unlike 1.18. Also, broke a long code line.
Aaron Schulz [Tue, 7 Feb 2012 23:12:17 +0000 (23:12 +0000)]
In LogFormatter:
* Changed LogFormatter to support displaying redacting log items if the context user can see them. The default mode is still "show only public items".
* Fixed static calls to non-static getRestrictedElement() function.
* Cleaned up LogFormatter that build up vars only to then throw them away and replace them with rev-deleted placeholders.
In RevDel_LogItem:
* Use LogFormatter instead of raw LogPage::actionText call as such calls are broken and just displayed things like the string "move" (the log action name) instead of "x moved a to b: reason" and such. Fixes r96546.
Aaron Schulz [Tue, 7 Feb 2012 22:22:27 +0000 (22:22 +0000)]
Made LogEntry::getPerformer() not fail miserable if we got the LogEntry via newFromRow() on just a logging table row. Previously, the current user IP would show.
Aaron Schulz [Tue, 7 Feb 2012 21:30:41 +0000 (21:30 +0000)]
Disable $wgDebugToolbar if file cache is turned on, as with $$wgShowIPinHeader
Antoine Musso [Tue, 7 Feb 2012 20:49:08 +0000 (20:49 +0000)]
drop comment about a removed parameter
Antoine Musso [Tue, 7 Feb 2012 20:47:45 +0000 (20:47 +0000)]
simplify FileCacheBase::fetchText
Implements a proposal by Tim on r98405 CR
Raimond Spekking [Tue, 7 Feb 2012 20:19:09 +0000 (20:19 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Tue, 7 Feb 2012 19:24:31 +0000 (19:24 +0000)]
Select fields returned by Revision::selectPageFields() and call Title::newFromRow() instead of Title::makeTitle() in Revision::getTitle() so that it doesn't need a separate query to load the page id or the latest revision id.
Antoine Musso [Tue, 7 Feb 2012 17:56:32 +0000 (17:56 +0000)]
add up comment for FileCache rewrite (r98698)
Sam Reed [Tue, 7 Feb 2012 16:49:34 +0000 (16:49 +0000)]
Merge r97508 changes to MessageCache.php and Skin.php into trunk
Antoine Musso [Tue, 7 Feb 2012 14:54:06 +0000 (14:54 +0000)]
test FileRepo constructor
Mark A. Hershberger [Tue, 7 Feb 2012 13:05:31 +0000 (13:05 +0000)]
w/s
Sam Reed [Tue, 7 Feb 2012 12:30:36 +0000 (12:30 +0000)]
Omg HTTPS
Ping r110822
Antoine Musso [Tue, 7 Feb 2012 11:50:31 +0000 (11:50 +0000)]
comment about wgShowIPinHeader disabling file cache
John Du Hart [Tue, 7 Feb 2012 11:03:30 +0000 (11:03 +0000)]
Fixes Bug 34243 - [Regression] Can't navigate from Special:ListUsers/sysop to other groups
Followup r97658
Antoine Musso [Tue, 7 Feb 2012 10:34:43 +0000 (10:34 +0000)]
Doxygen: show directories
The inline trees make it easier to browse the directory hierarchy.
Antoine Musso [Tue, 7 Feb 2012 10:12:09 +0000 (10:12 +0000)]
update Doxyfile default configuration
Max Semenik [Tue, 7 Feb 2012 09:40:08 +0000 (09:40 +0000)]
Follow-up r110750: move constants to a different class per CR
Antoine Musso [Tue, 7 Feb 2012 09:37:59 +0000 (09:37 +0000)]
rebuildFileCache now really disable debugToolbar
r110761 did not properly disabled the debug toolbar. It has to be
done before Setup.php (MWDebug uses a private static to track that
global variable).
really fix r110758 / r110762
Daniel Friesen [Tue, 7 Feb 2012 08:07:28 +0000 (08:07 +0000)]
(bug 34237) Regenerate an empty user_token and save to the database when we try to set the user's cookies for login.
This allows the entire user_token column to be regenerated after a leak by running `UPDATE user SET user_token = NULL;` and letting the user_tokens be regenerated as users try to log back in.
Tim Starling [Tue, 7 Feb 2012 03:43:23 +0000 (03:43 +0000)]
* Fix for r81363: instead of giving a PHP notice when PATH_INFO is missing, show the informative error message used before that revision.
* Revert the change to the relevant message made in r102612: it is plain text, not wikitext, a format which does not support protocol-relative URLs.
John Du Hart [Tue, 7 Feb 2012 02:49:28 +0000 (02:49 +0000)]
Fixes bug 33165 - GlobalFunctions.php line 1312: Call to a member function getText() on a non-object
Aaron Schulz [Tue, 7 Feb 2012 00:35:55 +0000 (00:35 +0000)]
r109469: protect FileOpScopedPHPTimeout from abuse by infinite loops. Also commented out the invocation of it for now.
Aaron Schulz [Tue, 7 Feb 2012 00:20:27 +0000 (00:20 +0000)]
r80240: throw an exception if an empty message key array is given
Chad Horohoe [Mon, 6 Feb 2012 22:44:30 +0000 (22:44 +0000)]
Revert r103467, r106446 (bug 24464: calling LoginAuthenticateAudit hook more often)
Pretty narrow use case isn't very well defined, and this has *felt wrong* to me since
it was committed in November. Easier to pull for now rather than blocking release.
Alexandre Emsenhuber [Mon, 6 Feb 2012 21:52:48 +0000 (21:52 +0000)]
Follow-up r110761: removed duplicate check of $wgShowIPinHeader and fix some whitespaces
Raimond Spekking [Mon, 6 Feb 2012 21:41:15 +0000 (21:41 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Antoine Musso [Mon, 6 Feb 2012 21:39:56 +0000 (21:39 +0000)]
disable ApiUploadTest
ApiUploadTest gives inconsistent results which trigger false alamrs to all
the ops team. We are disabling those tests for now.
See https://bugzilla.wikimedia.org/26169
Antoine Musso [Mon, 6 Feb 2012 21:38:14 +0000 (21:38 +0000)]
comment about wgDebugToolbar disabling file cache
Sam Reed [Mon, 6 Feb 2012 20:20:43 +0000 (20:20 +0000)]
Add @since to getIP/getRawIP
Came in r94932, soemwhere after 1.18 was branched, so is in 1.19
Alexandre Emsenhuber [Mon, 6 Feb 2012 17:34:33 +0000 (17:34 +0000)]
Recommit r110758 (again) now that the problem has been fixed in r110761
Antoine Musso [Mon, 6 Feb 2012 17:17:51 +0000 (17:17 +0000)]
disable wgDebugToolbar when rebuilding file cache
credits to iAlex :)
Sam Reed [Mon, 6 Feb 2012 17:06:10 +0000 (17:06 +0000)]
Ping r110759, remove erroneous extra subdir
Sam Reed [Mon, 6 Feb 2012 16:58:10 +0000 (16:58 +0000)]
Move mediawiki.api to own folder
Antoine Musso [Mon, 6 Feb 2012 16:42:58 +0000 (16:42 +0000)]
reverts r110488
Breaks maintenance/rebuildFileCache.php with stack trace saying that
FauxRequest::getRequestURL() not implemented
Backtrace:
#0 includes/WebRequest.php(1261): FauxRequest->notImplemented('FauxRequest::ge...')
#1 includes/debug/Debug.php(266): FauxRequest->getRequestURL()
#2 includes/Skin.php(561): MWDebug::getDebugHTML(Object(RequestContext))
#3 includes/SkinTemplate.php(461): Skin->generateDebugHTML()
#4 includes/OutputPage.php(1982): SkinTemplate->outputPage()
#5 maintenance/rebuildFileCache.php(119): OutputPage->output()
#6 maintenance/doMaintenance.php(105): RebuildFileCache->execute()
#7 maintenance/rebuildFileCache.php(146): require_once('/srv/trunk/main...')
#8 {main}
Sam Reed [Mon, 6 Feb 2012 16:16:01 +0000 (16:16 +0000)]
And fix fail rom r110752
Sam Reed [Mon, 6 Feb 2012 16:07:52 +0000 (16:07 +0000)]
Not much point making user_groups.ug_group 32 chars if we leave user_former_groups.ufg_group at 16
Also fix modify field to use correct table/column
Robin Pepermans [Mon, 6 Feb 2012 15:21:49 +0000 (15:21 +0000)]
Add fallback to Russian (per meta.wikimedia.org/wiki/Requests_for_new_languages/Wikipedia_Lezgi )
Max Semenik [Mon, 6 Feb 2012 15:21:10 +0000 (15:21 +0000)]
Fixed r63018: made it possible to delte half-baked images w/o descriptions, clearer error message
Alexandre Emsenhuber [Mon, 6 Feb 2012 11:35:24 +0000 (11:35 +0000)]
Removed false comment, we no longer use file cache for action=raw calls.
Alexandre Emsenhuber [Mon, 6 Feb 2012 11:19:14 +0000 (11:19 +0000)]
Use WikiPage instead of Article to call doEdit() and getId()
Aaron Schulz [Mon, 6 Feb 2012 05:26:36 +0000 (05:26 +0000)]
Added missing tests from r110731
Aaron Schulz [Mon, 6 Feb 2012 05:25:26 +0000 (05:25 +0000)]
In FileBackend:
* Added simple getReadOnly()/getReadOnlyReason() functions.
* Allow directly passing a LockManager object into __construct(), useful for testing.
* Fixed bug in FSFileBackend were creating empty files would result in a failing status.
* Added more file stat unit tests.
Alexandre Emsenhuber [Sun, 5 Feb 2012 20:29:53 +0000 (20:29 +0000)]
Fixed string -> __METHOD__ in calling method parameter
Raimond Spekking [Sun, 5 Feb 2012 20:20:23 +0000 (20:20 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Sun, 5 Feb 2012 18:45:07 +0000 (18:45 +0000)]
* Use $this->getRevision() to get the latest revision instead of loading it each time from the database
* Moved wfGetDB( DB_MASTER ) a bit after so that it is only called when needed
Alexandre Emsenhuber [Sun, 5 Feb 2012 16:45:41 +0000 (16:45 +0000)]
* Use WikiPage instead of Article for ParserCache stuff
* Use ParserOptions::newFromUserAndLang() instead of 'new ParserOptions' to not rely on global variables
Alexandre Emsenhuber [Sun, 5 Feb 2012 15:26:41 +0000 (15:26 +0000)]
Fix call to deprecated to fix test since it was throwing errors
Krinkle [Sun, 5 Feb 2012 13:30:24 +0000 (13:30 +0000)]
[Actions] Update usage of wgDisabledActions to check wgActions instead
* Setup.php adds any values in the deprecated wgDisabledActions to wgActions in the new format. So checking wgDisabledActions is actually insufficient, not just deprecated.
* Poke r86041
Krinkle [Sun, 5 Feb 2012 12:29:49 +0000 (12:29 +0000)]
[tests] update QUnitTestResources.php to include jquery.delayedBind
Krinkle [Sun, 5 Feb 2012 12:27:20 +0000 (12:27 +0000)]
[tests] use core qunit-fixture properly
QUnit provides a <div id="qunit-fixture"> by default that is cleared out after each test.
* Switch tests to append to the provided #qunit-fixture instead of appending to the body.
* Remove redundant .remove() calls, which now happens automatically
* Fix jquery.textSelection.test to not cause dozens of elements to be appended to the body with duplicate IDs, which was causing WebFonts test suite to fail (since the DOM can't select multiple elements with the same DOM). (Fixes r92923, r100391)
Thomas Gries [Sun, 5 Feb 2012 11:00:07 +0000 (11:00 +0000)]
Please review carefully, I cannot see negative side effects from this patch. It gives extensions which use the (depreacted) UnknownAction hook a chance to see the original action= value. This fixes bug 34203 and bug 34161 UnknownAction hook problem: the hook must pass the unknown action to the callee and not the value "nosuchaction"
Aaron Schulz [Sun, 5 Feb 2012 03:52:40 +0000 (03:52 +0000)]
Removed some useless code and a confusing comment in FSLockManager::doLock(). This was from before referencing counting was used.
Raimond Spekking [Sat, 4 Feb 2012 22:42:59 +0000 (22:42 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Sat, 4 Feb 2012 19:07:37 +0000 (19:07 +0000)]
Removed declaration of ProfilerSimpleTrace::$mMinimumTime; already defined in parent class
Alexandre Emsenhuber [Sat, 4 Feb 2012 14:51:01 +0000 (14:51 +0000)]
Added overrides of logData() and getCurrentSection() in ProfilerStub; just in case.
Aaron Schulz [Fri, 3 Feb 2012 23:37:30 +0000 (23:37 +0000)]
Reverted r106025 and friends (r106370, r106373, r108060, r108337, r106419). This can go in 1.20 if a Postgres person has time to look at it.
Raimond Spekking [Fri, 3 Feb 2012 23:30:18 +0000 (23:30 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Aaron Schulz [Fri, 3 Feb 2012 21:42:31 +0000 (21:42 +0000)]
(bug 33846) Fixed backwards error msg/param passing.
Ryan Kaldari [Fri, 3 Feb 2012 21:34:59 +0000 (21:34 +0000)]
adding note about local modifications
Aaron Schulz [Fri, 3 Feb 2012 18:05:33 +0000 (18:05 +0000)]
Per r108369 CR comment, use StringUtils::escapeRegexReplacement() since backend name can have $1 or such. Also added comments to discourage such characters in backend names.
Aaron Schulz [Fri, 3 Feb 2012 17:30:54 +0000 (17:30 +0000)]
Cleaned up a few file backend related messages