Andrew Garrett [Wed, 19 Nov 2008 12:01:43 +0000 (12:01 +0000)]
Starter for a re-jig of hit counting (in a per-day table).
Needs configurability, purty graphs, and some cleanup in the back-end.
Siebrand Mazeland [Wed, 19 Nov 2008 11:55:50 +0000 (11:55 +0000)]
Update magic words for Ukranian
Siebrand Mazeland [Wed, 19 Nov 2008 11:47:16 +0000 (11:47 +0000)]
Revert magic word localisation updates from r43441 for now. Somehow Russian aliases ended up in there too. Working on fixing this with Ahonc.
Aaron Schulz [Wed, 19 Nov 2008 09:08:49 +0000 (09:08 +0000)]
More fixes and consistency tweaks
Siebrand Mazeland [Wed, 19 Nov 2008 09:02:48 +0000 (09:02 +0000)]
Localisation updates for core messages from Betawiki (2008-11-19 09:50 CET)
Aaron Schulz [Wed, 19 Nov 2008 08:35:04 +0000 (08:35 +0000)]
* Checkbox fix
* Remove unused var
* Add $this->sk field
* Tweak code style
* Adding missing wfProfileOut( __METHOD__ );
Aaron Schulz [Wed, 19 Nov 2008 01:45:32 +0000 (01:45 +0000)]
* Make for loop faster
* Don't show incomplete prefix links
* Show the 'project' namespaces
* Tweak table margins
Aaron Schulz [Wed, 19 Nov 2008 00:19:25 +0000 (00:19 +0000)]
* Remove <hr/>
* Use count variables since they are already there
Aaron Schulz [Wed, 19 Nov 2008 00:11:14 +0000 (00:11 +0000)]
Add FeedItem::stripComment() and remove duplication
Aaron Schulz [Wed, 19 Nov 2008 00:02:23 +0000 (00:02 +0000)]
* Remove incomplete isFileCacheable(), the parent one is fine
* Break long line
Chad Horohoe [Tue, 18 Nov 2008 22:48:03 +0000 (22:48 +0000)]
* Move user-agent construction to its own method, so we're not writing the same string in two places (and provides a reliable way for getting MW's standard user-agent)
* Mark visibility, they're all public anyway
Siebrand Mazeland [Tue, 18 Nov 2008 22:22:31 +0000 (22:22 +0000)]
Fix syntax error in MessagesTe.php in r43687
Siebrand Mazeland [Tue, 18 Nov 2008 22:21:35 +0000 (22:21 +0000)]
Localisation updates for core from Betawiki
* Namespace updates
Siebrand Mazeland [Tue, 18 Nov 2008 22:18:31 +0000 (22:18 +0000)]
Localisation updates for core from Betawiki
* Namespace updates
Chad Horohoe [Tue, 18 Nov 2008 21:37:11 +0000 (21:37 +0000)]
Bunch of globals laying around and nobody using them.
Rotem Liss [Tue, 18 Nov 2008 20:27:47 +0000 (20:27 +0000)]
Localization update.
Chad Horohoe [Tue, 18 Nov 2008 19:57:03 +0000 (19:57 +0000)]
(bug 2077) Info on how to use external editor is vague. Minor tweak to the UI should make it a little more clear.
Rotem Liss [Tue, 18 Nov 2008 18:55:38 +0000 (18:55 +0000)]
Localization:
* Update for he.
* Rebuilding MessagesEn.php.
* Marking 'coll-template_blacklist_title' as an ignored message.
Roan Kattouw [Tue, 18 Nov 2008 16:05:24 +0000 (16:05 +0000)]
API: (bug 12760) meta=userinfo&uiprop=ratelimits doesn't list group-specific rate limits
Roan Kattouw [Tue, 18 Nov 2008 15:21:04 +0000 (15:21 +0000)]
API: Make reblocking (introduced in r42843) possible through the API
* Add reblock parameter to action=block
* Tweak the description for allowusertalk for consistency
Roan Kattouw [Tue, 18 Nov 2008 15:11:11 +0000 (15:11 +0000)]
API: (bug 16367) Add allowusertalk attribute to list=blocks output
Raimond Spekking [Tue, 18 Nov 2008 12:54:53 +0000 (12:54 +0000)]
* (bug 11728) Unify layout of enhanced watchlist/recent changes:
Changed from:
Time Page (4 changes) . . (+bytes) . . (hist) [list of editors]
To:
Time Page (4 changes; hist) . . (+bytes) . . [list of editors]
Use consistent message for the history link
Patch by Mormegil
Chad Horohoe [Tue, 18 Nov 2008 12:11:03 +0000 (12:11 +0000)]
Cleanup to r43657, don't really need strlen() here.
Raimond Spekking [Tue, 18 Nov 2008 09:36:19 +0000 (09:36 +0000)]
Add hints for maximum values of some user preferences.
Raimond Spekking [Tue, 18 Nov 2008 08:11:58 +0000 (08:11 +0000)]
Update per r43658 and r43661
Tim Starling [Tue, 18 Nov 2008 05:58:24 +0000 (05:58 +0000)]
Mark the functions I just accessed from outside the class as explicitly "public"
Tim Starling [Tue, 18 Nov 2008 05:57:08 +0000 (05:57 +0000)]
Protect users from attacks against their browsers via malicious script-containing uploads, by:
1) Requiring a session token before streaming files out via Special:Undelete
2) Restricting img_auth.php to private wikis only (its intended use case)
Tim Starling [Tue, 18 Nov 2008 05:07:54 +0000 (05:07 +0000)]
Improved the security of wfStreamFile():
* Use the file extension to determine Content-Type, don't look for magic numbers. This makes the attack surface similar to ordinary web server downloads, and avoids problems when MIME type is not checked on upload.
* Use the same restrictions for Content-Type when streaming as for uploading. This closes any vulnerabilities caused by a change to a more secure configuration, post-upload.
* Don't stream out the file after headers are unexpectedly sent (e.g. due to display_errors). The Content-Type will typically be fixed to text/html in this case and so we need to be careful what we send.
Andrew Garrett [Tue, 18 Nov 2008 02:53:29 +0000 (02:53 +0000)]
Remove some debugging code...
Andrew Garrett [Tue, 18 Nov 2008 02:20:55 +0000 (02:20 +0000)]
Warn when re-uploading a file with the same SHA1/extension pair as a file which has been deleted.
Chad Horohoe [Tue, 18 Nov 2008 02:03:44 +0000 (02:03 +0000)]
Bit of path cleanup per comments on code review (r43316). Construct proper hash paths and use the image name as a child directory of that.
Aaron Schulz [Tue, 18 Nov 2008 01:24:56 +0000 (01:24 +0000)]
Rename function to 'rasterize'
Aaron Schulz [Tue, 18 Nov 2008 01:18:12 +0000 (01:18 +0000)]
Refactor SvgHandler to have transformSvgToPng() function, which can be used for non-thumbnail purposes
Brion Vibber [Mon, 17 Nov 2008 22:09:29 +0000 (22:09 +0000)]
Reverting r43642 "Added $wgLoginAutocomplete to let wiki owner disable password autocompletion in Special:Userlogin by setting it to false. Defaults to true."
There's not a compelling reason to make it hard for users to manage their own password affairs here.
Roan Kattouw [Mon, 17 Nov 2008 21:55:36 +0000 (21:55 +0000)]
Fix up r43617: put RELEASE-NOTES entry in the API section
Marco Schuster [Mon, 17 Nov 2008 21:49:29 +0000 (21:49 +0000)]
Added $wgLoginAutocomplete to let wiki owner disable password autocompletion in Special:Userlogin by setting it to false. Defaults to true.
Marco Schuster [Mon, 17 Nov 2008 21:28:42 +0000 (21:28 +0000)]
Disabled auto-completion for password in Special:Preferences. Should resolve the behaviour described at lists.wikimedia.org/pipermail/wikitech-l/2008-November/040067.html
Siebrand Mazeland [Mon, 17 Nov 2008 21:27:00 +0000 (21:27 +0000)]
(bug 44) Rename Image namespace to File. Based on a patch by brion.
* Parser tests updated. 14 failing parser tests before the change, added one, and the same 14 failing parser tests are remaining
* added namespace aliases for Image and Image_talk for backward compatibility purposes
Marco Schuster [Mon, 17 Nov 2008 21:18:37 +0000 (21:18 +0000)]
little bit of cleanup in the generator for the "remember login" toggle
Siebrand Mazeland [Mon, 17 Nov 2008 20:21:17 +0000 (20:21 +0000)]
Localisation updates for core messages from Betawiki (2008-11-17 21:14 CET)
Brion Vibber [Mon, 17 Nov 2008 20:04:50 +0000 (20:04 +0000)]
Revert r43592 "Pass the user object in MakeGlobalVariablesScript in case some variables are user-dependent."
As a UI thingy, $wgUser will be the only relevant user object here; there's no circumstance in which we might pass some other user object. No reason to pass it to hooks just on the off chance that they might use it, then...
Brion Vibber [Mon, 17 Nov 2008 19:57:00 +0000 (19:57 +0000)]
Part of r43581 bits, reverting.
Brion Vibber [Mon, 17 Nov 2008 19:51:53 +0000 (19:51 +0000)]
Reverting r43581 "Added a new user right called "alwaysuseskin" that allows the user to use and set their configured skin even if the wiki administrator has
chosen to disable user skins for the rest of the wiki. Req. by Alexfusco5."
Seems a little weird to me; I'm not quite sure the use case. :)
Comments on the revision note that it needs documentation as well, and the name is a bit weird. If it is needed/desireable it might be better to just replace $wgAllowUserSkin with a right 'useskin' or something.
Rotem Liss [Mon, 17 Nov 2008 19:15:53 +0000 (19:15 +0000)]
Localization update.
Brion Vibber [Mon, 17 Nov 2008 19:03:37 +0000 (19:03 +0000)]
* Improved scripting safety heuristics for IE 5/6 content-type detection.
* Improved scripting safety heuristics on SVG uploads.
Siebrand Mazeland [Mon, 17 Nov 2008 19:01:32 +0000 (19:01 +0000)]
Update messages.inc per r43624
Brion Vibber [Mon, 17 Nov 2008 19:01:07 +0000 (19:01 +0000)]
* Add a .htaccess to deleted images directory for additional protection
against exposure of deleted files with known SHA-1 hashes on default
installations.
Applying Tim's fixes
Brion Vibber [Mon, 17 Nov 2008 18:58:57 +0000 (18:58 +0000)]
* Improved input validation on Special:Import form
Applying Tim's fixes
Brion Vibber [Mon, 17 Nov 2008 18:54:55 +0000 (18:54 +0000)]
* Blacklist redirects via Special:Filepath, hard to use.
Committing Tim's fixes...
Brion Vibber [Mon, 17 Nov 2008 18:53:35 +0000 (18:53 +0000)]
* Less verbose errors from profileinfo.php when not configured
Brion Vibber [Mon, 17 Nov 2008 18:51:21 +0000 (18:51 +0000)]
* Safer handling of non-MediaWiki exceptions -- now obeys our settings for formatting and path exposure.
Applying Tim's fixes...
Brion Vibber [Mon, 17 Nov 2008 18:13:11 +0000 (18:13 +0000)]
* API siteinfo query no longer throws an exception for empty sifilter parameter.
The parameter is defined as being one of two values ('local' or '!local'), but comes back as array() if it was specified but empty... which then got overly-strictly checked against 'false', which was used internally for the case where it's unspecified, and an exception thrown internally.
Now the filter parameter is nicely ignored whether it's unspecified or specified as empty, which is good clear behavior.
As before, other values return a standard API error about invalid values being passed.
Rotem Liss [Mon, 17 Nov 2008 17:52:41 +0000 (17:52 +0000)]
Localization update for he.
Raimond Spekking [Mon, 17 Nov 2008 17:38:30 +0000 (17:38 +0000)]
Add a class when a usergroup contains no members to allow hiding these rows per Commons.css or user specific CSS. Per suggestion of Purodha.
Siebrand Mazeland [Mon, 17 Nov 2008 10:07:19 +0000 (10:07 +0000)]
Localisation updates for core messages from Betawiki
* re-export new search UI messages
* copy contents of 'helppage' to 'searchhelp-url'
Aaron Schulz [Mon, 17 Nov 2008 04:56:14 +0000 (04:56 +0000)]
* Re-commit new search UI code, disabled by default. Old form messages still used and thus kept.
* Update old-fashioned profile calls
Brion Vibber [Mon, 17 Nov 2008 04:30:31 +0000 (04:30 +0000)]
Rename file to lowercase per its use. (Some folks use case-sensitive filesystems on their servers, like.... oh.... every Unix/Linux that's not Mac OS X)
Chad Horohoe [Mon, 17 Nov 2008 02:33:29 +0000 (02:33 +0000)]
Pass the user object in MakeGlobalVariablesScript in case some variables are user-dependent.
Siebrand Mazeland [Mon, 17 Nov 2008 00:13:16 +0000 (00:13 +0000)]
Localisation updates for core messages from Betawiki (2008-11-17 01:10 CET)
Aaron Schulz [Sun, 16 Nov 2008 23:18:43 +0000 (23:18 +0000)]
Refactor getCharacterDifference()
Charles Melbye [Sun, 16 Nov 2008 21:09:32 +0000 (21:09 +0000)]
Forgot to update one part, and also got rid of some historial stuff (hiding
preview links if they can't choose a skin).
Charles Melbye [Sun, 16 Nov 2008 20:57:21 +0000 (20:57 +0000)]
Added a new user right called "alwaysuseskin" that allows the user to
use and set their configured skin even if the wiki administrator has
chosen to disable user skins for the rest of the wiki. Req. by Alexfusco5.
Rotem Liss [Sun, 16 Nov 2008 19:20:44 +0000 (19:20 +0000)]
Localization update for he.
Siebrand Mazeland [Sun, 16 Nov 2008 18:46:57 +0000 (18:46 +0000)]
Change default special page names for special page names containing "image". Leave old names in for backward compatibility.
Siebrand Mazeland [Sun, 16 Nov 2008 15:43:38 +0000 (15:43 +0000)]
Localisation updates for core messages from Betawiki (2008-11-16 16:25 CET)
Raimond Spekking [Sun, 16 Nov 2008 14:55:48 +0000 (14:55 +0000)]
Add 'statistics-summary' as default existing but empty message (to be ignored for i18n)
Aaron Schulz [Sun, 16 Nov 2008 02:42:30 +0000 (02:42 +0000)]
doc typo
Ilmari Karonen [Sat, 15 Nov 2008 18:12:40 +0000 (18:12 +0000)]
minor fix for r43517: float tables to the right on RTL wikis
Siebrand Mazeland [Sat, 15 Nov 2008 12:03:56 +0000 (12:03 +0000)]
Localisation updates for core messages from Betawiki
* Update messages for r43554
Raimond Spekking [Sat, 15 Nov 2008 11:47:02 +0000 (11:47 +0000)]
Restore message for search prefs. Removed in r43384 in combination with the new search form but reverted now.
Andrew Garrett [Sat, 15 Nov 2008 01:29:52 +0000 (01:29 +0000)]
Configure extension:
* Let users enter an image name for the logo, and then click a button to have it converted to a thumbnail URL.
Brion Vibber [Sat, 15 Nov 2008 01:23:39 +0000 (01:23 +0000)]
$oldName parameter to UserLogoutComplete hook call was missing.
Caused this warning (harmless in practice):
PHP Warning: Missing argument 3 for CentralAuthHooks::onUserLogoutComplete() in /usr/local/apache/common-local/php-1.5/extensions/CentralAuth/CentralAuthHooks.php on line 217
Chad Horohoe [Sat, 15 Nov 2008 01:19:46 +0000 (01:19 +0000)]
Revert r41710, r41978, r42012, r42048 (integration of Poem extension to core plus misc. fixes). Per Wikitech-l, this isn't properly attributed to the original authors of the extension. Furthermore, "Poem" is entirely too narrow a name for the functionality this tag provides. If this is to be integrated, a better name should be chosen.
Ilmari Karonen [Sat, 15 Nov 2008 01:18:59 +0000 (01:18 +0000)]
make the layout of the namespace checkboxes in powerSearchBox() look nicer
Siebrand Mazeland [Fri, 14 Nov 2008 23:59:17 +0000 (23:59 +0000)]
Recover from r43499. Gotta love having all messages in a database :)
Alexandre Emsenhuber [Fri, 14 Nov 2008 22:45:32 +0000 (22:45 +0000)]
* Removed the inclusion of memcached-client.php since this file is autoloaded
* Document a bit
Raimond Spekking [Fri, 14 Nov 2008 21:28:30 +0000 (21:28 +0000)]
Add consistent classes for the common UI elements userlinks and usertoollinks per suggestion mediawiki.org/wiki/Special:Code/MediaWiki/43327#c689
Brion Vibber [Fri, 14 Nov 2008 19:11:52 +0000 (19:11 +0000)]
Reverting in-development search changes pending fixing.
Can we please do these sorts of experimental developments on branches before putting them to trunk? Our trunk is meant to be functional and ready to deploy at all times; doing experiments on trunk delays deployments because we have to test and fix them or roll them back.
Reverted:
r43376
r43385
r43403
r43404
r43405
r43406
r43423
Issues I noticed during a few minutes testing:
* Background color mismatch on the frameset for wikis that set a BG color on Special:
* 'browse pages with this prefix' is kind of funky in "Pages & Project" (goes to main namespace only)
* Which namespaces are in "Pages & Project" is not discoverable
* Default link to nonexistent help page Project:Searching kind of sucks. we should avoid doing those by default. It used to link to Help:Contents; any reason for the change from one page which might have previously existed to one which doesn't?
* "Create the page "Stuff" on this wiki!" - Double page creation links seem kind of weird. There should only be one, otherwise why have two?
* Bad prefix link output when search terms are not a valid wiki title
* We've lost the Whatlinkshere link from the old results
Rotem Liss [Fri, 14 Nov 2008 15:25:41 +0000 (15:25 +0000)]
Localization update for he.
Rotem Liss [Fri, 14 Nov 2008 14:05:43 +0000 (14:05 +0000)]
Localization update for he.
Siebrand Mazeland [Fri, 14 Nov 2008 11:58:45 +0000 (11:58 +0000)]
(bug 16251) Update linktrail for Breton.
Siebrand Mazeland [Fri, 14 Nov 2008 10:05:57 +0000 (10:05 +0000)]
Localisation updates for core messages from Betawiki (2008-11-14 10:55 CET)
Siebrand Mazeland [Fri, 14 Nov 2008 08:58:42 +0000 (08:58 +0000)]
Remove message id for message that no longer exists.
Aaron Schulz [Fri, 14 Nov 2008 07:44:14 +0000 (07:44 +0000)]
(bug 16305) Allow optional replacement of user talk page
Tim Starling [Fri, 14 Nov 2008 05:51:39 +0000 (05:51 +0000)]
-1 is not a valid exit code
Brion Vibber [Fri, 14 Nov 2008 02:21:45 +0000 (02:21 +0000)]
Revert class cruft in r43327 :)
I think I'd rather see consistent classes for common UI elements, regardless of where they appear.
For instance 'mw-rc-usertoollinks' ... We have user tool links in a hojillion places; they should all have *the same* class. If you need to distinguish those on RC from those on another page, you use a fancier selector that grabs only those in the special you want.
Brion Vibber [Fri, 14 Nov 2008 00:46:53 +0000 (00:46 +0000)]
Use strict parameter on in_array() checks in wfMsgExt(). In PHP 5.1.6 this was whinging when a Language object was passed as 'language' parameter, trying to convert it to an int (!?).
Since we're only checking for exact strings, an exact match is just fine and it stops the whinging. (Saw no such problem on 5.2.6.)
Example whinge:
Notice: Object of class Language could not be converted to int in /Library/WebServer/Documents/trunk/includes/GlobalFunctions.php on line 742
Tim Starling [Fri, 14 Nov 2008 00:44:08 +0000 (00:44 +0000)]
Fix incorrect use of Title::newFromText(). That function lets the user choose the namespace using a title with colons, to force the namespace you must use Title::makeTitleSafe(). Images are always in the image namespace.
Tim Starling [Fri, 14 Nov 2008 00:30:34 +0000 (00:30 +0000)]
Don't use getParameter() inside substituteResultWithError(), since it will try to call dieUsage() again if the format parameter is invalid. This fixes the error message for invalid formats, which was broken.
Aaron Schulz [Thu, 13 Nov 2008 22:20:51 +0000 (22:20 +0000)]
Various code/style/performance tweaks
Aaron Schulz [Thu, 13 Nov 2008 09:05:16 +0000 (09:05 +0000)]
Follow-up to r43438, forgot this file
Siebrand Mazeland [Thu, 13 Nov 2008 08:59:14 +0000 (08:59 +0000)]
Localisation updates for core messages from Betawiki (2008-11-13 09:37 CET)
Tim Starling [Thu, 13 Nov 2008 08:51:10 +0000 (08:51 +0000)]
Improved $wgRC2UDPInterwikiPrefix feature, so that it can actually be a prefix and not just a boolean. Documented RC2UDP settings.
Aaron Schulz [Thu, 13 Nov 2008 08:15:23 +0000 (08:15 +0000)]
Revert r43329, r43330 due to said performance issues
Aaron Schulz [Thu, 13 Nov 2008 07:58:42 +0000 (07:58 +0000)]
Fix
Brion Vibber [Thu, 13 Nov 2008 01:02:17 +0000 (01:02 +0000)]
Run parsemag stuff through the proper language when wfMsgExt() asks for a specific one.
Previously we only passed on if we were interface or content, but if we're rendering for some third alternative it didn't get used.
Note that parse and parseinline are probably still wrong.... some better model may be required here.
Also it may be wrong in the case of fallbacks ... if you get an English message, is it right to use the Czech magic word parsing?
Hmm.
Might back it out if there's a better way. :)
Aaron Schulz [Wed, 12 Nov 2008 21:12:48 +0000 (21:12 +0000)]
Fix prefix link
Raimond Spekking [Wed, 12 Nov 2008 21:00:59 +0000 (21:00 +0000)]
Add messages for hardcoded parser warnings
Brion Vibber [Wed, 12 Nov 2008 18:06:14 +0000 (18:06 +0000)]
Roll back r43377, r43379 "Factored wfInvokeFancyCallback() out of wfRunHooks(). Allows flexible dynamic invocation to be used in other contexts." / "Renamed the new wfInvokeFancyCallback to simply wfInvoke."
Breaks existing hooks including core language converters:
Notice: Undefined variable: event in /Library/WebServer/Documents/trunk/includes/Hooks.php on line 61
Warning: call_user_func_array(): First argument is expected to be a valid callback, 'ZhConverter::on' was given in /Library/WebServer/Documents/trunk/includes/Hooks.php on line 119
Notice: Undefined variable: args in /Library/WebServer/Documents/trunk/includes/Hooks.php on line 80
Notice: Undefined variable: event in /Library/WebServer/Documents/trunk/includes/Hooks.php on line 61
Detected bug in an extension! Hook ZhConverter::on failed to return a value; should return true to continue hook processing or false to abort.
Backtrace:
#0 /Library/WebServer/Documents/trunk/includes/Article.php(1684): wfRunHooks('ArticleSaveComp...', Array)
#1 /Library/WebServer/Documents/trunk/includes/Article.php(1354): Article->doEdit('Article for spe...', '', 97)
#2 /Library/WebServer/Documents/trunk/maintenance/parserTests.inc(998): Article->insertNewArticle('Article for spe...', '', false, false)
#3 /Library/WebServer/Documents/trunk/maintenance/parserTests.inc(307): ParserTest->addArticle('Xyzzyx', 'Article for spe...', 5168)
#4 /Library/WebServer/Documents/trunk/maintenance/parserTests.inc(273): ParserTest->runFile('/Library/WebSer...')
#5 /Library/WebServer/Documents/trunk/maintenance/parserTests.php(73): ParserTest->runTestsFromFiles(Array)
#6 {main}
Brion Vibber [Wed, 12 Nov 2008 17:50:07 +0000 (17:50 +0000)]
Avoid destructing the language object, as it corrupts the language object cache, and causes the next test to load a bogus language object and esplode.