Brion Vibber [Tue, 3 Oct 2017 22:15:15 +0000 (15:15 -0700)]
Support uploads with UTF-8 names on Windows
On PHP 7.1 and later, filesystem functions on Windows
use the Unicode system functions, which makes our file
handling work for non-ASCII file names.
Previously this was blacklisted for Windows on all PHP
versions. Versions before 7.1 will still reject Unicode
filenames with non-ASCII chars.
Bug: T3780
Change-Id: I94377faa5185f133be2dfb7b9b6aeacbd582834f
Translation updater bot [Tue, 3 Oct 2017 20:11:24 +0000 (22:11 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Id856ec22448bbe6d788185bbfbe020bb387d8a56
jenkins-bot [Tue, 3 Oct 2017 20:02:19 +0000 (20:02 +0000)]
Merge "TitleWidget: Only apply padding fix to withImages mode"
jenkins-bot [Tue, 3 Oct 2017 19:49:48 +0000 (19:49 +0000)]
Merge "TitleOptionWidget: Don't show an icon when showImages=false"
jenkins-bot [Tue, 3 Oct 2017 19:49:44 +0000 (19:49 +0000)]
Merge "mw.widgets.SearchInputWidget: Avoid overriding getOptionWidgetData"
jenkins-bot [Tue, 3 Oct 2017 18:46:52 +0000 (18:46 +0000)]
Merge "Remove 'Browser default' editfont option"
jenkins-bot [Tue, 3 Oct 2017 18:12:37 +0000 (18:12 +0000)]
Merge "mediawiki.searchSuggest: Add support for search namespace preferences"
Paladox [Sun, 15 Jan 2017 18:18:29 +0000 (18:18 +0000)]
mediawiki.searchSuggest: Add support for search namespace preferences
This way it allows namespaces other then NS_MAIN.
Bug: T26214
Change-Id: I6a545eb8563e81a66de39a8295ef2e40c3e73f95
Kunal Mehta [Tue, 15 Aug 2017 20:00:27 +0000 (13:00 -0700)]
OutputPage: Turn html5shiv into a raw ResourceLoader module
This lets us take advantage of ResourceLoader's on the fly minification
rather than needing to ship a minified copy, which is problematic for
other distributions like Debian.
Because the startup module excludes raw modules, it is not possible to
load or depend upon this module, and trying to use
`mw.loader.load('html5shiv')` for example will throw an exception.
This follows-up
3a30e03645f895b.
Change-Id: I635e224fb043c614c4918771c7c8f836575c683b
Timo Tijhof [Tue, 3 Oct 2017 17:18:49 +0000 (18:18 +0100)]
resourceloader: Add unit test for ClientHtml::makeLoad sync=>true
Used by Special:JavaScriptTest, and we may need to use this
in OutputPage as well (for html5shiv).
Change-Id: If7d7c12056dc3aab78486050f0798d42b158d9a9
Timo Tijhof [Tue, 3 Oct 2017 17:10:02 +0000 (18:10 +0100)]
phpunit: Include all raw modules in detection of illegal dependencies
* Use getStartupModules() instead of hardcoding these two module names.
* Also collect any other module that is registered with raw=>true.
Change-Id: I5f75cc8f99b90f58d76b7e87f068f50f9f608ed0
jenkins-bot [Tue, 3 Oct 2017 15:57:09 +0000 (15:57 +0000)]
Merge "Add a help button to the Tagged Edits menu"
jenkins-bot [Tue, 3 Oct 2017 15:52:29 +0000 (15:52 +0000)]
Merge "Change "Advanced filters" label color"
jenkins-bot [Tue, 3 Oct 2017 15:06:13 +0000 (15:06 +0000)]
Merge "SpecialBlock: Tweaks for OOUI HTMLForm"
Ed Sanders [Tue, 3 Oct 2017 15:04:54 +0000 (16:04 +0100)]
TitleWidget: Only apply padding fix to withImages mode
Change-Id: I60d0c3169cede2251595d68649c76823ea77afe9
Ed Sanders [Tue, 3 Oct 2017 14:52:13 +0000 (15:52 +0100)]
TitleOptionWidget: Don't show an icon when showImages=false
Change-Id: Ib4262bc15a3845ec9e7af484dbdfa4277f2f4014
Ed Sanders [Tue, 3 Oct 2017 14:42:19 +0000 (15:42 +0100)]
mw.widgets.SearchInputWidget: Avoid overriding getOptionWidgetData
This means we don't have to track upstream changes to the method.
Change-Id: I44739eefae4d47aeee9f506e0d99e605da4fb961
Bartosz Dziewoński [Tue, 3 Oct 2017 13:44:30 +0000 (15:44 +0200)]
SpecialBlock: Tweaks for OOUI HTMLForm
* Expand both the dropdown and textfield of "Reason" field to the
usual maximum width and display them on separate lines.
* Fix autohiding of form fields where applicable (checkboxes that only
apply when blocking a user or an IP address).
* Fix bolding of the "Confirm block" label when blocking yourself.
Follow-up to
d56758e134358fdac3f8dda16417bfd30f78bab9.
Bug: T107036
Change-Id: Ia5c54e518de99a79f5319c42ccf1a9a0e31ad471
petarpetkovic [Tue, 3 Oct 2017 11:45:03 +0000 (13:45 +0200)]
Change "Advanced filters" label color
Change "Advanced filters" label color to Base20 (#54595D),
fixing monobook skin low contrast.
Bug: T172733
Change-Id: Idb1b9ad7120c387482f8df7fcad8508f2a95139e
petarpetkovic [Tue, 3 Oct 2017 11:04:55 +0000 (13:04 +0200)]
Add a help button to the Tagged Edits menu
Bug: T176661
Change-Id: Ia295633dcf96a5466650620ef6e5cef766d19988
Željko Filipin [Tue, 3 Oct 2017 09:17:39 +0000 (11:17 +0200)]
Selenium tests should log in before creating pages
MediaWiki Vagrant by default allows creating pages to anonymous users,
but other environments, like Beta Cluster, require user to log in
before creating pages.
Bug: T176315
Change-Id: I34eeaf3cc22a64be6580aa483b28885137ba60b6
Translation updater bot [Mon, 2 Oct 2017 20:14:52 +0000 (22:14 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I75b3048eb0491d6e67a2a3cdf34b47791bd6baed
Roan Kattouw [Mon, 2 Oct 2017 19:07:57 +0000 (12:07 -0700)]
Reapply "RCFilters: Don't apply/clear highlights 66 times"
Reverts
84ddcd5d23, reapplies
212d67c67.
The original version broke the highlight color circles, this fixes it
by using enable instead of this.highlightEnabled to pass down to the
items. The former was always false, so it didn't actually propagate
the state down correctly.
Bug: T177107
Change-Id: I341d9bcd39252eac07bfebfa6d46895bc62c372f
jenkins-bot [Mon, 2 Oct 2017 18:34:38 +0000 (18:34 +0000)]
Merge "Revert "RCFilters: Don't apply/clear highlights 66 times""
Catrope [Mon, 2 Oct 2017 18:24:33 +0000 (18:24 +0000)]
Revert "RCFilters: Don't apply/clear highlights 66 times"
Breaks highlight display
This reverts commit
212d67c67e153f95fd2eb49a75b7ece27d794b53.
Change-Id: Ia0111bd35a40df56122a5b8c483de1be35609911
jenkins-bot [Mon, 2 Oct 2017 17:41:41 +0000 (17:41 +0000)]
Merge "Updated type and function docs for MagicWord.php"
jenkins-bot [Mon, 2 Oct 2017 16:36:49 +0000 (16:36 +0000)]
Merge "TitleWidget: Use OOUI query highlighting, instead of jQuery lib"
Umherirrender [Mon, 2 Oct 2017 11:52:17 +0000 (13:52 +0200)]
Updated type and function docs for MagicWord.php
Change-Id: I46ebd315a99b1677ff89ba392c0072b41bbeb36d
jenkins-bot [Mon, 2 Oct 2017 09:09:19 +0000 (09:09 +0000)]
Merge "SpecialBlock: Switch to OOUI form"
jenkins-bot [Mon, 2 Oct 2017 09:06:58 +0000 (09:06 +0000)]
Merge "Enable IP ranges in HTMLUserTextField"
jenkins-bot [Mon, 2 Oct 2017 04:44:08 +0000 (04:44 +0000)]
Merge "Remove unneeded js module in SpecialUnblock"
Seb35 [Fri, 15 Sep 2017 08:29:13 +0000 (10:29 +0200)]
Improve GitInfo for reading packed refs
GitInfo only reads branches in files /refs/heads/*; it should also
read those in /.git/packed-refs.
There are 4 tests in this commit to test this new "feature" and add some
code coverage to other methods. Given this class tests Git behaviour and
MediaWiki itself is versioned with Git, the test data are created during
the tests and removed at the end to avoid interference with Git as CVS.
Bug: T155747
Change-Id: Icccdf3ec797788582f836e2d8e267a1d714d50dc
jenkins-bot [Sun, 1 Oct 2017 21:59:39 +0000 (21:59 +0000)]
Merge "mw.loader: Return consistent object shape from splitModuleKey()"
jenkins-bot [Sun, 1 Oct 2017 20:51:31 +0000 (20:51 +0000)]
Merge "Avoid double escaping headers in InfoAction"
jenkins-bot [Sun, 1 Oct 2017 20:50:07 +0000 (20:50 +0000)]
Merge "Clean up wiki ID and DB domain ID handling"
Translation updater bot [Sun, 1 Oct 2017 19:55:27 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I9d12a53dfbb3eb90cae81cd670f94cb5305e3ff4
Ed Sanders [Sun, 1 Oct 2017 12:14:40 +0000 (13:14 +0100)]
TitleWidget: Use OOUI query highlighting, instead of jQuery lib
Change-Id: I75ee7b3da74bdf9638c442322b699d22b4fee74c
jenkins-bot [Sat, 30 Sep 2017 23:45:11 +0000 (23:45 +0000)]
Merge "Check requirements for parser test suite in phpunit tests"
jenkins-bot [Sat, 30 Sep 2017 23:44:57 +0000 (23:44 +0000)]
Merge "build: Updating mediawiki/mediawiki-codesniffer to 13.0.0"
Translation updater bot [Sat, 30 Sep 2017 19:54:25 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ic025a6a40c6af463475b0e50ce14a20ea17243f6
Timo Tijhof [Sat, 30 Sep 2017 17:50:53 +0000 (18:50 +0100)]
mw.loader: Use Array#indexOf directly instead of jQuery.inArray
Unlike other jQuery methods (which are quite often significantly
faster or slower than native methods), jQuery.inArray is quite
literally a wrapper around Array#indexOf. Use it directly where
possible.
Also:
* Replace `$.inArray(val, [a, b]) !== -1` pattern
with `val === a || val === b` which is upto 10x faster.
* mw.loader.store.set.: Remove redundant parenthesis in nested expression.
Change-Id: Ia2b922b3245bfb39b609b57e84938317e9c89cd6
Timo Tijhof [Sat, 30 Sep 2017 17:35:13 +0000 (18:35 +0100)]
mw.loader: Return consistent object shape from splitModuleKey()
This is used in mw.loader.implement() in a truthy check before
assigning as value of `registry[module].version`.
Both implicit undefined and empty string are falsey so the
behaviour is unchanged.
This reduces shape variability for JS engines, and also avoid
potential mistakes if the function is used elsewhere since
internally the registry, as maintained by mw.loader.register(),
uses empty string as default for version, not undefined.
Change-Id: I067137557a55d521fefa40986373e55b6bbb59ff
Aaron Schulz [Mon, 25 Sep 2017 10:37:13 +0000 (12:37 +0200)]
Clean up wiki ID and DB domain ID handling
Bug: T174017
Change-Id: I42299a393c6691d39817db1d83a176a17df2474b
jenkins-bot [Sat, 30 Sep 2017 02:09:46 +0000 (02:09 +0000)]
Merge "RCFilters: Don't apply/clear highlights 66 times"
Roan Kattouw [Sat, 30 Sep 2017 00:35:43 +0000 (17:35 -0700)]
RCFilters: Don't apply/clear highlights 66 times
Applying highlights on init was very slow, because applyHighlights
was called 66 times and clearHighlights 64 times.
We first call toggleHighlight() on each filter item, which
leads to update events being emitted by each item, and onItemUpdate
calls clearHighlights() followed by applyHighlights().
There are 64 filter items in my setup, so that's 64 pairs of
clear+apply calls. Then we emit highlightChange, which causes
another apply call, and onModelUpdate calls apply as well.
This change makes sure that the model-wide ("global") highlight
flag is always set to false while we're toggling the highlight
flags on the individual items, so that onItemUpdate short-circuits
and doesn't call clear/apply. There are still other issues (too many
places call clear/apply, too many events emitted), but running the
highlight code twice instead of 130 times on init fixes most
of the performance problems.
Bug: T177107
Change-Id: I65c409ccfabd974ef0b5e2bddff70c9e78e8fd60
Kunal Mehta [Sat, 30 Sep 2017 00:24:37 +0000 (17:24 -0700)]
Sanitizer: hard deprecate passing $options to escapeIdReferenceList()
Change-Id: I22743102e75614bba848e09f032586923cef0f60
jenkins-bot [Fri, 29 Sep 2017 22:20:52 +0000 (22:20 +0000)]
Merge "Remove "only newlines in trailer" special case for category/language links"
Matěj Suchánek [Wed, 20 Sep 2017 14:41:40 +0000 (16:41 +0200)]
Avoid double escaping headers in InfoAction
Bug: T111763
Change-Id: I4f582ce5785448a4cb48f3a1d56371eddf38a232
Bartosz Dziewoński [Sun, 26 Jul 2015 23:44:25 +0000 (01:44 +0200)]
SpecialBlock: Switch to OOUI form
* Remove additional wrapper, and the 'blockip-legend' message.
* Replace autocompletion using 'mediawiki.userSuggest' with OOUI,
by using 'type' => 'user' for the username field
Bug: T107036
Change-Id: Ib8f7e03388073450ecff28ad2c0d3f9161f259d8
Florian [Tue, 25 Aug 2015 18:05:35 +0000 (20:05 +0200)]
Enable IP ranges in HTMLUserTextField
Like an existing user and a single IP, allow to use an IP range, too.
Bug: T107039
Change-Id: I9137f71f6119c68d787f508a3f57b476404315d8
Amir Sarabadani [Fri, 29 Sep 2017 17:44:30 +0000 (19:44 +0200)]
Remove unneeded js module in SpecialUnblock
Followup to I3c51183c0275dd2f9522ba60990852cc96409e2d
Bug: T107036
Change-Id: I6d1ca8b07e40950480344a106558a98a5bf5d341
jenkins-bot [Fri, 29 Sep 2017 17:13:04 +0000 (17:13 +0000)]
Merge "Revert "CSSMin: Improve encoding of quotes in embedded SVGs""
jenkins-bot [Fri, 29 Sep 2017 17:10:44 +0000 (17:10 +0000)]
Merge "Revert "CSSMin: Mangle whitespace in embedded SVGs""
jenkins-bot [Fri, 29 Sep 2017 16:34:23 +0000 (16:34 +0000)]
Merge "TitleWidget: Upstream generic page icons from VE"
Ed Sanders [Fri, 29 Sep 2017 15:30:40 +0000 (16:30 +0100)]
Tweak layout of TitleWidget results
Bug: T177085
Change-Id: I663e63e89b1be2d377de28ba74ad43519ff04741
Ed Sanders [Fri, 29 Sep 2017 14:42:47 +0000 (15:42 +0100)]
TitleWidget: Upstream generic page icons from VE
Change-Id: I297648d14b4a2540a40f3a0b7d22a7905ef7c035
VolkerE [Fri, 29 Sep 2017 11:53:02 +0000 (11:53 +0000)]
Revert "CSSMin: Improve encoding of quotes in embedded SVGs"
This reverts commit
5e3165f0080961e637e9ed600b696786aee7eda4.
Bug: T176884
Change-Id: I8bd9af67aeb11cb478ba402205ce834b1bec17a7
Esanders [Fri, 29 Sep 2017 13:39:50 +0000 (13:39 +0000)]
Revert "CSSMin: Mangle whitespace in embedded SVGs"
This reverts commit
dfd42d2653ea9ff2ca05dab7cd6f2285abba9d08.
Bug: T176884
Change-Id: Iddc98332d0b5a31d3a1c56c14014a53a06393f21
jenkins-bot [Fri, 29 Sep 2017 11:08:39 +0000 (11:08 +0000)]
Merge "Migrate Special:Unblock to OOUI"
jenkins-bot [Fri, 29 Sep 2017 05:37:43 +0000 (05:37 +0000)]
Merge "Update cleanupSpam.php to hide its activity from RecentChanges"
jenkins-bot [Fri, 29 Sep 2017 05:33:26 +0000 (05:33 +0000)]
Merge "Improve namespace handling in tests"
jenkins-bot [Fri, 29 Sep 2017 05:31:59 +0000 (05:31 +0000)]
Merge "Fix patchfile used to add newtalk table on mysql"
MarcoAurelio [Tue, 19 Sep 2017 20:26:14 +0000 (22:26 +0200)]
Update cleanupSpam.php to hide its activity from RecentChanges
Spam cleanup activities, mostly when it comes from automated processes
(the so called 'spambots') can involve a fair ammount of edits and log
actions to accomplish.
As such, to avoid flooding Special:RecentChanges, this script will now
set a bot flag on the script run so its edits and actions won't show
up in that special page.
To prepare this patch I had the help of Bartosz Dziewoński which I'd
also like to thank and I'll credit as co-author as well.
Bug: T176206
Co-Authored-By: Bartosz Dziewoński <matma.rex@gmail.com>
Change-Id: Ifde08056a7481b877b4b82699cc0a5ea3f962dd9
jenkins-bot [Fri, 29 Sep 2017 05:25:22 +0000 (05:25 +0000)]
Merge "Do not include RC_EXTERNAL in number active users on Special:Statistics"
Brad Jorsch [Mon, 11 Sep 2017 20:37:18 +0000 (16:37 -0400)]
Improve namespace handling in tests
MWNamespace has three internal caches, only one of which can be cleared
(and that somewhat oddly by passing a boolean to
MWNamespace::getCanonicalNamespaces()).
This change introduces a MWNamespace::clearCaches() method to clear all
three caches. It also adds some resetting in tests that seemed to be
missing it.
Change-Id: I1dcfcd8713888b3ff8fc75e95329ba72bd95d0c9
jenkins-bot [Fri, 29 Sep 2017 05:18:09 +0000 (05:18 +0000)]
Merge "Revert "DumpFilter is autoloaded. No need to require in maintenance script""
jenkins-bot [Fri, 29 Sep 2017 05:16:10 +0000 (05:16 +0000)]
Merge "Consistently preserve anchors in the title specified in 'mainpage' message"
jenkins-bot [Fri, 29 Sep 2017 05:15:56 +0000 (05:15 +0000)]
Merge "Fix CreditsAction when user has no real name set but real names enabled"
jenkins-bot [Fri, 29 Sep 2017 05:15:53 +0000 (05:15 +0000)]
Merge "objectcache: Improve WANObjectCache test coverage"
Brian Wolff [Tue, 26 Sep 2017 21:40:04 +0000 (21:40 +0000)]
Do not include RC_EXTERNAL in number active users on Special:Statistics
We already exclude external (mostly Wikidata) actions from counting on
Special:ActiveUsers as of
56524c05. Should be consistent.
Change-Id: Ib69a614a65246a0f4f47365751f9bef130f47475
Brian Wolff [Thu, 28 Sep 2017 21:35:44 +0000 (21:35 +0000)]
Follow-up
67f04373d fix stupid typo
Fot should be For
Change-Id: I3cb87a94feea32f1c98345ceaa19f9a75fde266d
jenkins-bot [Thu, 28 Sep 2017 20:26:44 +0000 (20:26 +0000)]
Merge "Make the RC/Watchlist legend not jump when initially collapsed"
Translation updater bot [Thu, 28 Sep 2017 19:54:45 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I02b4624b999123b0841af96adf9f6c3467fa9b3b
Roan Kattouw [Thu, 28 Sep 2017 00:09:05 +0000 (17:09 -0700)]
Make the RC/Watchlist legend not jump when initially collapsed
Look at the collapsed/expanded cookie and add class="mw-collapsed"
if it's going to be collapsed.
This is kind of a prelude to T42812.
Change-Id: Icaca762a9d7b000c973d9275f395623129f67979
jenkins-bot [Thu, 28 Sep 2017 18:11:58 +0000 (18:11 +0000)]
Merge "Distinguish GET from POST for PostSend expectations"
jenkins-bot [Thu, 28 Sep 2017 18:11:55 +0000 (18:11 +0000)]
Merge "Add more ProcessCacheLRU comments"
Timo Tijhof [Mon, 25 Sep 2017 23:21:40 +0000 (00:21 +0100)]
objectcache: Improve WANObjectCache test coverage
class WANObjectCache (methods: 40% -> 67%, lines: 65% -> 88%)
* Allow indirect coverage of protected/private utility methods from
existing tests.
* Add basic test for setLogger().
* Add basic test for newEmpty().
* Add basic test for getQoS().
Change-Id: Ifb79ed2ff1febbd2f5477b8ed6319992ce88eb29
jenkins-bot [Thu, 28 Sep 2017 17:53:50 +0000 (17:53 +0000)]
Merge "HTMLFormField: Treat weird ' ' labels as empty in OOUI mode"
jenkins-bot [Thu, 28 Sep 2017 17:12:51 +0000 (17:12 +0000)]
Merge "LogFormatter: Don't return a non-array from formatParameterValueForApi"
Huji Lee [Thu, 28 Sep 2017 15:20:45 +0000 (11:20 -0400)]
Unregister hooks that interfere with unit testing
Id7403f57cc9d751ada85b611193c1d8f3503e713 did not properly
reference the hook
Bug: T176102
Change-Id: Ibff72c0efe82ba6fd4458e3c8a96179f50ca21b0
Brad Jorsch [Thu, 28 Sep 2017 14:06:53 +0000 (10:06 -0400)]
LogFormatter: Don't return a non-array from formatParameterValueForApi
If the title for a 'title' or 'title-link' type is invalid, the code
still must not return a non-array from the method.
I'm not sure this is what was behind T176938, but it's the only thing I
can find that might cause the errors I saw logged at about the same
time.
Change-Id: Iae77eb6ad9a64d8b67074164ff0c0fea36826f3c
Bartosz Dziewoński [Thu, 28 Sep 2017 12:10:31 +0000 (14:10 +0200)]
HTMLFormField: Treat weird ' ' labels as empty in OOUI mode
I have no idea where this convention came from, but we had them in
core until
265ff105aaa814c828a35e599ed35d0b0bb00e53 and they still
appear widely in extensions. The non-OOUI code also has special
handling for it (a label equalling ' ' is treated as raw HTML
even when not marked as such). In OOUI-style "vertical" forms these
fake labels cause a lot of unnecessary white space to appear, so let's
just not display them.
Change-Id: I45559fa69dc1ae4b9d048445e27a24815fe93b6d
jenkins-bot [Thu, 28 Sep 2017 10:47:52 +0000 (10:47 +0000)]
Merge "Migrate and convert WL settings to the new UX"
jenkins-bot [Thu, 28 Sep 2017 10:33:21 +0000 (10:33 +0000)]
Merge "Fix insertSelect() with IGNORE in PostgreSQL"
jenkins-bot [Thu, 28 Sep 2017 10:29:19 +0000 (10:29 +0000)]
Merge "Reopen db connection after doing SpecialPageCacheUpdates"
Aaron Schulz [Thu, 28 Sep 2017 10:05:03 +0000 (12:05 +0200)]
Distinguish GET from POST for PostSend expectations
This avoids needless log entries for POST requests.
Bug: T166199
Change-Id: I515fde1f619f7f016d08b7c270a1c155ee171bf9
Brian Wolff [Thu, 28 Sep 2017 02:36:31 +0000 (02:36 +0000)]
Fix CreditsAction when user has no real name set but real names enabled
Change-Id: Ief347739a1231fa8bd814694bdb5b4f44ba41a77
jenkins-bot [Wed, 27 Sep 2017 23:09:23 +0000 (23:09 +0000)]
Merge "Revert Message dependency from DB exception classes"
jenkins-bot [Wed, 27 Sep 2017 23:02:57 +0000 (23:02 +0000)]
Merge "user: Unregister hooks that interfere with unit testing"
Huji Lee [Mon, 18 Sep 2017 01:10:27 +0000 (21:10 -0400)]
user: Unregister hooks that interfere with unit testing
testExecute_email() should unregister the hooks
mailPasswordInternal and SpecialPasswordResetOnSubmit
for proper unit testing.
Bug: T176102
Change-Id: Id7403f57cc9d751ada85b611193c1d8f3503e713
Brian Wolff [Tue, 26 Sep 2017 21:51:31 +0000 (21:51 +0000)]
Reopen db connection after doing SpecialPageCacheUpdates
Special page updates on commons have been broken recently due
to Mysql "going away" after doing the ActiveUsers special page
cache update. Presumably this is because we were only repinging
the server after QueryPage updates, and not the callback updates
(Combined with a spike in wikidata recentchanges entries making
the ActiveUsers callback now take about an hour to complete)
Bug: T176055
Change-Id: Ic344940460c353544d7c08bbe2d8c900f6cc73da
Bartosz Dziewoński [Wed, 27 Sep 2017 21:41:47 +0000 (23:41 +0200)]
Consistently preserve anchors in the title specified in 'mainpage' message
When 'mainpage' was used in the 'sidebar' message, the anchor would be
preserved (code in Skin::addToSidebarPlain() uses Title::getLinkURL()).
When 'mainpage' was used on its own in Skin::makeMainPageUrl() (which
is used in SkinTemplate::buildNavUrls(), and many skins use that data
to generate the logo link), it would not be preserved (the code used
Title::getLocalURL()).
Bug: T176583
Change-Id: Icc4895c08089caaa06e37ce765819829b90de0ff
Translation updater bot [Wed, 27 Sep 2017 19:55:40 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I7ea7ab422e07d18a233e2c9e8df9e8d0c3d158c0
petarpetkovic [Wed, 27 Sep 2017 14:00:18 +0000 (16:00 +0200)]
Migrate and convert WL settings to the new UX
Convert Watchlist settings to new UX, with following rules:
- If "Hide edits by anonymous users from the watchlist" is checked,
add "Registered" filter to defaults.
- If "Hide edits by logged in users from the watchlist" is checked,
add "Unregistered" filter to defaults.
- Change test for Special:Watchlist page, so new structured filters
are supported.
Bug: T172757
Change-Id: I27bdaa1401323fa3143f79a57dc5b9773e48fd1d
Chad [Wed, 27 Sep 2017 18:52:58 +0000 (18:52 +0000)]
Revert "DumpFilter is autoloaded. No need to require in maintenance script"
Broke dumps, turns out autoloader isn't infallible
This reverts commit
f127125ec6b76f843fc73a1faba31d973e33bfa5.
Change-Id: I7711094351cf3f186730857ae59975e183daed1d
Brad Jorsch [Wed, 27 Sep 2017 12:01:58 +0000 (08:01 -0400)]
Fix watchlist "in the last X hours" display
If6280ad6 changed the interpretation of the URL parameter "days=0" (or
any negative value) from meaning "maximum number of days" to actually
meaning "0 days". That's a somewhat annoying breaking change, but easily
worked around by updating bookmarks.
But it didn't update the display on the page, so despite querying 0 days
it would still incorrectly say something like "in the last 720 hours"
rather than "in the last 0 hours".
Bug: T176857
Change-Id: I90c79ef9c4819a34060515b863277fd185828ed9
Aaron Schulz [Fri, 24 Feb 2017 16:20:07 +0000 (08:20 -0800)]
Revert Message dependency from DB exception classes
This was added in
a90bbf1a.
These classes are in /libs and should not depend on all of MediaWiki.
Change-Id: I67bc818b0c674f1aa3e0dde27a38a9f385fcab75
jenkins-bot [Wed, 27 Sep 2017 02:32:38 +0000 (02:32 +0000)]
Merge "objectcache: Improve WANObjectCache test coverage"
jenkins-bot [Tue, 26 Sep 2017 23:20:31 +0000 (23:20 +0000)]
Merge "Update jQuery Migrate to v3.0.1"
Jforrester [Tue, 26 Sep 2017 21:57:26 +0000 (21:57 +0000)]
Merge "Update OOjs UI to v0.23.2"