From: Aaron Schulz <aschulz@wikimedia.org>
Date: Tue, 27 May 2014 18:21:07 +0000 (-0700)
Subject: Reduce Title::invalidateCache contention a bit
X-Git-Tag: 1.31.0-rc.0~15558
X-Git-Url: https://git.cyclocoop.org/%7B%7B%20url_for%28%27admin_user_edit%27%2C%20iduser=user.userid%29%20%7D%7D?a=commitdiff_plain;h=fc30f03dd3c8bb2d1278b59cf27213c6af64bed0;p=lhc%2Fweb%2Fwiklou.git

Reduce Title::invalidateCache contention a bit

* Lots of deadlocks seems to happen on page deletion,
  where the ID is likely 0 (this also has the worst locks)

bug: 37519
Change-Id: I028783a998946615b93e1425c6f69e00afd7b1bb
---

diff --git a/includes/Title.php b/includes/Title.php
index ea4a1b2fb6..d8f6b75112 100644
--- a/includes/Title.php
+++ b/includes/Title.php
@@ -4728,6 +4728,10 @@ class Title {
 			return false;
 		}
 
+		if ( $this->mArticleID === 0 ) {
+			return true; // avoid gap locking if we know it's not there
+		}
+
 		$method = __METHOD__;
 		$dbw = wfGetDB( DB_MASTER );
 		$conds = $this->pageCond();