From: Bartosz DziewoƄski Date: Mon, 16 Apr 2018 18:09:32 +0000 (+0200) Subject: mw.widgets.visibleLengthLimit: Do not show countdown until last 99 characters X-Git-Tag: 1.34.0-rc.0~5520^2 X-Git-Url: https://git.cyclocoop.org/%7B%7B%20url_for%28%27admin_user_edit%27%2C%20iduser=user.userid%29%20%7D%7D?a=commitdiff_plain;h=d1d907b36e6e93eb71a8f01630a62b0861818408;p=lhc%2Fweb%2Fwiklou.git mw.widgets.visibleLengthLimit: Do not show countdown until last 99 characters With the limit being recently increased to 500 characters users are less likely to hit it, and so the distracting label is less useful, and it might instead inspire users to fill in the longest possible summary when it's not needed. Bug: T190570 Change-Id: I54d75ab6061de0de79b7a8112eb859a4c8a5e22a --- diff --git a/resources/src/mediawiki.widgets.visibleLengthLimit/mediawiki.widgets.visibleLengthLimit.js b/resources/src/mediawiki.widgets.visibleLengthLimit/mediawiki.widgets.visibleLengthLimit.js index c92c5e5beb..aab1e7c6d3 100644 --- a/resources/src/mediawiki.widgets.visibleLengthLimit/mediawiki.widgets.visibleLengthLimit.js +++ b/resources/src/mediawiki.widgets.visibleLengthLimit/mediawiki.widgets.visibleLengthLimit.js @@ -20,7 +20,11 @@ function updateCount() { var remaining = limit - byteLength( textInputWidget.getValue() ); - remaining = mw.language.convertNumber( remaining ); + if ( remaining > 99 ) { + remaining = ''; + } else { + remaining = mw.language.convertNumber( remaining ); + } textInputWidget.setLabel( remaining ); } textInputWidget.on( 'change', updateCount ); @@ -44,7 +48,11 @@ function updateCount() { var remaining = limit - codePointLength( textInputWidget.getValue() ); - remaining = mw.language.convertNumber( remaining ); + if ( remaining > 99 ) { + remaining = ''; + } else { + remaining = mw.language.convertNumber( remaining ); + } textInputWidget.setLabel( remaining ); } textInputWidget.on( 'change', updateCount );