* Item class for a archive table row
*/
class RevDelArchiveItem extends RevDelRevisionItem {
- public function __construct( $list, $row ) {
- RevDelItem::__construct( $list, $row );
- $this->revision = Revision::newFromArchiveRow( $row,
- [ 'page' => $this->list->title->getArticleID() ] );
+ protected static function initRevision( $list, $row ) {
+ return Revision::newFromArchiveRow( $row,
+ [ 'page' => $list->title->getArticleID() ] );
}
public function getIdField() {
protected $lockFile;
public function __construct( $list, $row ) {
- RevDelItem::__construct( $list, $row );
- $this->file = ArchivedFile::newFromRow( $row );
+ parent::__construct( $list, $row );
$this->lockFile = RepoGroup::singleton()->getLocalRepo()->newFile( $row->fa_name );
}
+ protected static function initFile( $list, $row ) {
+ return ArchivedFile::newFromRow( $row );
+ }
+
public function getIdField() {
return 'fa_id';
}
* used via RevDelRevisionList.
*/
class RevDelArchivedRevisionItem extends RevDelArchiveItem {
- public function __construct( $list, $row ) {
- RevDelItem::__construct( $list, $row );
-
- $this->revision = Revision::newFromArchiveRow( $row,
- [ 'page' => $this->list->title->getArticleID() ] );
- }
-
public function getIdField() {
return 'ar_rev_id';
}
public function __construct( $list, $row ) {
parent::__construct( $list, $row );
- $this->file = RepoGroup::singleton()->getLocalRepo()->newFileFromRow( $row );
+ $this->file = static::initFile( $list, $row );
+ }
+
+ /**
+ * Create file object from $row sourced from $list
+ *
+ * @param RevDelFileList $list
+ * @param mixed $row
+ * @return mixed
+ */
+ protected static function initFile( $list, $row ) {
+ return RepoGroup::singleton()->getLocalRepo()->newFileFromRow( $row );
}
public function getIdField() {
public function __construct( $list, $row ) {
parent::__construct( $list, $row );
- $this->revision = new Revision( $row );
+ $this->revision = static::initRevision( $list, $row );
+ }
+
+ /**
+ * Create revision object from $row sourced from $list
+ *
+ * @param RevisionListBase $list
+ * @param mixed $row
+ * @return Revision
+ */
+ protected static function initRevision( $list, $row ) {
+ return new Revision( $row );
}
public function getIdField() {
"PhanUndeclaredMethod",
// approximate error count: 1224
"PhanUndeclaredProperty",
- // approximate error count: 3
- "PhanUndeclaredStaticMethod",
// approximate error count: 58
"PhanUndeclaredVariableDim",
],