From ce1e42b87fac93becfa74beaa45e1f4644629cae Mon Sep 17 00:00:00 2001 From: Siebrand Mazeland Date: Wed, 9 Mar 2016 01:09:54 +0100 Subject: [PATCH] Skin::newFromKey() was removed Deprecated since 1.24. No uses in core or Gerrit extensions remaining. Change-Id: If5d18ec56a066ea3ab28503b1bf5a84a8588ba5a --- RELEASE-NOTES-1.27 | 1 + includes/skins/Skin.php | 17 ----------------- 2 files changed, 1 insertion(+), 17 deletions(-) diff --git a/RELEASE-NOTES-1.27 b/RELEASE-NOTES-1.27 index d91af428f2..c6da46f3c9 100644 --- a/RELEASE-NOTES-1.27 +++ b/RELEASE-NOTES-1.27 @@ -393,6 +393,7 @@ changes to languages because of Phabricator reports. * Title::newFromRedirect() was removed (deprecated since 1.21). * Skin::commonPrintStylesheet() was removed (deprecated since 1.22). * Skin::getCommonStylePath() was removed (deprecated since 1.24). +* Skin::newFromKey() was removed (deprecated since 1.24). == Compatibility == diff --git a/includes/skins/Skin.php b/includes/skins/Skin.php index 17f5fa4e0b..a22571144b 100644 --- a/includes/skins/Skin.php +++ b/includes/skins/Skin.php @@ -140,23 +140,6 @@ abstract class Skin extends ContextSource { } } - /** - * Factory method for loading a skin of a given type - * @param string $key 'monobook', 'vector', etc. - * @return Skin - * @deprecated since 1.24; Use SkinFactory instead - */ - static function &newFromKey( $key ) { - wfDeprecated( __METHOD__, '1.24' ); - - $key = Skin::normalizeKey( $key ); - $factory = SkinFactory::getDefaultInstance(); - - // normalizeKey() guarantees that a skin with this key will exist. - $skin = $factory->makeSkin( $key ); - return $skin; - } - /** * @return string Skin name */ -- 2.20.1