From: Niklas Laxström <niklas.laxstrom@gmail.com>
Date: Sat, 21 Jun 2014 10:59:05 +0000 (+0000)
Subject: Make the deprecation notice actually useful by listing the class
X-Git-Tag: 1.31.0-rc.0~15292^2
X-Git-Url: https://git.cyclocoop.org/%7B%7B%20url_for%28?a=commitdiff_plain;h=66315413b32fa7067c5408cafae81b0281dc03b6;p=lhc%2Fweb%2Fwiklou.git

Make the deprecation notice actually useful by listing the class

Follows-up Id8a559a

Change-Id: I101e5e864d6c14d2a67721514f02c5166137211f
---

diff --git a/includes/specialpage/SpecialPageFactory.php b/includes/specialpage/SpecialPageFactory.php
index 5a4d7420f3..f5e4f0ed23 100644
--- a/includes/specialpage/SpecialPageFactory.php
+++ b/includes/specialpage/SpecialPageFactory.php
@@ -347,10 +347,10 @@ class SpecialPageFactory {
 
 				return new $className;
 			} elseif ( is_array( $rec ) ) {
+				$className = array_shift( $rec );
 				// @deprecated, officially since 1.18, unofficially since forever
-				wfDeprecated( "Array syntax for \$wgSpecialPages is deprecated, " .
+				wfDeprecated( "Array syntax for \$wgSpecialPages is deprecated ($className), " .
 					"define a subclass of SpecialPage instead.", '1.18' );
-				$className = array_shift( $rec );
 				self::getList()->$realName = MWFunction::newObj( $className, $rec );
 			}