From: Stephane Bisson <sbisson@wikimedia.org>
Date: Wed, 3 May 2017 18:58:22 +0000 (-0400)
Subject: RC Filters: always join with 'page'
X-Git-Tag: 1.31.0-rc.0~3349^2
X-Git-Url: https://git.cyclocoop.org/%7B%7B%20url_for%28%27votes%27%2C%20votes=%27waiting%27%29%20%7D%7D?a=commitdiff_plain;h=a0ac6a453bd00326f5903f4fa19a7b4b01cf9e67;p=lhc%2Fweb%2Fwiklou.git

RC Filters: always join with 'page'

The 'last revision' filter group relies on
the 'page' table to filter and highlight.

Bug: T163561
Change-Id: I29be21596ce02270859936203c921777c952e3a4
---

diff --git a/includes/specials/SpecialRecentchanges.php b/includes/specials/SpecialRecentchanges.php
index aaa99b60f1..e1435096fa 100644
--- a/includes/specials/SpecialRecentchanges.php
+++ b/includes/specials/SpecialRecentchanges.php
@@ -247,11 +247,10 @@ class SpecialRecentChanges extends ChangesListSpecialPage {
 			] ];
 		}
 
-		if ( $user->isAllowed( 'rollback' ) ) {
-			$tables[] = 'page';
-			$fields[] = 'page_latest';
-			$join_conds['page'] = [ 'LEFT JOIN', 'rc_cur_id=page_id' ];
-		}
+		// JOIN on page, used for 'last revision' filter highlight
+		$tables[] = 'page';
+		$fields[] = 'page_latest';
+		$join_conds['page'] = [ 'LEFT JOIN', 'rc_cur_id=page_id' ];
 
 		ChangeTags::modifyDisplayQuery(
 			$tables,