Krinkle [Sun, 29 May 2011 03:13:54 +0000 (03:13 +0000)]
Introducing mw.libs, moving JpegMeta into it.
* Reverts/re-do's r88794 and r88796.
** mediawiki.util.js no longer extends itself but is defined once.
** mediawiki.util.jpegmeta no longer extends mw.util but is installed as an object property of mw.libs
* Empty placeholder defined in mediawiki.js
* Removed the redundant 'mw' argument from the IIFE around mediawiki.libs.jpegmeta.js
* Fixed all usages in /mediawiki/trunk/*
** http://toolserver.org/~krinkle/wikimedia-svn-search/view.php?id=205&hash=
ddc0908eef111558816c9fe1c775f7c1
Krinkle [Sun, 29 May 2011 02:54:01 +0000 (02:54 +0000)]
Adding or adjusting front-end function and variable documentation per our conventions.
Also did some trivial clean up, JSHint fixes and performance optimizations while at it. (per http://www.mediawiki.org/wiki/JavaScript_performance )
* Missing semicolons.
* [mediawiki.js Line 540] Unreachable 'registry' after 'throw'.
* [mediawiki.log.js] Checked for window.console but used console.
* Added callback option to mw.util.toggleToc (forwarded to jQuery.fn.slideUp/Down)
* Made mw.log argument more descriptive (logmsg instead of string)
* Using deepEqual(, true) instead of ok() when asserting true. (ok() is like casting a boolean (or a plain if() statement) to verify that something is not falsy)
Added missing test suites for:
* mw.util.toggleToc (follow-up r88732, Dummy check was introduced in r87898)
/me has been infected by Reedy and will be doing more of this tonight.
Russ Nelson [Sun, 29 May 2011 01:27:47 +0000 (01:27 +0000)]
There is no getThumbRel;
$wgLocalFileRepo needs to self-identify as local;
the documentation and variable names for FileRepo->append() are correct, but they got positionally swapped at implementation time;
and I am checking in a matching fix to Extension:ResumableUpload in a sec.
Krinkle [Sat, 28 May 2011 22:38:59 +0000 (22:38 +0000)]
Adding or adjusting front-end function and variable documentation per our conventions.
* Adding "return this;" in object constructor functions.
* Added test suites for Map and Message object constructors to match the @return descriptions.
Also did some trivial clean up and performance optimizations while at it. (per http://www.mediawiki.org/wiki/JavaScript_performance )
/me has been infected by Reedy and will be doing more of this tonight.
Antoine Musso [Sat, 28 May 2011 21:43:06 +0000 (21:43 +0000)]
ApiBlockTest: delete a block only if it exist
Fix cruise control, follow up r89071
Raimond Spekking [Sat, 28 May 2011 21:32:53 +0000 (21:32 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-05-28 21:01:00 UTC)
Antoine Musso [Sat, 28 May 2011 21:25:29 +0000 (21:25 +0000)]
Use the correct ID when retrieving a block
The ID might be different than the one you expect. Since r88755 the tables
are no more dropped and recreated, thus the autoincrement pointer is not
reset. A previous test could have raised that pointer, thus the id might
be above the expected value.
This patch track the block ID inserted and use it in the assertion.
Antoine Musso [Sat, 28 May 2011 21:22:29 +0000 (21:22 +0000)]
ApiBlockTest now remove block it creates
This follow up r88755 that make tests depends on each other. The creation
of a Block through the API is troublesome to the BlockTest suite.
Requires r89070
Antoine Musso [Sat, 28 May 2011 21:19:24 +0000 (21:19 +0000)]
Allow test to remove data from the database
This new removeDBData() is run after the tests result. It is similar
to the addDBData() method.
Sam Reed [Sat, 28 May 2011 19:00:01 +0000 (19:00 +0000)]
And even more documentation, the last of this batch
Sam Reed [Sat, 28 May 2011 18:59:42 +0000 (18:59 +0000)]
And even more documentation
Sam Reed [Sat, 28 May 2011 18:58:51 +0000 (18:58 +0000)]
And even more documentation
Sam Reed [Sat, 28 May 2011 17:52:12 +0000 (17:52 +0000)]
Some for MaxSem too
Sam Reed [Sat, 28 May 2011 17:51:33 +0000 (17:51 +0000)]
And some more....
Sam Reed [Sat, 28 May 2011 17:18:50 +0000 (17:18 +0000)]
And more documentation. Yaaaay
Sam Reed [Sat, 28 May 2011 16:32:09 +0000 (16:32 +0000)]
And even mooore
Sam Reed [Sat, 28 May 2011 16:31:00 +0000 (16:31 +0000)]
And some more parameter documentation!!
Alexandre Emsenhuber [Sat, 28 May 2011 16:11:40 +0000 (16:11 +0000)]
Now that Hooks.php contains a class, moved wfRunHooks() definition to GlobalFunctions.php and removed its inclusion from Setup.php
Sam Reed [Sat, 28 May 2011 15:59:57 +0000 (15:59 +0000)]
More parameter documentation!!
Alexandre Emsenhuber [Sat, 28 May 2011 15:11:39 +0000 (15:11 +0000)]
svn:eol-style native
Sam Reed [Sat, 28 May 2011 14:54:13 +0000 (14:54 +0000)]
Loads more documentation for this file.. Hopefully CR will show it all ;)
Sam Reed [Sat, 28 May 2011 14:52:55 +0000 (14:52 +0000)]
More parameter documentation!!
Krinkle [Sat, 28 May 2011 14:51:07 +0000 (14:51 +0000)]
Fix type, follow-up r81615
Niklas Laxström [Sat, 28 May 2011 13:03:16 +0000 (13:03 +0000)]
fu r89029 - spelling
Antoine Musso [Sat, 28 May 2011 09:58:43 +0000 (09:58 +0000)]
Handle old libxml when extracting SVG metadata
Mac OS X 10.5.8 comes with libxml 2.6.16, thus some methods of XMLReader
are not availabe (ex: readInnerXML()).
This patch, throw an error if the above method does not exist (only one
use in our code).
Since metadata can comes as string or an XML fragment, I have split the tests
to take care of the two usages and of the exception.
Antoine Musso [Sat, 28 May 2011 09:03:44 +0000 (09:03 +0000)]
* Fix db->makeList() spacing
* Tests assertions where upside-down (expected <-> value)
* Tests did not use LIST_AND
Follow up r87992
Antoine Musso [Sat, 28 May 2011 08:38:14 +0000 (08:38 +0000)]
Only run CleanUpTest on a quarter of the cases.
Speed up the testDoubleBytes & testTripleBytes which generates 32k assertions.
The processing took 12 and 18 seconds respectively on my computer, now down
to 8k assertions.
Mark A. Hershberger [Sat, 28 May 2011 02:09:01 +0000 (02:09 +0000)]
follow up r88997 with a rough attempt at a parser test, though, really, we can't test signature expansion
Roan Kattouw [Fri, 27 May 2011 22:42:20 +0000 (22:42 +0000)]
Refactor MessageBlobStore::updateModule() to remove the multi-language update behavior. Instead of updating all language's blobs at once, it now only updates the requested language. This, in combination with the bug fixed in r89001, was what caused the UploadWizard timeouts on the cluster
Brion Vibber [Fri, 27 May 2011 22:31:48 +0000 (22:31 +0000)]
* (bug 29174) Fix regression in upload-by-URL: files larger than PHP memory limit work again
r65152 switched upload-by-URL ($wgAllowCopyUploads) to use Http / MwHttpRequest class instead of CURL directly.
While this is mostly nice, it switched from saving large files directly to a temp file to buffering them in memory, causing large files to fail when they hit the PHP memory limit.
Fix uses MwHttpRequest's callback capability to override the read handler; now appending it to the temporary file as we go, and can confirm that largish files work again; was able to upload a 64mb .ogv that previously didn't work for me: http://prototype.wikimedia.org/tmh/images/b/b2/File-Arborophila_brunneopectus_pair_feeding_-_Kaeng_Krachan.ogv
Also expanded the documentation on MwHttpRequest::setCallback to clarify the function parameters and return value for the callback (which currently matches the low-level CURL handler's callback directly).
Note that the non-CURL implementation doesn't abort the read if the callback doesn't return the expected number of bytes, but this is an immediate fatal end of request on the Curl backend. May want further cleanup.
Roan Kattouw [Fri, 27 May 2011 22:09:22 +0000 (22:09 +0000)]
Fix issue on the live site causing RL requests for ext.uploadWizard to consistently take more than 5 seconds: the cache freshness check was failing all the time because ext.uploadWizard listed some messages twice, and duplicates were filtered on the left-hand side of the !== comparison (implicitly, because they're array keys), but not on the right-hand side.
Mark A. Hershberger [Fri, 27 May 2011 21:43:07 +0000 (21:43 +0000)]
Fix failing preprocessor tests by checking if ot is set.
Mark A. Hershberger [Fri, 27 May 2011 20:55:02 +0000 (20:55 +0000)]
fix for Bug #93 “tilde signatures inside nowiki tags sometimes get expanded (<includeonly><nowiki>~~~~</nowiki></includeonly>)”
Patch from Brad Jorsch
Fix for includeonly case. Hopefully fixing this ancient bug doesn't
‘cause people to cry
Raimond Spekking [Fri, 27 May 2011 20:35:05 +0000 (20:35 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-05-27 20:18:00 UTC)
Alexandre Emsenhuber [Fri, 27 May 2011 19:15:13 +0000 (19:15 +0000)]
Simplify a bit :)
Ilmari Karonen [Fri, 27 May 2011 18:51:26 +0000 (18:51 +0000)]
bug 29123: record use of the "editsection" option so that users who can't edit (or have section edit links disabled) get a different cache key; also simplify freaky code layout (briefly tested, seem to work)
Ilmari Karonen [Fri, 27 May 2011 16:23:39 +0000 (16:23 +0000)]
translate userlogin-resetlink
Ilmari Karonen [Fri, 27 May 2011 16:14:09 +0000 (16:14 +0000)]
fix broken condition in r83847 (tested)
Sam Reed [Fri, 27 May 2011 11:43:33 +0000 (11:43 +0000)]
MFB r88946
Tim Starling [Fri, 27 May 2011 06:25:21 +0000 (06:25 +0000)]
Some HipHop fixes:
* Scan the C++ for volatile classes and show a warning with a list of them
* Fixed volatile classes Revision, CoreLinkFunctions and FileRepoStatus, made them non-volatile by patching the referring code
* Added some configuration for the build process to DefaultSettings.php.
* Split a few functions off MakeHipHop::execute()
* Only include UtfNormalDefines.php in interpreted mode, since in compiled mode, the constants exist from startup
* Apparently HipHop does not support set_exception_handler(). Added a try/catch block around the main part of index.php instead.
* Fixed ini_get() dependencies in Special:Upload. Upload now works, if you disable ZipDirectoryReader.
Platonides [Thu, 26 May 2011 22:30:35 +0000 (22:30 +0000)]
Move down interwiki disabling to dumpIterator and make SearchDump work without a db.
Removed stripParameters() which shouldn't have been added to the base class in r88914
Raimond Spekking [Thu, 26 May 2011 20:54:58 +0000 (20:54 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-05-26 20:23:00 UTC)
Sam Reed [Thu, 26 May 2011 20:38:05 +0000 (20:38 +0000)]
It's not just for < 5.1!
Sam Reed [Thu, 26 May 2011 20:26:51 +0000 (20:26 +0000)]
More documentation tweaks/additions
Alexandre Emsenhuber [Thu, 26 May 2011 19:56:42 +0000 (19:56 +0000)]
Fix for r88898: fix variable name
Sam Reed [Thu, 26 May 2011 19:52:56 +0000 (19:52 +0000)]
More documentation tweaks/additions
Sam Reed [Thu, 26 May 2011 19:21:50 +0000 (19:21 +0000)]
Param documentation updates/added
Sam Reed [Thu, 26 May 2011 19:20:35 +0000 (19:20 +0000)]
Remove unused variables/globals
Swap while to foreach
Platonides [Thu, 26 May 2011 18:49:25 +0000 (18:49 +0000)]
Refactor the common code of compareParsers.php and preprocessDump.php into a dumpIterator.php script.
Implement a simple 'search into this dump'
Bryan Tong Minh [Thu, 26 May 2011 18:41:06 +0000 (18:41 +0000)]
Follow-up r81536: Fix misleading comment in Status and add a comment to LocalFileRestoreBatch::cleanupFailedBatch.
Bryan Tong Minh [Thu, 26 May 2011 17:11:51 +0000 (17:11 +0000)]
(bug 27891) Follow-up r72475: destroy the LBFactory singleton before doing any jobs so that jobs do not access the current session while still preserving ChronologyProtector.
Alexandre Emsenhuber [Thu, 26 May 2011 16:41:11 +0000 (16:41 +0000)]
Merged MediaWiki::performRequestForTitle() and MediaWiki::handleSpecialCases() into MediaWiki::performRequest():
* this allows to perform tests in the correct order, i.e. first BadTitle check and then userCanRead()
* the Article object is now returned by the function instead of passed back in pass-by-reference parameter
* Removed the "return false;" when MediaWiki detects a redirect, was causing an useless full execution
Alexandre Emsenhuber [Thu, 26 May 2011 16:18:35 +0000 (16:18 +0000)]
Use WebRequest::getQueryValues() to get all query strings parameters instead of $_GET
Alexandre Emsenhuber [Thu, 26 May 2011 16:11:47 +0000 (16:11 +0000)]
Removed comment about the usage $wgTitle which is no longer true
Leo Koppelkamm [Thu, 26 May 2011 11:44:40 +0000 (11:44 +0000)]
r88885: Change message as well
Leo Koppelkamm [Thu, 26 May 2011 11:36:32 +0000 (11:36 +0000)]
Remove reset button from Special:Undelete. It does more harm than good
Roan Kattouw [Thu, 26 May 2011 09:49:45 +0000 (09:49 +0000)]
(bug 28840) URLs with dots break because of IE6 security check
* Replace the overly paranoid regex with a function that simulates IE6's behavior
* Remove the UA check in isPathInfoBad(), was causing more problems than it was worth
* Revert r87711, going back to using dots for dots in ResourceLoader URLs, instead of exclamation marks
* Append &* to ResourceLoader URLs. * is an illegal character in extensions, and putting it at the end of the URL ensures that both IE6 and our detection function will deem the URL to have no extension (unless something like .html? appears in the query string, but in that case we're screwed no matter what)
Sam Reed [Thu, 26 May 2011 00:57:54 +0000 (00:57 +0000)]
* (bug 29144) Move action=dublincore and action=creativecommons to extensions
Add back links for metadata in <head>
Sam Reed [Thu, 26 May 2011 00:08:16 +0000 (00:08 +0000)]
* (bug 29144) Move action=dublincore and action=creativecommons to extensions
Moved CreativeCommonsRDF out to extension
Brion Vibber [Wed, 25 May 2011 23:59:43 +0000 (23:59 +0000)]
* (bug 27465) Fix metadata extraction for SVG files using unusual namespace names
The previous fix (in r82307) only checked explicitly for a namespace given the 'svg' prefix; this fix use XML namespacing support on XMLReader to check for the actual namespace URI correctly.
Fixed up a test case (for RDF extraction) and added trimming on the whitespace.
Also added another test case file that doesn't use a namespace name on the root.
Brion Vibber [Wed, 25 May 2011 23:57:44 +0000 (23:57 +0000)]
Reverting r82307 (bug 27465) as initial step to recommitting a cleaner fix.
Sam Reed [Wed, 25 May 2011 23:55:15 +0000 (23:55 +0000)]
* (bug 29144) Move action=dublincore and action=creativecommons to extensions
Moved dublincore out to extension
Brion Vibber [Wed, 25 May 2011 23:34:20 +0000 (23:34 +0000)]
Test cases for bug 27465: problems with XML namespace handling break SVGMetadataExtractor::getMetadata()
$ php phpunit.php includes/media/SVGMetadataExtractorTest.php
PHPUnit 3.5.13 by Sebastian Bergmann.
..E
Time: 1 second, Memory: 14.00Mb
There was 1 error:
1) SVGMetadataExtractorTest::testGetMetadata with data set #2 ('/var/www/trunk/tests/phpunit/includes/media/US_states_by_total_state_tax_revenue.svg', array(593, 959))
MWException: Expected <svg> tag, got ns0:svg
/var/www/trunk/includes/media/SVGMetadataExtractor.php:105
/var/www/trunk/includes/media/SVGMetadataExtractor.php:78
/var/www/trunk/includes/media/SVGMetadataExtractor.php:30
/var/www/trunk/tests/phpunit/includes/media/SVGMetadataExtractorTest.php:14
/var/www/trunk/tests/phpunit/MediaWikiTestCase.php:63
/var/www/trunk/tests/phpunit/MediaWikiPHPUnitCommand.php:20
/var/www/trunk/tests/phpunit/phpunit.php:60
FAILURES!
Tests: 3, Assertions: 2, Errors: 1.
Jeroen De Dauw [Wed, 25 May 2011 22:32:42 +0000 (22:32 +0000)]
added @since tag
Brion Vibber [Wed, 25 May 2011 22:01:08 +0000 (22:01 +0000)]
* (bug 29140) FirePHP debugging assist extension
FirePHP is an extension to Firebug, an awesome debugging extension to Firefox.
It allows pulling debug log data in from your PHP script via HTTP headers, which then get displayed in Firebug's console along with errors, warnings, and AJAX hits from the web page.
Added 'Debug' hook which gets called from wfDebug() and wfDebugLog() to take this; note that a few lines of output won't make it to FirePHP as they are output either before we've done all plugin initialization, or after we've flushed output and can no longer add HTTP headers.
BSD-licensed FirePHPCore library from firephp-libs commit
aff25803a3ff460b2797:
https://github.com/cadorn/firephp-libs/blob/
aff25803a3ff460b2797/packages/core/lib/FirePHPCore/FirePHP.class.php
There's not a lot of fancy integration; everything's just output as a 'log' line.
You can use $wgFirePHP global (or call FirePHP::getInstance() yourself) to get direct access to FirePHP's fancier features in test code.
Sam Reed [Wed, 25 May 2011 20:57:15 +0000 (20:57 +0000)]
We check self::$pageCount, then assign it to another array, and return it from that array
Not ever caching stuff further
Follows up some ancient revisions
Raimond Spekking [Wed, 25 May 2011 20:35:59 +0000 (20:35 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-05-25 20:01:00 UTC)
Chad Horohoe [Wed, 25 May 2011 20:19:18 +0000 (20:19 +0000)]
Fix for r83799: mw.org -> mediawiki.org
Sam Reed [Wed, 25 May 2011 18:58:02 +0000 (18:58 +0000)]
More documentation stuffs
Alexandre Emsenhuber [Wed, 25 May 2011 18:56:05 +0000 (18:56 +0000)]
* Check existence in correct language
* Simplify a bit existence check
Sam Reed [Wed, 25 May 2011 18:41:31 +0000 (18:41 +0000)]
Documentation
Alexandre Emsenhuber [Wed, 25 May 2011 18:37:32 +0000 (18:37 +0000)]
Also change $wgLanguageCode along with $wgContLang, this was breaking when arriving at LanguageConverterTest with "nooo!"
Alexandre Emsenhuber [Wed, 25 May 2011 18:32:04 +0000 (18:32 +0000)]
Moved wfGetCaller(), wfGetAllCallers() and wfFormatStackFrame() near other related functions
Krinkle [Wed, 25 May 2011 17:18:52 +0000 (17:18 +0000)]
Removing the last occurrences/mentions of mw.loader.go
* Follow-up r88125, r88790.
* Also cleaned up some comments to use the same uppercase/colon use as the rest of this file.
Search results: http://toolserver.org/~krinkle/wikimedia-svn-search/view.php?id=202&hash=
96029a8f5c6a5aaadc61767532e01571
Sam Reed [Wed, 25 May 2011 17:06:04 +0000 (17:06 +0000)]
Move DB utility classes into own file
Updated AutoLoader to match
Sam Reed [Wed, 25 May 2011 17:03:15 +0000 (17:03 +0000)]
Move DB(.*?)Error classes into own file
Updated AutoLoader to match
Sam Reed [Wed, 25 May 2011 16:14:59 +0000 (16:14 +0000)]
Fix undefined variable from r39635
Chad Horohoe [Wed, 25 May 2011 15:59:30 +0000 (15:59 +0000)]
Followup r87468: remove refs to CleanUpTest from Makefile
Mark A. Hershberger [Wed, 25 May 2011 15:39:47 +0000 (15:39 +0000)]
Misc EOL w/s and spaces-instead-of-tabs fixes. One day I'll get around to nagging people for this stuff, but for now, I'll JFDI myself.
Roan Kattouw [Wed, 25 May 2011 15:28:21 +0000 (15:28 +0000)]
Fix syntax error in r88794
Mark A. Hershberger [Wed, 25 May 2011 15:19:38 +0000 (15:19 +0000)]
Fixes Bug #29133: “Special:PasswordReset button text not i18n-able” by
adding the alterForm() method to set the submit button text.
Roan Kattouw [Wed, 25 May 2011 15:19:16 +0000 (15:19 +0000)]
Use $.extend() in mw.util and mw.util.jpegmeta so they can be loaded in either order. This means mw.util.jpegmeta doesn't depend on mw.util loading first any more
Roan Kattouw [Wed, 25 May 2011 14:16:21 +0000 (14:16 +0000)]
Fix r88125: forgot to remove another call to mw.loader.go()
Aaron Schulz [Wed, 25 May 2011 10:11:06 +0000 (10:11 +0000)]
* Follow-up r88740:
* Fixed parse() arguments in getRevIncludes()
* Changed clearTagHook() to avoid preprocessed-xml cache corruption
* Check current version cache in getRevIncludes()
Aaron Schulz [Wed, 25 May 2011 05:26:54 +0000 (05:26 +0000)]
Finish r88768, *ahem*
Chad Horohoe [Wed, 25 May 2011 00:49:51 +0000 (00:49 +0000)]
Workaround for duplicate key errors
Chad Horohoe [Wed, 25 May 2011 00:30:06 +0000 (00:30 +0000)]
Extend MediaWikiTestCase in a few places
Aaron Schulz [Wed, 25 May 2011 00:25:29 +0000 (00:25 +0000)]
* Changed @ => wfSuppressWarnings
* Added wfSuppressWarnings to Bitmap.php:
Notice: unserialize(): Error at offset 0 of 2 bytes in D:\www\MW_trunk\phase3\includes\media\Bitmap.php on line 685
Platonides [Tue, 24 May 2011 22:56:42 +0000 (22:56 +0000)]
Don't generate the footer div if there isn't any footer link.
Removed blank line between the <li>s of $validFooterLinks
Raimond Spekking [Tue, 24 May 2011 21:34:27 +0000 (21:34 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-05-24 20:59:00 UTC)
Chad Horohoe [Tue, 24 May 2011 21:22:36 +0000 (21:22 +0000)]
Fixup phpunit tests so we don't drop/create tables on EVERY SINGLE TEST.
Now just create them on the first test that needsDB() and skip creation on the rest.
Leaves you with a bunch of useless tables at the end of a run, but oh well at least its faster :)
Brion Vibber [Tue, 24 May 2011 21:04:50 +0000 (21:04 +0000)]
* (bug 29116) Fix regression breaking CheckUser extension
Fixes regression from r84475 and friends which made Block->load() and its new front-end Block::newFromTarget() fail when an empty string was passed in as the IP / $vagueTarget parameter to indicate skipping IP-based lookups.
Added phpunit test cases to confirm that both Block->load() and Block::newFromTarget() work when given null (already ok), '' (as done from CheckUser), or false (not seen, but perfectly legit sounding).
Adjusted comparisons to work as expected.
Aaron Schulz [Tue, 24 May 2011 19:52:27 +0000 (19:52 +0000)]
Follow-up r88740: forgot to commit this guy
Happy-melon [Tue, 24 May 2011 19:03:41 +0000 (19:03 +0000)]
(bug 29116) follow-up r84475: normalise the empty string to null in Block::newFromTarget().
Brion Vibber [Tue, 24 May 2011 18:50:43 +0000 (18:50 +0000)]
r88734 followup: pretty up the doc link added to qunit test result page; per Krinkle's suggestion moved it into the qunit toolbar div and it's much happier :D
Brion Vibber [Tue, 24 May 2011 18:41:26 +0000 (18:41 +0000)]
Add quick and dirty link to mediawiki.org/wiki/Manual:JavaScript_unit_testing from the qunit runner page
It's not styled; qunit result styles are entirely id-based for some reason so you can't just add a div or p with matching style.
Brion Vibber [Tue, 24 May 2011 18:35:30 +0000 (18:35 +0000)]
add a @fixme comment about toggleToc test case: doesn't actually test if the function works, just confirms that it exists.
Max Semenik [Tue, 24 May 2011 17:48:22 +0000 (17:48 +0000)]
Introduced Maintenance::getDB() and corresponding setDB() to control externally what database object should be used by maintenance script. Currently used by updater to avoid DatabaseSqliteTest from running stuff like Populate* on the live database instead of the one used for testing.
Alexandre Emsenhuber [Tue, 24 May 2011 17:28:21 +0000 (17:28 +0000)]
Simplify message existence checks by using wfMessage() instead of wfEmptyMsg()
Krinkle [Tue, 24 May 2011 16:52:28 +0000 (16:52 +0000)]
Reverting r88607. This downgrades jQuery from 1.5.2 back to 1.4.4.
* The main reason being the problems with $.ajax that arose in UploadWizard (as remarked on wikitech-l).
* My plan is to take the following week (or two) to talk a bit about JavaScript unit testing and how we plan to do distributed continuous integration testing for it. After that we could upgrade right to 1.6.1
* See also bug 28904 and "[Wikitech-l] Any issues with pending jQuery 1.6.1 update on trunk?"