jenkins-bot [Mon, 18 Aug 2014 00:15:17 +0000 (00:15 +0000)]
Merge "CSS style for thumbs on special pages"
jenkins-bot [Sun, 17 Aug 2014 22:02:36 +0000 (22:02 +0000)]
Merge "Fix phpcs errors in tests dir"
addshore [Sat, 16 Aug 2014 12:53:24 +0000 (13:53 +0100)]
Fix phpcs errors in tests dir
Change-Id: I79fa3b8f92e958f4a0dc4fe892703f37d711ca95
addshore [Sun, 17 Aug 2014 21:38:07 +0000 (22:38 +0100)]
Override phpunit assertTag method to stop errors
This method throws a deperecation error in phpunit
that we dont want to see (and dont want to break
travis tests).
Nothing this method uses is beign deprecated thus
we can override the method and not need to worry
about the error or it vanishing in the future!
Bug: 69505
Change-Id: I0eb63be390b4fdf416635dd8e8a2ad94615e6a47
jenkins-bot [Sun, 17 Aug 2014 21:24:42 +0000 (21:24 +0000)]
Merge "Remove some unused files from skins/common/"
Translation updater bot [Sun, 17 Aug 2014 21:19:20 +0000 (21:19 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Bartosz Dziewoński [Sun, 17 Aug 2014 20:38:18 +0000 (22:38 +0200)]
Remove some unused files from skins/common/
Grepping doesn't point to any usages, and they don't appear in logs
from bug 69277 comment 11.
add.png
Arr_.png
closewindow.png
diffunderline.gif
link_icon.gif
remove.png
tooltip_icon.png
Zoom_sans.gif
Bug: 69277
Change-Id: I09c0c13b353366e83124e7ffa1fa02eeada76729
jenkins-bot [Sun, 17 Aug 2014 20:30:51 +0000 (20:30 +0000)]
Merge "Use public instead of var in classes"
Translation updater bot [Sun, 17 Aug 2014 20:15:26 +0000 (22:15 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I3a6292805700b7071997414a2e601220cd564188
addshore [Sun, 17 Aug 2014 20:07:37 +0000 (21:07 +0100)]
Use public instead of var in classes
Change-Id: I16d1714ba37667d8c9c7c79a765c7199ea0023e4
jenkins-bot [Sun, 17 Aug 2014 20:06:26 +0000 (20:06 +0000)]
Merge "WebInstallerOutput: Restore 'global $wgResourceModules'"
jenkins-bot [Sun, 17 Aug 2014 19:51:07 +0000 (19:51 +0000)]
Merge "Avoid theoretical division by zero"
jenkins-bot [Sun, 17 Aug 2014 19:49:25 +0000 (19:49 +0000)]
Merge "Use Xml::element instead of Html::element for empty elements"
jenkins-bot [Sun, 17 Aug 2014 19:43:46 +0000 (19:43 +0000)]
Merge "Add dependencies to module mediawiki.util"
jenkins-bot [Sun, 17 Aug 2014 19:37:38 +0000 (19:37 +0000)]
Merge "Remove fallback 'de' gender namespaces"
addshore [Sun, 17 Aug 2014 19:25:21 +0000 (20:25 +0100)]
Fix @returns >> @return phpdoc
Change-Id: Ib0050a3854e1d3405ffcdd4c92569d4df6ff847f
Bartosz Dziewoński [Sun, 17 Aug 2014 17:00:37 +0000 (19:00 +0200)]
WebInstallerOutput: Restore 'global $wgResourceModules'
Deleted in
301a7f3d, previously added in
a96afeb2.
Change-Id: If0889bc003320abd0b74fc57b8975255f0efcc7e
umherirrender [Sun, 17 Aug 2014 13:54:13 +0000 (15:54 +0200)]
Remove fallback 'de' gender namespaces
Some languages are fallback to 'de', but have there own namespaces.
There is no feedback, that the german gender namespaces should override
the localized namespaces for gender, so removing it for now.
At least nds has ask for this at
https://de.wikipedia.org/w/index.php?title=Benutzer_Diskussion:Raymond&oldid=
133185685#merkw.C3.BCrdiges_Software-Verhalten_auf_nds.wp
Change-Id: Ie666c95b614faeb9ac1cb57d4b5d96294d43c6cf
Fomafix [Sun, 17 Aug 2014 13:23:40 +0000 (13:23 +0000)]
Add dependencies to module mediawiki.util
* mediawiki.Uri.js uses mw.util.wikiUrlencode().
* mediawiki.special.unwatchedPages.js uses mw.util.getParamValue().
Change-Id: Id109e1ba3ec8421ff278a2b2c5111413b4c3bc62
Fomafix [Sun, 17 Aug 2014 11:51:08 +0000 (11:51 +0000)]
mediawiki.page.watch.ajax depends on mediawiki.page.startup
mediawiki.page.watch.ajax.js requires mw.page, which is defined in
mediawiki.page.startup.js
I just got the error message:
Exception thrown by mediawiki.page.watch.ajax
TypeError: mw.page is undefined
Change-Id: I869fbcb701c3c17ecf6564d89a9bb773bd1a76bd
jenkins-bot [Sat, 16 Aug 2014 13:20:31 +0000 (13:20 +0000)]
Merge "Fix the (un)watch token to include the namespace name."
Kunal Mehta [Sat, 16 Aug 2014 05:50:25 +0000 (22:50 -0700)]
Register a fake skin instead of a 'vector' that will fail
Bug: 69639
Change-Id: Icd87520f7b6de337b009144420c3a430861d0833
jenkins-bot [Sat, 16 Aug 2014 00:48:19 +0000 (00:48 +0000)]
Merge "Add blanket support for mediawiki ui via globals"
jenkins-bot [Fri, 15 Aug 2014 21:49:35 +0000 (21:49 +0000)]
Merge "mediawiki.toc: Remove class="internal" from tocToggleLink"
jdlrobson [Wed, 30 Jul 2014 17:56:25 +0000 (10:56 -0700)]
Add blanket support for mediawiki ui via globals
This provides better mobile experiences on various pages
and a more consistent UI across both mobile and desktop.
It does this in two ways.
1) Forces HTMLForms to not use table based layouts so as
not to interfere with responsive nature of mediawiki ui elements
2) Applies MediaWiki.UI classes to most pages
If a page is created via Xml or Html classes it will use mediawiki ui
Where possible I've added classes unconditionally, but for cases of buttons
this is behind the $wgUseMediaWikiUIEverywhere global since button styling is
enabled on pages by default and for checkboxes since it is changes HTML markup.
3) Adds all MediaWiki.UI styles to pages which can use it
When enabled:
* Apply these styles to all pages which use HTMLForms
* Apply to EditPage
* Apply to anything that uses certain elements outputted by the
Xml or HTML helper classes
* Apply to History page
* Apply to protection page
* Apply to move page
* Apply to deletion page
Currently kept behind a global to allow us time to finetune
existing elements. After further testing we will look to kill the
globals and make mediawiki.ui the default
See: I430c0fbb79d2a33bb828b2427bda0ee01115d73f
Change-Id: I47db5eab4569514d039261d11b6dedb0eeae17b5
jenkins-bot [Fri, 15 Aug 2014 21:40:32 +0000 (21:40 +0000)]
Merge "Turn HTMLBlockedUsersItemSelect into HTMLSelectLimitField"
jenkins-bot [Fri, 15 Aug 2014 21:29:35 +0000 (21:29 +0000)]
Merge "mediawiki.jqueryMsg: Prevent default action for functions as external link"
jenkins-bot [Fri, 15 Aug 2014 20:26:17 +0000 (20:26 +0000)]
Merge "Set relevant title on Special:RecentChangesLinked"
paladox [Mon, 4 Aug 2014 11:13:21 +0000 (11:13 +0000)]
Update Moment.js from 2.7.0 to 2.8.1
Project site
* http://momentjs.com/ and https://github.com/moment/moment/
File source
* https://github.com/moment/moment/blob/2.8.1/moment.js
README
* https://github.com/moment/moment/blob/2.8.1/readme.md
Changelog
1.8.0 changelog
* https://gist.github.com/ichernev/
ac3899324a5fa6c8c9b4
1.8.1 changelog
* https://github.com/moment/moment/blob/2.8.1/CHANGELOG.md
difference between 2.7.0 and 2.8.1
incompatible changes
* #1761: moments created without a language are no longer following the global language, in case it changes. Only newly created moments take the global language by default. In case you're affected by this, wait, comment on #1797 and wait for a proper reimplementation
* #1642: 45 days is no longer "a month" according to humanize, cutoffs for month, and year have changed. Hopefully your code does not depend on a particular answer from humanize (which it shouldn't anyway)
* #1784: if you use the human readable English datetime format in a weird way (like storing them in a database) that would break when the format changes you're at risk.
* #1785 moment.momentProperties is now an array of properties instead of a hash. If you have a plugin that uses it to make sure cloned moments will retain the plugin-added properties you need to change your code.
deprecations (old behavior will be dropped in 3.0)
* #1761 lang is renamed to locale , langData -> localeData . Also there is now defineLocale that should be used when creating new locales
* #1763 add(unit, value) and subtract(unit, value) are now deprecated. Use add(value, unit) and subtract(value, unit) instead.
* #1759 rename duration.toIsoString to duration.toISOString . The js standard library and moment's toISOString follow that convention.
new locales
* #1789 Tibetan (bo)
* #1786 Africaans (af)
* #1778 Burmese (my)
* #1727 Belarusian (be)
bugfixes
* #1738 local to zone conversion with keepLocalTime=true
* #1642 more accurate humanize
performance
* #1808 speedup cloning 49x
* #1708 speedup creation with Date object
features
*#1716 moment.relativeTimeThreshold now supports getting the existing threshold
locale bugfix
* #1784 add comma between day-of-month and year in us-en
* #1710 fix lithuanian month name
2.8.1
* bugfix #1813: fix moment().lang([key]) incompatibility
Change-Id: Iaffaaa18e08773f8f36e83e918e61a2259f1e2e3
jenkins-bot [Fri, 15 Aug 2014 16:32:05 +0000 (16:32 +0000)]
Merge "API: Mark seldom-used formats as deprecated"
jenkins-bot [Fri, 15 Aug 2014 14:33:45 +0000 (14:33 +0000)]
Merge "Use lowercase array in ResourceLoaderStartUpModule.php"
jenkins-bot [Fri, 15 Aug 2014 13:32:49 +0000 (13:32 +0000)]
Merge "jquery.tablesorter: Only look at th's for headers"
umherirrender [Fri, 15 Aug 2014 13:29:28 +0000 (15:29 +0200)]
Use lowercase array in ResourceLoaderStartUpModule.php
Change-Id: Idf28e6d302e3b28c1c5cfb9f8f108dd9a69a092c
Brad Jorsch [Fri, 8 Aug 2014 10:00:22 +0000 (11:00 +0100)]
API: Mark seldom-used formats as deprecated
While it doesn't take a lot to maintain most of these, there is some
effort needed (e.g. wddx was breaking with HHVM). None have much if any
usage that seems likely to be actual code of some sort, and humans
should be able to read the jsonfm format as easily as dbgfm, dumpfm, or
txtfm.
Change-Id: I4e3d2ef59d4306756b289a4be46caef7d359ccef
Brad Jorsch [Thu, 14 Aug 2014 18:15:23 +0000 (14:15 -0400)]
API: Log usage of various deprecated features
This will let us know how aggressively we can finally remove these.
Change-Id: I03fab36e921807e74fbabfa878756af254d89a1b
Brad Jorsch [Fri, 8 Aug 2014 09:37:02 +0000 (10:37 +0100)]
API: Add method for logging feature usage
For example, to determine usage levels of deprecated features.
Change-Id: Ifd640883e46f3e6c8179c63d122c704b046674ca
jenkins-bot [Thu, 14 Aug 2014 22:58:42 +0000 (22:58 +0000)]
Merge "Fixed doc comment"
Aaron Schulz [Thu, 14 Aug 2014 22:35:30 +0000 (15:35 -0700)]
Fixed doc comment
Change-Id: I906f3f34ac27207dd6b87b07fa6e791bc7b66691
Bartosz Dziewoński [Thu, 14 Aug 2014 21:05:55 +0000 (21:05 +0000)]
Merge "Normalize key before creating a Skin object"
Kunal Mehta [Thu, 14 Aug 2014 20:47:24 +0000 (13:47 -0700)]
Normalize key before creating a Skin object
Bug: 69566
Change-Id: Id0af543cf206f47a3577019313597388ebc63b6a
Translation updater bot [Thu, 14 Aug 2014 20:52:59 +0000 (22:52 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I45940b5477b7d441b2d029061b2e2c2da443b164
umherirrender [Thu, 14 Aug 2014 19:34:55 +0000 (21:34 +0200)]
Add missing @param to function docs
Change-Id: Ib7ac94d05a04490f25dfd40b46b27973cbab582c
Tyler Romeo [Sun, 27 Jul 2014 19:48:22 +0000 (15:48 -0400)]
Changed password default to PBKDF2
Bug: 28419
Change-Id: I096a862c884f6a6adbb381c0fcc70844bf007c63
jenkins-bot [Thu, 14 Aug 2014 18:48:44 +0000 (18:48 +0000)]
Merge "Make Special:UserLogin form use mw-ui-checkbox"
jenkins-bot [Thu, 14 Aug 2014 18:34:20 +0000 (18:34 +0000)]
Merge "Add missing @param to function docs"
jdlrobson [Fri, 25 Jul 2014 23:43:36 +0000 (16:43 -0700)]
Make Special:UserLogin form use mw-ui-checkbox
Change-Id: Ib585e32463765d7eb7d0be5dae54dc828ddd4ca9
umherirrender [Thu, 14 Aug 2014 18:22:52 +0000 (20:22 +0200)]
Add missing @param to function docs
Change-Id: I47fa96a976f55a1a93cb75397285edb8c7f4cd8a
jenkins-bot [Thu, 14 Aug 2014 18:06:35 +0000 (18:06 +0000)]
Merge "Remove various functions and globals deprecated since 1.22 from RecentChange"
jenkins-bot [Thu, 14 Aug 2014 16:58:25 +0000 (16:58 +0000)]
Merge "Correctly handle incorrect namespace in cleanupTitles.php"
jenkins-bot [Thu, 14 Aug 2014 16:47:32 +0000 (16:47 +0000)]
Merge "Remove useless $out parameter from SkinTemplate::prepareQuickTemplate()"
jenkins-bot [Thu, 14 Aug 2014 12:51:27 +0000 (12:51 +0000)]
Merge "Followup I4049b666: "Removing prefix exception for HTMLCheckMatrix""
jenkins-bot [Wed, 13 Aug 2014 23:04:00 +0000 (23:04 +0000)]
Merge "mediawiki.notify: Simplify callback by using .then()"
jenkins-bot [Wed, 13 Aug 2014 22:42:57 +0000 (22:42 +0000)]
Merge "Use camel case for variable names in Article.php"
jenkins-bot [Wed, 13 Aug 2014 22:30:55 +0000 (22:30 +0000)]
Merge "Don't set the session name in CLI or when sessions are deactivated"
jenkins-bot [Wed, 13 Aug 2014 22:24:39 +0000 (22:24 +0000)]
Merge "Allow to send the memory usage with UDP profiler."
Aaron Schulz [Tue, 12 Aug 2014 17:55:05 +0000 (10:55 -0700)]
Enabled $wgUseLinkNamespaceDBFields
Change-Id: I7aa64c3ef50cd0bc210ea755a0c9d6ee1b7abb7c
Fomafix [Wed, 13 Aug 2014 21:31:48 +0000 (21:31 +0000)]
mediawiki.notify: Simplify callback by using .then()
Change-Id: Ifff25534d716721ff1d2d4484dbd0f63161ecb43
jenkins-bot [Wed, 13 Aug 2014 21:21:07 +0000 (21:21 +0000)]
Merge "Pass $name to default Skin constructor for backwards-compatability"
jenkins-bot [Wed, 13 Aug 2014 21:06:52 +0000 (21:06 +0000)]
Merge "Added --lastUpdatedId option to backlink namespace population script"
jenkins-bot [Wed, 13 Aug 2014 21:02:56 +0000 (21:02 +0000)]
Merge "Run some parser tests with tidy."
jenkins-bot [Wed, 13 Aug 2014 21:01:36 +0000 (21:01 +0000)]
Merge "Revert "Made LCStoreDB try to use a separate DB connection""
jenkins-bot [Wed, 13 Aug 2014 20:48:48 +0000 (20:48 +0000)]
Merge "includes/actions/: Use Config instead of globals"
Kunal Mehta [Wed, 13 Aug 2014 20:45:56 +0000 (13:45 -0700)]
Pass $name to default Skin constructor for backwards-compatability
This feature was necessary when it was only possible to specify the
name of the class a skin used, this was the only way for one class to
dynamically serve multiple skins (such as if the skins were purely
template based with no PHP or if one skin had different themes to it).
It also provided an option for other skins to set $this->skinname dynamically.
See code review on I5c442f3c9e.
Change-Id: I7315fadf2e26d164ccc4f47b6d883945fa2570da
Translation updater bot [Wed, 13 Aug 2014 20:42:33 +0000 (20:42 +0000)]
Merge "Localisation updates from https://translatewiki.net."
jenkins-bot [Wed, 13 Aug 2014 20:41:06 +0000 (20:41 +0000)]
Merge "SkinFallbackTemplate: Use SkinFactory instead of $wgValidSkinNames"
Kunal Mehta [Wed, 13 Aug 2014 02:45:55 +0000 (19:45 -0700)]
includes/actions/: Use Config instead of globals
Changed InfoAction::pageCounts to be non-static, so
it's able to access $this to get the Config object.
Also replaced instances of $wgScript with wfScript().
Change-Id: I4a6a3224e762f13640af04a73e2934b887dffedd
jenkins-bot [Wed, 13 Aug 2014 20:27:00 +0000 (20:27 +0000)]
Merge "Fix documentation."
Translation updater bot [Wed, 13 Aug 2014 20:24:45 +0000 (22:24 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ie88a32c00c27abb72f24c9585884b7253d938b31
jenkins-bot [Wed, 13 Aug 2014 20:24:19 +0000 (20:24 +0000)]
Merge "Update release notes and documentation about skins"
Kunal Mehta [Mon, 11 Aug 2014 12:40:52 +0000 (05:40 -0700)]
SkinFallbackTemplate: Use SkinFactory instead of $wgValidSkinNames
Change-Id: I463d263fc24a3e0c589ddc7176b77dffde17d105
umherirrender [Wed, 13 Aug 2014 17:59:03 +0000 (19:59 +0200)]
Fixed spacing
- Added newline at end of files
- Added/Removed spaces around comma, parentheses and negation
- Added space after function word
Change-Id: I2dd338153aeb5f07702ba015945e95c7d0ae673b
jenkins-bot [Wed, 13 Aug 2014 20:13:37 +0000 (20:13 +0000)]
Merge "Correct variable names in @param to match method declarations"
jenkins-bot [Wed, 13 Aug 2014 20:08:54 +0000 (20:08 +0000)]
Merge "Cleanup - let's make IDEs more useful"
Yuri Astrakhan [Tue, 8 Jul 2014 21:40:06 +0000 (17:40 -0400)]
Cleanup - let's make IDEs more useful
http://phpdoc.org/docs/latest/references/phpdoc/types.html
If IDEs have many warnings, we don't look at them.
Let's minimize the number of warnings, and make them useful again.
* Some function docs fixes
* Removed unused $iwprefixes var in ApiQuerySearch.php
* declared private $blockStatusByUid in SpecialActiveusers
* declared private $repo in UploadFromChunks
Change-Id: Ifd20f78b168b9a913fdb8d89dc26a76a173b1c29
Bartosz Dziewoński [Wed, 13 Aug 2014 19:58:01 +0000 (21:58 +0200)]
Update release notes and documentation about skins
skins/README based on extensions/README. Also updated the latter.
Bug: 68402
Bug: 69372
Change-Id: I6d045af0509aa8fc485255b507554d771d101ee0
umherirrender [Wed, 13 Aug 2014 19:41:39 +0000 (21:41 +0200)]
Correct variable names in @param to match method declarations
Some @param have a typo in the variable name,
some @param's were in wrong order.
Change-Id: Ie25806831027112b398f6f4a909c59147ac3a5fa
Daniel Friesen [Wed, 13 Aug 2014 19:36:28 +0000 (12:36 -0700)]
Fix documentation.
It's true that right now the internal skin name doesn't have to be all-lowercase,
however not doing so leads to side effects such as the changing of case of i18n message keys,
if the documentation makes programmers aware that something other than all-lowercase can
be used, they should also be aware of the side effects of doing so.
Change-Id: Ib1ed192b1ba83ae864313c34b450a1151485750b
umherirrender [Wed, 13 Aug 2014 19:26:20 +0000 (21:26 +0200)]
Use /** for doc comments
/* is only a comment, which is not used when build the documentation
Change-Id: Id5f917928e3a253a90fd17b0d7aad7340f9393f5
jenkins-bot [Wed, 13 Aug 2014 18:58:07 +0000 (18:58 +0000)]
Merge "SkinFactory: Improve documentation and comments"
jenkins-bot [Wed, 13 Aug 2014 18:56:53 +0000 (18:56 +0000)]
Merge "SkinFactory: register skins in Setup.php"
umherirrender [Wed, 13 Aug 2014 18:01:46 +0000 (20:01 +0200)]
Fixed some docs
- Added since to @deprecated
- Use lowercase array on @param
- Added missing type on @param
- Swapped type and variable on @param
- Fixed spelling of @return
Change-Id: Idbbc6b4c8aadb6d98c636f53024ac513346c912b
jenkins-bot [Wed, 13 Aug 2014 17:53:59 +0000 (17:53 +0000)]
Merge "ApiTestCase: Avoid notices about undefined indices"
Bartosz Dziewoński [Wed, 13 Aug 2014 17:47:57 +0000 (19:47 +0200)]
ApiTestCase: Avoid notices about undefined indices
We're going to throw an exception right away here, but this is still
problematic because of PHPUnit:
"By default, PHPUnit converts PHP errors, warnings, and notices that
are triggered during the execution of a test to an exception."
http://phpunit.de/manual/4.2/en/writing-tests-for-phpunit.html#writing-tests-for-phpunit.errors
Also change the exception message to something saner.
Change-Id: I766c36076d34428035be78bbb3cf36cc572b565b
umherirrender [Wed, 13 Aug 2014 17:39:07 +0000 (19:39 +0200)]
Docs: compatability -> compatibility
https://en.wiktionary.org/wiki/compatability
Change-Id: I71d82ae04d4b17609a1d5a7eec4497115e64972e
jenkins-bot [Wed, 13 Aug 2014 16:41:49 +0000 (16:41 +0000)]
Merge "EditPage::newSectionSummary should return a value in all code paths"
umherirrender [Fri, 8 Aug 2014 19:44:01 +0000 (21:44 +0200)]
Set $wgUploadNavigationUrl to false on parser and unit tests
Setting this to default avoids failing parser tests,
when it is set in LocalSettings.php
Bug: 54576
Change-Id: I531d5839e9abe571c6c29f290bb159dabca34798
Bartosz Dziewoński [Wed, 13 Aug 2014 11:55:55 +0000 (13:55 +0200)]
SkinFactory: Improve documentation and comments
* Document parameters to register()
* Document what the "human-readable name" does
* Document the distinction between autodiscovery and $wgValidSkinNames
skins
Change-Id: Iee5bd18b3e68f3e48ccd28e386109e60fee31085
Kunal Mehta [Mon, 11 Aug 2014 11:33:54 +0000 (12:33 +0100)]
SkinFactory: register skins in Setup.php
This un-makes $wgValidSkinNames a legacy thing, and is
more backwards-compatible friendly.
Change-Id: I5c442f3c9e4ee7a4a3980fd02138ee756ef9fa7a
withoutaname [Thu, 31 Jul 2014 03:55:30 +0000 (20:55 -0700)]
Remove various functions and globals deprecated since 1.22 from RecentChange
Change-Id: I5200892e75ffa894133e2e386d53c09536547de9
withoutaname [Thu, 31 Jul 2014 03:18:28 +0000 (20:18 -0700)]
Remove deprecated $wgHTCPMulticastAddress, $wgHTCPMulticastRouting and $wgHTCPPort
Change-Id: Icfbc178d823e59f2e305cbc4bca0b194d2786026
umherirrender [Sun, 3 Aug 2014 19:29:54 +0000 (21:29 +0200)]
Set relevant title on Special:RecentChangesLinked
This adds title related tabs like watch on the special page
Same as on Special:MovePage
Change-Id: I0e8ef723b44069945d4e39566225ec77b2f85e10
jenkins-bot [Wed, 13 Aug 2014 01:31:07 +0000 (01:31 +0000)]
Merge "Remove return from Action::checkCanExecute"
jenkins-bot [Wed, 13 Aug 2014 00:50:10 +0000 (00:50 +0000)]
Merge "resourceloader: Wrap only=script responses in "if(window.mw)""
Timo Tijhof [Wed, 6 Aug 2014 15:54:22 +0000 (15:54 +0000)]
resourceloader: Wrap only=script responses in "if(window.mw)"
We currently have a few legacy requests to the load.php end point
that bypass the ResourceLoader client by coding a request to
load.php via a "<script src>" directly. Most prominently the
request for the 'site' wiki module (aka MediaWiki:Common.js).
Remove the manual wrapping of embedded private modules as this
is now taken are of by ResourceLoader::makeModuleResponse itself.
Misc:
* Mark "jquery" and "mediawiki" as Raw modules. While the startup
module had this already, these didn't. Without this, they'd
get the conditional wrap – which would be a problem since mediawiki.js
can't be conditional on 'window.mw' for that file defines that
namespace itself.
* Strip the cache-key comment in the unit tests because the hash
no longer matches and using the generic 'wiki' dbname was breaking
DB queries.
* Relates to bug 63587.
* See also
05d0f6fefdcc959d which expands the reach of the non-JS
environment to IE6 and helped expose this bug.
Change-Id: Icf6ede09b51ce212aa70ff6be4b341762ec75b4d
addshore [Mon, 11 Aug 2014 20:58:31 +0000 (21:58 +0100)]
Fix phpcs issues in actions and revisiondelete dirs
Change-Id: I54c1e336b8c44ff8720ac38c8b2d68ede42af305
jenkins-bot [Tue, 12 Aug 2014 22:33:18 +0000 (22:33 +0000)]
Merge "actions: Move SubmitAction class out of EditAction.php"
jenkins-bot [Tue, 12 Aug 2014 22:29:06 +0000 (22:29 +0000)]
Merge "resourceloader: Fix undefined variable in ResourceLoaderFileModule::getSkipFunction"
withoutaname [Mon, 4 Aug 2014 00:15:17 +0000 (17:15 -0700)]
actions: Move SubmitAction class out of EditAction.php
Straight move, except for the slight change in the comparison operator
for session_id().
Change-Id: I9404f48ee75ff3d3655f2f5b75a05d66f334b80d
Alexandre Emsenhuber [Tue, 12 Aug 2014 18:15:53 +0000 (20:15 +0200)]
resourceloader: Fix undefined variable in ResourceLoaderFileModule::getSkipFunction
Follows-up
75c08916b02ac87. Looking at the call chain of
validateScriptFile() up to JSTokenzier, the first parameter is the file
name, otherwise "[inline]" is used; so that variable should be $localPath.
Bug: 69214
Change-Id: If7f36449cb352f50ba795a6d306e5d949a3dbd29
jenkins-bot [Tue, 12 Aug 2014 22:12:19 +0000 (22:12 +0000)]
Merge "Change "ENGINE=HEAP" to "ENGINE=MEMORY""