Brian Wolff [Fri, 15 Jun 2018 08:19:49 +0000 (08:19 +0000)]
SECURITY: Fix reauth in Special:ChangeEmail
Previously you could bypass reauthentication by directly
POSTing to Special:ChangeEmail.
Bug: T197279
Change-Id: I674557351e0e91a8105c12ddf6cd30283aac9f7a
Adam Wight [Thu, 6 Jun 2019 10:51:03 +0000 (12:51 +0200)]
Correct name of the recommended function
Change-Id: I6b79b6a9e3d17eafdb92fd940d64e9108ff5c293
jenkins-bot [Thu, 6 Jun 2019 09:04:26 +0000 (09:04 +0000)]
Merge "Refactor buildPrevNextNavigation"
jenkins-bot [Thu, 6 Jun 2019 04:20:49 +0000 (04:20 +0000)]
Merge "Improve type hints to special page related classes"
jenkins-bot [Thu, 6 Jun 2019 02:02:29 +0000 (02:02 +0000)]
Merge "Remove DatabaseSqliteMock unit test class in favor of mocking"
jenkins-bot [Thu, 6 Jun 2019 01:46:42 +0000 (01:46 +0000)]
Merge "Improve @var on User class"
jenkins-bot [Thu, 6 Jun 2019 00:07:23 +0000 (00:07 +0000)]
Merge "Update OOUI to v0.32.1"
clarakosi [Wed, 29 May 2019 23:08:11 +0000 (19:08 -0400)]
Refactor buildPrevNextNavigation
Refactored buildPrevNextNavigation() into standalone helper class,
PrevNextNavigationRenderer, to be used by both SpecialPages and Pagers.
Bug:T207977
Change-Id: Ic49837a451f795ec203e867961ec1c69075cc91a
Aaron Schulz [Wed, 5 Jun 2019 21:25:46 +0000 (22:25 +0100)]
Remove DatabaseSqliteMock unit test class in favor of mocking
Change-Id: Id22233359df25920c335e4945e606c6c3283f2a1
jenkins-bot [Wed, 5 Jun 2019 20:51:04 +0000 (20:51 +0000)]
Merge "Decouple DatabaseBlock::newFromTarget from DatabaseBlock::newLoad"
Translation updater bot [Wed, 5 Jun 2019 19:58:20 +0000 (21:58 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I5ff3c17b7b9ee534e3efa6cdb7ce4b7b40a54d16
Umherirrender [Wed, 5 Jun 2019 17:19:22 +0000 (19:19 +0200)]
Improve @var on User class
Add missing @var tags with types or add missing types to @var
Change-Id: I34eb4c26d34da072465f1b162fb2d0291610f564
James D. Forrester [Wed, 5 Jun 2019 16:32:46 +0000 (09:32 -0700)]
Update OOUI to v0.32.1
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.32.1
Bug: T223841
Bug: T224739
Bug: T224885
Depends-On: I1e6ed138cbab66c94cd45289799302d88d22cad9
Change-Id: I72278024790829841c15dd7b3eb09fe1a98cac9c
jenkins-bot [Wed, 5 Jun 2019 15:42:04 +0000 (15:42 +0000)]
Merge "HTMLForm: Use PHP 5.6 splat operator directly instead of ObjectFactory"
Thalia [Fri, 24 May 2019 13:02:32 +0000 (14:02 +0100)]
Decouple DatabaseBlock::newFromTarget from DatabaseBlock::newLoad
Before this, DatabaseBlock:newFromTarget initialises a new block and
calls DatabaseBlock::newLoad on that instance, passing through the
target and type via that instance. However, newLoad returns a brand
new block instance. This patch makes newLoad into a static method,
with the target and type passed as method parameters.
It also separates the block-choosing logic in newLoad into a separate
method, DatabaseBlock::chooseMostSpecificBlock. Doing this (1) makes
it more transparent that Block uses two different ways to choose a
block (see also Block::chooseBlock), and (2) makes it possible to
re-use newLoad to get multiple blocks.
Also, filter out any duplicate autoblocks that are found by newLoad.
Bug: T206163
Change-Id: Iefa3aaadf2954c3b86f5c691096af31de40fae6c
daniel [Wed, 22 May 2019 20:12:11 +0000 (22:12 +0200)]
Make userLink() not fail too hard on false and null.
This works around an issue in Flow, which sometimes passes false
for a user name.
Bug: T224095
Change-Id: I14dc52f7199012dc35605f3170b06eb1719165a7
jenkins-bot [Wed, 5 Jun 2019 09:10:26 +0000 (09:10 +0000)]
Merge "Fix return type of UploadBase::check* functions"
jenkins-bot [Wed, 5 Jun 2019 08:57:05 +0000 (08:57 +0000)]
Merge "Allow int as return type of MediaHandler::isMetadataValid"
jenkins-bot [Wed, 5 Jun 2019 08:56:34 +0000 (08:56 +0000)]
Merge "Fix type to callable on FileRepo::getErrorCleanupFunction"
Kunal Mehta [Tue, 4 Jun 2019 19:45:38 +0000 (15:45 -0400)]
HTMLForm: Use PHP 5.6 splat operator directly instead of ObjectFactory
Change-Id: I3fddf30f1b0fc2cce79f652cb71efba119439a9f
jenkins-bot [Tue, 4 Jun 2019 20:03:38 +0000 (20:03 +0000)]
Merge "Add action=query&meta=languageinfo API module"
Translation updater bot [Tue, 4 Jun 2019 19:57:17 +0000 (21:57 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I98b20ec1bd615860212c254729a20ed998a76ba1
Umherirrender [Tue, 4 Jun 2019 19:44:51 +0000 (21:44 +0200)]
Fix return type of UploadBase::check* functions
Change-Id: I37964663fc8cb63575c1e0be9c5ced489d69136e
Umherirrender [Tue, 4 Jun 2019 19:33:37 +0000 (21:33 +0200)]
Allow int as return type of MediaHandler::isMetadataValid
MediaHandler::METADATA_COMPATIBLE is a int,
which is a possible return value here
Change-Id: Ia84139ee8e09839e1f46a6d34738612dfd365415
Umherirrender [Tue, 4 Jun 2019 19:28:25 +0000 (21:28 +0200)]
Fix type to callable on FileRepo::getErrorCleanupFunction
Change-Id: Idb07fb2d6ade9eb3619ecea5516d7e9815b7bb54
Kunal Mehta [Mon, 3 Jun 2019 00:56:10 +0000 (20:56 -0400)]
Hard-deprecate SkinFactory::getDefaultInstance()
Was soft-deprecated in 1.27.
Change-Id: I5f4afefc6c439c7e8d173a844c76ccd693f9bbf1
jenkins-bot [Mon, 3 Jun 2019 20:38:46 +0000 (20:38 +0000)]
Merge "selenium: Re-add all tests and wdio-mocha-framework, now v0.6.4"
jenkins-bot [Mon, 3 Jun 2019 20:23:35 +0000 (20:23 +0000)]
Merge "Set content language for test to en to ensure it passes"
Translation updater bot [Mon, 3 Jun 2019 19:59:29 +0000 (21:59 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Iebfb3ccd127a9dab6dac283fe6d6f3427422c004
James D. Forrester [Mon, 3 Jun 2019 17:58:18 +0000 (10:58 -0700)]
selenium: Re-add all tests and wdio-mocha-framework, now v0.6.4
This reverts commit
c3878c08b5275123972354ba5479d3315c4fefb4.
Now that we're running on node10, this will fail until we fix
things.
Bug: T213268
Bug: T222406
Change-Id: I5935fc5d5bc23978e50275d3c99ac870b3b82f49
Umherirrender [Mon, 3 Jun 2019 19:11:10 +0000 (21:11 +0200)]
Improve type hints to special page related classes
Change-Id: I96e2ff2fbd6f69e83212b22cf107417014b665e1
Thalia [Mon, 3 Jun 2019 17:44:11 +0000 (13:44 -0400)]
Set content language for test to en to ensure it passes
Change-Id: I5bff92e304795ac4f76fd07f12f3598fbf816f39
jenkins-bot [Mon, 3 Jun 2019 17:37:47 +0000 (17:37 +0000)]
Merge "HTMLForm: Remove deprecated unused getErrors() method"
jenkins-bot [Mon, 3 Jun 2019 17:26:05 +0000 (17:26 +0000)]
Merge "make sure revision uids are 0 in the xml if missing/0 in the db"
jenkins-bot [Mon, 3 Jun 2019 16:47:14 +0000 (16:47 +0000)]
Merge "selenium: Temporarily drop all tests and wdio-mocha-framework"
jenkins-bot [Mon, 3 Jun 2019 16:32:03 +0000 (16:32 +0000)]
Merge "Add missing newline between <?php and namespace/use section"
Ariel T. Glenn [Mon, 27 May 2019 13:03:29 +0000 (16:03 +0300)]
make sure revision uids are 0 in the xml if missing/0 in the db
Bug: T224221
Change-Id: Id9861866fd9e4d2fe8d151c9631403aa24b9a779
jenkins-bot [Mon, 3 Jun 2019 15:00:12 +0000 (15:00 +0000)]
Merge "Use ExtensionRegistry::setAttributeForTest() instead of Reflection"
James D. Forrester [Tue, 7 May 2019 19:43:54 +0000 (12:43 -0700)]
selenium: Temporarily drop all tests and wdio-mocha-framework
This is so that we can migrate to node 10 in CI. It should only land
for an hour or so, and is to be reverted as soon as we get CI up to
node 10 and working, lest our suites of selenium tests become
subject to bitrot.
Bug: T222406
Change-Id: I9473e0213c070a0e963913fd81062c6bbf9ec2f2
jenkins-bot [Mon, 3 Jun 2019 14:27:37 +0000 (14:27 +0000)]
Merge "Remove usage of deprecated SkinFactory::getDefaultInstance()"
Derick Alangi [Mon, 3 Jun 2019 14:16:38 +0000 (15:16 +0100)]
HTMLForm: Remove deprecated unused getErrors() method
Was deprecated in 1.28 and no longer used, see usage below;
Usage
=====
https://codesearch.wmflabs.org/search/?q=%5CbgetErrors%5C(%20(.*%3F)%20%5C)&i=nope&files=&repos=
Bug: T220656
Change-Id: I542df4f1f7f4180d42282eaf2e069ab0bc9e8614
jenkins-bot [Mon, 3 Jun 2019 13:55:03 +0000 (13:55 +0000)]
Merge "Add a "help" button for action=info"
Thiemo Kreuz [Tue, 28 May 2019 14:04:23 +0000 (16:04 +0200)]
Add missing newline between <?php and namespace/use section
The rest of the codebase is using this code formatting standard.
Change-Id: I4d2ba61757a7e28d40096d9dc5915005c340d4f2
Lucas Werkmeister [Thu, 16 May 2019 09:42:05 +0000 (11:42 +0200)]
Add action=query&meta=languageinfo API module
This API module can be used to get information about all the languages
supported by this MediaWiki installation. Since parts of this
information, such as the fallback chain, are expensive to retrieve if
the localization cache is not populated, we apply continuation if the
request is taking too long (suggested by Anomie in T217239#
4994301); we
don’t expect this to happen in Wikimedia production, though.
Bug: T74153
Bug: T220415
Change-Id: Ic66991cd85ed4439a47bfb1412dbe24c23bd9819
jenkins-bot [Mon, 3 Jun 2019 08:55:58 +0000 (08:55 +0000)]
Merge "API: Migrate Title::userCan() calls to PermissionManager"
jenkins-bot [Mon, 3 Jun 2019 08:55:50 +0000 (08:55 +0000)]
Merge "always order by page_id for dumps of current revisions"
jenkins-bot [Mon, 3 Jun 2019 04:31:44 +0000 (04:31 +0000)]
Merge "Wording"
DannyS712 [Mon, 3 Jun 2019 02:42:30 +0000 (02:42 +0000)]
Add a "help" button for action=info
Bug: T224848
Change-Id: Id72fb9134ce889b9610ca088e53799804580903e
Kunal Mehta [Mon, 3 Jun 2019 00:58:58 +0000 (20:58 -0400)]
Use ExtensionRegistry::setAttributeForTest() instead of Reflection
Change-Id: If29e8825f1734f8c0efa21aa77f6354fa3468248
Kunal Mehta [Mon, 3 Jun 2019 00:55:00 +0000 (20:55 -0400)]
Remove usage of deprecated SkinFactory::getDefaultInstance()
Change-Id: I3bd50f8ca5baabd34dbc0e3bbc2f97e94650a17a
Translation updater bot [Sun, 2 Jun 2019 19:57:51 +0000 (21:57 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ia730eebb70ecece0daca1d97c3d541a767777ecc
Seb35 [Sat, 1 Jun 2019 12:16:00 +0000 (14:16 +0200)]
Wording
In GitInfo, the debug sentence "Computed cacheFile" could imply that some
file is written, but in reality "computed" refers to the name. Change to
"Candidate cacheFile".
Bug: T215722
Change-Id: I19448e5790a0f2fcb5202170ca03ab0f5e16d24e
DannyS712 [Sat, 1 Jun 2019 02:15:40 +0000 (02:15 +0000)]
Add a "help" link for Special:PermanentLink
Bug: T224793
Change-Id: I4099b1a794df8477842d5f018d63304cef99d372
jenkins-bot [Sat, 1 Jun 2019 00:35:12 +0000 (00:35 +0000)]
Merge "Improve changePassword.php error handling"
jenkins-bot [Fri, 31 May 2019 22:00:28 +0000 (22:00 +0000)]
Merge "Allow $conds of IDatabase::selectRow to be a string"
jenkins-bot [Fri, 31 May 2019 20:33:29 +0000 (20:33 +0000)]
Merge "Fix typos in DefaultSettings"
jenkins-bot [Fri, 31 May 2019 20:33:21 +0000 (20:33 +0000)]
Merge "Inline trivial …_internal() methods in Title/UserArray classes"
Umherirrender [Fri, 31 May 2019 19:47:55 +0000 (21:47 +0200)]
Allow $conds of IDatabase::selectRow to be a string
When not having a condition you can pass a empty string or '*'
Change-Id: Id1bb6cf6e6bd89ad2df492e7441253d06fcf2a2d
jenkins-bot [Fri, 31 May 2019 15:51:16 +0000 (15:51 +0000)]
Merge "rdbms: cleanup code for read-only propagation for master connections"
jenkins-bot [Fri, 31 May 2019 10:05:52 +0000 (10:05 +0000)]
Merge "Add CirrusSearch dev dependency to require-dev"
Dayllan Maza [Fri, 31 May 2019 04:07:34 +0000 (00:07 -0400)]
Fix typo in docs
Change-Id: I69085afd4f3475ae6449a0e3683a28ccddf47445
jenkins-bot [Thu, 30 May 2019 23:12:33 +0000 (23:12 +0000)]
Merge "Make sure that each DataUpdate still has outer transaction scope"
jenkins-bot [Thu, 30 May 2019 23:06:52 +0000 (23:06 +0000)]
Merge "rdbms: make resolveDomainID() use more consistent in LoadBalancer"
Aaron Schulz [Wed, 8 May 2019 16:13:37 +0000 (09:13 -0700)]
rdbms: cleanup code for read-only propagation for master connections
Make "readOnlyReason" immediately propagate from LoadBalancer to the
DB handle even when getConnection() with DB_REPLICA yields a master
DB handle. This can happen when the master has a non-zero "load".
Previously, it would not be set until something later used DB_MASTER
with getConnection(). This didn't really effect anything but seemed
confusing.
Short-circuit getLaggedReplicaMode() when the reader index uses the
master DB since there is no chance of lag. Also simplify it to just
calling getReaderIndex(), which since nothing else is needed to set
the "laggedReplicaMode" field.
Also rename "readerIndex" field to "genericReadIndex" and "loads"
field to "genericLoads" for clarity.
Change-Id: I6dc28933d2f94f0de1e8f9c5b2b8d2cf8a1a9d08
jenkins-bot [Thu, 30 May 2019 22:45:20 +0000 (22:45 +0000)]
Merge "rdbms: clean up and refactor ResultWrapper classes"
jenkins-bot [Thu, 30 May 2019 22:11:49 +0000 (22:11 +0000)]
Merge "Consistently use spaces and stars in comments"
Aaron Schulz [Wed, 29 May 2019 21:07:03 +0000 (14:07 -0700)]
Make sure that each DataUpdate still has outer transaction scope
Bug: T221577
Change-Id: I620e461d791416ca37fa9ca4fca501e28d778cf5
Translation updater bot [Thu, 30 May 2019 20:22:58 +0000 (22:22 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ib076d5736f1bea05df4c649cddd1b12ea6cc3af4
Erik Bernhardson [Thu, 30 May 2019 19:31:51 +0000 (12:31 -0700)]
Add CirrusSearch dev dependency to require-dev
Adds symfony/yaml for parsing event schemas used by EventBus
as part of the CirrusSearch test suite. The dependency needs to be
added to core to support CI testing extensions that depend on
CirrusSearch.
Bug: T220723
Change-Id: Iddbfb81fb667980470d6872c34a1e63897f1e4af
Máté Szabó [Sat, 18 May 2019 16:58:24 +0000 (18:58 +0200)]
API: Migrate Title::userCan() calls to PermissionManager
T208768 introduced the PermissionManager service that can now be used
for page specific permission checks. This change replaces calls to
Title::userCan() with the new service in API classes.
Bug: T220191
Change-Id: I768d07a520ca6473a4eefb88c9f587657bc74357
jenkins-bot [Thu, 30 May 2019 18:09:09 +0000 (18:09 +0000)]
Merge "Cleanup LinkerTest leakage between provider entries"
jenkins-bot [Thu, 30 May 2019 15:35:39 +0000 (15:35 +0000)]
Merge "Fix empty auto-summaries triggering a fatal error."
Fomafix [Thu, 30 May 2019 10:29:37 +0000 (12:29 +0200)]
Consistently use spaces and stars in comments
Change-Id: Ia8e005ec65b5a98b12fc1c079604db175b731a88
daniel [Tue, 21 May 2019 10:16:22 +0000 (12:16 +0200)]
Fix empty auto-summaries triggering a fatal error.
Aka: Streamline Linker::formatAutocomments() and add tests
This uses the "streamlining" for the code proposed by Thiemo
in I38edc1ad7720. I have squashed the two commits, so it now
has his code in Linker, but still has my tests as well as his.
Thiemo wrote on his patch:
This also changes the output in case there is no fragment to link to.
Before an empty `/* */` in a summary this would have created a link to
the page. I would like to argue this is not what a user expects.
Bug: T222628
Change-Id: I05408ede0e20dfd976f4057fc5baab461d2ef769
jenkins-bot [Thu, 30 May 2019 14:24:07 +0000 (14:24 +0000)]
Merge "Revert "Factors out permissions check from User into PermissionManager service""
Kosta Harlan [Thu, 30 May 2019 13:51:37 +0000 (13:51 +0000)]
Revert "Factors out permissions check from User into PermissionManager service"
This reverts commit
7faa7a7420866ec685863c1d6c530bd4999da643.
Reason for revert: T224607
Change-Id: I549810a4cd2e424cc4a438887d2f24614a24cc00
Aaron Schulz [Tue, 7 May 2019 17:57:09 +0000 (10:57 -0700)]
rdbms: make resolveDomainID() use more consistent in LoadBalancer
Use the method in getConnection()/openConnection() and make it
handle the local domain alias as well.
Also:
* Move some code to a new getConnectionIndex() method.
* Make the text of various index/domain exceptions more consistent.
* Improve some auto-commit flag code comments.
Change-Id: I7e0d4f2134ee91ad60b0d34bf01e05115193b04a
Aaron Schulz [Wed, 29 May 2019 21:05:10 +0000 (14:05 -0700)]
Cleanup LinkerTest leakage between provider entries
The problem was that new revisions were being added to the same page
since it is not deleted between each run.
Change-Id: I52e8db8e5ef3cde309c26f928fd44de4e6ec18e4
jenkins-bot [Wed, 29 May 2019 23:01:10 +0000 (23:01 +0000)]
Merge "jquery.suggestions: Do not show suggestions on prefilled values"
Fomafix [Wed, 29 May 2019 09:18:47 +0000 (11:18 +0200)]
jquery.suggestions: Do not show suggestions on prefilled values
Show the suggestions on load only if the current value differs to the
defaultValue from the HTML. This prevents suggestions if there is
already a prefilled value in the input field.
Also direct call $.suggestions.update() instead of trigger a keypress.
This change is a follow-up to
72f61f7a5930cf03d4e8ddde62c2ef627b05dd69.
Bug: T224524
Change-Id: I501596996a20c62d1497bf66e23c7858b58bf4ea
jenkins-bot [Wed, 29 May 2019 21:10:43 +0000 (21:10 +0000)]
Merge "Fix typo in comment about class name"
jenkins-bot [Wed, 29 May 2019 20:21:01 +0000 (20:21 +0000)]
Merge "Print chained exceptions when maintenance script fails."
jenkins-bot [Wed, 29 May 2019 19:36:04 +0000 (19:36 +0000)]
Merge "Add checkDependencies.php"
Thiemo Kreuz [Tue, 28 May 2019 14:07:50 +0000 (16:07 +0200)]
Inline trivial …_internal() methods in Title/UserArray classes
This code is quite old. I can't tell why it was written this way.
But I can see these methods are never used anywhere else. We can as
well inline them.
Change-Id: I252f4d2b2b2da822c8d43ffc1f088f5848034c5e
Umherirrender [Wed, 29 May 2019 19:17:12 +0000 (21:17 +0200)]
Fix typo in comment about class name
Change-Id: I52e2b9f6553f4d3977c609bc1e2bc86c24e0c9c7
jenkins-bot [Wed, 29 May 2019 19:11:38 +0000 (19:11 +0000)]
Merge "parser: list the vary-* flags in the NewPP report HTML comment"
Aaron Schulz [Wed, 29 May 2019 17:55:57 +0000 (10:55 -0700)]
parser: list the vary-* flags in the NewPP report HTML comment
Change-Id: I5a4afba2bfdb5b5b56ba0a01ed8ff444a67fbb1a
jenkins-bot [Wed, 29 May 2019 17:48:23 +0000 (17:48 +0000)]
Merge "WatchedItemStore: Remove deprecated Title param to getNextRevision()"
Vedmaka [Tue, 9 Apr 2019 06:58:04 +0000 (09:58 +0300)]
Factors out permissions check from User into PermissionManager service
The following methods should are factored out of the User class into PermissionManager, leaving only deprecated stubs:
- User::isAllowed -> PermissionManager::userHasRight
- User::getRights -> PermissionManager::getUserPermissions
- User::groupHasPermission -> PermissionManager::groupHasPermission
- User::getGroupPermissions -> PermissionManager::getGroupPermissions
-User::getGroupsWithPermission -> PermissionManager::getGroupsWithPermission
- User::groupHasPermission -> PermissionManager::groupHasPermission
- User::isEveryoneAllowed -> PermissionManager::isEveryoneAllowed
- User::getAllRights -> PermissionManager::getAllPermissions
Depends-On: I258f02e286b6ba0387e1bff540a744fafb03dc55
Depends-On: Ie4cedf457eaaa93ec3055c37539322855e02ce26
Depends-On: Id274f240d687efa61cb9f7a15033ae2a7a532083
Bug: T218558
Bug: T223294
Change-Id: Ia0d840b772ea5f20c9594ce151cc57adc270e48b
Aaron Schulz [Wed, 29 May 2019 03:01:17 +0000 (20:01 -0700)]
rdbms: clean up and refactor ResultWrapper classes
Change-Id: Ib1d71dbbd31e134cf89dca58f7aa77bdddc828c0
Volker E [Wed, 29 May 2019 00:57:59 +0000 (17:57 -0700)]
Update OOUI to v0.32.0
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.32.0
Bug: T141320
Bug: T163142
Bug: T169484
Bug: T178950
Bug: T180730
Bug: T203859
Bug: T212186
Bug: T213884
Bug: T215644
Bug: T219479
Bug: T220239
Depends-On: Ia65a8053082ac95bf89cb5484aa64668fb780735
Change-Id: I0a48885642b86950180d1fbe4c7a609d323fb87f
jenkins-bot [Tue, 28 May 2019 22:43:51 +0000 (22:43 +0000)]
Merge "Rename Block to MediaWiki\Block\DatabaseBlock"
Simon Legner [Tue, 28 May 2019 21:59:06 +0000 (23:59 +0200)]
Fix typos in DefaultSettings
Change-Id: I692286d68bdf5585694c8a65d9d9d512f813fb9e
jenkins-bot [Tue, 28 May 2019 21:46:27 +0000 (21:46 +0000)]
Merge "Fix typos in MessageCache"
jenkins-bot [Tue, 28 May 2019 21:39:21 +0000 (21:39 +0000)]
Merge "media: Fix $ext property name in BmpHandler::getThumbType()"
jenkins-bot [Tue, 28 May 2019 19:27:49 +0000 (19:27 +0000)]
Merge "EditPage: Remove unused deprecated method ::submit()"
Simon Legner [Tue, 28 May 2019 19:12:45 +0000 (21:12 +0200)]
Fix typos in MessageCache
Change-Id: I5ede5ad5687144535545248940ca6f676f514900
jenkins-bot [Tue, 28 May 2019 19:15:01 +0000 (19:15 +0000)]
Merge "Hard-deprecate Title::moveTo and friends"
jenkins-bot [Tue, 28 May 2019 19:12:49 +0000 (19:12 +0000)]
Merge "Finish sentence in MultiUsernameFilter documentation"
Derick Alangi [Tue, 28 May 2019 18:27:02 +0000 (19:27 +0100)]
EditPage: Remove unused deprecated method ::submit()
Was deprecated in 1.29 and EditPage::edit() was made available for
use and replacement of this ::submit().
Usage
=====
https://codesearch.wmflabs.org/search/?q=%5C-%5C%3Esubmit%5C(%5C)&i=nope&files=&repos=
The usage of ->submit() in the search link above are not for EditPage
but for other classes.
Change-Id: Ibd65965c785f84e9bda65cfaa2c491310cda8166