Aryeh Gregor [Sun, 2 May 2010 01:59:08 +0000 (01:59 +0000)]
Improve IE6 version check to avoid false positives
Bug 23171. Not added to RELEASE-NOTES because I'll backport to 1.16.
Roan Kattouw [Sat, 1 May 2010 21:26:30 +0000 (21:26 +0000)]
Followup to r65590: we don't need to explain the meanings of 'true' and 'false' for cases like these where a dictionary will suffice. Fix another typo in the RELEASE-NOTES entry as well, and bump $wgStyleVersion for r65591.
Roan Kattouw [Sat, 1 May 2010 21:17:44 +0000 (21:17 +0000)]
Rephrase potentially confusing comment in r65555
Platonides [Sat, 1 May 2010 20:16:13 +0000 (20:16 +0000)]
Bug 23371: Fix CSRF similar to r64677 covering the other three execute()
branches. Checks added to mailPassword() and addNewAccountInternal()
(covers addNewAccount & addNewAccountMailPassword).
Paranoia: Use different tokens for login and account creation.
*For wikis allowing public account creation, an attacker could create
many accounts via proxying users, avoiding ip blocks, the anon gets
logged in (wikis using ConfirmEdit to request a captcha for createaccount
are protected from this).
*If the victims were logged users, the attacker could create the
accounts by email and flood innocent parties using the wiki as gateway.
*If the victim was a sysop, the attacker could not only bypass the
captcha protection, but also the username blacklist.
*It also provides a way to bypass the blocks and ping limit for sending
many password resets flooding its targets.
*On private wikis an account creation by targeting a sysop may expose
confidential information.
Raimond Spekking [Sat, 1 May 2010 19:24:56 +0000 (19:24 +0000)]
* (bug 23364) Changed native name for Azerbaijani.
Raimond Spekking [Sat, 1 May 2010 19:15:20 +0000 (19:15 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-05-01 19:00:00 UTC)
Tobias [Sat, 1 May 2010 10:56:52 +0000 (10:56 +0000)]
fixing documentation (it seems the function name has changed)
Mark A. Hershberger [Sat, 1 May 2010 02:09:08 +0000 (02:09 +0000)]
Wrap UploadFromUrlTest with a special TestSuite that ensures the test database + global vars are set correctly. Eventually need to use this wrapper for all tests.
Jack Phoenix [Fri, 30 Apr 2010 22:21:36 +0000 (22:21 +0000)]
more follow-up to r65715: coding style tweaks, etc.
Jack Phoenix [Fri, 30 Apr 2010 22:06:13 +0000 (22:06 +0000)]
follow-up to r65715: convert spaces to tabs for indentation, as per our coding standards. no functional changes.
Platonides [Fri, 30 Apr 2010 21:57:26 +0000 (21:57 +0000)]
No MaxSem, you can't revert r65715 on r65716. Use a class variable instead of a global variable for passing the error from the error handler to user code.
Ryan Lane [Fri, 30 Apr 2010 20:45:52 +0000 (20:45 +0000)]
Initial commit of the Selenium framework
Rotem Liss [Fri, 30 Apr 2010 20:30:33 +0000 (20:30 +0000)]
Localization update for he.
Raimond Spekking [Fri, 30 Apr 2010 19:17:20 +0000 (19:17 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-04-30 19:00:00 UTC)
Platonides [Thu, 29 Apr 2010 22:02:44 +0000 (22:02 +0000)]
Follow up r65672. FIXED.
Platonides [Thu, 29 Apr 2010 21:49:58 +0000 (21:49 +0000)]
Actually check sourceFile for failure, showing the error message in the install.
See report on http://permalink.gmane.org/gmane.org.wikimedia.mediawiki/33902
Fixed several tag nesting problems from setup_database().
Make sourceFile() always use text errors in the installer. It can't handle
exceptions properly (introduced in r36211). But they are appropiate for update.php
thus the ugly branches.
The installer now always handles sourceFile() errors.
Raimond Spekking [Thu, 29 Apr 2010 19:22:42 +0000 (19:22 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-04-29 19:00:00 UTC)
Chad Horohoe [Thu, 29 Apr 2010 19:06:11 +0000 (19:06 +0000)]
Kill 5.0.x compat functions, we require 5.1+ anyway
Alexandre Emsenhuber [Thu, 29 Apr 2010 15:09:22 +0000 (15:09 +0000)]
* (bug 23284) Times are now rounded correctly
Daniel Kinzler [Thu, 29 Apr 2010 10:32:18 +0000 (10:32 +0000)]
allow img_auth.php to use path= in place of PATH_INFO, so it can be used in CGI mode. Use with RewriteRule ^/w/images/(.*)$ /w/img_auth.php?path=bell-style
Tobias [Thu, 29 Apr 2010 10:28:28 +0000 (10:28 +0000)]
follow-up on r65546#c6661: minor code style issue. (suggested by Nikerabbit)
Chad Horohoe [Thu, 29 Apr 2010 10:24:52 +0000 (10:24 +0000)]
Followup r64509, need bmp after image/x-ms-bmp
Tobias [Wed, 28 Apr 2010 21:43:23 +0000 (21:43 +0000)]
fixing r65546: move variable decleration up
Raimond Spekking [Wed, 28 Apr 2010 19:46:05 +0000 (19:46 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-04-28 19:20:00 UTC)
Chad Horohoe [Wed, 28 Apr 2010 19:13:43 +0000 (19:13 +0000)]
Unused $wgTitle
Raimond Spekking [Wed, 28 Apr 2010 18:40:51 +0000 (18:40 +0000)]
* Add accesskey 'b' and tooltip to the summary field of edit mode
Max Semenik [Wed, 28 Apr 2010 18:12:42 +0000 (18:12 +0000)]
Marked Database::newFromParams() as deprecated, cleaned up a few mysqlisms in comments
Mark A. Hershberger [Wed, 28 Apr 2010 16:18:33 +0000 (16:18 +0000)]
get complete coverage
Rotem Liss [Wed, 28 Apr 2010 14:33:35 +0000 (14:33 +0000)]
Localization update for he.
Platonides [Wed, 28 Apr 2010 12:28:28 +0000 (12:28 +0000)]
Follow up r65590. Release notes typos.
Happy-melon [Wed, 28 Apr 2010 12:27:57 +0000 (12:27 +0000)]
Follow-up per r65570 CR, also check wgEnableWriteAPI.
Mark A. Hershberger [Wed, 28 Apr 2010 04:28:38 +0000 (04:28 +0000)]
Set globals consisitently for TitlePermissionTest.php
Mark A. Hershberger [Wed, 28 Apr 2010 04:27:30 +0000 (04:27 +0000)]
* Clean up tests so that they run together as well as separately
* TODO: Still tracking down a bug with the tests+jobqueue that shows up during UploadFromURLTest.php
Trevor Parscal [Tue, 27 Apr 2010 22:13:29 +0000 (22:13 +0000)]
Resource changes needed for $wgVectorShowVariantName (see r65590) to function properly.
Trevor Parscal [Tue, 27 Apr 2010 22:11:04 +0000 (22:11 +0000)]
Added $wgVectorShowVariantName global configuration varaible which causes Vector to render the the variants drop-down menu with a label showing the current variant name. This is off by default, pending further research into it's user experience implications. Addresses bug #20193.
Raimond Spekking [Tue, 27 Apr 2010 18:59:21 +0000 (18:59 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-04-27 18:15:00 UTC)
Alexandre Emsenhuber [Tue, 27 Apr 2010 18:15:55 +0000 (18:15 +0000)]
Fix for r65579: removed "!" that should really not be there...
Alexandre Emsenhuber [Tue, 27 Apr 2010 18:09:37 +0000 (18:09 +0000)]
* (bug 23298) Interwiki links with prefix only in log summaries now link to the correct link
Happy-melon [Tue, 27 Apr 2010 15:09:04 +0000 (15:09 +0000)]
Rewrite ajaxwatch.js to use the API watch action, and JQuery. Allows it to be used to asynchronise any watch links, not just the watch tab/links/spinny-starry-thing. Will make it nice and easy to add unwatch links to Special:Watchlist, etc.
Trevor Parscal [Mon, 26 Apr 2010 21:02:30 +0000 (21:02 +0000)]
Added $wgLocalStylePath global variable, and solved bug #22858 by using this new variable in the Vector skin for the inclusion of skins/vector/csshover.htc. HTC files are not cross-domain friendly, so in production environments where $wgStylePath is set to point to bits.wikimedia.org, this will throw JavaScript errors on the page. By adding this new global, which is identical to $wgStylePath except that it will not become customized when $wgStylePath is, we can ensure that certain files, if needed, are always loaded from the same domain as the site.
Raimond Spekking [Mon, 26 Apr 2010 19:31:58 +0000 (19:31 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-04-26 19:15:00 UTC)
Alexandre Emsenhuber [Mon, 26 Apr 2010 19:31:55 +0000 (19:31 +0000)]
Fixed some doxygen warnings and updated doc
Tobias [Mon, 26 Apr 2010 16:35:02 +0000 (16:35 +0000)]
fixing bug 20186: allow filtering SpecialContributions for RevisionDeleted edits. See also bug 20186 comment 22
Rotem Liss [Mon, 26 Apr 2010 16:03:00 +0000 (16:03 +0000)]
Localization update for he.
Jack D. Pond [Mon, 26 Apr 2010 14:44:54 +0000 (14:44 +0000)]
Modification to LocalFile::getHistory for custom repos
Hard coded OldLocalFile::getHistory now used only when oldFileFromRowFactory not declared - for backwards compatibility
Chad Horohoe [Mon, 26 Apr 2010 13:46:04 +0000 (13:46 +0000)]
Kill last vestiges of mediawiki_version. Nobody actually uses it anymore, it just gets silently updated (and only for Postgres at that)
Shinjiman [Mon, 26 Apr 2010 00:10:53 +0000 (00:10 +0000)]
Localisation updates Chinese
making more consistent message as zh-Hant per r65519
Siebrand Mazeland [Sun, 25 Apr 2010 23:11:12 +0000 (23:11 +0000)]
(bug 23313) Move watchlisthidepatrolled above token in watchlist preferences to enhance preference grouping.
Andrew Garrett [Sun, 25 Apr 2010 23:10:53 +0000 (23:10 +0000)]
As well as fixing the broken implementation of sslVerifyHost, correct its documentation and implement a new option, sslVerifyCert, to do what the documentation said that sslVerifyHost did.
Note that CURLOPT_SSL_VERIFYHOST controls *only* the verification of hostname against the hostname on the certificate.
Siebrand Mazeland [Sun, 25 Apr 2010 22:57:12 +0000 (22:57 +0000)]
Follow-up 65339: fix 'pass by reference' warning as reported in bug 23322.
Andrew Garrett [Sun, 25 Apr 2010 22:53:19 +0000 (22:53 +0000)]
HttpFunctions: Fix bug where sslVerifyHost was only added to the CURL options when it would have no effect anyway.
Raimond Spekking [Sun, 25 Apr 2010 19:08:29 +0000 (19:08 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-04-25 18:40:00 UTC)
Shinjiman [Sun, 25 Apr 2010 09:51:55 +0000 (09:51 +0000)]
Localisation updates Cantonese, Chinese and Literary Chinese
Raimond Spekking [Sat, 24 Apr 2010 20:37:56 +0000 (20:37 +0000)]
Add a comment with the used message keys to make sure the grep find them
Raimond Spekking [Sat, 24 Apr 2010 20:07:13 +0000 (20:07 +0000)]
* Add accesskey 's' and tooltip to 'Save' button at Special:Preferences
Raimond Spekking [Sat, 24 Apr 2010 20:01:43 +0000 (20:01 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-04-24 19:50:00 UTC)
Sam Reed [Sat, 24 Apr 2010 11:58:52 +0000 (11:58 +0000)]
Append " and errors" to getDescription for ApiParamInfo to signify that information about the errors a module can return is there
Sam Reed [Sat, 24 Apr 2010 11:12:07 +0000 (11:12 +0000)]
Fix hooks.txt to match code, minor followup to r65506
Sam Reed [Sat, 24 Apr 2010 11:05:15 +0000 (11:05 +0000)]
* (bug 23276) Add hook to Special:NewPages to modify query
Patch by Dan Barrett
Mark A. Hershberger [Sat, 24 Apr 2010 06:22:11 +0000 (06:22 +0000)]
* Refactor super-long title function
* Add tests to achieve almost-complete coverage since I want to make sure my changes don't break thinks.
* Still need to write tests for checkPermissionHooks
* Tests could probably be cleaned up a lot.
Mark A. Hershberger [Sat, 24 Apr 2010 01:14:13 +0000 (01:14 +0000)]
typo
Mark A. Hershberger [Sat, 24 Apr 2010 00:23:57 +0000 (00:23 +0000)]
cache the result of getTitleProtection to make testing easier
Raimond Spekking [Fri, 23 Apr 2010 22:05:09 +0000 (22:05 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-04-23 21:20:00 UTC)
Siebrand Mazeland [Fri, 23 Apr 2010 20:35:25 +0000 (20:35 +0000)]
Tweak comment
Siebrand Mazeland [Fri, 23 Apr 2010 20:31:23 +0000 (20:31 +0000)]
Document parameters in the correct order
Mark A. Hershberger [Fri, 23 Apr 2010 19:36:37 +0000 (19:36 +0000)]
Don't rely on the extract and its side-effects when we can be explicit.
Also, we can do a simple boolean test rather than use is_array.
Mark A. Hershberger [Fri, 23 Apr 2010 18:37:33 +0000 (18:37 +0000)]
Make sure a member var is declared.
Mark A. Hershberger [Fri, 23 Apr 2010 17:29:17 +0000 (17:29 +0000)]
Remove code that looks like it came from Perl as it “works” (doesn't produce an error) but always evaluates to true.
$ php -r '$a = array();var_dump($a > 0);'
bool(true)
Tim Starling [Fri, 23 Apr 2010 16:24:54 +0000 (16:24 +0000)]
More rigorous fix for ImageMagick parameter interpretation (bug 23148 etc.) based on examination of the source code, updating r64932. The source was large and complex and I might have missed some bits, but this is my best guess for now.
Tested bug 23148 and wildcards in filenames (was broken) using a patched convert. With a manual unit test (no convert), tested all branches of the new functions except wfIsWindows() == true.
Rotem Liss [Fri, 23 Apr 2010 14:33:17 +0000 (14:33 +0000)]
Localization update for he.
Raimond Spekking [Thu, 22 Apr 2010 20:21:30 +0000 (20:21 +0000)]
* (bug 23283) Native name for Old English -> Ænglisc
Raimond Spekking [Thu, 22 Apr 2010 19:46:04 +0000 (19:46 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-04-22 19:30:00 UTC)
Alexandre Emsenhuber [Thu, 22 Apr 2010 09:36:18 +0000 (09:36 +0000)]
* (bug 23286) Fix for r62890: namespace selector no longer has effect
Aaron Schulz [Thu, 22 Apr 2010 01:16:03 +0000 (01:16 +0000)]
Removed redundant check if diffButtons()
Raimond Spekking [Wed, 21 Apr 2010 19:10:25 +0000 (19:10 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-04-21 18:30:00 UTC)
Platonides [Wed, 21 Apr 2010 17:33:17 +0000 (17:33 +0000)]
(bug 16487) Do not display the fake Anonymous user account used by Postgres on Special:Listusers. It will surely still produce strange results on many more places, though.
Chad Horohoe [Wed, 21 Apr 2010 16:29:29 +0000 (16:29 +0000)]
Remove current MSSQL implementation from trunk. See wikitech-l for discussion.
Trevor Parscal [Wed, 21 Apr 2010 14:19:06 +0000 (14:19 +0000)]
Actually fix bug #20706 - Next time I will read more carefully and test more thouroughly...
Andrew Garrett [Wed, 21 Apr 2010 14:19:04 +0000 (14:19 +0000)]
Eliminate $wgLivePreview toggle for the uselivepreview preference
Andrew Garrett [Wed, 21 Apr 2010 13:53:59 +0000 (13:53 +0000)]
Fix regression in r65384 with document.write() compatibility
Trevor Parscal [Wed, 21 Apr 2010 13:50:30 +0000 (13:50 +0000)]
Moved a style over to shared.css out of Monobook, making the edit summary box a consistent width accross skins.
Chad Horohoe [Wed, 21 Apr 2010 13:49:50 +0000 (13:49 +0000)]
Revert r65382, can't use global functions here.
Andrew Garrett [Wed, 21 Apr 2010 13:46:44 +0000 (13:46 +0000)]
Live Preview: Do a better job of emulating the edit form submission. Fixes Live Preview in LiquidThreads NewMessages pages.
Trevor Parscal [Wed, 21 Apr 2010 13:46:06 +0000 (13:46 +0000)]
Fixed the font size of pre elements, which was previously too small.
Chad Horohoe [Wed, 21 Apr 2010 13:44:53 +0000 (13:44 +0000)]
Use wfSuppress/RestoreWarnings instead of @
Trevor Parscal [Wed, 21 Apr 2010 13:39:20 +0000 (13:39 +0000)]
Style bump for r65380.
Trevor Parscal [Wed, 21 Apr 2010 13:38:22 +0000 (13:38 +0000)]
Defined a foreground color for text. Solves bug #20737.
Tobias [Wed, 21 Apr 2010 10:53:26 +0000 (10:53 +0000)]
fixing r65339 which broke Upload when file dest was undefined
Raimond Spekking [Wed, 21 Apr 2010 06:45:48 +0000 (06:45 +0000)]
Self revert r65357. Stupid comitter :-(
Raimond Spekking [Wed, 21 Apr 2010 06:40:38 +0000 (06:40 +0000)]
Follow-up r65351: Add a missing comma in message
Raimond Spekking [Wed, 21 Apr 2010 06:37:18 +0000 (06:37 +0000)]
Follow-up r65339: Add new message key to maintenance file
Siebrand Mazeland [Tue, 20 Apr 2010 23:06:59 +0000 (23:06 +0000)]
(bug 22647) Add category details in search results. Contributed by Lejonel.
Siebrand Mazeland [Tue, 20 Apr 2010 22:49:50 +0000 (22:49 +0000)]
(bug 23075) correct MediaTransformError default width in gallery. Contributed by Derk-Jan Hartman.
Submitter's remarks:
This patch changes the minimum size of a MediaTransformError to 120px, which
makes sure it will at least fit galleries. Any smaller and likely it would
become unreadable, so keep the ugly in those cases.
The patch also changes the message from a table to a div, because there is no
real need to use a table here. I have added "display:inline-block" to the css
to make it behave almost exactly as an img or table element would (This might
be important for [[File:image.gif|180px]], where no other framing is provided.)
Tobias [Tue, 20 Apr 2010 20:30:11 +0000 (20:30 +0000)]
When visiting a 'red link' of a deleted file, a deletion and move log excerpt is provided on the Upload form.
Platonides [Tue, 20 Apr 2010 19:04:00 +0000 (19:04 +0000)]
Follow up r65286. If we are going to support <img we should support width and height
attributes, too. Since there's a potential for creating webbugs of 1x1px we might want
to enforce a minimum size for them. But that has always existed when the attacker provides
the image.
The sanitizer isn't treating numeric-like arguments in a special way. That is something
to fix.
Raimond Spekking [Tue, 20 Apr 2010 18:55:30 +0000 (18:55 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-04-20 18:15:00 UTC)
Raimond Spekking [Tue, 20 Apr 2010 08:14:47 +0000 (08:14 +0000)]
Follow-up r64078: Define $ntl at the beginning to avoid PHP Notice: Undefined variable: ntl in /www/w/includes/Skin.php on line 2238
Seen on translatewiki today
Raimond Spekking [Mon, 19 Apr 2010 20:28:28 +0000 (20:28 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2010-04-19 19:55:00 UTC)
Aryeh Gregor [Mon, 19 Apr 2010 18:44:11 +0000 (18:44 +0000)]
Create $wgAllowImageTag to whitelist <img>
I could have reused $wgAllowExternalImages, but that's . . . rather
ugly. It makes some external links mysteriously behave differently, and
of course doesn't allow setting attributes.
Roan Kattouw [Mon, 19 Apr 2010 14:08:38 +0000 (14:08 +0000)]
(bug 23240) Add ID to namespace selector form on Special:Watchlist