jenkins-bot [Fri, 12 Apr 2019 23:44:51 +0000 (23:44 +0000)]
Merge "Category: Remove "todo" comment about moving code from CategoryPage"
Eugene Gvozdetsky [Fri, 16 Nov 2018 09:13:32 +0000 (10:13 +0100)]
Category: Remove "todo" comment about moving code from CategoryPage
All stuff was already moved from CategoryPage.php to Category.php
Change-Id: I19820ec573c39d7368e3c6644e7c54ca9d8104c5
jenkins-bot [Fri, 12 Apr 2019 21:38:16 +0000 (21:38 +0000)]
Merge "Improve documentation of constants throughout the codebase"
jenkins-bot [Fri, 12 Apr 2019 21:23:57 +0000 (21:23 +0000)]
Merge "parser: Convert wikitext Preprocessor class to using WAN cache"
jenkins-bot [Fri, 12 Apr 2019 21:02:56 +0000 (21:02 +0000)]
Merge "HistoryPager: Unset 'date-range-to' parameter when paging"
Aaron Schulz [Thu, 28 Feb 2019 20:54:49 +0000 (12:54 -0800)]
parser: Convert wikitext Preprocessor class to using WAN cache
Change-Id: Ida96a976109f7ceee0003b9d1d487c8cf9b80114
jenkins-bot [Fri, 12 Apr 2019 20:36:15 +0000 (20:36 +0000)]
Merge "Get rid of unnecessary func_get_args() and friends"
jenkins-bot [Fri, 12 Apr 2019 20:34:45 +0000 (20:34 +0000)]
Merge "Set MW_INSTALL_PATH in Maintenance.php"
jenkins-bot [Fri, 12 Apr 2019 20:22:58 +0000 (20:22 +0000)]
Merge "HTMLFormFieldWithButton: Allow passing 'inputtype' and pass through 'buttonid'"
jenkins-bot [Fri, 12 Apr 2019 20:18:30 +0000 (20:18 +0000)]
Merge "dao: Correct return type doc for getLoadBalancer()"
Aryeh Gregor [Mon, 8 Oct 2018 14:10:45 +0000 (17:10 +0300)]
Get rid of unnecessary func_get_args() and friends
HHVM does not support variadic arguments with type hints. This is
mostly not a big problem, because we can just drop the type hint, but
for some reason PHPUnit adds a type hint of "array" when it creates
mocks, so a class with a variadic method can't be mocked (at least in
some cases). As such, I left alone all the classes that seem like
someone might like to mock them, like Title and User. If anyone wants
to mock them in the future, they'll have to switch back to
func_get_args(). Some of the changes are definitely safe, like
functions and test classes.
In most cases, func_get_args() (and/or func_get_arg(), func_num_args() )
were only present because the code was written before we required PHP
5.6, and writing them as variadic functions is strictly superior. In
some cases I left them alone, aside from HHVM compatibility:
* Forwarding all arguments to another function. It's useful to keep
func_get_args() here where we want to keep the list of expected
arguments and their meanings in the function signature line for
documentation purposes, but don't want to copy-paste a long line of
argument names.
* Handling deprecated calling conventions.
* One or two miscellaneous cases where we're basically using the
arguments individually but want to use them as an array as well for
some reason.
Change-Id: I066ec95a7beb7c0665146195a08e7cce1222c788
Reedy [Thu, 11 Apr 2019 23:26:51 +0000 (00:26 +0100)]
Add test to check action- messages exist
Bug: T220779
Change-Id: Ide681e1f03957a8024f538ea6cac4e4396fef23e
Ammar [Fri, 12 Apr 2019 16:22:55 +0000 (17:22 +0100)]
Add missing action- messages to MW Core
Bug: T220810
Change-Id: Ic43435bc42c23f055bde0c6cf7648d9f219cfb34
Fomafix [Sun, 24 Feb 2019 09:08:49 +0000 (10:08 +0100)]
resourceloader: Avoid global window.mwTestFooJsCounter in unit tests
This change avoids a failure when running Special:JavaScriptTest with
the option noglobals.
Change-Id: Id61fca5ccedbd793f7786ad95681eaebb9feafb6
jenkins-bot [Fri, 12 Apr 2019 15:17:23 +0000 (15:17 +0000)]
Merge "Fix order of @var parameter in PHP"
jenkins-bot [Fri, 12 Apr 2019 14:58:32 +0000 (14:58 +0000)]
Merge "Use https://php.net/ instead of https://secure.php.net/"
Aaron Schulz [Wed, 10 Apr 2019 01:46:47 +0000 (18:46 -0700)]
rdbms: drop inappropriate and poorly documented "DatabaseOraclePostInit" hook
Change-Id: I3152e80d99b040b7918927e6c2a215cab59a9b10
Translation updater bot [Fri, 12 Apr 2019 06:11:08 +0000 (08:11 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Id524db06f2e39860f8455a22ee5805cfe06e4f8f
Fomafix [Fri, 12 Apr 2019 04:41:14 +0000 (06:41 +0200)]
Use https://php.net/ instead of https://secure.php.net/
Change-Id: I0acca592c6909e91b28b904da49dcbd6a43cd2a5
Aaron Schulz [Fri, 12 Apr 2019 00:54:26 +0000 (17:54 -0700)]
search: make legalSearchChars() non-static
No outside callers from code in gerrit are using this statically
Change-Id: I9513a5384bca71f419a9af09908678bcc86c0263
Bartosz Dziewoński [Fri, 12 Apr 2019 00:20:28 +0000 (02:20 +0200)]
HistoryPager: Unset 'date-range-to' parameter when paging
Follow-up to
1b27cee8979b2fefa65dafee237485787693eb98. This fixes
paging on Special:History, and matches the existing behavior for the
previously supported 'year'/'month' parameters.
It is possible that this should be unset in IndexPager. However, in a
quick test, other pagers that have filtering by date seem to function
correctly already (tested Special:Contributions and Special:Log).
I'm making this change in HistoryPager to avoid accidentally breaking
anything, but perhaps this should be reevaluated.
Maybe the real bug is that 'date-range-to' is not ignored when
'offset' is specified?
Bug: T220781
Change-Id: I01c309178e6d5d9c919f410c64e2b833a5750141
jenkins-bot [Thu, 11 Apr 2019 23:01:28 +0000 (23:01 +0000)]
Merge "Fix docs for MWNamespace::clearCaches() removal"
jenkins-bot [Thu, 11 Apr 2019 22:58:20 +0000 (22:58 +0000)]
Merge "Follow-up
4ee606f: Add note to RELEASE-NOTES-1.34 now we know where it landed"
Aryeh Gregor [Thu, 11 Apr 2019 11:21:41 +0000 (14:21 +0300)]
Fix docs for MWNamespace::clearCaches() removal
Originally I had intended setMwGlobals() to magically reset the
namespace-related services if namespace-related settings were changed,
but Tim told me to remove it during review and I forgot to update the
release notes. Moving forward, everyone will need to reset services
after every config change to ensure correctness, and there's no point in
trying to reset specific services automatically as special cases.
I also moved the note to the 1.34 notes, since this missed the cutoff
and should not be backported.
Change-Id: Ib7cbdaef22a15ddfc7aaf99d0972b99d3cddc011
jenkins-bot [Thu, 11 Apr 2019 22:38:10 +0000 (22:38 +0000)]
Merge "rdbms: inject reserved word table name rewrite logic into DatabaseOracle"
jenkins-bot [Thu, 11 Apr 2019 22:34:14 +0000 (22:34 +0000)]
Merge "rdbms: optimize DBConnRef::getType() to avoid connections when possible"
jenkins-bot [Thu, 11 Apr 2019 22:31:25 +0000 (22:31 +0000)]
Merge "resourceloader: Move expandModuleNames() to ResourceLoader.php"
Aaron Schulz [Thu, 11 Apr 2019 04:54:50 +0000 (21:54 -0700)]
rdbms: inject reserved word table name rewrite logic into DatabaseOracle
This works similar to that of DatabasePostgres, which uses similar rules.
Fix bogus field access in duplicateTableStructure() as well.
Also, remove a pointless wfDebug() call in DatabaseOracle.
Change-Id: Ia06ff78011dfabc17c525d7a6d2ffad98fe297de
Derick Alangi [Thu, 11 Apr 2019 22:03:57 +0000 (23:03 +0100)]
dao: Correct return type doc for getLoadBalancer()
This method creates a load balancer object using services and calls
getMainLB() which returns an instance of ILoadBalancer and not an
instance of LoadBalancer, hence, getLoadBalancer() should return an
instance of ILoadBalancer instead.
Change-Id: I8859f293985d256d02ddc6f90e2aea813ebfc955
Aaron Schulz [Thu, 11 Apr 2019 04:40:16 +0000 (21:40 -0700)]
rdbms: optimize DBConnRef::getType() to avoid connections when possible
Change-Id: Ibe7f2ab173ba1457b6b11c4fe37e599962ae51b0
James D. Forrester [Thu, 11 Apr 2019 22:06:34 +0000 (15:06 -0700)]
Follow-up
4ee606f: Add note to RELEASE-NOTES-1.34 now we know where it landed
Change-Id: I12dbff9dc9d7572d5f7caa057775044dffc92842
jenkins-bot [Thu, 11 Apr 2019 21:46:45 +0000 (21:46 +0000)]
Merge "rdbms: mark DatabaseSqlite::checkForEnabledSearch() as public"
jenkins-bot [Thu, 11 Apr 2019 21:45:02 +0000 (21:45 +0000)]
Merge "rdbms: add limitResults() to IDatabase"
jenkins-bot [Thu, 11 Apr 2019 21:42:43 +0000 (21:42 +0000)]
Merge "OutputPage: Remove unused variable left out after a refactor"
jenkins-bot [Thu, 11 Apr 2019 21:42:35 +0000 (21:42 +0000)]
Merge "HistoryAction: Amend `margin` in collapsed form state"
jenkins-bot [Thu, 11 Apr 2019 21:33:46 +0000 (21:33 +0000)]
Merge "RCFilters: hygiene"
jenkins-bot [Thu, 11 Apr 2019 21:30:48 +0000 (21:30 +0000)]
Merge "TemplateParser: Use operator short cut where necessary"
Timo Tijhof [Thu, 11 Apr 2019 20:28:53 +0000 (21:28 +0100)]
resourceloader: Move expandModuleNames() to ResourceLoader.php
This has always been an odd case, as indicicated by the cross-class
comment references, and the fact that its test cases are already
in ResourceLoaderTest.php, for convenience, as that's also where
the creation of 'module name strings' is done and tested.
Actually move it there instead of pretending it is there.
Change-Id: Ied9569436cc78704a5c1b75eeebb73f8631350f6
Derick Alangi [Thu, 11 Apr 2019 20:48:07 +0000 (21:48 +0100)]
TemplateParser: Use operator short cut where necessary
Change-Id: I7f9dbe54cec876863920155ccd7cd735a3101481
Derick Alangi [Thu, 11 Apr 2019 20:20:35 +0000 (21:20 +0100)]
OutputPage: Remove unused variable left out after a refactor
This variable was added in I0e18dc7fdbf133f3e400 (2017) and later
removed in I11b390f2e4f5e7db8b4 (2018) but the $sk was left which
now makes it used. Hence, cleaning this up.
Change-Id: I277b9de23409da3429a3b74d42e8ab9e9d5f5399
Volker E [Thu, 11 Apr 2019 18:51:09 +0000 (11:51 -0700)]
HistoryAction: Amend `margin` in collapsed form state
Also update comment at top.
Bug: T220555
Change-Id: I20b0f42d36a6909625bc9f481d0e016ae8cd1d96
Fomafix [Sun, 10 Feb 2019 11:29:11 +0000 (12:29 +0100)]
Remove deprecated Language::setCode
Language::setCode was hard-deprecated in
76f5584377 included in
MediaWiki release 1.33.
Change-Id: I32f6d1c9b7ad781182945222d40fd209bce23229
Max Semenik [Sun, 17 Mar 2019 07:34:10 +0000 (00:34 -0700)]
Remove CryptRand and related stuff
Deprecated in 1.31 and not used anywhere.
Change-Id: Idc2e9cec907e39cacc391fdd7e2718bd880081ae
jenkins-bot [Thu, 11 Apr 2019 16:53:19 +0000 (16:53 +0000)]
Merge "Selenium: fix 'Page should be editable' test"
Ed Sanders [Thu, 11 Apr 2019 16:39:16 +0000 (17:39 +0100)]
HTMLFormFieldWithButton: Allow passing 'inputtype' and pass through 'buttonid'
Change-Id: Ib1c94ac66caf6243631aa9d2b9f7fd2e6ca7a367
Cormac Parle [Thu, 11 Apr 2019 12:21:42 +0000 (13:21 +0100)]
Selenium: fix 'Page should be editable' test
The test is broken only when and targeting beta cluster, because an
extension adds text to page. Instead of checking the entire body of
the page, test just checks if expected string is there.
Bug: T217544
Change-Id: Ibd67790c1df2cd8556b9c71d872d52cfc18f5ebd
jenkins-bot [Thu, 11 Apr 2019 16:19:15 +0000 (16:19 +0000)]
Merge "Remove Preferences class"
jenkins-bot [Thu, 11 Apr 2019 16:18:56 +0000 (16:18 +0000)]
Merge "Add use Wikimedia\StaticArrayWriter statements to maintenance scripts"
Reedy [Thu, 11 Apr 2019 15:31:11 +0000 (16:31 +0100)]
Add use Wikimedia\StaticArrayWriter statements to maintenance scripts
Follows-Up: I022c074e8a708fb5219bc4ff4b53e7e31f60dc4b
Change-Id: Ieea214b31a6ba9cc8eb2b6bae50529d70448a872
jenkins-bot [Thu, 11 Apr 2019 13:30:23 +0000 (13:30 +0000)]
Merge "Update Parser to use NamespaceInfo"
Aryeh Gregor [Sun, 5 Aug 2018 12:50:01 +0000 (15:50 +0300)]
Update Parser to use NamespaceInfo
Change-Id: I668a51487786e4ab05a153ca3995388e79c13b42
jenkins-bot [Thu, 11 Apr 2019 11:27:17 +0000 (11:27 +0000)]
Merge "Update PermissionManager to use NamespaceInfo"
jenkins-bot [Thu, 11 Apr 2019 09:40:19 +0000 (09:40 +0000)]
Merge "Enable/disable Special:Block widgets according to block parameters"
jenkins-bot [Thu, 11 Apr 2019 09:29:16 +0000 (09:29 +0000)]
Merge "Simplify checking for widgets on special block page"
Aryeh Gregor [Tue, 9 Apr 2019 07:52:38 +0000 (10:52 +0300)]
Set MW_INSTALL_PATH in Maintenance.php
Otherwise, if running update.php, there are require_once failures from
extensions (at least Echo and Flow) if they aren't inside extensions/ --
e.g., if they're just symlinked from there.
Change-Id: Iaf4231abae1621627f01171f955b5bb7a0fa77d8
jenkins-bot [Thu, 11 Apr 2019 06:45:16 +0000 (06:45 +0000)]
Merge "Rehabilitate DateFormatter"
Aaron Schulz [Tue, 9 Apr 2019 23:31:34 +0000 (16:31 -0700)]
rdbms: inject more dependencies into DatabaseOracle and remove $wgContLang use
Instead of guessing/assuming input encodings for non-UTF8 fields,
just require that they be valid UTF-8 to begin with.
Also replace MWException use and break some long lines.
Change-Id: Ibb6f841d5d143776eca2a9d0d12cbb74f1e0d23e
Aaron Schulz [Thu, 11 Apr 2019 04:39:17 +0000 (21:39 -0700)]
rdbms: mark DatabaseSqlite::checkForEnabledSearch() as public
Change-Id: Ic059cc986b813bc4e667077a4a5de41b9714f123
Aaron Schulz [Thu, 11 Apr 2019 04:37:06 +0000 (21:37 -0700)]
rdbms: add limitResults() to IDatabase
Change-Id: Iec39db0b34a48cce0367fb91acb234a81715d145
jenkins-bot [Thu, 11 Apr 2019 01:40:16 +0000 (01:40 +0000)]
Merge "rdbms: reduce code duplication and make LBFactoryMulti sanity checks work"
Max Semenik [Sun, 17 Mar 2019 07:30:01 +0000 (00:30 -0700)]
Remove Preferences class
Deprecated in 1.31, the only extension using it is broken on modern MW
anyway.
Change-Id: Ifa0ea5ad5727254e60511fbc1889923e4bcc189a
jenkins-bot [Thu, 11 Apr 2019 00:29:00 +0000 (00:29 +0000)]
Merge "Prepare for REL1_33 cut, labelling master as 1.34-alpha"
James D. Forrester [Tue, 9 Apr 2019 17:01:18 +0000 (10:01 -0700)]
Prepare for REL1_33 cut, labelling master as 1.34-alpha
Change-Id: I841ee1c898a6db2e4a10b5e8c68647d45f046dc7
Stephane Bisson [Wed, 10 Apr 2019 21:28:33 +0000 (17:28 -0400)]
RCFilters: hygiene
Remove unused code, unneeded initialization
and fix documentation.
Change-Id: I82d7239b9003a82bc30484b01cf29e01c988b0d6
Bartosz Dziewoński [Wed, 10 Apr 2019 22:50:11 +0000 (00:50 +0200)]
HTMLDateTimeField: Load styles for PHP widget
Bug: T220601
Change-Id: Id507459fea434bd6eb1af2bb6d1163c138a3a9d1
Volker E [Wed, 10 Apr 2019 19:17:08 +0000 (12:17 -0700)]
HistoryAction: Clarify form legend for edit history page
Bug: T107069
Change-Id: Ie20408da1ebed8de442338e67703b898a38e0624
jenkins-bot [Wed, 10 Apr 2019 17:31:42 +0000 (17:31 +0000)]
Merge "tests: Mock the time in NameTableStoreTest to avoid failures if they run slowly"
Aaron Schulz [Tue, 9 Apr 2019 21:45:36 +0000 (14:45 -0700)]
rdbms: reduce code duplication and make LBFactoryMulti sanity checks work
Change-Id: I2308719b3a8fe4745c86dc7e5af0950588732ebe
Aaron Schulz [Wed, 10 Apr 2019 05:06:04 +0000 (22:06 -0700)]
tests: Mock the time in NameTableStoreTest to avoid failures if they run slowly
Bug: T220626
Change-Id: I4f8e0321f540b9ff48f3297a1ca0c6196c99ecf8
jenkins-bot [Wed, 10 Apr 2019 17:07:37 +0000 (17:07 +0000)]
Merge "Drop clearCache() from (Configured)ReadOnlyMode"
Aryeh Gregor [Wed, 10 Apr 2019 13:20:28 +0000 (16:20 +0300)]
Drop clearCache() from (Configured)ReadOnlyMode
These are services, so tests should just override services to reset
them.
Change-Id: Icb1a041f8fac1ea0b7421e69b7b31b24171d868b
jenkins-bot [Wed, 10 Apr 2019 16:38:55 +0000 (16:38 +0000)]
Merge "Bump Mustache from 1.0.0 to 3.0.1"
jenkins-bot [Wed, 10 Apr 2019 16:07:09 +0000 (16:07 +0000)]
Merge "jobqueue: add GenericParameterJob and RunnableJob interface"
jenkins-bot [Wed, 10 Apr 2019 14:33:30 +0000 (14:33 +0000)]
Merge "Add legoktm, James Forrester, bawolff, and addshore to main contributors"
Aryeh Gregor [Tue, 9 Apr 2019 16:34:23 +0000 (19:34 +0300)]
Don't pass Config object to SpecialPageFactory
That made SpecialPageFactory potentially dependent on every
configuration option, when it only uses a few.
In the convention I introduce here, the service class does not in
principle care that its options come from configuration variables. It
just declares a list of names of options it can receive, which happen to
match the names of configuration options, and ServiceWiring just copies
them over. In the event a service wants to receive other options that
are not configuration variables, ServiceWiring can set them
appropriately from other sources. In practice, most options will
probably come from configuration variables, so using the same names and
passing them directly makes the code shorter and easier to understand.
Change-Id: I3e57513826dc5130f468486470f29eeee659d697
Aryeh Gregor [Tue, 9 Apr 2019 09:28:38 +0000 (12:28 +0300)]
Update PermissionManager to use NamespaceInfo
Change-Id: I60825beb74d1d0a4e2a9bae0202372cc26752d0c
jenkins-bot [Wed, 10 Apr 2019 11:37:06 +0000 (11:37 +0000)]
Merge "Sort MediaWikiServices and ServiceWiring alphabetically"
Tim Starling [Wed, 10 Apr 2019 05:33:57 +0000 (15:33 +1000)]
Rehabilitate DateFormatter
This code is surprisingly little changed since I added the class in
November 2003, and needs some modernisation.
* Remove the "linked" option, unused since 1.21. Similarly, make the
"match-whole" option implied. This allows the regexes to be
simplified. Nothing will be broken, according to CodeSearch.
* Instead of ucfirst(), use the canonical month name from the language.
This will work with e.g. French which does not capitalise month names.
* Stop caching DateFormatter instances in APC. Caching was added
in 2005 when initialisation was being done on every request, but now
it is only needed when parsing a page with {{#formatdate}}, which is
rarely, and the constructor overhead is only 200µs after Language
object data initialisation. Instead, use an in-process cache via a
factory service.
* Add docs and extra tests.
* Remove todo note obsolete since 38 minutes after the original commit.
* Rename many variables.
* Use double-slash comments
* Don't store the Language object, just get arrays.
* Use mb_strtolower() instead of Language::lc() -- any customisation of
Language::lc() would break PCRE case-insensitive matching.
* Use named subpatterns instead of "keys"
* Remove the ISO1/ISO2 distinction, the only difference was linking.
* Use closure variables instead of temporary object members
Change-Id: I25fb1203dba2930724d7bc28ad0d51f59f88e1ea
Tim Starling [Wed, 10 Apr 2019 10:36:02 +0000 (20:36 +1000)]
Sort MediaWikiServices and ServiceWiring alphabetically
Don't sort them asciibetically, which is a weird sort order people only
use by accident.
Change-Id: I69be64dab104130841855f2ce58bf94667c0c300
Translation updater bot [Wed, 10 Apr 2019 06:28:29 +0000 (08:28 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I10aee1d68b54d24379123311ee43ad664ad3b6a2
jenkins-bot [Wed, 10 Apr 2019 05:46:24 +0000 (05:46 +0000)]
Merge "NamespaceInfo service to replace MWNamespace"
jenkins-bot [Wed, 10 Apr 2019 03:26:33 +0000 (03:26 +0000)]
Merge "Fix notices emitted from DateFormatter"
Tim Starling [Wed, 10 Apr 2019 02:50:17 +0000 (12:50 +1000)]
Fix notices emitted from DateFormatter
Some languages have date abbreviations that contain ".", which allows
the non-ISO regexes to match an input string containing an invalid month
name. Use preg_quote() to avoid this.
Also fix the error handling case of makeIsoMonth(). If the input date is
invalid, don't try to wrap it in a date span, since that's semantically
incorrect and may also access unset members of $bits, causing a notice.
Bug: T220563
Change-Id: Ib2b3fb315dc93b60de595d3c445637f6bcc78a1a
Aryeh Gregor [Sun, 5 Aug 2018 08:36:32 +0000 (11:36 +0300)]
NamespaceInfo service to replace MWNamespace
MWNamespace::clearCaches() has been removed entirely, along with the
$rebuild parameter to MWNamespace::getCanonicalNamespaces(). The rest of
MWNamespace is deprecated.
Diff best viewed with -C1 so git notices that NamespaceInfo is a copy of
MWNamespace.
Depends-On: Icb7a4a2a5d19fb1f2453b4b57a5271196b0e316d
Depends-On: Ib3c914fc99394e4876ac9fe27317a1eafa2ff69e
Change-Id: I1a03d4e146f5414ae73c7d1a5807c873323e8abc
jenkins-bot [Wed, 10 Apr 2019 02:01:26 +0000 (02:01 +0000)]
Merge "Remove redundant closure for all packageFiles with own directory"
jenkins-bot [Tue, 9 Apr 2019 23:10:09 +0000 (23:10 +0000)]
Merge "History form can be collapsed"
jdlrobson [Thu, 28 Mar 2019 00:06:35 +0000 (17:06 -0700)]
History form can be collapsed
A generic way for collapsing forms is added and used
on history.
Bug: T220555
Change-Id: I3073359210bcc25625c9ec07629100130effaed1
Amir Sarabadani [Tue, 9 Apr 2019 22:41:16 +0000 (00:41 +0200)]
Add legoktm, James Forrester, bawolff, and addshore to main contributors
Each one of these people has more than 500 commits (Kunal with more than 1000)
Change-Id: I8174f7e8af378dad7c2773b90e2b657ff948162d
Volker E [Tue, 9 Apr 2019 21:55:02 +0000 (14:55 -0700)]
DateInputWidget: Use `max-width` instead of `width`
Using `max-width` instead of `width` to address overflowing form
container on very small screens.
Change-Id: Ibe88fa68543343fc2a0fac3eb9843334c6e80433
jenkins-bot [Tue, 9 Apr 2019 20:40:44 +0000 (20:40 +0000)]
Merge "Fix return type in fallback8bitEncoding() documentation block"
jenkins-bot [Tue, 9 Apr 2019 20:26:30 +0000 (20:26 +0000)]
Merge "Default $wgActorTableSchemaMigrationStage to READ_NEW"
Aaron Schulz [Tue, 9 Apr 2019 20:22:52 +0000 (13:22 -0700)]
Fix return type in fallback8bitEncoding() documentation block
Change-Id: Ia50ed305d8f58bdea5d36362e03ad5a1ebbea847
Krinkle [Tue, 9 Apr 2019 19:40:00 +0000 (19:40 +0000)]
Merge "resourceloader: Simplify isCompatible() parameter in startup.js"
jenkins-bot [Tue, 9 Apr 2019 19:35:14 +0000 (19:35 +0000)]
Merge "resourceloader: Remove redundant filter() in mw.load.load()"
Timo Tijhof [Tue, 9 Apr 2019 03:14:48 +0000 (04:14 +0100)]
resourceloader: Simplify isCompatible() parameter in startup.js
This is a private function (now marked as such) only ever called
once in prod code (a few lines further down). It is exposed
to testing as well, which is why it has a parameter.
Call it with a parameter within startup.js as well, so that we can
remove the default handling and use the function the same way in
prod as the way we use it in tests.
Change-Id: Ie9db60e417cca29f86cea20359e880cb1fa20197
Timo Tijhof [Tue, 9 Apr 2019 03:06:38 +0000 (04:06 +0100)]
resourceloader: Remove redundant filter() in mw.load.load()
This was added for T36853, but never worked and wasn't needed
because other parts of the commit for that task did the work
already (I guess I was trying both ways and ended up submitting
both).
* The inline comment claims to remove unknown modules,
but doesn't actually. Unknown modules would yield state `null`,
which is not filtered out. They are actually filtered out
by resolveStubbornly() and sortDependencies().
* The inline comment claims to filter out modules we tried
previously and were already known to fail.
This would work, if there were modules in such state, but
that never happens at this stage because load() is the first
thing on the page requesting any modules. Nothing notable
happened before that. If this were to change in the future,
or in case of user scripts calling mw.loader.load() directly
with invalid module names, we're still covered by enqueue()
and again by mw.loader.work() - both of which make sure we
don't re-request or retry modules, by filtering down to
only modules in the 'registered' state.
Change-Id: I3b9f1a13379ad41aeabad8111647c0f6eddccdfc
jenkins-bot [Tue, 9 Apr 2019 18:17:31 +0000 (18:17 +0000)]
Merge "Switch more DatabaseUpdater type hints to using IMaintainableDatabase"
Brad Jorsch [Wed, 3 Apr 2019 17:11:46 +0000 (13:11 -0400)]
Default $wgActorTableSchemaMigrationStage to READ_NEW
Probably good to start testing this in CI sometime soon.
The unit tests being changed here are:
* Hacky importing of a revision in MessageCacheTest, changed to use an
interwiki username.
* WikiPageDbTestBase will get null rather than 0 for ar_user.
* DumpTestCase was using a custom IP $wgUser when creating its test
revisions, which was winding up referring to an actor_id that had been
deleted from the database. Fixed by having it use a registered user
instead.
Also this has MediaWikiTestCase reset the $wgUser User object when the
actor table is truncated, as various tests were otherwise failing because
it was caching a later-deleted actor ID for User:127.0.0.1.
Bug: T188327
Change-Id: Ic483d0fda931810ac639b9de1cc5e5a4ef8161cc
Depends-On: I1bd0288cc132627d75b4001219522ec5e952eda7
Gilles Dubuc [Tue, 9 Apr 2019 16:57:38 +0000 (18:57 +0200)]
Remove unnecessary slash in scalerThumbUrl
The thumb proxy URL already contains a trailing slash
Bug: T220265
Change-Id: I9176ac893250f857c04df5a6878278784cf785f6
jenkins-bot [Tue, 9 Apr 2019 16:17:49 +0000 (16:17 +0000)]
Merge "Add support for X-Swift-Secret to upload stash"