jenkins-bot [Tue, 4 Apr 2017 19:18:38 +0000 (19:18 +0000)]
Merge "Update oyejorge/less.php v1.7.0.13 to v1.7.0.14"
jenkins-bot [Tue, 4 Apr 2017 19:09:45 +0000 (19:09 +0000)]
Merge "Update cssjanus/cssjanus from 1.1.3 to 1.2.0"
jenkins-bot [Tue, 4 Apr 2017 19:09:39 +0000 (19:09 +0000)]
Merge "Update composer-merge-plugin from 1.3.1 to 1.4.0"
jenkins-bot [Tue, 4 Apr 2017 19:09:34 +0000 (19:09 +0000)]
Merge "Update monolog from 1.18.2 to 1.22.1"
jenkins-bot [Tue, 4 Apr 2017 02:23:39 +0000 (02:23 +0000)]
Merge "Split out some internal methods in QuorumLockManager for readability"
Aaron Schulz [Wed, 29 Mar 2017 20:45:31 +0000 (13:45 -0700)]
Split out some internal methods in QuorumLockManager for readability
Change-Id: I74930b930b18110c9f20b945c87790f898258ad5
Reedy [Tue, 4 Apr 2017 01:03:50 +0000 (02:03 +0100)]
Update oyejorge/less.php v1.7.0.13 to v1.7.0.14
https://github.com/oyejorge/less.php/releases/tag/v1.7.0.14
https://github.com/oyejorge/less.php/compare/v1.7.0.13...v1.7.0.14
Change-Id: Ibf7cc4704fae5890093e6855403d93b0a2b1b97f
Depends-On: Ie641cf2954c39fd84ab26a92ad3028a49c15926d
Reedy [Tue, 4 Apr 2017 01:03:12 +0000 (02:03 +0100)]
Update cssjanus/cssjanus from 1.1.3 to 1.2.0
https://github.com/cssjanus/php-cssjanus/releases/tag/v1.2.0
https://github.com/cssjanus/php-cssjanus/compare/v1.1.3...v1.2.0
Change-Id: Iad2ea202b7724edc8360ce74943e2026f57e1f06
Depends-On: Iec366b794e38710102deaba771dba5cf7b412d5a
Reedy [Tue, 4 Apr 2017 01:02:21 +0000 (02:02 +0100)]
Update composer-merge-plugin from 1.3.1 to 1.4.0
https://github.com/wikimedia/composer-merge-plugin/releases/tag/v1.4.0
https://github.com/wikimedia/composer-merge-plugin/compare/v1.3.1...v1.4.0
Change-Id: I3e01a632b764f7903291d0141243e6210da9bebe
Depends-On: I0c96d9a630ab25ff4269af25a660c5bd7837a9dc
Reedy [Tue, 21 Feb 2017 21:44:18 +0000 (21:44 +0000)]
Update monolog from 1.18.2 to 1.22.1
https://github.com/Seldaek/monolog/releases/tag/1.19.0
https://github.com/Seldaek/monolog/releases/tag/1.20.0
https://github.com/Seldaek/monolog/releases/tag/1.21.0
https://github.com/Seldaek/monolog/releases/tag/1.22.0
https://github.com/Seldaek/monolog/releases/tag/1.22.1
https://github.com/Seldaek/monolog/compare/1.18.2...1.22.1
Bug: T158707
Change-Id: Icfb87911486aee8b712ce643f0041f91eb6cc078
Depends-On: Id5a96aaba77e52290a5afaff2c01b29c285e67af
Translation updater bot [Mon, 3 Apr 2017 19:59:59 +0000 (21:59 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I60c8477ebebcc647c3d9b3e0ac0902401fe10f28
jenkins-bot [Mon, 3 Apr 2017 18:47:56 +0000 (18:47 +0000)]
Merge "RC Filters: Hooks for highlight guided tour"
jenkins-bot [Mon, 3 Apr 2017 18:25:37 +0000 (18:25 +0000)]
Merge "Valid tags on a gallery should correspond to unordered list"
jenkins-bot [Mon, 3 Apr 2017 17:00:29 +0000 (17:00 +0000)]
Merge "Document return string as JavaScript code for getScript"
jenkins-bot [Mon, 3 Apr 2017 16:43:52 +0000 (16:43 +0000)]
Merge "Fix two bugs in installer session error display"
Brad Jorsch [Mon, 3 Apr 2017 13:41:21 +0000 (09:41 -0400)]
Fix ApiMainTest::testApiErrorFormatterCreation
API tests are all subclasses of MediaWikiLangTestCase, which overrides
the content language when the tests are actually running. So we need to
always use 'en' to match that.
Bug: T162007
Change-Id: Ie001576fb62ae88c9141e471fd8fcbc49592be32
Fomafix [Mon, 3 Apr 2017 08:24:41 +0000 (10:24 +0200)]
Document return string as JavaScript code for getScript
Change-Id: I01055c2b6a11dbe6284d1aff2352ba428ed9bee2
jenkins-bot [Mon, 3 Apr 2017 08:19:43 +0000 (08:19 +0000)]
Merge "Move atj in RELEASE-NOTES-1.29 to language section"
jenkins-bot [Mon, 3 Apr 2017 07:34:33 +0000 (07:34 +0000)]
Merge "SpecialRecentchanges.php: Use ResourceLoader::makeMessageSetScript"
Tim Starling [Mon, 3 Apr 2017 03:55:48 +0000 (13:55 +1000)]
Fix two bugs in installer session error display
If Installer::startSession() returns false, then showError() is called
before setParserLanguage(), which causes DB access via
Title::getContentModel(). The code which was meant to handle DB access
from the parser did not do so, since the exception class which is thrown
on attempted DB access has changed.
Change-Id: I1478ec06a441851c5336bdde15734642615d45e9
jenkins-bot [Mon, 3 Apr 2017 02:35:34 +0000 (02:35 +0000)]
Merge "Update comment for indexName(), explaining why it exists"
jenkins-bot [Mon, 3 Apr 2017 02:30:19 +0000 (02:30 +0000)]
Merge "Make the indexName functions more obviously laid out"
Tim Starling [Thu, 30 Mar 2017 04:17:47 +0000 (15:17 +1100)]
Update comment for indexName(), explaining why it exists
Bug: T154872
Change-Id: Idf64b85dc56dcc28f3a25b2b8ded44c5490cf56c
Reedy [Sun, 2 Apr 2017 23:47:44 +0000 (00:47 +0100)]
Move atj in RELEASE-NOTES-1.29 to language section
Change-Id: I5ca54f5c749d2c65435647f1e8737fa139e641a9
Translation updater bot [Sun, 2 Apr 2017 19:53:56 +0000 (21:53 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I4e9b249b425cdd6cd5ccda7d63a4d61748c387c5
Fomafix [Sun, 2 Apr 2017 09:04:34 +0000 (11:04 +0200)]
SpecialRecentchanges.php: Use ResourceLoader::makeMessageSetScript
Change-Id: Ie0c8a8e5290e966935a9765cd8cc6c781b19f759
Subramanya Sastry [Sun, 2 Apr 2017 04:00:20 +0000 (23:00 -0500)]
Tweak Parsoid CSS for images with borders
* This fixes rendering diffs seen in visual diff testing.
Change-Id: I15f469b580d5d05d764a22d88b06237ce3571b62
Brian Wolff [Sat, 1 Apr 2017 21:45:13 +0000 (21:45 +0000)]
Release notes for CACHE_ANYTHING being CACHE_NONE (
c5a0fa5bed4c)
Change-Id: I88d967b73e623d25249a14c286eee7a9a98bd3f3
Brian Wolff [Sat, 1 Apr 2017 20:39:06 +0000 (20:39 +0000)]
Release notes for no <html> in system messages (
1c7889446)
Change-Id: I501d00974c6a5c00b36d070ca3d0495971529ed7
Translation updater bot [Sat, 1 Apr 2017 19:54:23 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ib10af896efdc2a9e354ca77776b17bb546357518
jenkins-bot [Sat, 1 Apr 2017 15:37:50 +0000 (15:37 +0000)]
Merge "mw.widgets.TitleOptionWidget: Apply styles for redirects/disambiguation links"
Arlo Breault [Sat, 1 Apr 2017 13:59:21 +0000 (09:59 -0400)]
Valid tags on a gallery should correspond to unordered list
* This was introduced in
4d3446a8e3e when galleries were tables.
However, in
05579cf0e60, it switched to ul's, but missed updating the
sanitization.
* As an example, the test shows that summary is currently wrongly
permitted.
Change-Id: I8c52477dc65499d0c8a1ee5cc661a5f9ae78cc07
Fomafix [Sat, 1 Apr 2017 07:28:28 +0000 (09:28 +0200)]
mediawiki.libs.jpegmeta.js: Map mediaWiki to mw in closure
Change-Id: I938b4a36058a9549ceedf5785eb1494247227a70
jenkins-bot [Sat, 1 Apr 2017 02:59:01 +0000 (02:59 +0000)]
Merge "ObjectFactory: Complete code coverage for ObjectFactoryTest"
jenkins-bot [Sat, 1 Apr 2017 02:57:18 +0000 (02:57 +0000)]
Merge "objectcache: Complete code coverage for HashBagOStuff"
jenkins-bot [Sat, 1 Apr 2017 02:56:46 +0000 (02:56 +0000)]
Merge "resourceloader: Complete code coverage for MessageBlobStore"
jenkins-bot [Sat, 1 Apr 2017 02:51:00 +0000 (02:51 +0000)]
Merge "phpunit: Remove unused assertNotTag() and assertTag() overrides"
jenkins-bot [Sat, 1 Apr 2017 02:48:40 +0000 (02:48 +0000)]
Merge "changes: Remove assertTag from RCCacheEntryFactoryTest"
jenkins-bot [Sat, 1 Apr 2017 02:46:50 +0000 (02:46 +0000)]
Merge "resourceloader: Improve code coverage for WikiModuleTest"
jenkins-bot [Sat, 1 Apr 2017 02:43:37 +0000 (02:43 +0000)]
Merge "FauxRequest: Complete code coverage for FauxRequestTest"
Timo Tijhof [Sat, 1 Apr 2017 01:35:09 +0000 (18:35 -0700)]
resourceloader: Improve code coverage for WikiModuleTest
preloadTitleInfo:
* Add missing case for empty $moduleNames.
* Add missing case for invalid page names.
getContent:
* Add missing case for bad title
* Add missing case for dead redirect.
* Add missing case for no content found.
Change-Id: I44dde13cb0db19d91c4ff15a5abefd17353cad90
Timo Tijhof [Sat, 1 Apr 2017 01:22:58 +0000 (18:22 -0700)]
FauxRequest: Complete code coverage for FauxRequestTest
Follows-up
d18d030d57b88.
* Add missing case of session being a Session object.
Change-Id: I7da0c6d4a6483d53bcfd56751cd1cb669bd5023e
Timo Tijhof [Sat, 1 Apr 2017 01:13:09 +0000 (18:13 -0700)]
Html: Add a few @covers for HtmlTest
Change-Id: I0804e87ebc732d7adf082915af6d137f82f310b6
Timo Tijhof [Sat, 1 Apr 2017 01:07:59 +0000 (18:07 -0700)]
ObjectFactory: Complete code coverage for ObjectFactoryTest
Cover missing case of expandClosures() where the array contains
both a closure and a non-closure.
Change-Id: I30ea8cf3fb909a499a95bf9bd24792f4dd6b5c64
Timo Tijhof [Sat, 1 Apr 2017 01:03:17 +0000 (18:03 -0700)]
objectcache: Complete code coverage for HashBagOStuff
Change-Id: I06cb9778df8239706bf82c0c39cccb419eade4b2
Timo Tijhof [Sat, 1 Apr 2017 00:58:43 +0000 (17:58 -0700)]
resourceloader: Complete code coverage for MessageBlobStore
Change-Id: I6269843ed51c67bf2d300eb58a613122ffdae740
jenkins-bot [Sat, 1 Apr 2017 00:33:56 +0000 (00:33 +0000)]
Merge "objectcache: Never use CACHE_NONE for CACHE_ANYTHING"
jenkins-bot [Sat, 1 Apr 2017 00:31:46 +0000 (00:31 +0000)]
Merge "ResourceLoaderModuleTest: Exchange expected and actual parameter"
Timo Tijhof [Fri, 31 Mar 2017 23:32:24 +0000 (16:32 -0700)]
phpunit: Remove unused assertNotTag() and assertTag() overrides
Deprecated since PHPUnit 4.2, we use PHPUnit 4.8 and would like
to be compatible with PHPUnit 5 which no longer has this method.
The current hack was only enough to avoid the deprecation warning,
the underlying logic in Xml::findNodes() was also removed in PHPUnit 5.
Follows-up
23ec64745c,
dba0522f70, T71505.
* assertNotTag() is not used anywhere in Wikimedia Git.
* assertTag() was used in 1 test in core, fixed in the parent commit.
Match in mediawiki/skins/chameleon is unrelated.
Change-Id: I56b8f1f88124d69190938fc522ea75419e96c49c
Timo Tijhof [Fri, 31 Mar 2017 23:57:05 +0000 (16:57 -0700)]
changes: Remove assertTag from RCCacheEntryFactoryTest
Use PHPUnit's Xml::load() to validate that all tags and attributes
are balanced.
Use simple assertEquals or assertRegexp for the specific parts.
Change-Id: I25796954a3bb9903e88256b8345ef751c767d7d5
jenkins-bot [Fri, 31 Mar 2017 22:01:28 +0000 (22:01 +0000)]
Merge "API: Allow returning parse warnings for action=parse"
Bartosz Dziewoński [Fri, 31 Mar 2017 20:33:34 +0000 (22:33 +0200)]
mw.widgets.TitleOptionWidget: Apply styles for redirects/disambiguation links
Bug: T63072
Change-Id: I3e0b67b021c6ad42f131a5c9d3d0d5053d4316a0
Translation updater bot [Fri, 31 Mar 2017 20:34:04 +0000 (22:34 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Idfecf37225dbcb6d02fcb7988263437dbb01af16
Fomafix [Fri, 31 Mar 2017 13:24:14 +0000 (15:24 +0200)]
ResourceLoaderModuleTest: Exchange expected and actual parameter
For assertEquals of PHPUnit the first parameter is $expected and the second
parameter is $actual.
https://phpunit.de/manual/current/en/appendixes.assertions.html#appendixes.assertions.assertEquals
Change-Id: Iad4b37ee74a03aa00f2dc14d3c474796b3191b51
Baha [Fri, 31 Mar 2017 18:59:35 +0000 (11:59 -0700)]
API: Allow returning parse warnings for action=parse
Passing in the 'parsewarnings' property will return warnings related
to parsing content.
Bug: T92634
Change-Id: I7e54765ee9a24ffb78e7763f73a520151023baf6
jenkins-bot [Fri, 31 Mar 2017 18:24:57 +0000 (18:24 +0000)]
Merge "RCFilters: Remove isAllowedCallable and isAllowed"
Matthew Flaschen [Fri, 31 Mar 2017 05:07:31 +0000 (01:07 -0400)]
RCFilters: Remove isAllowedCallable and isAllowed
This is pretty fragile; it's easy to accidentally miss one of the
checks (as has already happened in e.g. parseParameters).
Although I don't yet know of any bugs as a result of this, it's
cleaner to do it at registration time.
There are no extensions using this feature.
Change-Id: I8547ea6432cae73e1bc272dbe959f2415b8a6d21
jenkins-bot [Fri, 31 Mar 2017 05:10:22 +0000 (05:10 +0000)]
Merge "SECURITY: Disable <html> tag on system messages despite $wgRawHtml = true;"
jdlrobson [Thu, 24 Dec 2015 00:10:46 +0000 (16:10 -0800)]
mediawiki.util: Add module export to support require()
This allows mediawiki.util to be used with require() and
to bring attention to an alternative code pattern
that other developers may wish to adopt.
Bug: T140384
Change-Id: I8a4323bd56476caccb559b15ca543d64c5281f7c
Volker E [Thu, 30 Mar 2017 21:40:55 +0000 (14:40 -0700)]
Update OOjs UI to v0.20.2
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.20.2
Change-Id: Ib79bda91982de97425b6a025b18299ec8693255d
jenkins-bot [Thu, 30 Mar 2017 21:22:09 +0000 (21:22 +0000)]
Merge "Use consistent spaces at start and end of comments"
jenkins-bot [Thu, 30 Mar 2017 20:36:38 +0000 (20:36 +0000)]
Merge "Add closure around moment-locale-overrides.js"
Translation updater bot [Thu, 30 Mar 2017 20:16:21 +0000 (22:16 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ia2c8ceda86ed0cfcc66d5be2c9b7653931379245
Fomafix [Thu, 30 Mar 2017 19:53:50 +0000 (21:53 +0200)]
Use consistent spaces at start and end of comments
Change-Id: Idbb09b69aa1ef4e46433319aaea62f34f0dbc038
Fomafix [Thu, 30 Mar 2017 19:30:14 +0000 (21:30 +0200)]
Add closure around moment-locale-overrides.js
Change-Id: I262d53479ab7971323db12d345fc0cd343b1df5e
jenkins-bot [Thu, 30 Mar 2017 18:36:33 +0000 (18:36 +0000)]
Merge "Implement WikiPage::getOldestRevision() in terms of Title::getFirstRevision()"
jenkins-bot [Thu, 30 Mar 2017 18:16:18 +0000 (18:16 +0000)]
Merge "build: Bump grunt-banana-checker from 0.5.0 to 0.6.0"
Arlo Breault [Thu, 30 Mar 2017 14:23:17 +0000 (10:23 -0400)]
Sync up with Parsoid parserTests.txt
This now aligns with Parsoid commit
b1b271460c341e844e21641b5307794cf4dd7feb
Change-Id: I792787b38c464efcb8c68b66b52a4dc9a0b41c36
jenkins-bot [Thu, 30 Mar 2017 13:23:03 +0000 (13:23 +0000)]
Merge "Follow-up If0588439: Fix color of active & visited selflinks"
jenkins-bot [Thu, 30 Mar 2017 12:35:31 +0000 (12:35 +0000)]
Merge "Avoid database access in ImportTitleFactory tests dataProviders"
jenkins-bot [Thu, 30 Mar 2017 12:33:14 +0000 (12:33 +0000)]
Merge "Don't create user in AuthManagerTest dataProvider"
Reedy [Thu, 30 Mar 2017 11:29:35 +0000 (12:29 +0100)]
Make the indexName functions more obviously laid out
Move Sqlites's indexName to Database to have no remapping by default.
This is because MSSQL and Postgresql both don't need remapping, it's
just MySQL that's the problem.
So move the one from Database into MysqlBase to only do the remappings
there.
Also fix up the comments to make them less vague, not mentioning tables
when the function has no table parameter passed, so hence, no context
as to which table said index is wanted to be used
Bug: T154872
Change-Id: I46c575771e6cb36176bcf6cd1a865b703db0275d
Ed Sanders [Thu, 30 Mar 2017 10:54:49 +0000 (11:54 +0100)]
Follow-up If0588439: Fix color of active & visited selflinks
Bug: T160480
Change-Id: I3efb0705ad2365f676df41b0166403b8f43f19a5
jenkins-bot [Thu, 30 Mar 2017 02:32:53 +0000 (02:32 +0000)]
Merge "Revert "Remove old remapping hacks from Database::indexName()""
jenkins-bot [Thu, 30 Mar 2017 02:06:16 +0000 (02:06 +0000)]
Merge "Update psy/psysh 0.8.1 -> 0.8.3"
jenkins-bot [Thu, 30 Mar 2017 01:53:05 +0000 (01:53 +0000)]
Merge "Update phpunit 4.8.31 -> 4.8.35"
Brian Wolff [Wed, 15 Mar 2017 22:51:13 +0000 (22:51 +0000)]
objectcache: Never use CACHE_NONE for CACHE_ANYTHING
If $wgMainCacheType = CACHE_ACCEL, but there is no APC, then its
possible that CACHE_ANYTHING will default to CACHE_NONE because
that's what CACHE_ACCEL would do.
Possibly also T147161
Bug: T160519
Change-Id: I9ac2d071437b35a0f9cd3678e2279628f7b1931e
Reedy [Thu, 30 Mar 2017 01:11:56 +0000 (02:11 +0100)]
Update phpunit 4.8.31 -> 4.8.35
Change-Id: I909466567b9f66dc391258ca7f7bac12ce98b23c
Reedy [Thu, 30 Mar 2017 01:09:15 +0000 (02:09 +0100)]
Update psy/psysh 0.8.1 -> 0.8.3
https://github.com/bobthecow/psysh/releases/tag/v0.8.2
https://github.com/bobthecow/psysh/releases/tag/v0.8.3
https://github.com/bobthecow/psysh/compare/v0.8.1...v0.8.3
Change-Id: Ief2e0444d6e79df4433172d00d2db2b137bc2bb2
James D. Forrester [Thu, 16 Mar 2017 22:19:36 +0000 (15:19 -0700)]
Linker: Render selflinks as href-less classed <a>s, not <strong>s
Self-links are still semantically links, and representing them as <strong>s
is inelegant and more important a real pain to work with, especially in
contexts where they may change state (like inside an editor).
Instead, render them as <a>, with no href to avoid user agent style over-
rides and with a class to style them as before, named 'mw-selflink' to go
with 'mw-redirect'. This allows much easier adjustment later. The old CSS
class 'selflink' is retained for backwards compatibility, but deprecated.
Bug: T160480
Change-Id: If058843924c3b30c116df2520aef93a004d98a5d
jenkins-bot [Wed, 29 Mar 2017 20:48:46 +0000 (20:48 +0000)]
Merge "Update OOjs UI to v0.20.1"
jenkins-bot [Wed, 29 Mar 2017 20:39:07 +0000 (20:39 +0000)]
Merge "EditPage: Refactor getCheckboxes() to allow changing the format"
jenkins-bot [Wed, 29 Mar 2017 20:06:58 +0000 (20:06 +0000)]
Merge "ResourceLoaderImage: Correctly ignore 'deprecated' key"
jenkins-bot [Wed, 29 Mar 2017 20:06:03 +0000 (20:06 +0000)]
Merge "Special:RecentChangesLinked show "no results" message"
Bartosz Dziewoński [Sat, 25 Mar 2017 20:41:03 +0000 (21:41 +0100)]
EditPage: Refactor getCheckboxes() to allow changing the format
getCheckboxes() directly generated the HTML for the
"This is a minor edit" and "Watch this page" checkboxes,
and allowed extensions to add more HTML checkboxes (and
modify existing ones) using the 'EditPageBeforeEditChecks'
hook. This prevents us from ever changing the format of
the HTML (e.g. to use OOUI checkboxes).
Introduce new method getCheckboxesDefinition(), which
generates the checkboxes in a machine-readable format,
with a new hook 'EditPageGetCheckboxesDefinition'.
Rewrite getCheckboxes() in terms of that. The old hook
'EditPageBeforeEditChecks' is now deprecated.
Change-Id: I3dbe973dcac6cba0c3a1ac5d983cafcfb49d833c
Translation updater bot [Wed, 29 Mar 2017 19:57:26 +0000 (21:57 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I18df74d64336e8539b7ac85fc6a456759d283e9c
Volker E [Tue, 28 Mar 2017 23:25:58 +0000 (16:25 -0700)]
Update OOjs UI to v0.20.1
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.20.1
Depends-On: I9b50eee459085eaa00819cbabe340ac442a332bd
Change-Id: I9b50eee459085eaa00819cbabe340ac442a332db
jenkins-bot [Wed, 29 Mar 2017 19:39:18 +0000 (19:39 +0000)]
Merge "mw.widgets.Complex*: Add setDisabled"
Roan Kattouw [Wed, 29 Mar 2017 18:44:22 +0000 (14:44 -0400)]
ResourceLoaderImage: Correctly ignore 'deprecated' key
It turns out that 'resources/lib/oojs-ui/themes/mediawiki/Moved since v0.20.1, use from the 'interactions' pack instead.'
is not usually an existing file, and doesn't have the extension '.svg'.
Not sure why this didn't break earlier.
Bonus: Add module name to exceptions to make these errors easier
to track down.
Bonus #2: Use the post-expansion, not pre-expansion, definition everywhere
to avoid confusion when debugging.
Change-Id: I0325d4dab5658fd29c3c33fd3e762834b53d1b5d
jenkins-bot [Wed, 29 Mar 2017 18:29:11 +0000 (18:29 +0000)]
Merge "Move DBConnRef/MaintainableDBConnRef to Rdbms namespace"
Aaron Schulz [Wed, 29 Mar 2017 16:15:50 +0000 (09:15 -0700)]
Move DBConnRef/MaintainableDBConnRef to Rdbms namespace
Change-Id: I7ca6b40f973b2aae83747de92e280ded222c87e3
Stephane Bisson [Wed, 29 Mar 2017 16:36:49 +0000 (12:36 -0400)]
Special:RecentChangesLinked show "no results" message
Bug: T160482
Change-Id: I26743928b359ad052ff53bde281f0479cbe68a99
jenkins-bot [Wed, 29 Mar 2017 16:23:38 +0000 (16:23 +0000)]
Merge "Make Title::getFirstRevision() ignore the rev_timestamp index"
Roan Kattouw [Wed, 29 Mar 2017 15:53:08 +0000 (11:53 -0400)]
Implement WikiPage::getOldestRevision() in terms of Title::getFirstRevision()
They were both doing the same thing, except that getOldestRevision()
checks the master if the revision is missing on the replica.
Change-Id: I21a118c6cd5c98fb846a0a2765574c0dbdbf7220
Roan Kattouw [Tue, 28 Mar 2017 15:34:56 +0000 (11:34 -0400)]
Make Title::getFirstRevision() ignore the rev_timestamp index
We want the page_timestamp index to be used in this case, but sometimes
the rev_timestamp is chosen which leads to bad performance.
Also update WikiPage::getOldestRevision() which uses the exact same query.
I'll implement one in terms of the other in a follow-up commit.
Bug: T159319
Change-Id: I7c5c0a9b1af99ce2b5f4bdcc99710d8400ca8bcf
jenkins-bot [Wed, 29 Mar 2017 14:11:40 +0000 (14:11 +0000)]
Merge "Allow filtering by username on Special:NewFiles"
jenkins-bot [Wed, 29 Mar 2017 06:44:49 +0000 (06:44 +0000)]
Merge "HttpFunctions: Increase code coverage"
jenkins-bot [Wed, 29 Mar 2017 00:46:59 +0000 (00:46 +0000)]
Merge "Move IDatabase/IMaintainableDatabase to Rdbms namespace"
jenkins-bot [Wed, 29 Mar 2017 00:46:52 +0000 (00:46 +0000)]
Merge "Defer calling ChronologyProtector::initLB() until connecting"
Timo Tijhof [Wed, 29 Mar 2017 00:21:15 +0000 (17:21 -0700)]
HttpFunctions: Increase code coverage
* Complete coverage for Http::getProxy().
* Remove bogus @covers tag on data provider, and add the
relevant MWHttpRequest::getFinalUrl to the test instead.
* Convert test to use dataProvider and add missing test cases
to increase getFinalUrl() test coverage to 100%.
* Minor clean up in getFinalUrl to consistently use early-return
for all cases, not just for relative 'domain' and 'isset-host'
cases. Without this coverage actually couldn't reach 100% due
to the remainder of the empty else branch never being reached
(CRAP: "Redundant 'else' after 'return'")
Change-Id: I775d95965dc23a1e6c4c62ed84f9da64b6c72135