Brian Wolff [Wed, 24 Aug 2011 23:47:54 +0000 (23:47 +0000)]
(bug 28649) use $wgContLang->truncate on log action comments to avoid half eaten unicode chars and also adds a nice '...'
Patch by Umherirrender.
Brion Vibber [Wed, 24 Aug 2011 22:09:34 +0000 (22:09 +0000)]
Followup r95332 (bug 30441 fix) -- Roan pointed out that I forgot to do a global replace (d'oh!)
Now works with parameters containing multiple spaces. :)
John Du Hart [Wed, 24 Aug 2011 21:55:11 +0000 (21:55 +0000)]
Follow-up r95445, fix for IE6-7 no supporting display-inline. Removes alt attribute left over from using the img tag
Sam Reed [Wed, 24 Aug 2011 21:38:31 +0000 (21:38 +0000)]
Allow update to be passed an empty array for the WHERE condition
Krinkle [Wed, 24 Aug 2011 21:37:59 +0000 (21:37 +0000)]
jquery.spinner: Fix small issues
(Follows-up r95445)
* Using the same spinner as before, preserving svn history (20px vs. 16px)
* Adding a line-break at the end of file and changing indentation per our conventions
* Adjusting doc to reflect the plugin itself instead of what it replaces.
* Using shorthand utility in jQuery (no / and using the attr-object as second argument)
* Adding @return comment to $.fn.injectSpinner
* Adding return statement to $.removerSpinner (returning a jQuery object of the element). Could be useful, but better than not having a return value at all.
JSHint:
* Adding parentheses around the class object property, otherwise it may be interpreted as a class operator which breaks the object.
Sam Reed [Wed, 24 Aug 2011 21:36:15 +0000 (21:36 +0000)]
'*' for "all" apparently
r95446
Sam Reed [Wed, 24 Aug 2011 21:31:11 +0000 (21:31 +0000)]
Merge r94252 to trunk
Rewrite to use $dbw->update()
John Du Hart [Wed, 24 Aug 2011 21:08:39 +0000 (21:08 +0000)]
(bug 30499) Create jQuery replacements for injectSpinner and removeSpinner
Ariel Glenn [Wed, 24 Aug 2011 20:43:09 +0000 (20:43 +0000)]
remove extraneous hyphen that crept in, grr
Sam Reed [Wed, 24 Aug 2011 20:32:00 +0000 (20:32 +0000)]
Remove line that should have been removed in r95410
Raimond Spekking [Wed, 24 Aug 2011 20:28:02 +0000 (20:28 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sam Reed [Wed, 24 Aug 2011 20:15:04 +0000 (20:15 +0000)]
Fix missing $ from r95439
Sam Reed [Wed, 24 Aug 2011 20:14:03 +0000 (20:14 +0000)]
Fixup the rest of r82577
Raimond Spekking [Wed, 24 Aug 2011 20:04:55 +0000 (20:04 +0000)]
fu r95396: register new message keys in maintenacne file
Krinkle [Wed, 24 Aug 2011 19:56:54 +0000 (19:56 +0000)]
Partially revert r92245 per r92245 CR.
Sam Reed [Wed, 24 Aug 2011 19:52:24 +0000 (19:52 +0000)]
Fix testGetTalkExceptions from r82577
Sam Reed [Wed, 24 Aug 2011 19:48:59 +0000 (19:48 +0000)]
Revert r95408, breaks preferences
Krinkle [Wed, 24 Aug 2011 19:35:18 +0000 (19:35 +0000)]
Add comments and fix whitespace for r90657, r86305
Sam Reed [Wed, 24 Aug 2011 19:32:40 +0000 (19:32 +0000)]
Followup r82577
Remove $this->object
Swap assertEquals parameters
Siebrand Mazeland [Wed, 24 Aug 2011 19:32:28 +0000 (19:32 +0000)]
Triggered by r95414. Remove some UI diarrhea.
Sam Reed [Wed, 24 Aug 2011 18:47:38 +0000 (18:47 +0000)]
Update Listfiles-summary per translatewiki.net/w/i.php?title=MediaWiki%3AListfiles-summary%2Fen&action=historysubmit&diff=
3168956&oldid=967680
Sam Reed [Wed, 24 Aug 2011 18:46:12 +0000 (18:46 +0000)]
Fix fixme on r92059 per SPQRobin
Sam Reed [Wed, 24 Aug 2011 18:35:29 +0000 (18:35 +0000)]
Followup r85876
Fix the fixme
Sam Reed [Wed, 24 Aug 2011 18:22:53 +0000 (18:22 +0000)]
Revert r91728
Hence reverting r93382, t93383, r94236
Sam Reed [Wed, 24 Aug 2011 18:11:55 +0000 (18:11 +0000)]
Revert changes to HTMLForm from r92155
Sam Reed [Wed, 24 Aug 2011 18:09:14 +0000 (18:09 +0000)]
Revert most of r93261
Leave change from named color 'gainsboro' to hex #DCDCDC
Sam Reed [Wed, 24 Aug 2011 15:31:00 +0000 (15:31 +0000)]
Followup r95396
Lowercase names passed as the name to the SpecialPage constructor
Sam Reed [Wed, 24 Aug 2011 13:05:44 +0000 (13:05 +0000)]
Followup r95396, add missing comma
Sam Reed [Wed, 24 Aug 2011 13:03:03 +0000 (13:03 +0000)]
Merge the iwtransclusion branch back into trunk
Hexmode fixed broken unit tests in revisions after last time
Sam Reed [Wed, 24 Aug 2011 12:47:42 +0000 (12:47 +0000)]
Fix documentation (clearing w/c)
Thomas Gries [Tue, 23 Aug 2011 22:20:33 +0000 (22:20 +0000)]
follow up for r95341 , test case 025a corrected the expected result
Thomas Gries [Tue, 23 Aug 2011 22:03:55 +0000 (22:03 +0000)]
test case for jquery.highlightText.js : test case 025a => fails
Ryan Kaldari [Tue, 23 Aug 2011 21:33:23 +0000 (21:33 +0000)]
syncing updates from vector jquery.ui skin with default jquery.ui skin - forgot to change it in both places. Changes in vector jquery.ui skin are already reviewed and deployed. These changes are to make the handling of icons within buttons consistant and more in line with how jquery.ui skins normally handle this.
Brion Vibber [Tue, 23 Aug 2011 20:17:49 +0000 (20:17 +0000)]
* (bug 30441) getParamValue must understand "+" encoding of space
$.param() produces query string form encoding using the traditional '+' encoding for space; mediawiki.util.getParamValue() was using only decodeURIComponent() to do unescaping, which is not required by spec to handle '+'. Explicitly replacing '+' with '%20' before the decode nicely resolves this.
Added a test case to qunit tests for mediawiki.util module.
Raimond Spekking [Tue, 23 Aug 2011 20:11:33 +0000 (20:11 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Tue, 23 Aug 2011 20:02:15 +0000 (20:02 +0000)]
Per Raymond, follow-up r95321: LinkSearch is in core too
John Du Hart [Tue, 23 Aug 2011 19:56:15 +0000 (19:56 +0000)]
(bug 30335) Fix for HTMLForms using GET breaking when non-friendly URLs are used
Alexandre Emsenhuber [Tue, 23 Aug 2011 19:48:18 +0000 (19:48 +0000)]
Use local context instead of global variables
John Du Hart [Tue, 23 Aug 2011 19:42:55 +0000 (19:42 +0000)]
Updating release-notes for r95320
Thomas Gries [Tue, 23 Aug 2011 19:40:51 +0000 (19:40 +0000)]
added jquery.highlightText.js test cases for Russian Georgian Armenian Thai Arabic ru ka hy th ar
Alexandre Emsenhuber [Tue, 23 Aug 2011 19:38:07 +0000 (19:38 +0000)]
* Removed no longer existing special pages (Special:Makebot and Special:MakeSysop)
* Removed mention of Filepath extension since this is now in core
John Du Hart [Tue, 23 Aug 2011 19:27:38 +0000 (19:27 +0000)]
(bug 30344) Add configuration variable for setting custom priorities when generating sitemaps
John Du Hart [Tue, 23 Aug 2011 18:40:04 +0000 (18:40 +0000)]
(bug 30352) Add option to BlockList to filter out IP range blocks
Brion Vibber [Tue, 23 Aug 2011 18:33:28 +0000 (18:33 +0000)]
* (bug 30497) Add client-nojs and client-js classes on document element to let styles easily hide or show things based on general JS availability
Patch by John Du Hart - https://bugzilla.wikimedia.org/attachment.cgi?id=8956
Brion Vibber [Tue, 23 Aug 2011 17:58:18 +0000 (17:58 +0000)]
Followup r95262 - remove bogus test cases that seemed to be trying to test the browser's HTML fragment parser. :)
These test cases attempted, I think, to be bogus forced-fail cases, but the fail-forcing doesn't work because HTML 5 parsing in modern browsers parses the text into... the same as the actual expected text! :)
Resolves bug 30520.
Thomas Gries [Tue, 23 Aug 2011 07:28:57 +0000 (07:28 +0000)]
jquery.highlightText.js : test cases for French added
Ariel Glenn [Tue, 23 Aug 2011 00:36:15 +0000 (00:36 +0000)]
fix timestamp stuff, more fallout from bad merge attempt
Ariel Glenn [Tue, 23 Aug 2011 00:04:45 +0000 (00:04 +0000)]
fix a couple bad lines in previous commit from bad merge attempt
Ariel Glenn [Mon, 22 Aug 2011 22:45:22 +0000 (22:45 +0000)]
add support for writing out checkpoint files of xml dump at regular intervals (close and rename file based on filename pattern which includes first and last page id written)
Thomas Gries [Mon, 22 Aug 2011 22:15:43 +0000 (22:15 +0000)]
follow up to r94807 : more test cases incl. hebrew RTL and Japanese, the test cases 100 and 101 have been intentionally added with wrong expected result. It shows that the current qunit software may have problems with wrong double closing span tags. test cases 100 and 101 fail *correctly* on internet explorer 8.0, but with Firefox 6.0 and Chrome no errors are detected --- false negative with Firefox and Chrome and maybe other browsers
Ariel Glenn [Mon, 22 Aug 2011 22:01:32 +0000 (22:01 +0000)]
add functions that support close and rename of output files as they are being written, used to write out checkpoint files at regular intervals during XML dump production
Raimond Spekking [Mon, 22 Aug 2011 19:04:31 +0000 (19:04 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Mon, 22 Aug 2011 18:32:48 +0000 (18:32 +0000)]
Use local context instead of global variables
Niklas Laxström [Mon, 22 Aug 2011 08:12:10 +0000 (08:12 +0000)]
Make the language recaching non-recursive and load the data directly.
This might be a bit slower, but avoids problems with cyclic language fallbacks.
Followup r94907
Raimond Spekking [Sun, 21 Aug 2011 19:37:43 +0000 (19:37 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Brian Wolff [Sun, 21 Aug 2011 19:28:35 +0000 (19:28 +0000)]
follow-up r95171 - add unit test for tracking categories.
Brian Wolff [Sun, 21 Aug 2011 18:46:01 +0000 (18:46 +0000)]
Follow-up r86534 - Do not add tracking categories if we're looking at a special page.
Thank you Nikerabbit for suggesting how to fix.
Daniel Friesen [Sun, 21 Aug 2011 18:23:59 +0000 (18:23 +0000)]
Remove the * {{msg}} syntax introduced to MediaWiki:Sidebar in r66974. This syntax is in the way of projects attempting to use a more flexible sidebar-like message parser, or fixing the dependence on MediaWiki:Sidebar for sidebar config. Eliminating it before people end up using it in production (from my tests it never actually worked in 1.17).
Raimond Spekking [Sun, 21 Aug 2011 18:15:37 +0000 (18:15 +0000)]
fu r95152: remove debug line.
Brian Wolff [Sun, 21 Aug 2011 18:05:34 +0000 (18:05 +0000)]
(follow-up r86169) Moar unit-tests!! (sorry for uttetly huge commit)
This should be my last commit of unit tests for the media metadata stuff (hopefully).
Brian Wolff [Sun, 21 Aug 2011 17:16:57 +0000 (17:16 +0000)]
follow-up r86169 - 2 minor issues found while writing unit tests
# Some really obscure Exif properties did not have the Exif byte order taken into account
and were being extracted with the bytes reversed (for example user comment when encoded as utf-16).
Not a major issue as these properties are very rare in practise, but certainly not a good thing.
( One would think php's exif support would take care of that, but no it does not...)
# Change the fallback encoding for Gif comments to be windows-1252 instead of iso 8859-1. More
to be consitent with jpg and iptc then anything else.
Raimond Spekking [Sun, 21 Aug 2011 16:38:02 +0000 (16:38 +0000)]
New hook point to exempt an IP address from the account creation throttle. Redo of r95041 per Niklas CR
Needed for a new extension to make (mass) account creation easier for schools/colleges etc
Sam Reed [Sun, 21 Aug 2011 15:24:44 +0000 (15:24 +0000)]
Add in \n from/to r95055 to LoadBalancer.php
Differentiate error messages from r95050 per Hashar
Raimond Spekking [Sat, 20 Aug 2011 20:54:50 +0000 (20:54 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Sat, 20 Aug 2011 20:12:46 +0000 (20:12 +0000)]
Use local context instead of global variables
Raimond Spekking [Sat, 20 Aug 2011 18:07:48 +0000 (18:07 +0000)]
Self revert r95041 per CR. I will commit a cleaner patch.
Roan Kattouw [Sat, 20 Aug 2011 12:47:17 +0000 (12:47 +0000)]
Fix typo
Roan Kattouw [Sat, 20 Aug 2011 10:41:44 +0000 (10:41 +0000)]
Followup r95072: add tests for wfMatchesDomainList
Roan Kattouw [Sat, 20 Aug 2011 10:25:38 +0000 (10:25 +0000)]
Fix serious bug in r90849 that didn't show up in the tests until I restructured the code a bit and the tests started to actually hit it: $url is undefined, use $href
Roan Kattouw [Sat, 20 Aug 2011 10:18:09 +0000 (10:18 +0000)]
Per r90849, factor out most of the code that's duplicated between Parser::getExternalLinkAttribs() and Skin::addToSidebarPlain() into wfMatchesDomainList(). Change a loose comparison to a strict one, and add a FIXME comment about how whitelisting nl.wikipedia.org also whitelists nds-nl.wikipedia.org due to the function's simplistic substring approach.
Roan Kattouw [Sat, 20 Aug 2011 09:59:00 +0000 (09:59 +0000)]
Per CR on r90915, fix the description of one of the assertions
Roan Kattouw [Sat, 20 Aug 2011 07:19:10 +0000 (07:19 +0000)]
Revert r95058 (make letype multivalue): has been applied before in r88722 and reverted in r89348.
Sam Reed [Fri, 19 Aug 2011 23:30:12 +0000 (23:30 +0000)]
Couple more pieces of wikia upstreaming
Sam Reed [Fri, 19 Aug 2011 23:21:34 +0000 (23:21 +0000)]
Upstream wikia change
Make type multi
Sam Reed [Fri, 19 Aug 2011 23:19:26 +0000 (23:19 +0000)]
Upstream wikia changes
Sam Reed [Fri, 19 Aug 2011 23:12:46 +0000 (23:12 +0000)]
Swap from NS_MAIN to use MWNamespace::getContentNamespaces()
Sam Reed [Fri, 19 Aug 2011 23:11:12 +0000 (23:11 +0000)]
Use MWNamespace::getContentNamespaces() (instead of $wgContentNamespaces) like the rest of the Special pages seem to
Sam Reed [Fri, 19 Aug 2011 23:06:54 +0000 (23:06 +0000)]
Incorporate Wikia diff, don't duplicate debugging though, add the info to the debug call that already exists
Raimond Spekking [Fri, 19 Aug 2011 20:58:32 +0000 (20:58 +0000)]
Fix a typo
Raimond Spekking [Fri, 19 Aug 2011 20:57:41 +0000 (20:57 +0000)]
New hook point to change $wgAccountCreationThrottle
Needed for a new extension to make (mass) account creation easier for schools/colleges etc
Raimond Spekking [Fri, 19 Aug 2011 20:01:08 +0000 (20:01 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Max Semenik [Fri, 19 Aug 2011 18:27:35 +0000 (18:27 +0000)]
Don't check for each database's availability twice. This halves the number of ugly message boxes seen during CLI installation on Windows if Oracle is not installed, but its bindings for PHP are.
Sam Reed [Fri, 19 Aug 2011 17:54:42 +0000 (17:54 +0000)]
Remove duplicate patch contributors section from CREDITS added in r92528
Roan Kattouw [Fri, 19 Aug 2011 17:33:41 +0000 (17:33 +0000)]
Use canonical URLs in sitemaps, diff stuff and external edit stuff
Roan Kattouw [Fri, 19 Aug 2011 17:31:40 +0000 (17:31 +0000)]
Expand some more URLs: for feeds, referers and the proxy script
Roan Kattouw [Fri, 19 Aug 2011 17:20:35 +0000 (17:20 +0000)]
Use getInternalUrl() instead of getFullUrl() in purgeList.php . This was potentially a serious bug if $wgServer differed from $wgInternalServer in command-line mode (this is not the case on WMF, but might be the case on 3rd-party installs)
Roan Kattouw [Fri, 19 Aug 2011 15:56:59 +0000 (15:56 +0000)]
Use wfParseUrl() instead of parse_url() in interwiki search code: the latter can throw PHP warnings and is totally broken for protocol-relative URLs. Also remove the last usage in core of key_exists(), a deprecated alias for array_key_exists()
Roan Kattouw [Fri, 19 Aug 2011 15:46:08 +0000 (15:46 +0000)]
Make the PROTO_ parameter to wfExpandUrl() explicit in all calls. There are now no calls to wfExpandUrl() in core that rely on PROTO_CURRENT being the default. Also switch to using getCanonicalUrl() for.... rel="canonical" :D (I picked the right name, I KNEW IT)
Roan Kattouw [Fri, 19 Aug 2011 15:27:49 +0000 (15:27 +0000)]
* Introduce File::getCanonicalUrl()
* Make File::getFullUrl() use PROTO_RELATIVE for consistency with other methods named getFullUrl() and to prevent cache pollution
* Use canonical URLs in Export.php
Roan Kattouw [Fri, 19 Aug 2011 15:25:50 +0000 (15:25 +0000)]
Add a PROTO_CANONICAL mode to wfExpandUrl(), which uses $wgCanonicalServer
Roan Kattouw [Fri, 19 Aug 2011 14:46:03 +0000 (14:46 +0000)]
Use canonical URLs (introduced in r94995) for all URLs in e-mails
Roan Kattouw [Fri, 19 Aug 2011 14:41:35 +0000 (14:41 +0000)]
Make $wgVaryOnXFPForAPI apply to RSS/Atom feeds too, because they too use PROT_CURRENT. Make PROT_CURRENT usage explicit there too
Roan Kattouw [Fri, 19 Aug 2011 14:39:37 +0000 (14:39 +0000)]
Use canonical URLs (introduced in r94995) in the OpenSearch discovery thingy
Roan Kattouw [Fri, 19 Aug 2011 14:05:00 +0000 (14:05 +0000)]
Followup r94995: add hooks.txt entries for the new hooks
Roan Kattouw [Fri, 19 Aug 2011 13:25:43 +0000 (13:25 +0000)]
Reverse a bad decision in r93820, which added a comment to WebRequest::getFullRequestURL() saying it would return protocol-relative URLs if $wgServer is protocol-relative. This behavior makes no sense, though, and most callers expect fully qualified URLs. So make it return a fully qualified URL and update the one caller that expected the return value would be compatible with getFullURL()
Roan Kattouw [Fri, 19 Aug 2011 11:23:17 +0000 (11:23 +0000)]
Per CR on r44412 and my promise in the commit summary of r94990, stop abusing $wgInternalServer (intended for Squid URLs) for IRC/e-mail URLs and introduce $wgCanonicalServer for these purposes instead. This revision introduces two new hooks for WMF hacks, in exchange for making the core code saner.
* Introduce $wgCanonicalServer, which should typically be a fully qualified version of $wgServer but in practice can be anything that you'd like to be used in IRC/e-mail notifs
** Default value is $wgServer, expanded to http:// if protocol-relative
** This means you can easily set HTTPS as the 'default' protocol to use in IRC and e-mail notifs by setting $wgCanonicalServer to https://example.com
* Introduce Title::getCanonicalURL(). Similar to getInternalURL(), including a hook for WMF usage (which will be needed as long as secure.wikimedia.org is used)
** Also add escapeCanonicalURL(). Due to some ridiculous accident of history, the other escapeFooURL() functions don't have a $variant parameter; I decided not to follow that bad example
* Reinstate the spirit of r44406 and r44412: instead of calling getInternalURL() (or getCanonicalURL()) and regexing the title parameter out, obtain the path to index.php using $wgCanonicalServer . $wgScript and append params to that. Sadly, we need to add a hook here to support the secure server hack for WMF, but that's the price of saner code in this case
* Introduce the {{canonicalurl:}} and {{canonicalurle:}} parser functions, which work just like {{fullurl:}} and {{fullurle:}} except that they use getCanonicalURL() instead of getFullURL()
* Use {{canonicalurl:}} in the enotif_body message, fixing bug 29993 (protocol-relative URLs appear in e-mail notifications)
Niklas Laxström [Fri, 19 Aug 2011 09:02:35 +0000 (09:02 +0000)]
Fu r94907 - also update localisation cache, which accesses the fallback variable directly
Fixes bug 30456
Roan Kattouw [Fri, 19 Aug 2011 08:56:39 +0000 (08:56 +0000)]
Followup r94754: move protocol expansion from getIRCLine() to inside getInternalUrl(); these internal URLs should always be fully qualified. Effectively this means that if $wgServer is protocol-relative and $wgInternalServer either isn't set or is also protocol relative (but it really shouldn't be the latter!), we'll add to URLs used for Squid purging and in IRC lines. If people want those to be https:// instead, they can set $wgInternalServer accordingly.
We should really, really break the connection between internal URLs used for Squid purges and URLs used for IRC, and use the latter in e-mails as well. This was briefly discussed in the CR comments on r44412 and I'll be working on that today.
Sam Reed [Thu, 18 Aug 2011 23:37:04 +0000 (23:37 +0000)]
* (bug 30450) Clear page_props table on page deletion
Also clear them on a move over redirect
Modified delete() calls in doDeleteArticle to pass __METHOD__ for the function name
Ian Baker [Thu, 18 Aug 2011 23:36:24 +0000 (23:36 +0000)]
Two bugs:
1. When the user isn't passed to UploadFromStash::__construct(), it would break when it shouldn't.
2. When stashing files, sometimes an instance of UnregisteredLocalFile would be returned instead of UploadStashFile