Translation updater bot [Tue, 26 Dec 2017 09:00:05 +0000 (10:00 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I495ab349530db87303fc33f06b2610681ba3efc5
Kunal Mehta [Mon, 25 Dec 2017 03:13:51 +0000 (19:13 -0800)]
tests: Use checkPHPExtension() instead of re-implementing it
Change-Id: I7f5e8684d556befc0aefa302187c573e7a3cff62
Kunal Mehta [Mon, 25 Dec 2017 03:10:14 +0000 (19:10 -0800)]
Add @covers tags for Collation tests
Change-Id: I8b0623a6b716acdc9d369349fd4e306dbdc91d18
Translation updater bot [Mon, 25 Dec 2017 08:31:53 +0000 (09:31 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I69b50503f8a9db7b3883f664f2703ab16f9132dc
jenkins-bot [Mon, 25 Dec 2017 03:27:42 +0000 (03:27 +0000)]
Merge "Allow fallbacks for $wgReferrerPolicy"
Kunal Mehta [Mon, 25 Dec 2017 03:16:26 +0000 (19:16 -0800)]
Fix @covers in XmlTest
Follows up
389fa13ff875.
Change-Id: I32ddf37b24a6b5162b383260233d616cb49f7ddb
Amir Sarabadani [Mon, 25 Dec 2017 01:54:25 +0000 (02:54 +0100)]
Add tests for several methods of Xml
Added tests for methods: monthSelector, span, buildTable, buildTableRow
Change-Id: I5ca6bb231b5ed95f57f649a92d659245a4852c85
jenkins-bot [Sun, 24 Dec 2017 23:42:56 +0000 (23:42 +0000)]
Merge "[MCR] Don't require $title to be passed to Revision::newFromId"
jenkins-bot [Sun, 24 Dec 2017 23:39:58 +0000 (23:39 +0000)]
Merge "[MCR] Introduce BlobStoreFactory"
jenkins-bot [Sun, 24 Dec 2017 23:38:57 +0000 (23:38 +0000)]
Merge "Add `margin-bottom` for editButtons (EditPage)"
Kunal Mehta [Sun, 24 Dec 2017 23:23:49 +0000 (15:23 -0800)]
Add @covers tags to CategoriesRdfTest
Change-Id: I6e2eae3fc2ac722dc94bee1a7aa6632e08a4d097
addshore [Sat, 23 Dec 2017 17:14:28 +0000 (17:14 +0000)]
[MCR] Introduce BlobStoreFactory
This allows Revision::getRevisionText to get
a different BlobStore instance when $wiki is passed in
restoring the behaviour for $wiki before the MCR Revision
overhaul patch was merged.
Ia4c20a91e98df0b9b14b138eb4825c55e5200384
Bug: T183634
Bug: T183631
bug: T183583
Change-Id: Ib0949454e9a003c2965adc1aab38e31fcf121afe
Gergő Tisza [Sat, 23 Dec 2017 17:35:59 +0000 (09:35 -0800)]
Allow fallbacks for $wgReferrerPolicy
For browsers that support older versions of the Referrer Policy
specification (Edge and Safari), using a value from a newer version of
the specification will result in those browsers falling back to a
default of "default".
So allow $wgReferrerPolicy to have fallbacks if the browser does not
recognize the currently set value. It will emit <meta> tags for each
value in the array, but in reverse order, as browsers will use the last
one that they recognize.
Bug: T180921
Change-Id: Ie0f523fc6937c9ecffc8a6fc791c6b54d5a1cb06
jenkins-bot [Sun, 24 Dec 2017 22:56:00 +0000 (22:56 +0000)]
Merge "Improve documentation of $wgReferrerPolicy"
jenkins-bot [Sun, 24 Dec 2017 21:57:01 +0000 (21:57 +0000)]
Merge "JavaScriptMinifier: Improve docs around parsing of regexp literals"
jenkins-bot [Sun, 24 Dec 2017 21:54:45 +0000 (21:54 +0000)]
Merge "JavaScriptMinifier: Remove support for unused $statementsOnOwnLine flag"
Timo Tijhof [Fri, 22 Dec 2017 18:00:42 +0000 (19:00 +0100)]
JavaScriptMinifier: Improve docs around parsing of regexp literals
Bug: T75556
Change-Id: Ifcb6bc21418dfc2e1d3e44dbd2497a0f5f691bf3
Phantom42 [Wed, 20 Dec 2017 15:18:55 +0000 (17:18 +0200)]
Add `margin-bottom` for editButtons (EditPage)
Bug: T179040
Change-Id: I9e6c04556e4ff7f0cc567877041449f50abf4b4c
jenkins-bot [Sun, 24 Dec 2017 15:01:11 +0000 (15:01 +0000)]
Merge "Remove duplicate ServiceWiring definitions"
Translation updater bot [Sat, 23 Dec 2017 20:55:31 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I26ca1588d1f8063a673809759e5b05728e4dc550
addshore [Sat, 23 Dec 2017 17:16:09 +0000 (17:16 +0000)]
Remove duplicate ServiceWiring definitions
Change-Id: I70b377c417ce6937e5d52d1790cf0b6f2ed33c15
jenkins-bot [Sat, 23 Dec 2017 12:08:42 +0000 (12:08 +0000)]
Merge "Set wgCommentTableSchemaMigrationStage in RevisionStoreTest"
addshore [Fri, 22 Dec 2017 17:32:54 +0000 (17:32 +0000)]
[MCR] Don't require $title to be passed to Revision::newFromId
If the title is not passed in as a param (already known) then select
it in Revision::newFromId instead of waiting for it to be selected
further down the tree.
This means that we can use the same Title object to pass into the
RevisionRecord as well as our legacy Revision object.
The selection chooses either a slave or master depending on
recent writes.
This logic used to be in Revision::getTitle and also in
Revision::newFromConds which was called by newFromId
Bug: T183505
Change-Id: I9cf4ce2c3c86d6bf979a3c88eb423b942b9a1ba4
Gergő Tisza [Sun, 19 Nov 2017 22:19:44 +0000 (14:19 -0800)]
Improve documentation of $wgReferrerPolicy
Reference current version of the spec.
Change-Id: I1cca89b9e46a2b5ae8242715eddfdbd23ccb2d83
Umherirrender [Fri, 22 Dec 2017 22:40:57 +0000 (23:40 +0100)]
Update reference to DatabaseBase in hooks.txt
Change-Id: I65f84c0deadb611380e17a5b1b7593876894c099
Translation updater bot [Fri, 22 Dec 2017 20:59:32 +0000 (21:59 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I1edcc9b4af56fb6b66961a14e38d878ff97843e9
jenkins-bot [Fri, 22 Dec 2017 20:39:09 +0000 (20:39 +0000)]
Merge "RCLFilters: support longer page names"
jenkins-bot [Fri, 22 Dec 2017 18:46:27 +0000 (18:46 +0000)]
Merge "resourceloader: Improve JavaScriptMinifier code coverage"
Timo Tijhof [Fri, 22 Dec 2017 17:47:21 +0000 (18:47 +0100)]
JavaScriptMinifier: Remove support for unused $statementsOnOwnLine flag
The $wgResourceLoaderMinifierStatementsOnOwnLine config var was deprecated
in MediaWiki 1.27. The parameter of minify() was not used by other code, and
no new usage has been introduced since then, either.
Remove the feature from JavaScriptMinifier, and add a release note for that.
The same 1.31 release notes also contain a note already about the removal
of the configuration variable.
The feature was not covered by unit tests.
The following private variables have been removed, that are no longer used
due to this change: $newlineBefore, $newlineAfter, $newlineAdded.
Change-Id: I2cbf271156c1954abb982531d0125b4b9573b12c
Stephane Bisson [Fri, 22 Dec 2017 17:13:12 +0000 (12:13 -0500)]
RCLFilters: support longer page names
* Make target page selector at least 400px wide
* Set the page name as title (tooltip)
Bug: T183484
Change-Id: Ife806c0b5e5c2ab6e9be32194804e89daaf8b71c
Moriel Schottlender [Fri, 22 Dec 2017 17:53:40 +0000 (09:53 -0800)]
RCFilters: Move product-specific rules into RCFilters styles
Afterwards, the fix in Vector skin should be merged:
Ie36eeddc46c8ea3d154a006fed2fe578be1cd05c
Change-Id: I8357ef2ff0fe4f46b9ee665ef068624de0afd2e5
Timo Tijhof [Fri, 22 Dec 2017 17:36:09 +0000 (18:36 +0100)]
resourceloader: Improve JavaScriptMinifier code coverage
Change-Id: I234b996cfec8ef48ce3dc48aabbdf88bc9439c15
addshore [Fri, 22 Dec 2017 16:39:00 +0000 (16:39 +0000)]
[MCR] Revision::newFromArchiveRow convert overrides for rows
This method used to overwrite attributes, then passed to
Revision::__construct
RevisionStore::newRevisionFromArchiveRow instead overrides row field
names
This patch adds a conversion for the one field that we need to care
about which is 'page' -> 'page_id'.
After looking through the usages in core and extensions it looks
like this will also fix a bug in the following classes which also
passes in 'page'.
- RevDelArchivedRevisionItem
- RevDelArchiveItem
Bug: T183564
Change-Id: I6a472b93663a0599abb55453c6939463ff56275d
jenkins-bot [Fri, 22 Dec 2017 14:50:04 +0000 (14:50 +0000)]
Merge "[MCR] Add and use $title param to RevisionStore getPrevious/Next"
addshore [Fri, 22 Dec 2017 14:25:12 +0000 (14:25 +0000)]
[MCR] Add and use $title param to RevisionStore getPrevious/Next
When the title is already known use it.
This is similar to the issue fixed in
I714ee391caac9bc56ce4c037967e424b44d9c2fe.
As of this patch all methods within RevisionStore
that call getTitle internally also have an option
to pass in an already known Title object.
Bug: T183548
Change-Id: Ieabca1cf157fb667c75fc907b9da2917f71c61b3
jenkins-bot [Fri, 22 Dec 2017 13:43:44 +0000 (13:43 +0000)]
Merge "Remove ESLint inline comments in WebdriverIO configuration files"
addshore [Fri, 22 Dec 2017 11:05:31 +0000 (11:05 +0000)]
[MCR] Add optional $title param to Revision byId methods
Bug: T183505
Change-Id: I714ee391caac9bc56ce4c037967e424b44d9c2fe
jenkins-bot [Fri, 22 Dec 2017 12:28:16 +0000 (12:28 +0000)]
Merge "Improve coverage of PageArchive"
Amir Sarabadani [Fri, 22 Dec 2017 11:00:13 +0000 (12:00 +0100)]
Improve coverage of PageArchive
Some minor tests
Change-Id: I5c455d6665febc20304e278828ddf8fb3cb5e709
jenkins-bot [Fri, 22 Dec 2017 11:50:15 +0000 (11:50 +0000)]
Merge "RCFilters: Create one single source of truth for item display"
jenkins-bot [Fri, 22 Dec 2017 11:33:27 +0000 (11:33 +0000)]
Merge "[WikiImporter::notice] use wfDebug instead of echo in notice()"
Fomafix [Fri, 22 Dec 2017 11:11:26 +0000 (12:11 +0100)]
jquery.tablesorter.less: Simplify by using less syntax
Change-Id: I4f7ee23c02c6ef0d39cb0135e6669f23b6977c59
Kunal Mehta [Fri, 22 Dec 2017 07:29:08 +0000 (23:29 -0800)]
RevisionTest: Fix @covers tags
Namespaced classes need to be absolutely named.
Change-Id: I48a4b356835e9edf3151a0c8d3bed08ea8cfb452
Kunal Mehta [Tue, 19 Dec 2017 06:01:02 +0000 (22:01 -0800)]
RevisionTest: Make @covers tags absolute (re-apply)
PHPUnit requires @covers tags to be absolute, they cannot depend
upon `use ...` statements.
Change-Id: I06efa94be3a814acbcb116162db162dcbf36432e
Yifei He [Fri, 22 Dec 2017 03:12:28 +0000 (11:12 +0800)]
[WikiImporter::notice] use wfDebug instead of echo in notice()
Make the default notice implementation of notice() function to
send the notice to wfDebug() instead of simply echo to prevent XSS
Bug: T177997
Change-Id: I9ffb597e0642afc1603cdd15e2d09c6f2584b448
jenkins-bot [Fri, 22 Dec 2017 03:07:33 +0000 (03:07 +0000)]
Merge "objectcache: fix getMultiWithUnionSetCallback() doc"
jenkins-bot [Fri, 22 Dec 2017 01:44:22 +0000 (01:44 +0000)]
Merge "shell: Add NO_LOCALSETTINGS restriction"
jenkins-bot [Fri, 22 Dec 2017 01:33:27 +0000 (01:33 +0000)]
Merge "shell: Add debug logging to find binaries that aren't being restricted"
jenkins-bot [Fri, 22 Dec 2017 01:33:23 +0000 (01:33 +0000)]
Merge "shell: Run firejail inside limit.sh, make NO_EXECVE work"
Moriel Schottlender [Tue, 19 Dec 2017 02:25:34 +0000 (18:25 -0800)]
RCFilters: Create one single source of truth for item display
Synchronize the search input, filter view and all view selection into
a single source of truth through the model.
- Stop using OO.ui.MenuSelectWidget's internal filtering logic, and
use our own filtering logic in the model instead.
- Add a concept of 'search' to the model, that is synchronized with
the current search term of the systme. The search dictates the view
and the visible items in the filters.
-- Whenever the search changes for whatever reason,
the model automatically updates the visibility of all items and
groups in the filter list.
-- This means that after changing view or search, the widgets can
always trust that they have the most updated visible item list
to scroll to or select.
- Make the view model's findMatches
as the ultimate source of truth as to what should be visible.
The items are now **always** all included in the menu, but they
change their visibility according to the logic in the findMatches.
If there is a search term, the function will account for that and
the selected view, so we can be sure that search results also
change between changing views.
This allows us to simplify the operation of selecting a tag, where
we know that the order of operation is bound to switching the views,
that will also show us the relevant results. We can bind to the display
event and properly select -- and scroll to -- the item.
Bug: T182720
Bug: T178540
Change-Id: If575f348705d863b9d68d19761ded55a4d453550
addshore [Thu, 14 Dec 2017 23:14:14 +0000 (23:14 +0000)]
[MCR] Use RevisionStore::getArchiveQueryInfo in PageArchive
This is needed to allow RevisionStore to be switched to an
alternative database schema for MCR.
Bug: T174026
Bug: T183509
Change-Id: I51318cb102f6fb8962e608196bee96bde023bcff
addshore [Thu, 21 Dec 2017 14:33:28 +0000 (14:33 +0000)]
[MCR] Add @covers tag for PageArchive::undeleteRevisions
Change-Id: I8dd19244e29f05e22aa5014ec6d6182b5917cc3c
jenkins-bot [Thu, 21 Dec 2017 22:10:35 +0000 (22:10 +0000)]
Merge "[MCR] Add test for PageArchive::listRevisions"
addshore [Thu, 21 Dec 2017 21:18:07 +0000 (21:18 +0000)]
[MCR] Fix RevisionInsertComplete Revision pass by reference
This was broken in:
6af796f3e0cf3e66cd7d7e59af8445f5712d68fe
Ia4c20a91e98df0b9b14b138eb4825c55e5200384
https://gerrit.wikimedia.org/r/#/c/399174/7
Bug: T183503
Change-Id: I674493507ca4aa6677a3bab7a01d6dc3c2cdbc5b
Translation updater bot [Thu, 21 Dec 2017 20:57:18 +0000 (21:57 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Iaad62f37560b8d965c81d72158dbcf5335babdd8
jenkins-bot [Thu, 21 Dec 2017 19:01:05 +0000 (19:01 +0000)]
Merge "ApiBlock: Improve username validation"
jenkins-bot [Thu, 21 Dec 2017 18:40:21 +0000 (18:40 +0000)]
Merge "MCR: Deprecate and gut Revision class"
jenkins-bot [Thu, 21 Dec 2017 18:26:09 +0000 (18:26 +0000)]
Merge "RecentChangesLinked: Include title without subpage in form"
daniel [Thu, 31 Aug 2017 18:41:04 +0000 (20:41 +0200)]
MCR: Deprecate and gut Revision class
This is a re-submission of I4f24e7fbb68.
As a first major step towards Multi-Content-Revisions (MCR),
this patch turns the Revision class into a legacy proxy for
the new RevisionRecord and RevisionStore classes.
Backwards compatibility is maintained for all but some
rare edge cases, like constructing a completely empty
Revision object.
For more information on MCR, see
<https://www.mediawiki.org/wiki/Requests_for_comment/Multi-Content_Revisions>.
NOTE: once this is merged, verify create/delete/restore cycle on beta,
ideally with emulated replication lag.
Bug: T174025
Change-Id: Ia4c20a91e98df0b9b14b138eb4825c55e5200384
addshore [Thu, 21 Dec 2017 14:33:03 +0000 (14:33 +0000)]
[MCR] Add test for PageArchive::listRevisions
Change-Id: If4ab58cd889e7166142a9f9a28fc81d776a7db3f
Željko Filipin [Thu, 21 Dec 2017 16:28:58 +0000 (17:28 +0100)]
Remove ESLint inline comments in WebdriverIO configuration files
Comments are not needed. ESLint has configuration file(s).
Bug: T175179
Change-Id: Ieafd7b5666faaccb73b8ef7daa7aef3ed4114662
Stephane Bisson [Thu, 21 Dec 2017 14:38:21 +0000 (09:38 -0500)]
RecentChangesLinked: Include title without subpage in form
When the 'title' hidden field contains the subpage, the 'target'
input field is never taken into account since the subpage always
takes precedence in ChangesListSpecialPage->setup()
I75cfb2b56a4da6357e6117b3f34f3178bfb2c90c introduced
SpecialRecentChangesLinked->getPageTitle which overrides
SpecialPage->getPageTitle to include the subpage by default.
This helped with redirecting to the right page when parsing
a saved query on the server but changed the behavior everywhere
that function was used in the context of RCL. That includes
SpecialRecentChanges.php:545 where the option form is built.
Bug: T183437
Change-Id: Id39d1887719ecb6900b25fefbb133dff9c4d0456
Stephane Bisson [Thu, 21 Dec 2017 15:04:33 +0000 (10:04 -0500)]
RCFilters: Query using current (not default) sticky parameters values
For some sticky parameters, defaults are synchronized to current
using Item to Group event, but it only happens for some specific
group types.
That should be cleaned up, but regardless, there is no reason
to query using the default values. Current values are what matters.
Bug: T183438
Change-Id: I527b38ea7f91f70231ed74723212e493e9cce9e5
jenkins-bot [Thu, 21 Dec 2017 13:39:38 +0000 (13:39 +0000)]
Merge "Fix typo"
Roan Kattouw [Thu, 21 Dec 2017 11:59:53 +0000 (12:59 +0100)]
Follow-up
e213462f7c61c: fix typo ("constriant" -> "constraint")
Change-Id: I6e1fd74e387af5a913301bf296fe9f6da0dd1837
Fomafix [Thu, 21 Dec 2017 11:53:54 +0000 (12:53 +0100)]
Fix typo
Change-Id: I56e762d0d565e36530a5dc7a7ad0aa7cb66531b8
daniel [Wed, 20 Dec 2017 18:37:13 +0000 (19:37 +0100)]
Test for writes being prevented on replica connections.
Bug: T183265
Change-Id: I319efa418cf8a46985f6faa60096559efa15d267
Nikerabbit [Thu, 21 Dec 2017 07:27:17 +0000 (07:27 +0000)]
Merge "Add tags for undo edits"
jenkins-bot [Wed, 20 Dec 2017 22:32:24 +0000 (22:32 +0000)]
Merge "Simplify logic to prevent writes on replica DB connections"
Aaron Schulz [Wed, 20 Dec 2017 22:24:43 +0000 (14:24 -0800)]
objectcache: fix getMultiWithUnionSetCallback() doc
Change-Id: I5700ff8ccbe2ef3aa6730e20bdc17314bceade42
Translation updater bot [Wed, 20 Dec 2017 21:56:21 +0000 (22:56 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ibf7138a1acb001da968e74c7cc24333188c675ae
Aaron Schulz [Wed, 20 Dec 2017 12:31:07 +0000 (04:31 -0800)]
Simplify logic to prevent writes on replica DB connections
This reverts most of
36f4daf32c591d6b7e2435629fc6e431398b641a.
Change-Id: Ie8205749b14be186e80296b168c32310c10ce875
jenkins-bot [Wed, 20 Dec 2017 20:47:08 +0000 (20:47 +0000)]
Merge "Fix old style filters disappearing regression"
jenkins-bot [Wed, 20 Dec 2017 19:08:02 +0000 (19:08 +0000)]
Merge "RCFilters: Don't load JS or redirect when transcluding"
petarpetkovic [Wed, 20 Dec 2017 17:50:03 +0000 (18:50 +0100)]
Fix old style filters disappearing regression
Add FormWrapperWidget after controller is initialized, to avoid it
being removed when changes list view model is updated during
initialization.
Change-Id: I3bd4d1bc9efbcdbf99493498267ed1a690fd1ab2
jenkins-bot [Wed, 20 Dec 2017 16:38:05 +0000 (16:38 +0000)]
Merge "Provide an appropriate comment"
jenkins-bot [Wed, 20 Dec 2017 16:29:40 +0000 (16:29 +0000)]
Merge "objectcache: add another example case to WANObjectCache::getWithSetCallback()"
Roan Kattouw [Wed, 20 Dec 2017 14:25:35 +0000 (15:25 +0100)]
Follow-up
36f4daf32c: allow no-write database connections to use transactions
After
36f4daf32c was merged, Aaron pointed out on Gerrit that:
Transaction can be used on replicas for REPEATABLE-READ mode, so
queries in that transaction see the same version of the DB. Those
do not involve writes and things would probably break sometimes
without it (like reads following foreign keys and reference in
separate queries).
So allow no-write connections to call begin() and commit(), and only
throw an exception when a write query is attempted.
Bug: T183265
Change-Id: I138677a714df13ead08061c3e9ef794c3befbe9d
jenkins-bot [Wed, 20 Dec 2017 01:25:05 +0000 (01:25 +0000)]
Merge "Standardize editfont size across browsers/OSes"
jenkins-bot [Tue, 19 Dec 2017 23:18:47 +0000 (23:18 +0000)]
Merge "Remove empty RevisionRecordTest"
Volker E [Wed, 27 Sep 2017 22:39:32 +0000 (00:39 +0200)]
Unify monospace font family stack
Bug: T176636
Change-Id: I28d490a6c1decb68fce20307cc58678c9fe64ecc
Ed Sanders [Thu, 7 Dec 2017 13:24:09 +0000 (13:24 +0000)]
Standardize editfont size across browsers/OSes
Bug: T176636
Bug: T181324
Bug: T182320
Change-Id: I836a05674723ae0864372f8d0e32c7b430906a92
Translation updater bot [Tue, 19 Dec 2017 21:01:09 +0000 (22:01 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ia4bc5f0583c9f8d5d3d1868d6e5f85d2e41afcbf
Bartosz Dziewoński [Tue, 19 Dec 2017 18:48:05 +0000 (19:48 +0100)]
mw.Feedback: Remove weird unnecessary switch statements
They made sense prior to
7196fafcdcbe658caf9ffde508717714b9cf4510,
but no longer do since the success and error handling are in different
functions. I probably should have removed them in that commit.
Change-Id: I1167dc1b5a79eadfe607abfc73bd2f0e95194b78
addshore [Tue, 19 Dec 2017 17:50:03 +0000 (17:50 +0000)]
Remove empty RevisionRecordTest
Bug: T183219
Change-Id: Ic58308da4a54186995a2d985b40e0bbf86b8cef3
Volker E [Tue, 19 Dec 2017 17:27:56 +0000 (09:27 -0800)]
Provide an appropriate comment
Let's stay with blue (`#36c`) for something called blue.
Change-Id: I1ebb0909d491f1ecf4d1e5733e7ac6589d28c731
jenkins-bot [Tue, 19 Dec 2017 16:44:46 +0000 (16:44 +0000)]
Merge "Prevent write operations to database replicas."
daniel [Tue, 19 Dec 2017 16:11:08 +0000 (17:11 +0100)]
Prevent write operations to database replicas.
Bug: T183265
Change-Id: I8e17644d1b447416adee18e42cf0122b52a80b22
jenkins-bot [Tue, 19 Dec 2017 15:45:06 +0000 (15:45 +0000)]
Merge "Trigger name changes"
freakolowsky [Fri, 15 Dec 2017 12:47:27 +0000 (13:47 +0100)]
Trigger name changes
Modifid the names as described in the task/bug.
Additionally found and added two missing permissions in user.sql, and
fixed an unrelated error to make the schema function.
Bug: T182981
Change-Id: Ia213c0e6b6759a950cdee4181d9c5695e3c5da4a
jenkins-bot [Tue, 19 Dec 2017 15:06:02 +0000 (15:06 +0000)]
Merge "[MCR] Fix SqlBlobStore using DB_REPLICA for writes"
Brad Jorsch [Tue, 19 Dec 2017 14:56:16 +0000 (09:56 -0500)]
ApiBlock: Improve username validation
The current username validation lets any invalid username through, on
the assumption that it's an IP address. We can do better: call the
backend to get the actual type and target, and reject anything with
TYPE_USER where the actual input name is invalid (regardless of
underlying mangling for stuff like T31797).
Bug: T183211
Change-Id: I676642eee1222447df22a1c32b24f55e6273bcec
addshore [Tue, 19 Dec 2017 14:58:06 +0000 (14:58 +0000)]
[MCR] Fix SqlBlobStore using DB_REPLICA for writes
Bug: T183242
Bug: T183245
Bug: T183252
Change-Id: Ic0b9910b5de5ce6817d6a4a3e5e32103e2113926
jenkins-bot [Tue, 19 Dec 2017 13:10:53 +0000 (13:10 +0000)]
Merge "Revert "[MCR] Turn Revision into a proxy to new code.""
jenkins-bot [Tue, 19 Dec 2017 12:44:42 +0000 (12:44 +0000)]
Merge "Add HEBREW POINT METEG to the Hebrew special characters"
Daniel Kinzler [Tue, 19 Dec 2017 10:42:34 +0000 (10:42 +0000)]
Revert "[MCR] Turn Revision into a proxy to new code."
This reverts commit
9dcc56b3c9e7a3212d0900ee23808b9402cad952.
With this patch applied, newly created revisions are sometimes not found
just after submitting an edit, until replicas have caught up.
Our best theory is that it somehow interfere with ChronologyProtector,
but we don't have a good idea how.
Also, as legoktm mentioned, the commit message is terrible and needs fixing.
Change-Id: Idf3404f3fa8f8d08a7fb2ab8268726e2c1edecfe
jenkins-bot [Tue, 19 Dec 2017 12:34:59 +0000 (12:34 +0000)]
Merge "RCLFilters: make target and to/from parameters sticky again"
jenkins-bot [Tue, 19 Dec 2017 12:21:59 +0000 (12:21 +0000)]
Merge "Require indentation of CASE statements in PHP code"
Stephane Bisson [Tue, 19 Dec 2017 12:03:26 +0000 (07:03 -0500)]
RCLFilters: make target and to/from parameters sticky again
Regression from Id0bf89ce397ff8a54ce0a30d1ba7d8f9bbdd14a3
Change-Id: Ied7a73b662266eb1ea0c085e5b9c88df0de7e2f6
Amire80 [Tue, 19 Dec 2017 09:52:47 +0000 (11:52 +0200)]
Add HEBREW POINT METEG to the Hebrew special characters
It's very common in the Bible, and in many other books for indicating stress.
Change-Id: I4a564df82398b15ea4ec9c0a67f119c7ef1bdf95