jan [Mon, 22 Oct 2012 09:00:15 +0000 (11:00 +0200)]
(bug 24620) Add types to LogFormatter
This change adds types to LogFormatter like "msg" so log values
(paramaters for the log message) can be formated as e.g. a message in
user or content language.
If you want to add another type feel free to suggest it in your review.
Change-Id: I6a56c2041bcbce292cff485e706db02305aab01c
Siebrand [Sun, 9 Dec 2012 23:42:34 +0000 (23:42 +0000)]
Merge "(Bug 38439) Attempt on fixing the suicidal LangObjCache"
jenkins-bot [Sun, 9 Dec 2012 23:28:47 +0000 (23:28 +0000)]
Merge "Genderize Special:Preferences"
Translation updater bot [Sun, 9 Dec 2012 20:06:59 +0000 (20:06 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Id7a882a6e7c4915b47594fdcb3afaada84e2f2a6
jenkins-bot [Sun, 9 Dec 2012 19:54:08 +0000 (19:54 +0000)]
Merge "Set wgWellFormedXml for LinkerTest::testUserLink"
jenkins-bot [Sun, 9 Dec 2012 16:35:19 +0000 (16:35 +0000)]
Merge "Set wgHtml5/wgWellFormedXml for XmlTests"
umherirrender [Sun, 9 Dec 2012 10:56:45 +0000 (11:56 +0100)]
Set wgWellFormedXml for LinkerTest::testUserLink
Change-Id: I9ab370e2f23e0134741680ff620e8bb552496868
umherirrender [Sun, 9 Dec 2012 10:47:03 +0000 (11:47 +0100)]
Set wgHtml5/wgWellFormedXml for XmlTests
Change-Id: I3cab843bad9461098cf3c6b574fb767c3267ab14
umherirrender [Sun, 9 Dec 2012 10:03:03 +0000 (11:03 +0100)]
Fix SanitizerTest for wikis with wgUseTidy = true;
testRemovehtmltagsOnHtml5Tags needs wgUseTidy = false;
3) SanitizerTest::testRemovehtmltagsOnHtml5Tags with data set #2
('time', false)
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<time></time>
-'
+'<time>'
Change-Id: Ib7e156293e2efae053b055e40393e442719eb5bd
IAlex [Sun, 9 Dec 2012 09:52:05 +0000 (09:52 +0000)]
Merge "ParserOutput::addLanguageLink needs a string"
IAlex [Sun, 9 Dec 2012 09:48:40 +0000 (09:48 +0000)]
Merge "Tidy up some unbalanced returns in methods"
IAlex [Sun, 9 Dec 2012 09:39:12 +0000 (09:39 +0000)]
Merge "Remove static method from interface"
IAlex [Sun, 9 Dec 2012 09:37:32 +0000 (09:37 +0000)]
Merge "Adding missing @group Database to unit tests"
jenkins-bot [Sun, 9 Dec 2012 09:30:10 +0000 (09:30 +0000)]
Merge "Remove unreachable lines"
umherirrender [Sun, 9 Dec 2012 09:27:56 +0000 (10:27 +0100)]
Adding missing @group Database to unit tests
Reasons:
* Signature parsing
* GenderCache
* Using TestUser class (inside ApiTestCase)
Change-Id: Iea4e9f9cafaa3afe7da8b922644061d3d575afe3
jenkins-bot [Sun, 9 Dec 2012 09:25:33 +0000 (09:25 +0000)]
Merge "[JobQueue] Make doIsEmpty return bool in all cases."
Reedy [Sun, 9 Dec 2012 02:40:33 +0000 (02:40 +0000)]
[JobQueue] Make doIsEmpty return bool in all cases.
Change-Id: Ic42f426ef3d13bd0726955fe29b7e7c3d0cae152
IAlex [Sun, 9 Dec 2012 07:52:43 +0000 (07:52 +0000)]
Merge "Add numerous missing @throws to method documentation"
IAlex [Sun, 9 Dec 2012 07:44:43 +0000 (07:44 +0000)]
Merge "Fixup a couple of uses of return values of functions that return void"
Reedy [Sun, 9 Dec 2012 03:16:14 +0000 (03:16 +0000)]
Fixup a couple of uses of return values of functions that return void
Change-Id: I7c8f08c5b436cb3209fd98b9479a50abe223cccc
Reedy [Sun, 9 Dec 2012 03:09:48 +0000 (03:09 +0000)]
Add numerous missing @throws to method documentation
Change-Id: Iba868e82a75fef7c7d011bc5be192bf059d037c0
Reedy [Sun, 9 Dec 2012 02:59:04 +0000 (02:59 +0000)]
Tidy up some unbalanced returns in methods
Leave a TODO
Change-Id: Ic49ac8630650b341aafb3c17abd22f3a07805d27
Reedy [Sun, 9 Dec 2012 02:37:10 +0000 (02:37 +0000)]
Remove unreachable lines
Change-Id: Ie7ec14f4ce65bc87b0cd49ec9266c394770ee7c4
Reedy [Sun, 9 Dec 2012 02:33:51 +0000 (02:33 +0000)]
Move insertUpdateRow call before return applyPatch to make it reachable
This might not be quite right... We might want to cache the result of apply patch, insert the row and then return the result...
Change-Id: Ie6a1bb16d2912ad43aa8fd45b2bf10a8bf8652ae
daniel [Sat, 8 Dec 2012 21:09:30 +0000 (22:09 +0100)]
Fix condition for the entries with a null model.
A null model means ‘guess from page name’.
Change-Id: I63e80761e46cc7707e9c862e2e50a950c1766aa4
Platonides [Sat, 8 Dec 2012 21:04:50 +0000 (22:04 +0100)]
The error message should refer to $wgContentHandlerUseDB
Change-Id: I81bc50e6949cecdc7f3d7e0b89f54464b4a146c7
jenkins-bot [Sat, 8 Dec 2012 18:54:01 +0000 (18:54 +0000)]
Merge "Remove broken test."
jeroendedauw [Fri, 7 Dec 2012 18:42:13 +0000 (19:42 +0100)]
Remove broken test.
Calling the method does not raise an exception but a notice (depending on settings).
PHPUnit just happens to turn this into an exception. The test thus breaks if PHPUnit
does not do this, which apparently happens in some cases and caused bug 41491
Change-Id: I9d14fd875c70c8b3d164c0b8a4fa2667c5769682
IAlex [Sat, 8 Dec 2012 15:08:46 +0000 (15:08 +0000)]
Merge "prefix debug log when they end up in the main log"
IAlex [Sat, 8 Dec 2012 14:44:43 +0000 (14:44 +0000)]
Merge "(bug 38897) Fix unhandled exception when visiting e.g. MediaWiki:Somemessage/0"
IAlex [Sat, 8 Dec 2012 14:40:55 +0000 (14:40 +0000)]
Merge "Replace deprecated Title::userIsWatching()"
IAlex [Sat, 8 Dec 2012 14:37:31 +0000 (14:37 +0000)]
Merge "worthwhile tests in testTitleObjectStringConversion"
IAlex [Sat, 8 Dec 2012 14:20:27 +0000 (14:20 +0000)]
Merge "Memory setting for djvutext is now a constant"
IAlex [Sat, 8 Dec 2012 14:13:04 +0000 (14:13 +0000)]
Merge "Use MWNamespace method instead of binary arithmetic"
jenkins-bot [Sat, 8 Dec 2012 13:54:26 +0000 (13:54 +0000)]
Merge "Allow SQL queries with long field list to wrap"
jenkins-bot [Sat, 8 Dec 2012 13:16:31 +0000 (13:16 +0000)]
Merge "mediawiki.Uri.test: Clean up"
jenkins-bot [Sat, 8 Dec 2012 12:47:07 +0000 (12:47 +0000)]
Merge "(bug 40585) Don't drop 'step="any"' in HTML input fields."
Niklas Laxström [Sat, 8 Dec 2012 12:12:34 +0000 (12:12 +0000)]
Allow SQL queries with long field list to wrap
Change-Id: I7ed64a246455a7f2c48e7e120d45d1ebeb929584
umherirrender [Sat, 8 Dec 2012 11:09:15 +0000 (12:09 +0100)]
Use MWNamespace method instead of binary arithmetic
"& ~1" or "| 1" are not easy to read
Change-Id: I08ff92669d32f3663ea58e98d8c49f0a54dfeca4
Dereckson [Fri, 7 Dec 2012 21:00:41 +0000 (22:00 +0100)]
Memory setting for djvutext is now a constant
This is a follow-up for change Ia735e1b7.
See also bug 42466.
Change-Id: I67d8ae9000713c349c7506e9a77d350c89992400
Bsitu [Fri, 7 Dec 2012 22:40:26 +0000 (22:40 +0000)]
Merge "Adding fragment support to SpecialPage::getTitleFor()"
Timo Tijhof [Sun, 2 Dec 2012 04:23:08 +0000 (05:23 +0100)]
mediawiki.Uri.test: Clean up
* Grouped assertions together by logical test unit (method names).
* Re-ordered (constructor, properties, methods, special cases).
Change-Id: Ia8de947278cdf469859062af47e1333c7a9f827b
jenkins-bot [Fri, 7 Dec 2012 22:13:00 +0000 (22:13 +0000)]
Merge "hideDeprecated( 'CategoryPage::getAutosummary' )"
Translation updater bot [Fri, 7 Dec 2012 22:01:49 +0000 (22:01 +0000)]
Merge "Localisation updates from translatewiki.net."
Nikerabbit [Fri, 7 Dec 2012 21:55:33 +0000 (21:55 +0000)]
Merge "parse argument for message 'ago' in MWTimestamp::getHumanTimestamp"
Platonides [Fri, 7 Dec 2012 21:43:02 +0000 (22:43 +0100)]
hideDeprecated( 'CategoryPage::getAutosummary' )
check-vars correctly detects the call to CategoryPage::getAutosummary as
deprecated by coming from Article::getAutosummary but needs an explicit
hideDeprecated() to not complain about it.
Change-Id: I8a51a3041cc4cab592c5e37862efb69b538821a0
Translation updater bot [Fri, 7 Dec 2012 21:35:35 +0000 (21:35 +0000)]
Localisation updates from translatewiki.net.
Change-Id: Ieb8805eb3bdd1dfadbcacb1ef86a51610e1155f8
jenkins-bot [Fri, 7 Dec 2012 21:32:31 +0000 (21:32 +0000)]
Merge "Preferences: Use explicit string as returnto param"
Platonides [Fri, 7 Dec 2012 19:30:45 +0000 (20:30 +0100)]
Use JobQueueGroup::singleton()
Replaces usages of the deprecated pop() and insert()/insertBatch()
methods of Job class.
Change-Id: I5572c9e31a14bd660d7e3b9aa7792d0be9a26103
Tim Landscheidt [Thu, 29 Nov 2012 12:12:35 +0000 (12:12 +0000)]
(bug 40585) Don't drop 'step="any"' in HTML input fields.
The default value for "step" is "1" which effectively bans any decimal
number from being entered into an 'type="number"' field and makes
HTMLFloatField unusable.
Change-Id: I103fd4047814a7fb0dfdc174f36badd5b660b7a4
Platonides [Fri, 7 Dec 2012 18:33:34 +0000 (19:33 +0100)]
Replace deprecated Title::userIsWatching()
Change-Id: I74203e4ed51be6fe72414d1a0b95b8370aaf0720
Max Semenik [Thu, 22 Nov 2012 00:39:54 +0000 (04:39 +0400)]
(bug 38897) Fix unhandled exception when visiting e.g. MediaWiki:Somemessage/0
Change-Id: I9876e4fb21c2a1a3a0a14bff05633c7aef6a3fd3
jenkins-bot [Fri, 7 Dec 2012 17:57:15 +0000 (17:57 +0000)]
Merge "Remove code duplication"
jenkins-bot [Fri, 7 Dec 2012 17:55:39 +0000 (17:55 +0000)]
Merge "Leave some FIXME comments for Bug 36911 - Division by zero"
jenkins-bot [Fri, 7 Dec 2012 17:49:41 +0000 (17:49 +0000)]
Merge "Add the required call to the parent setUp to DiffHistoryBlobTest::setUp()"
jenkins-bot [Fri, 7 Dec 2012 17:40:48 +0000 (17:40 +0000)]
Merge "Fix method declaration in UploadFromStash"
jenkins-bot [Fri, 7 Dec 2012 17:29:14 +0000 (17:29 +0000)]
Merge "Make sure MaintenanceFixup's shutdown is simulated"
umherirrender [Fri, 7 Dec 2012 16:41:00 +0000 (17:41 +0100)]
Preferences: Use explicit string as returnto param
Change-Id: I783ced55d5f811d55b4c26300890a386bcf55da1
jenkins-bot [Fri, 7 Dec 2012 16:16:40 +0000 (16:16 +0000)]
Merge "Reset $mConvRuleTitle before every language conversion run"
Brad Jorsch [Fri, 7 Dec 2012 16:08:15 +0000 (11:08 -0500)]
Make sure MaintenanceFixup's shutdown is simulated
Previously, MaintenanceTest created a MaintenanceFixup in setUp and
relied on each test to call MaintenanceFixup's simulateShutdown instead
of making sure this was called in tearDown. Change Iee1261e7 broke this
by introducing a meta-test in a parent class.
Fixing that also allows us to not have to special-case failed tests.
Change-Id: I67c8615dd94734bb55ca48aac0c66298accbe0b4
Platonides [Fri, 7 Dec 2012 15:54:23 +0000 (15:54 +0000)]
Merge "Also pass $doxygenInputFilter as parameter instead of global."
Antoine Musso [Fri, 7 Dec 2012 15:50:58 +0000 (16:50 +0100)]
prefix debug log when they end up in the main log
Whenever we use wfDebugLog( "group", "message" ); and "group" is not
also set in $wfDebugLogGroups, the group information is lost. By
prefixing the message with the group name, it makes it obvious where the
message comes from.
Example output:
...
[EventLogging] wgEventLoggingSchemaIndexUri has not been configured.
[EventLogging] EventLogging requires memcached, and no memcached[...]
Fully initialised
Profiler::instance called without $wgProfiler['class'] set[...]
Connected to database 0 at
MessageGroups::init-nocache
SQL ERROR (ignored): no such table: revtag_type
MessageGroups::loadGroupDefinitions-end
[ContentHandler] Created handler for wikitext: WikitextContentHandler
[ContentHandler] Created handler for javascript: JavaScriptContentHandler
...
Change-Id: Id75401bec516b5111cd1e3d4a9b29843953ce12b
Liangent [Tue, 25 Sep 2012 17:45:54 +0000 (01:45 +0800)]
Reset $mConvRuleTitle before every language conversion run
When conversion is run more than once, and manual title conversion is
only used in some of them, the result of title conversion is incorrectly
applied to all output after where it's really used.
In the past nothing has been broken because the converter is run for at
most one page (so at most one page title) in one request but this is not
true anymore when parser tests come.
Change-Id: Id689feaeff93acb859f7ba8d2aec0d7dbb5d1b6c
Antoine Musso [Fri, 7 Dec 2012 15:39:39 +0000 (16:39 +0100)]
worthwhile tests in testTitleObjectStringConversion
The previous tests were not reflecting their comment, I have tweaked the
assertions a bit to actually test something that reflect the comments.
Change-Id: Ie1764ee1a218ead0169958704ba8625ab8d56445
Demon [Fri, 7 Dec 2012 12:37:11 +0000 (12:37 +0000)]
Merge "[JobQueue] Added __METHOD__ to delete() call."
umherirrender [Fri, 7 Dec 2012 11:33:47 +0000 (12:33 +0100)]
ParserOutput::addLanguageLink needs a string
The Parser passed a string, not a Title object to that method, doing
this in the test also
Change-Id: I05d195c1dc3cd2366795334f81601007240d9f33
umherirrender [Fri, 7 Dec 2012 11:28:17 +0000 (12:28 +0100)]
parse argument for message 'ago' in MWTimestamp::getHumanTimestamp
Change-Id: I8ec8052f949313f5a3bcef2b9e668d139d7cbf6d
Hashar [Fri, 7 Dec 2012 10:51:16 +0000 (10:51 +0000)]
Merge changes Ic85d486d,I95bfb886
* changes:
Rename JavascriptContentTest to JavaScriptContentTest
Use the canonical class name: s/JavascriptContent/JavaScriptContent/
Hashar [Fri, 7 Dec 2012 10:43:28 +0000 (10:43 +0000)]
Merge "(bug 42226) failure in sites tests"
jeroendedauw [Thu, 6 Dec 2012 22:34:23 +0000 (23:34 +0100)]
(bug 42226) failure in sites tests
MediaWikiSiteTest::testRemove got a duplicate key error.
Change-Id: I7a40fe50b757e4162b7ccf1655d872cbd2c51f5d
umherirrender [Fri, 7 Dec 2012 08:18:41 +0000 (09:18 +0100)]
Fix method declaration in UploadFromStash
1) UploadStashTest::testValidRequest
Declaration of UploadFromStash::stashFile() should be compatible with
that of UploadBase::stashFile()
Change-Id: If94ab8b718e23b50a1b67ba0fac3ea24926d5950
Kaldari [Fri, 7 Dec 2012 05:14:01 +0000 (05:14 +0000)]
Merge "[JobQueue] Added a sanity check to catch ack() breakage."
Aaron Schulz [Fri, 7 Dec 2012 03:30:25 +0000 (19:30 -0800)]
[JobQueue] Added a sanity check to catch ack() breakage.
* Also make sure the "id" field is set even if broken
subclasses do not set it as the base class does.
Change-Id: I2f617187e225df6c1b02b4062c835cd6581c5d99
Reedy [Fri, 7 Dec 2012 01:11:38 +0000 (01:11 +0000)]
Remove code duplication
Remove trailing whitespace
Change-Id: I31b381c45ccc1631bd17c4d62a1cc1985a4770ba
Brion VIBBER [Fri, 7 Dec 2012 00:08:20 +0000 (00:08 +0000)]
Merge "[FileBackend] Removed obsolete "allowStale" parameter."
Reedy [Thu, 6 Dec 2012 23:59:18 +0000 (23:59 +0000)]
Leave some FIXME comments for Bug 36911 - Division by zero
Change-Id: I994c482cad1d195cf29d18f7ccf1d8816b1e7330
Aaron Schulz [Thu, 6 Dec 2012 23:41:31 +0000 (15:41 -0800)]
[JobQueue] Added __METHOD__ to delete() call.
Change-Id: If2644e2d0ef12b6ad68b7229f1e60a3d50fc139d
Hashar [Thu, 6 Dec 2012 23:19:01 +0000 (23:19 +0000)]
Merge "Register WikitextContentTest in the test autoloader."
Hashar [Thu, 6 Dec 2012 23:16:18 +0000 (23:16 +0000)]
Merge "Add missing wfProfileOut()"
Demon [Thu, 6 Dec 2012 22:45:30 +0000 (22:45 +0000)]
Merge "[JobQueue] Reduced the change of deadlocks in recycleStaleJobs()."
Platonides [Thu, 6 Dec 2012 22:29:44 +0000 (23:29 +0100)]
Also pass $doxygenInputFilter as parameter instead of global.
Change-Id: I63fa0125576c4694f63d271f9824d783869f25d1
Platonides [Thu, 6 Dec 2012 22:13:10 +0000 (23:13 +0100)]
Rename JavascriptContentTest to JavaScriptContentTest
Better match the original class name.
Change-Id: Ic85d486d55c2bc58189e5d5b411d296e872fc577
Platonides [Thu, 6 Dec 2012 22:11:16 +0000 (23:11 +0100)]
Use the canonical class name: s/JavascriptContent/JavaScriptContent/
Change-Id: I95bfb8860f77d01bad027d1c2baf2d871e093758
Platonides [Thu, 6 Dec 2012 22:03:25 +0000 (23:03 +0100)]
Add missing wfProfileOut()
Change-Id: Id9c4958aa6659d66bb3486d17186424fbd9b5758
Platonides [Thu, 6 Dec 2012 21:58:51 +0000 (22:58 +0100)]
Register WikitextContentTest in the test autoloader.
Change-Id: I3c3b0fab9850196b0aad7c0bee06c4ca0b8e2fc6
umherirrender [Thu, 6 Dec 2012 16:57:37 +0000 (17:57 +0100)]
Add parent::setUp() to DatabaseSQLTest
1) DatabaseSQLTest::testMediaWikiTestCaseParentSetupCalled
DatabaseSQLTest::setUp() must call parent::setUp()
Failed asserting that an array has the key 'setUp'.
Change-Id: I6aa5cb09999e0cee9b36fedd9193cb5aa08914ad
Aaron Schulz [Thu, 6 Dec 2012 21:02:34 +0000 (13:02 -0800)]
[JobQueue] Reduced the change of deadlocks in recycleStaleJobs().
* Do the DELETE by primary key to avoid gap locks. This should cut
down on deadlocks, though their frequency is still fairly modest.
* Also use GET_LOCK() to assure that two processes are not doing this
update at the same time.
Change-Id: Ic3de3b7cb3acd5294a151b4a00bfed65c33d0f1e
Pavel Selitskas [Sun, 2 Dec 2012 21:31:30 +0000 (00:31 +0300)]
Genderize Special:Preferences
GENDER support added for messages:
* username
* uid
* prefs-memberingroups
These messages require GENDER for grammatically correct sentences
at least in some Slavic languages. Perhaps, other languages may
require its support in other messages as well (e.g. yourrealname).
+ Some refactoring per review request.
Change-Id: I51cc8ea9128dda90d87de656ea3a4605a5dc04e0
Translation updater bot [Thu, 6 Dec 2012 20:18:31 +0000 (20:18 +0000)]
Merge "Localisation updates from translatewiki.net."
Translation updater bot [Thu, 6 Dec 2012 20:04:03 +0000 (20:04 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I857041254a52acb1ba791211048840168c120384
Aaron Schulz [Thu, 6 Dec 2012 20:03:40 +0000 (20:03 +0000)]
Merge "Purge videos from squid on action=purge"
Reedy [Thu, 6 Dec 2012 19:58:22 +0000 (19:58 +0000)]
Merge "(bug 42466) Allow djvutxt to use more memory"
Jan Gerber [Tue, 27 Nov 2012 05:41:56 +0000 (05:41 +0000)]
Purge videos from squid on action=purge
While we don't want to re-encode videos on purge, they should still
be removed from squid; compute the list of all urls before extensions
can filter it to remove files that should not be deleted from the
file backend.
Change-Id: Id837843b5a203e49a8594439ce3620da9b3c7b6a
Demon [Thu, 6 Dec 2012 18:50:41 +0000 (18:50 +0000)]
Merge "[Upload] Added async upload concatenation support."
Hashar [Thu, 6 Dec 2012 18:38:29 +0000 (18:38 +0000)]
Merge "LinkerTest needs to set the wiki language to en."
Platonides [Thu, 6 Dec 2012 17:53:43 +0000 (18:53 +0100)]
LinkerTest needs to set the wiki language to en.
The localisation of Special:Contributions break the
testUserLink otherwise.
Change-Id: I25a40356a96e03975d8ceca975449f7b064bca2b
Aaron Schulz [Thu, 6 Dec 2012 17:38:21 +0000 (17:38 +0000)]
Merge "While testing, turn off DataBase::ignoreErrors."
Platonides [Thu, 6 Dec 2012 16:22:18 +0000 (17:22 +0100)]
Add the required call to the parent setUp to DiffHistoryBlobTest::setUp()
Change-Id: I598064cc7690f8dcc2fc5ef7a5d7c75935566d26
DiffHistoryBlobTest::testMediaWikiTestCaseParentSetupCalled
DiffHistoryBlobTest::setUp() must call parent::setUp()
Catrope [Thu, 6 Dec 2012 06:25:35 +0000 (06:25 +0000)]
Merge "mediawiki.Uri: Don't raw encode the 'title' query parameter."
Kaldari [Thu, 6 Dec 2012 01:47:43 +0000 (17:47 -0800)]
Adding fragment support to SpecialPage::getTitleFor()
Change-Id: I2007ad5166117b90af5560fd9bb1d0ee26e45cef