From dc7338be6f8db7541540a443696981f3ca109ea9 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Wed, 21 Sep 2016 11:56:22 -0700 Subject: [PATCH] Set more fields in fake DB subclasses to avoid errors Change-Id: I6b24422e830a8f82ba24383b3425808cb2a28b15 --- tests/phpunit/includes/db/DatabaseTestHelper.php | 3 +++ tests/phpunit/includes/installer/DatabaseUpdaterTest.php | 6 ++++++ 2 files changed, 9 insertions(+) diff --git a/tests/phpunit/includes/db/DatabaseTestHelper.php b/tests/phpunit/includes/db/DatabaseTestHelper.php index 29b2bedbf9..4c3ba10238 100644 --- a/tests/phpunit/includes/db/DatabaseTestHelper.php +++ b/tests/phpunit/includes/db/DatabaseTestHelper.php @@ -36,6 +36,9 @@ class DatabaseTestHelper extends DatabaseBase { $this->cliMode = isset( $opts['cliMode'] ) ? $opts['cliMode'] : true; $this->connLogger = new \Psr\Log\NullLogger(); $this->queryLogger = new \Psr\Log\NullLogger(); + $this->errorLogger = function ( Exception $e ) { + wfWarn( get_class( $e ) . ": {$e->getMessage()}" ); + }; $this->currentDomain = DatabaseDomain::newUnspecified(); } diff --git a/tests/phpunit/includes/installer/DatabaseUpdaterTest.php b/tests/phpunit/includes/installer/DatabaseUpdaterTest.php index 463423907c..f01c47d04e 100644 --- a/tests/phpunit/includes/installer/DatabaseUpdaterTest.php +++ b/tests/phpunit/includes/installer/DatabaseUpdaterTest.php @@ -21,6 +21,12 @@ class FakeDatabase extends DatabaseBase { public $lastInsertData; function __construct() { + $this->cliMode = true; + $this->connLogger = new \Psr\Log\NullLogger(); + $this->queryLogger = new \Psr\Log\NullLogger(); + $this->errorLogger = function ( Exception $e ) { + wfWarn( get_class( $e ) . ": {$e->getMessage()}" ); + }; $this->currentDomain = DatabaseDomain::newUnspecified(); } -- 2.20.1