From 7339f798d037c49664569449472a97d49f12bf1e Mon Sep 17 00:00:00 2001 From: Moriel Schottlender Date: Tue, 27 Feb 2018 17:12:01 -0800 Subject: [PATCH] RCFilters: Actually apply the $autoCloseIgnore to the overlay The way we extended the configuration meant we overrided the overlay $autoCloseIgnore with default rather than override the default with the overlay. Bug: T188459 Change-Id: If20bd400a8a206aa77c25c390d9e9ce5111b68cb --- .../ui/mw.rcfilters.ui.MenuSelectWidget.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js index cbb4350357..d968f0c486 100644 --- a/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js +++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js @@ -38,12 +38,12 @@ this.footers = []; // Parent - mw.rcfilters.ui.MenuSelectWidget.parent.call( this, $.extend( { + mw.rcfilters.ui.MenuSelectWidget.parent.call( this, $.extend( config, { $autoCloseIgnore: this.$overlay, width: 650, // Our filtering is done through the model filterFromInput: false - }, config ) ); + } ) ); this.setGroupElement( $( '
' ) .addClass( 'mw-rcfilters-ui-menuSelectWidget-group' ) -- 2.20.1