From 417bd2905c887a1d7863979b7dc3d0c917c3cab2 Mon Sep 17 00:00:00 2001 From: addshore Date: Thu, 16 Mar 2017 10:30:11 +0000 Subject: [PATCH] Deprecate WikiRevision::$user This was introduced in 436a028086fb3f01c4605c5ad2964d56f9306aca but was not used there. It also currently looks unused. We could go ahead and just remove this now, as anything that wants to set the $user when the property is removed would still succeed. But lets adhere to the deprecation policy here. Change-Id: Id47323bb1ff480a16b46107825ed5f2f861ad976 --- RELEASE-NOTES-1.29 | 1 + includes/import/WikiRevision.php | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/RELEASE-NOTES-1.29 b/RELEASE-NOTES-1.29 index 04f5578808..2380e9f99c 100644 --- a/RELEASE-NOTES-1.29 +++ b/RELEASE-NOTES-1.29 @@ -266,6 +266,7 @@ changes to languages because of Phabricator reports. * The 'jquery.autoEllipsis' ResourceLoader module is now deprecated. * WikiRevision::$fileIsTemp was deprecated. * WikiRevision::$importer was deprecated. +* WikiRevision::$user was deprecated. == Compatibility == diff --git a/includes/import/WikiRevision.php b/includes/import/WikiRevision.php index 4b76394205..df71524240 100644 --- a/includes/import/WikiRevision.php +++ b/includes/import/WikiRevision.php @@ -50,7 +50,9 @@ class WikiRevision { /** * @var int - * @todo Can't find any uses. Public, because that's suspicious. Get clarity. */ + * @deprecated in 1.29. Unused. + * @note Introduced in 436a028086fb3f01c4605c5ad2964d56f9306aca, unused there, unused now. + */ public $user = 0; /** @var string */ -- 2.20.1