From: Kunal Mehta <legoktm@member.fsf.org>
Date: Thu, 30 Aug 2018 05:08:32 +0000 (-0700)
Subject: Linker: Add @return-taint for formatLinksInComment()
X-Git-Tag: 1.34.0-rc.0~4249
X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/exercices/journal.php?a=commitdiff_plain;h=faf2e14517b05f8c2c5016c0be11b76a02c27efd;p=lhc%2Fweb%2Fwiklou.git

Linker: Add @return-taint for formatLinksInComment()

Works around a false positive in the phan-taint-check-plugin.

Bug: T202797
Change-Id: If7c9e729ca7624b3f791fe01d0b768791657277b
---

diff --git a/includes/Linker.php b/includes/Linker.php
index 7e565224cf..0aa8ec5649 100644
--- a/includes/Linker.php
+++ b/includes/Linker.php
@@ -1212,7 +1212,8 @@ class Linker {
 	 * @param string|null $wikiId Id of the wiki to link to (if not the local wiki),
 	 *  as used by WikiMap.
 	 *
-	 * @return string
+	 * @return string HTML
+	 * @return-taint escapes_html
 	 */
 	public static function formatLinksInComment(
 		$comment, $title = null, $local = false, $wikiId = null