From: James D. Forrester Date: Mon, 20 Feb 2017 22:32:12 +0000 (-0800) Subject: includes/libs: Replace implicit Bugzilla bug numbers with Phab ones X-Git-Tag: 1.31.0-rc.0~3964^2 X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/exercices/journal.php?a=commitdiff_plain;h=b715f432f420dece9feb56268ce2410a168d3312;p=lhc%2Fweb%2Fwiklou.git includes/libs: Replace implicit Bugzilla bug numbers with Phab ones It's unreasonable to expect newbies to know that "bug 12345" means "Task T14345" except where it doesn't, so let's just standardise on the real numbers. Skipping jsminplus.php as those bug numbers aren't Wikimedia's, nor obviously someone else's. Change-Id: I9a2210e17852ee56f11282b980ac66d8c7a95671 --- diff --git a/includes/libs/CSSMin.php b/includes/libs/CSSMin.php index bc99672f36..30b56ad206 100644 --- a/includes/libs/CSSMin.php +++ b/includes/libs/CSSMin.php @@ -237,7 +237,7 @@ class CSSMin { // * Otherwise remap the URL to work in generated stylesheets // Guard against trailing slashes, because "some/remote/../foo.png" - // resolves to "some/remote/foo.png" on (some?) clients (bug 27052). + // resolves to "some/remote/foo.png" on (some?) clients (T29052). if ( substr( $remote, -1 ) == '/' ) { $remote = substr( $remote, 0, -1 ); } diff --git a/includes/libs/IP.php b/includes/libs/IP.php index 21203a47ce..a6aa0a3f88 100644 --- a/includes/libs/IP.php +++ b/includes/libs/IP.php @@ -675,7 +675,7 @@ class IP { * @return string|null Valid dotted quad IPv4 address or null */ public static function canonicalize( $addr ) { - // remove zone info (bug 35738) + // remove zone info (T37738) $addr = preg_replace( '/\%.*/', '', $addr ); if ( self::isValid( $addr ) ) { diff --git a/includes/libs/filebackend/SwiftFileBackend.php b/includes/libs/filebackend/SwiftFileBackend.php index d40e896488..c50dfd7245 100644 --- a/includes/libs/filebackend/SwiftFileBackend.php +++ b/includes/libs/filebackend/SwiftFileBackend.php @@ -1089,7 +1089,7 @@ class SwiftFileBackend extends FileBackendStore { // good } elseif ( $rcode === 404 ) { $status->fatal( 'backend-fail-stream', $params['src'] ); - // Per bug 41113, nasty things can happen if bad cache entries get + // Per T43113, nasty things can happen if bad cache entries get // stuck in cache. It's also possible that this error can come up // with simple race conditions. Clear out the stat cache to be safe. $this->clearCache( [ $params['src'] ] ); diff --git a/includes/libs/objectcache/RedisBagOStuff.php b/includes/libs/objectcache/RedisBagOStuff.php index d852f82ea5..583ec37755 100644 --- a/includes/libs/objectcache/RedisBagOStuff.php +++ b/includes/libs/objectcache/RedisBagOStuff.php @@ -321,7 +321,7 @@ class RedisBagOStuff extends BagOStuff { */ protected function serialize( $data ) { // Serialize anything but integers so INCR/DECR work - // Do not store integer-like strings as integers to avoid type confusion (bug 60563) + // Do not store integer-like strings as integers to avoid type confusion (T62563) return is_int( $data ) ? $data : serialize( $data ); } diff --git a/includes/libs/rdbms/database/Database.php b/includes/libs/rdbms/database/Database.php index 9d800a29c8..9ec0b206c9 100644 --- a/includes/libs/rdbms/database/Database.php +++ b/includes/libs/rdbms/database/Database.php @@ -846,7 +846,7 @@ abstract class Database implements IDatabase, IMaintainableDatabase, LoggerAware } // Add trace comment to the begin of the sql string, right after the operator. - // Or, for one-word queries (like "BEGIN" or COMMIT") add it to the end (bug 42598) + // Or, for one-word queries (like "BEGIN" or COMMIT") add it to the end (T44598) $commentedSql = preg_replace( '/\s|$/', " /* $fname {$this->agent} */ ", $sql, 1 ); # Start implicit transactions that wrap the request if DBO_TRX is enabled @@ -1025,8 +1025,8 @@ abstract class Database implements IDatabase, IMaintainableDatabase, LoggerAware private function handleSessionLoss() { $this->mTrxLevel = 0; - $this->mTrxIdleCallbacks = []; // bug 65263 - $this->mTrxPreCommitCallbacks = []; // bug 65263 + $this->mTrxIdleCallbacks = []; // T67263 + $this->mTrxPreCommitCallbacks = []; // T67263 $this->mSessionTempTables = []; $this->mNamedLocksHeld = []; try { diff --git a/includes/libs/rdbms/database/DatabasePostgres.php b/includes/libs/rdbms/database/DatabasePostgres.php index 109f8481d5..f730d1474a 100644 --- a/includes/libs/rdbms/database/DatabasePostgres.php +++ b/includes/libs/rdbms/database/DatabasePostgres.php @@ -985,7 +985,7 @@ __INDEXATTR__; /** * Prepend our schema (e.g. 'mediawiki') in front * of the search path - * Fixes bug 15816 + * Fixes T17816 */ $search_path = $this->getSearchPath(); array_unshift( $search_path, @@ -1026,7 +1026,7 @@ __INDEXATTR__; // Normal client $this->numericVersion = $versionInfo['server']; } else { - // Bug 16937: broken pgsql extension from PHP<5.3 + // T18937: broken pgsql extension from PHP<5.3 $this->numericVersion = pg_parameter_status( $conn, 'server_version' ); } } diff --git a/includes/libs/rdbms/lbfactory/LBFactory.php b/includes/libs/rdbms/lbfactory/LBFactory.php index b2bd7ca727..6d2605fcd3 100644 --- a/includes/libs/rdbms/lbfactory/LBFactory.php +++ b/includes/libs/rdbms/lbfactory/LBFactory.php @@ -337,7 +337,7 @@ abstract class LBFactory implements ILBFactory { $masterPositions = array_fill( 0, count( $lbs ), false ); foreach ( $lbs as $i => $lb ) { if ( $lb->getServerCount() <= 1 ) { - // Bug 27975 - Don't try to wait for replica DBs if there are none + // T29975 - Don't try to wait for replica DBs if there are none // Prevents permission error when getting master position continue; } elseif ( $opts['ifWritesSince'] diff --git a/includes/libs/xmp/XMP.php b/includes/libs/xmp/XMP.php index 0d171f5247..90e4543421 100644 --- a/includes/libs/xmp/XMP.php +++ b/includes/libs/xmp/XMP.php @@ -895,7 +895,7 @@ class XMPReader implements LoggerAwareInterface { if ( $elm === self::NS_RDF . ' Seq' ) { array_unshift( $this->mode, self::MODE_LI ); } elseif ( $elm === self::NS_RDF . ' Bag' ) { - # bug 27105 + # T29105 $this->logger->info( __METHOD__ . ' Expected an rdf:Seq, but got an rdf:Bag. Pretending' . ' it is a Seq, since some buggy software is known to screw this up.' ); array_unshift( $this->mode, self::MODE_LI ); diff --git a/includes/libs/xmp/XMPInfo.php b/includes/libs/xmp/XMPInfo.php index 052be33a4b..5211a2cd39 100644 --- a/includes/libs/xmp/XMPInfo.php +++ b/includes/libs/xmp/XMPInfo.php @@ -650,7 +650,7 @@ class XMPInfo { 'choices' => [ '1' => true, '2' => true ], ], /******** - * Disable extracting this property (bug 31944) + * Disable extracting this property (T33944) * Several files have a string instead of a Seq * for this property. XMPReader doesn't handle * mismatched types very gracefully (it marks @@ -658,7 +658,7 @@ class XMPInfo { * the relavent prop). Since this prop * doesn't communicate all that useful information * just disable this prop for now, until such - * XMPReader is more graceful (bug 32172) + * XMPReader is more graceful (T34172) * 'YCbCrSubSampling' => array( * 'map_group' => 'exif', * 'mode' => XMPReader::MODE_SEQ,