From: Bartosz Dziewoński <matma.rex@gmail.com>
Date: Wed, 23 Dec 2015 21:17:06 +0000 (+0100)
Subject: SpecialContributions: Simplify check for 'Special:Contributions/newbies'
X-Git-Tag: 1.31.0-rc.0~8558^2
X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/exercices/journal.php?a=commitdiff_plain;h=8068ec255eb0d0f484dff1c456e7c5bd997dd26e;p=lhc%2Fweb%2Fwiklou.git

SpecialContributions: Simplify check for 'Special:Contributions/newbies'

Added in 54615b5ea1a05caf40461b46193b4779e912f528 (per T36659)
as a possibly temporary workaround, it has stuck around for six
release versions now. It's not going to suddenly disappear
and we shouldn't optimize this code for ease of removal :)

Bug: T36659
Change-Id: I946ae7cf164f5c71b2ea4023161df7452bd1745a
---

diff --git a/includes/specials/SpecialContributions.php b/includes/specials/SpecialContributions.php
index fc9f750d84..bf3ab907f7 100644
--- a/includes/specials/SpecialContributions.php
+++ b/includes/specials/SpecialContributions.php
@@ -49,11 +49,7 @@ class SpecialContributions extends IncludableSpecialPage {
 			$target = $request->getVal( 'target' );
 		}
 
-		// check for radiobox
-		if ( $request->getVal( 'contribs' ) == 'newbie' ) {
-			$target = 'newbies';
-			$this->opts['contribs'] = 'newbie';
-		} elseif ( $par === 'newbies' ) { // b/c for WMF
+		if ( $request->getVal( 'contribs' ) == 'newbie' || $par === 'newbies' ) {
 			$target = 'newbies';
 			$this->opts['contribs'] = 'newbie';
 		} else {