From: C. Scott Ananian <cscott@cscott.net>
Date: Fri, 26 Oct 2018 02:02:47 +0000 (-0400)
Subject: Hard deprecate $wgTidyConfig['driver'] = 'disabled'
X-Git-Tag: 1.34.0-rc.0~3620^2
X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/exercices/journal.php?a=commitdiff_plain;h=661c43f3ebea4256e32fb0523cbc9a7f198b635f;p=lhc%2Fweb%2Fwiklou.git

Hard deprecate $wgTidyConfig['driver'] = 'disabled'

This was already deprecated in the release notes, and is not used in
production, but I'd overlooked adding an appropriate hard deprecation
notice in MWTidy::factory() to notify downstream users.

Change-Id: I8f4d8154a1d8a233017f54f0fb4bcfdf4a0373e1
---

diff --git a/RELEASE-NOTES-1.32 b/RELEASE-NOTES-1.32
index 8ccc9c2fa7..2cd1222f40 100644
--- a/RELEASE-NOTES-1.32
+++ b/RELEASE-NOTES-1.32
@@ -598,6 +598,7 @@ because of Phabricator reports.
   $wgTidyConfig instead.
 * All Tidy configurations other than Remex have been hard deprecated;
   future parsers will not emit compatible output for these configurations.
+  In particular, running MediaWiki with tidy disabled has been deprecated.
 * (T198214) OutputPage::addWikiText(), OutputPage::addWikiTextWithTitle(),
   and OutputPage::addWikiTextTitle() have been deprecated, since they
   can result in untidy output.  In addition OutputPage::addWikiTextTidy()
diff --git a/includes/parser/MWTidy.php b/includes/parser/MWTidy.php
index a73c28cdba..8881786067 100644
--- a/includes/parser/MWTidy.php
+++ b/includes/parser/MWTidy.php
@@ -117,6 +117,7 @@ class MWTidy {
 				$instance = new MediaWiki\Tidy\RemexDriver( $config );
 				break;
 			case 'disabled':
+				wfDeprecated( '"disabled" tidy driver', '1.32' );
 				return false;
 			default:
 				throw new MWException( "Invalid tidy driver: \"{$config['driver']}\"" );