From eb25a6dd0243eece02ec6587a0633165991443cd Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Mon, 21 Nov 2016 15:30:57 +0100 Subject: [PATCH] mw.Upload.BookletLayout: Improve error message when not all logged-in users can upload Bug: T139257 Change-Id: I0ba4d0deba68d76bbcb01ee2202f82d392a68107 --- resources/src/mediawiki/mediawiki.Upload.BookletLayout.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/resources/src/mediawiki/mediawiki.Upload.BookletLayout.js b/resources/src/mediawiki/mediawiki.Upload.BookletLayout.js index 100714a862..c7ebfd8a51 100644 --- a/resources/src/mediawiki/mediawiki.Upload.BookletLayout.js +++ b/resources/src/mediawiki/mediawiki.Upload.BookletLayout.js @@ -187,8 +187,11 @@ // If the user can't upload anything, don't give them the option to. api.getUserInfo().then( function ( userInfo ) { if ( userInfo.rights.indexOf( 'upload' ) === -1 ) { - // TODO Use a better error message when not all logged-in users can upload - booklet.getPage( 'upload' ).$element.msg( 'api-error-mustbeloggedin' ); + if ( mw.user.isAnon() ) { + booklet.getPage( 'upload' ).$element.msg( 'api-error-mustbeloggedin' ); + } else { + booklet.getPage( 'upload' ).$element.msg( 'api-error-badaccess-groups' ); + } } return $.Deferred().resolve(); } ) -- 2.20.1