From 0c71217d09c74020df6543175b70708af93e1001 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Thu, 19 Jun 2014 08:10:16 +0200 Subject: [PATCH] qunit.completenessTest: Ignore mw.loader.moduleRegistry It was iterating over it and considering its 'script' properties to be methods that had to be tested. The CompletnessTest before this change is filled with stuff like: - loader.moduleRegistry.skins.vector.js.script - loader.moduleRegistry.mediawiki.api.script - loader.moduleRegistry.mediawiki.Title.script - .. And was actually causing it to hit hard limit and thus actual lots of actual methods were no longer inspected by the test. Change-Id: I13fbf1224b48aa34a7bb01fdc0543023e502bb4f --- tests/qunit/data/testrunner.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/qunit/data/testrunner.js b/tests/qunit/data/testrunner.js index ab9aab19d3..50e89da8bc 100644 --- a/tests/qunit/data/testrunner.js +++ b/tests/qunit/data/testrunner.js @@ -136,6 +136,12 @@ return true; } + // Don't iterate over the module registry (the 'script' references would + // be listed as untested methods otherwise) + if ( val === mw.loader.moduleRegistry ) { + return true; + } + return false; }; -- 2.20.1