From: Željko Filipin <zeljko.filipin@gmail.com>
Date: Wed, 15 Jun 2016 11:38:46 +0000 (+0200)
Subject: Fix RSpec::Expectations::ExpectationNotMetError in Selenium tests
X-Git-Tag: 1.31.0-rc.0~6595^2
X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/exercices/bilan.php?a=commitdiff_plain;h=337808e15bbb5c111413c768f5a1beeab3efeb6f;p=lhc%2Fweb%2Fwiklou.git

Fix RSpec::Expectations::ExpectationNotMetError in Selenium tests

The error was introduced by changes caused by AuthManager.

Bug: T137806
Change-Id: I5582159bde66ec3b39c30740876f0ce49f7ce3ff
---

diff --git a/tests/browser/features/step_definitions/create_account_steps.rb b/tests/browser/features/step_definitions/create_account_steps.rb
index fa0570c62b..d9b4f52a91 100644
--- a/tests/browser/features/step_definitions/create_account_steps.rb
+++ b/tests/browser/features/step_definitions/create_account_steps.rb
@@ -11,5 +11,5 @@ When(/^I submit the form$/) do
 end
 
 Then(/^an error message is displayed$/) do
-  expect(on(CreateAccountPage).error_message_element.class_name).to eq 'errorbox'
+  expect(on(CreateAccountPage).error_message_element).to exist
 end
diff --git a/tests/browser/features/step_definitions/login_steps.rb b/tests/browser/features/step_definitions/login_steps.rb
index bda0faac1e..9b35e998c5 100644
--- a/tests/browser/features/step_definitions/login_steps.rb
+++ b/tests/browser/features/step_definitions/login_steps.rb
@@ -23,11 +23,11 @@ When(/^I log in without entering password$/) do
 end
 
 Then(/^error box should be visible$/) do
-  expect(on(LoginErrorPage).error_box_element).to be_visible
+  expect(on(LoginPage).error_message_element).to exist
 end
 
 Then(/^error box should not be visible$/) do
-  expect(on(LoginErrorPage).error_box_element).not_to be_visible
+  expect(on(LoginPage).error_message_element).not_to exist
 end
 
 Then(/^feedback should be (.+)$/) do |feedback|
diff --git a/tests/browser/features/support/pages/create_account_page.rb b/tests/browser/features/support/pages/create_account_page.rb
index 9c1c3ba5bf..20e274425c 100644
--- a/tests/browser/features/support/pages/create_account_page.rb
+++ b/tests/browser/features/support/pages/create_account_page.rb
@@ -4,5 +4,5 @@ class CreateAccountPage
   page_url '<%=params[:page_title]%>'
 
   button(:create_account, id: 'wpCreateaccount')
-  div(:error_message, id: 'mw-createacct-status-area')
+  element(:error_message, css: 'div#userloginForm div.error')
 end
diff --git a/tests/browser/features/support/pages/login_error_page.rb b/tests/browser/features/support/pages/login_error_page.rb
deleted file mode 100644
index 9a1805f377..0000000000
--- a/tests/browser/features/support/pages/login_error_page.rb
+++ /dev/null
@@ -1,5 +0,0 @@
-class LoginErrorPage
-  include PageObject
-
-  div(:error_box, class: 'errorbox')
-end
diff --git a/tests/browser/features/support/pages/login_page.rb b/tests/browser/features/support/pages/login_page.rb
index 8ef1e44cd3..47273188b7 100644
--- a/tests/browser/features/support/pages/login_page.rb
+++ b/tests/browser/features/support/pages/login_page.rb
@@ -5,6 +5,7 @@ class LoginPage
 
   page_url 'Special:UserLogin'
 
+  element(:error_message, css: 'div#userloginForm div.error')
   div(:feedback, class: 'errorbox')
   button(:login, id: 'wpLoginAttempt')
   li(:logout, id: 'pt-logout')