From: Derick Alangi <alangiderick@gmail.com>
Date: Sun, 10 Mar 2019 18:12:48 +0000 (+0100)
Subject: ProtectionForm: Add type hint to ::showLogExtract() header
X-Git-Tag: 1.34.0-rc.0~2565^2
X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/exercices//%22?a=commitdiff_plain;h=a6bd784b9ba15d48dd83cd46fd91d49eda77f994;p=lhc%2Fweb%2Fwiklou.git

ProtectionForm: Add type hint to ::showLogExtract() header

https://codesearch.wmflabs.org/core/?q=showLogExtract%5C(&i=nope&files=&repos=
according to codesearch shows that this method takes as first argument an output
page object and also, objects are passed by reference by default so removed &.

Change-Id: I167ae6300b37d4e9292bd8ad14351f1ca35184d2
---

diff --git a/includes/ProtectionForm.php b/includes/ProtectionForm.php
index 6ce7ef4757..0e18e46a3b 100644
--- a/includes/ProtectionForm.php
+++ b/includes/ProtectionForm.php
@@ -622,10 +622,10 @@ class ProtectionForm {
 	/**
 	 * Show protection long extracts for this page
 	 *
-	 * @param OutputPage &$out
+	 * @param OutputPage $out
 	 * @private
 	 */
-	function showLogExtract( &$out ) {
+	function showLogExtract( OutputPage $out ) {
 		# Show relevant lines from the protection log:
 		$protectLogPage = new LogPage( 'protect' );
 		$out->addHTML( Xml::element( 'h2', null, $protectLogPage->getName()->text() ) );