From c4e407cf6cfb67dc748674c2c201c03de6bb89a4 Mon Sep 17 00:00:00 2001 From: jeroendedauw Date: Wed, 2 May 2012 17:04:29 +0200 Subject: [PATCH] add type check and bail out when title could not be created Change-Id: I5d931892d8f8f70a3dc13d0ed73413de47d43f53 --- includes/job/JobQueue.php | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/includes/job/JobQueue.php b/includes/job/JobQueue.php index ac70dcbd76..e436333f32 100644 --- a/includes/job/JobQueue.php +++ b/includes/job/JobQueue.php @@ -186,6 +186,11 @@ abstract class Job { $namespace = $row->job_namespace; $dbkey = $row->job_title; $title = Title::makeTitleSafe( $namespace, $dbkey ); + + if ( is_null( $title ) ) { + return false; + } + $job = Job::factory( $row->job_cmd, $title, Job::extractBlob( $row->job_params ), $row->job_id ); // Remove any duplicates it may have later in the queue @@ -204,7 +209,7 @@ abstract class Job { * @param $id Int: Job identifier * @return Job */ - static function factory( $command, $title, $params = false, $id = 0 ) { + static function factory( $command, Title $title, $params = false, $id = 0 ) { global $wgJobClasses; if( isset( $wgJobClasses[$command] ) ) { $class = $wgJobClasses[$command]; -- 2.20.1