Dayllan Maza [Tue, 11 Sep 2018 19:50:42 +0000 (15:50 -0400)]
Fix missing comma on sql file
Bug: T197144
Change-Id: I9e1562fd0ce94aaa44e932a608065a7340492746
jenkins-bot [Tue, 11 Sep 2018 19:06:08 +0000 (19:06 +0000)]
Merge "Add release notes for removed collations"
Bartosz Dziewoński [Tue, 11 Sep 2018 18:10:49 +0000 (20:10 +0200)]
Add release notes for removed collations
* 'uppercase-se' - removed in
3469713f4e36f9fb7e9babe0f2fd165d6e59b2e2
* 'xx-uca-et' - removed in
9c46871d60f02a033c6082836f9b6a18b3a10ec1
* 'xx-uca-fa' - removed in
5a21de8abb7f03e72a07d8578babc1835dff4a64
Change-Id: I28a20fdf86af527a209d826fb12fb0ee28c83a66
jenkins-bot [Tue, 11 Sep 2018 18:18:17 +0000 (18:18 +0000)]
Merge "Revert MCR migration stage to write-both/read-old"
jenkins-bot [Tue, 11 Sep 2018 18:13:00 +0000 (18:13 +0000)]
Merge "Remove xx-uca-et collation workaround"
Lucas Werkmeister [Tue, 11 Sep 2018 16:07:43 +0000 (18:07 +0200)]
Revert MCR migration stage to write-both/read-old
This partially reverts commit
9bd162dce2 (change I15989adae2).
Bug: T204065
Change-Id: I5426b5efd09dd1253883e405ec5db6d0ebac779e
daniel [Tue, 14 Aug 2018 16:37:30 +0000 (18:37 +0200)]
Use RevisionRenderer for rendering ParserOutput
Bug: T174035
Bug: T174036
Change-Id: I1085b05d635dd954c143c8a398fae909632ba0a9
daniel [Mon, 3 Sep 2018 13:34:12 +0000 (15:34 +0200)]
Cover incomplete revision case in RenderedRevision.
This introduces a check that allows magic words like {{REVISIONUSER}}
to still work even when an incomplete fake RevisonRecord is provided to
RevisionRenderer. In such a case, the revision is loaded from the database
if needed. This lets old code that only has access to a Content object for
rendering use that Content object in a fake RevisionRecord, instead of
having to load the full revision from the database in all cases.
Bug: T174035
Change-Id: I658eab97a8282b8943baf7968f3256da35789ec1
jenkins-bot [Tue, 11 Sep 2018 15:14:17 +0000 (15:14 +0000)]
Merge "Introduce RevisionRecord::isReadForInsertion"
jenkins-bot [Tue, 11 Sep 2018 13:59:46 +0000 (13:59 +0000)]
Merge "[MCR] Set MCR migration stage to write-both/read-new."
Pikne [Tue, 11 Sep 2018 13:30:06 +0000 (13:30 +0000)]
Remove xx-uca-et collation workaround
Remove workaround introduced in I3e8031b9. No longer needed.
Bug: T202977
Change-Id: I39921ef83cddc33535b99bd9c0b75f8afb52ea9a
daniel [Mon, 10 Sep 2018 19:34:31 +0000 (21:34 +0200)]
Introduce RevisionRecord::isReadForInsertion
RevisionRecord::isReadForInsertion provides a concise way to check
whether a revision is complete enough to be inserted into the database.
Change-Id: I0c79f55c0b935bce9943163ed4c2cc8b5f9c82d5
daniel [Wed, 4 Jul 2018 13:39:24 +0000 (15:39 +0200)]
[MCR] Set MCR migration stage to write-both/read-new.
This patch exists to see if CI passes with
$wgMultiContentRevisionSchemaMigrationStage set to
SCHEMA_COMPAT_WRITE_BOTH | SCHEMA_COMPAT_READ_NEW.
NOTE: verify that $wgMultiContentRevisionSchemaMigrationStage
is explicitly set toSCHEMA_COMPAT_WRITE_BOTH | SCHEMA_COMPAT_READ_OLD
in production config (T197816) before merging this.
Bug: T198561
Depends-On: Ib718868d2c768b6ea851355eef047bc0e6593495
Change-Id: I15989adae2b5916577d164c50d7da88774e49324
jenkins-bot [Tue, 11 Sep 2018 09:48:47 +0000 (09:48 +0000)]
Merge "Add hooks to MediaWikiPHPUnitTestListener start/endTest"
jenkins-bot [Tue, 11 Sep 2018 09:30:52 +0000 (09:30 +0000)]
Merge "resourceloader: Remove closure around $CODE.defineLoader()"
jenkins-bot [Tue, 11 Sep 2018 09:06:41 +0000 (09:06 +0000)]
Merge "resourceloader: Optimise register() to avoid different self-called signature"
jenkins-bot [Tue, 11 Sep 2018 09:06:36 +0000 (09:06 +0000)]
Merge "resourceloader: Remove redundant UA-check for Opera 12"
jenkins-bot [Tue, 11 Sep 2018 09:06:31 +0000 (09:06 +0000)]
Merge "resourceloader: Remove support for `addSource(id, url)`"
Translation updater bot [Tue, 11 Sep 2018 07:26:21 +0000 (09:26 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I76f3672d900827a2df2f88f668e6db92c911ba9e
jenkins-bot [Tue, 11 Sep 2018 02:03:03 +0000 (02:03 +0000)]
Merge "resources: Sort keys of foreign-resources.yaml"
jenkins-bot [Tue, 11 Sep 2018 02:00:34 +0000 (02:00 +0000)]
Merge "resources: Register html5shiv as foreign resource"
Prateek Saxena [Thu, 20 Jul 2017 17:40:35 +0000 (23:10 +0530)]
Special:AllPages: Use OOUI
Also:
* Use the usual $formDescriptor and $htmlForm
* Fix typos
Bug: T117724
Change-Id: I1e9b45d687492eed290a825de78c6ecc61013da8
jenkins-bot [Mon, 10 Sep 2018 23:55:19 +0000 (23:55 +0000)]
Merge "Pass delimiter to preg_quote"
Timo Tijhof [Mon, 10 Sep 2018 23:26:21 +0000 (00:26 +0100)]
resources: Sort keys of foreign-resources.yaml
Makes it easier to correlate entries when browsing resources/lib/
side-by-side with the file. Also, remove redundant 'dest' keys
from a few 'file' resources.
Change-Id: I543a37a3721080d01434f7c804fab2a51ac9ff75
Timo Tijhof [Mon, 10 Sep 2018 23:24:55 +0000 (00:24 +0100)]
resources: Register html5shiv as foreign resource
Change-Id: If3e119a85eb1c40288a5a02dc51c388e8da2c3ff
jenkins-bot [Mon, 10 Sep 2018 23:16:15 +0000 (23:16 +0000)]
Merge "jsduck: Fix OOUI resource links"
jenkins-bot [Mon, 10 Sep 2018 23:16:08 +0000 (23:16 +0000)]
Merge "resources: Rename oojs-ui file paths to ooui per general branding"
jenkins-bot [Mon, 10 Sep 2018 22:21:49 +0000 (22:21 +0000)]
Merge "foreign-resources.yaml: Add blank lines between registrations for easier merges"
James D. Forrester [Mon, 10 Sep 2018 21:47:54 +0000 (14:47 -0700)]
jsduck: Fix OOUI resource links
The theme was renamed from 'mediawiki' to 'wikimediaui' months ago, at
which point these files would have broken.
oojs-ui-local.css doesn't currently exist, and possibly hasn't for a
long while(?).
Change-Id: Ib2f77ff357b8cf51c5ae00df6f187fca4a91be15
James D. Forrester [Mon, 10 Sep 2018 20:42:52 +0000 (13:42 -0700)]
resources: Rename oojs-ui file paths to ooui per general branding
No change to the module names yet.
Change-Id: Ica33520b0128bd56dc06c8951bdc6932fce041fe
jenkins-bot [Mon, 10 Sep 2018 21:26:48 +0000 (21:26 +0000)]
Merge "Fix undeletion write-both/read-old mode."
jenkins-bot [Mon, 10 Sep 2018 21:26:42 +0000 (21:26 +0000)]
Merge "Update wikimedia/timestamp to v2.1.1"
jenkins-bot [Mon, 10 Sep 2018 21:06:02 +0000 (21:06 +0000)]
Merge "Bump qunit from 2.6.0 to 2.6.2"
jenkins-bot [Mon, 10 Sep 2018 21:05:56 +0000 (21:05 +0000)]
Merge "resourceloader: Update startup mock in jsduck/eg-iframe"
James D. Forrester [Mon, 10 Sep 2018 20:42:14 +0000 (13:42 -0700)]
foreign-resources.yaml: Add blank lines between registrations for easier merges
Change-Id: I412da56d1f981fa72799fb51b8216f39f02f0042
James D. Forrester [Wed, 5 Sep 2018 22:51:03 +0000 (15:51 -0700)]
Bump qunit from 2.6.0 to 2.6.2
Change-Id: Id7f47eee423c2fc1289f468c6622b952814d8912
Timo Tijhof [Mon, 10 Sep 2018 20:22:49 +0000 (21:22 +0100)]
resourceloader: Update startup mock in jsduck/eg-iframe
Follows-up
dec800968eb. Without it, the mediawiki.base.js script
fails upon trying to access 'window.RLQ', which startup.js normally
defines.
Bug: T203578
Change-Id: Icfe16948b1b7af47f6e3f058500aa8fa86cafbfc
jenkins-bot [Mon, 10 Sep 2018 20:36:19 +0000 (20:36 +0000)]
Merge "resources: Register CLDRPluralRuleParser as foreign resource"
jenkins-bot [Mon, 10 Sep 2018 20:20:05 +0000 (20:20 +0000)]
Merge "build: Update grunt-karma from 2.0.0 to 3.0.0"
Timo Tijhof [Mon, 10 Sep 2018 19:38:43 +0000 (20:38 +0100)]
resources: Register CLDRPluralRuleParser as foreign resource
The script verifies that our copy still matches the original
release.
Change-Id: Idc982434c066f3b38cb95c6c2aaad7839f261ab1
daniel [Mon, 27 Aug 2018 19:45:40 +0000 (21:45 +0200)]
Fix undeletion write-both/read-old mode.
With the new schema, undeletion does not create now slot rows.
However, when in read-old mode, we may still have un-migrated
archive rows. When undeletion based on such a row, we do need
to insert a slot row.
This also changes the return value of SlotRecord for
SCHEMA_COMPAT_READ_OLD mode from null to the negative value of
rev_text_id, for consistency. Conceptually, the emulated slots
in SCHEMA_COMPAT_OLD now have a "virtual" content ID, hich is
however distinct from any real content ID that may exist in
the future. Such virtual content IDs are however not assigned
in SCHEMA_COMPAT_WRITE_BOTH mode. In that mode, unmigrated
rows can be detected by calling hasContentId() on the main
slot. Migrated rows will return true here and provide the
id of the associated content row, even in
SCHEMA_COMPAT_READ_OLD mode. This is particularly essential
for undeletion, which needs to maintain the association
between revision and slot rows even in SCHEMA_COMPAT_READ_OLD
mode.
Bug: T174024
Bug: T194015
Bug: T183488
Change-Id: I88ee9809b9752e1e72d635d62e82008315402901
Brad Jorsch [Mon, 10 Sep 2018 19:28:43 +0000 (15:28 -0400)]
Update wikimedia/timestamp to v2.1.1
Also enable some tests for PostgreSQL that are fixed by the new version.
Bug: T195807
Change-Id: Id0d016f620662836b3a17de5f118715c1cbe3e69
Depends-On: I3bd8df5236600963be89602b2a52d0d95d640d66
jenkins-bot [Mon, 10 Sep 2018 18:41:02 +0000 (18:41 +0000)]
Merge "Consolidate tests for getQueryInfo() and related methods."
jenkins-bot [Mon, 10 Sep 2018 18:38:04 +0000 (18:38 +0000)]
Merge "mediawiki.notification: Use data-mw-foo instead of data-mw.foo"
daniel [Mon, 3 Sep 2018 17:15:37 +0000 (19:15 +0200)]
Consolidate tests for getQueryInfo() and related methods.
This consolidates tests for getQueryInfo, getArchiveQueryInfo,
getSlotQueryInfo, and similar methods that help application logic
be compatible with different migration stages of different aspects
of the revision storage schema.
Bug: T198561
Change-Id: I8e4ae69d7e00721a0af125afaf9a708f7fe99b0a
Volker E [Mon, 10 Sep 2018 18:08:38 +0000 (11:08 -0700)]
Special:Preferences OOUI: Limit `max-width` override to inputs only
Follow-up to I23e2e98a389a60
Change-Id: I08c41916418349172530204d070f12ef05b9246b
jenkins-bot [Mon, 10 Sep 2018 16:51:14 +0000 (16:51 +0000)]
Merge "Special:Preferences OOUI: Reduce width of number inputs to 10em "
James D. Forrester [Mon, 10 Sep 2018 16:46:17 +0000 (09:46 -0700)]
build: Update grunt-karma from 2.0.0 to 3.0.0
Bug: T194280
Change-Id: Iba043c036c06bebd961896f390063ca9a0129eb2
Ed Sanders [Sat, 8 Sep 2018 13:33:59 +0000 (14:33 +0100)]
Special:Preferences OOUI: Reduce width of number inputs to 10em
Bug: T181844
Change-Id: I23e2e98a389a609145fa451902e62ca53b83c72e
Fomafix [Mon, 10 Sep 2018 13:53:31 +0000 (15:53 +0200)]
mediawiki.notification: Use data-mw-foo instead of data-mw.foo
All other data-mw attributes or .data() parameters use 'mw-foo' instead
of 'mw.foo'.
Change-Id: I2f7290c8a7ba1684c65b976c17912aa85846de02
addshore [Fri, 24 Aug 2018 14:56:20 +0000 (15:56 +0100)]
Add hooks to MediaWikiPHPUnitTestListener start/endTest
Used in Wikibase I89ab5e9c2d608fb2d2f7
An alternate proposal to:
- If9448650a56f30294cc3ef766b5f5ec201e85ba4
- Idd12370b09ad0ebae23d77c743b79a7163961436
Change-Id: I82b5e94009527f9e46262bf6f505a43ddc9767f0
Translation updater bot [Mon, 10 Sep 2018 07:07:15 +0000 (09:07 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Id9ce66ace073f0974d15610e14c64a565ce575dd
Translation updater bot [Sun, 9 Sep 2018 08:00:52 +0000 (10:00 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Id50ca26cf97d5d23e50ab7f597d68827c31ac1da
Timo Tijhof [Sat, 8 Sep 2018 18:01:45 +0000 (19:01 +0100)]
resourceloader: Remove closure around $CODE.defineLoader()
Follows-up
b7b84d55d4e, which embedded the whole of the three 'mediawiki'
JS files inside of startup.js, but did so inside of the pre-existing
closure that was there.
This adds some overhead we don't get value of, so best to remove
it and embed it as a sibling of startup.js in the same top-level
scope.
In local testing (Chrome stable, CPU 1/6th) this reduced startup
run-time from 73-78ms to 63-65ms.
Also:
* Declare isCompatible() as a normal function.
Disable the implicit-globals warning given this isn't a regular module,
this file is intentionally in the global scope.
* Unfold the private startUp() function to its call site.
Change-Id: Ida51ab20898c9e4ae6cbf7ad2968d88d824a1483
Timo Tijhof [Fri, 7 Sep 2018 04:09:53 +0000 (05:09 +0100)]
resourceloader: Optimise register() to avoid different self-called signature
Follows-up
6815e355753c, and I24786f90bcfb2, which also removed
similar self-calling implementations to simplify stack depth,
and improve startup run-time performance.
Change-Id: Ieb4a7d1e1758856411a49566a69a840b9aeddaa6
Timo Tijhof [Fri, 7 Sep 2018 01:36:56 +0000 (02:36 +0100)]
resourceloader: Remove redundant UA-check for Opera 12
Follows-up
07d8fded3eb336257.
Change-Id: Ie3873292d26984eaa26c80c184e7388893d56c87
Timo Tijhof [Mon, 3 Sep 2018 23:17:11 +0000 (00:17 +0100)]
resourceloader: Remove support for `addSource(id, url)`
The PHP interface still supports it without deprecation, but there
is no need for the client to support it given it is only ever called
from the startup module, which always passes it an object.
Follows-up
6815e355753c, which did the same for `state(key, val)`.
Also simplify the implementation to avoid extra calls and optimise
for the only signature.
Mark the method as @private, and change the existing use of
@protected to @private (doesn't really make sense in JavaScript).
Change-Id: I24786f90bcfb256b2e7c37f7760bba1a5e399443
Translation updater bot [Sat, 8 Sep 2018 07:57:21 +0000 (09:57 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ia40c19790cdf5164d2bd787d8b0e404b9d578572
jenkins-bot [Sat, 8 Sep 2018 01:35:49 +0000 (01:35 +0000)]
Merge "Linker: Remove outdated comment"
jenkins-bot [Fri, 7 Sep 2018 22:44:50 +0000 (22:44 +0000)]
Merge "Make Schema changes for Partial Blocks"
David Barratt [Mon, 18 Jun 2018 14:26:20 +0000 (10:26 -0400)]
Make Schema changes for Partial Blocks
Update the database schema so a block can be switched between a sitewide and
partial block. Also add the restrictions table for specifiying the partial
blocks.
Bug: T197144
Change-Id: I4a725312c4b980a1b14e5ca826069fa2278a5913
jenkins-bot [Fri, 7 Sep 2018 21:54:47 +0000 (21:54 +0000)]
Merge "build: Bump most devDependencies to latest"
jenkins-bot [Fri, 7 Sep 2018 20:28:15 +0000 (20:28 +0000)]
Merge "mw.special.preferences/confirmClose: Catch clicks inside OOUI dropdowns"
Bartosz Dziewoński [Fri, 7 Sep 2018 17:58:34 +0000 (19:58 +0200)]
mw.special.preferences/confirmClose: Catch clicks inside OOUI dropdowns
I did what needed to be done. I am not proud of it.
Bug: T203825
Change-Id: I57d6177cfb50641d8e085a48258e321e4d028712
Ed Sanders [Fri, 7 Sep 2018 17:46:19 +0000 (18:46 +0100)]
Prevent field margin FOUC when loading OOUI Special:Preferences
Bug: T195986
Change-Id: Ib99db544faa4881efc0d762abf4b80bfcf034f50
jenkins-bot [Fri, 7 Sep 2018 17:14:36 +0000 (17:14 +0000)]
Merge "Allow dumps to function with MCR in read-new mode."
Gergő Tisza [Fri, 7 Sep 2018 08:42:29 +0000 (10:42 +0200)]
Unwrap HTML loaded from parser cache
Partially and temporarily reverts I1641b7995 to deal with cached
HTML the same way the old code did.
Bug: T203716
Change-Id: I29846a6513f6b580b429c0bfe6c310ada50b28bb
daniel [Fri, 7 Sep 2018 12:12:12 +0000 (14:12 +0200)]
Allow dumps to function with MCR in read-new mode.
This is a temporary fix that forces the dump code to continue to
use the old database schema, even when MCR is in
SCHEMA_COMPAT_READ_NEW mode. This will continue to function until
SCHEMA_COMPAT_WRITE_OLD mode is disabled.
Bug: T198561
Change-Id: Ic54ee703f47d1843f70fdb7185ac1b098f148680
jenkins-bot [Fri, 7 Sep 2018 07:33:47 +0000 (07:33 +0000)]
Merge "Make assertFileContains not create files by default"
Translation updater bot [Fri, 7 Sep 2018 06:37:35 +0000 (08:37 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I668054749e5551c2fe306e08b30935a916e91ae6
Reedy [Thu, 6 Sep 2018 21:40:19 +0000 (22:40 +0100)]
Fix table prefixing in patch-change_tag-change_tag_rc_tag_id.sql
Change-Id: Id1963e93a43d4b183a31788b645c83e3037f3016
Follows-up: I24609c57e47308d1330a97527f4ea374d0d307ba
jenkins-bot [Thu, 6 Sep 2018 19:41:59 +0000 (19:41 +0000)]
Merge "Linker: more consistent whitespace parsing in formatLinksInComment"
jenkins-bot [Thu, 6 Sep 2018 19:25:50 +0000 (19:25 +0000)]
Merge "API: Use ct_tag_id in queries when applicable"
jenkins-bot [Thu, 6 Sep 2018 19:25:44 +0000 (19:25 +0000)]
Merge "Update API tests to comply with the new backend for change tags"
jenkins-bot [Thu, 6 Sep 2018 19:16:45 +0000 (19:16 +0000)]
Merge "Schema change for reading ct_tag_id instead of ct_tag"
jenkins-bot [Thu, 6 Sep 2018 19:04:45 +0000 (19:04 +0000)]
Merge "Watchlist preferences: Disallow zero value for days/limit"
jenkins-bot [Thu, 6 Sep 2018 18:42:32 +0000 (18:42 +0000)]
Merge "Provide a RevisionRecord with the correct title after a move"
Brad Jorsch [Thu, 6 Sep 2018 18:02:53 +0000 (14:02 -0400)]
Provide a RevisionRecord with the correct title after a move
Currently we're creating the null revision for the move before actually
updating the page's title, so when it gets passed through
RevisionRenderer the output uses the old page's title in the <h1>.
To make that null revision have the correct title, let's try simply
updating the page table before creating it instead. The ordering
shouldn't matter since this all happens in an atomic section.
Bug: T203661
Change-Id: I9ebdcbc566b11dea3a9bdd402ea4418c4e51b096
jenkins-bot [Thu, 6 Sep 2018 17:57:12 +0000 (17:57 +0000)]
Merge "Provide new, unsaved revision to PST to fix magic words."
jenkins-bot [Thu, 6 Sep 2018 17:31:24 +0000 (17:31 +0000)]
Merge "Update OOUI to v0.28.1"
Thiemo Kreuz (WMDE) [Tue, 26 Jun 2018 09:55:21 +0000 (09:55 +0000)]
Linker: more consistent whitespace parsing in formatLinksInComment
Try to paste and preview this in the wikitext as well as the summary
line: [[:a]] [[ :a]]
The wikitext will show "a a", but the summary line will show "a :a".
This is only a display issue, all 4 links correctly link to the
article [[A]].
Change-Id: I08253a6d0b55b9aa3eace519bbdc1a456400bf84
Kosta Harlan [Thu, 6 Sep 2018 14:50:08 +0000 (10:50 -0400)]
Watchlist preferences: Disallow zero value for days/limit
"0" used to work as an undocumented shortcut for "maximum allowed" days/edits,
but this behavior was removed in If6280ad6fbad65909e1d0b2a48344e24d485aca2
This commit brings the preference options into alignment with how the code
functions.
Bug: T199049
Bug: T176033
Change-Id: I5ffd87565df6b3c602d1f69d9d63621a817ce8cf
James D. Forrester [Wed, 5 Sep 2018 15:14:54 +0000 (08:14 -0700)]
build: Bump most devDependencies to latest
grunt-stylelint 0.10.0 → 0.10.1
karma 2.0.2 → 3.0.0
karma-firefox-launcher 1.0.1 → 1.1.0
karma-qunit 2.0.1 → 2.1.0
postcss-less 1.1.5 → 2.0.0
This reduces our `npm audit` alerts down to just those from grunt-karma.
Bug: T194280
Change-Id: I7d321dd715db9d214e65ed7197e917cb7c6b14f3
daniel [Wed, 5 Sep 2018 18:03:15 +0000 (20:03 +0200)]
Provide new, unsaved revision to PST to fix magic words.
This injects the new, unsaved RevisionRecord object into the Parser used
for Pre-Save Transform, and sets the user and timestamp on that revision,
to allow {{subst:REVISIONUSER}} and {{subst:REVISIONTIMESTAMP}} to function.
Bug: T203583
Change-Id: I31a97d0168ac22346b2dad6b88bf7f6f8a0dd9d0
Bartosz Dziewoński [Thu, 6 Sep 2018 16:16:37 +0000 (18:16 +0200)]
Update OOUI to v0.28.1
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.28.1
Depends-On: Ief8dd72fa454277c75aee367cd6421a61cff26f8
Change-Id: I8d8d99545151898ae9710c2c2ea46565b28258a3
jenkins-bot [Thu, 6 Sep 2018 16:15:15 +0000 (16:15 +0000)]
Merge "Allow skins to place notification container for mw.notify"
Moriel Schottlender [Tue, 30 Aug 2016 23:02:18 +0000 (16:02 -0700)]
Allow skins to place notification container for mw.notify
Give skins the ability to place the mw.notification notifications
in a div of their choosing rather than force the container to be
in the content area.
This is particularly useful for skins that deal with multiple
overlays that are created and displayed outside the content div,
which then in turn hides the notification area. A good example of
this behavior is in MobileFrontend's overlays that are created as
siblings to the content div, and so all mw.notify() notifications
are then hidden behind them.
Bug: T143837
Bug: T202466
Change-Id: I5a78949efef88083bdafc4207a6872c76b463970
Timo Tijhof [Fri, 24 Aug 2018 20:13:57 +0000 (21:13 +0100)]
exception: Do not log PHP errors with severity DEBUG or INFO
All PHP errors should be considered by monitoring queries
and error-rate alerts.
Levels DEBUG and INFO are for manual entries that can help in
debugging to see what path a program went down or what the
circumstances were in that code.
There is no reason to spread PHP error-types out on the full range
of PSR-3's DEBUG to ERROR spectrum. Instead, keep it within either
WARNING or ERROR, not below it.
Change-Id: I3f35a519b50aef5b93b9ab7a89a7c3e11d70681f
jdlrobson [Fri, 10 Aug 2018 18:02:22 +0000 (11:02 -0700)]
Hygiene: Discourage use of $.each
Even though Array.prototype.forEach only works on arrays, and
$.each is more generic, I think it makes sense to begin discouraging
the usage of $.each now. This can be overriden by ignore lines or
by Array.prototype.forEach compatible lines. This doesn't seem too
much of an ask of engineers and helps future migrations
Bug: T200877
Change-Id: I339cff311a830699c8e32f07cec338a39870c53f
Stanislav Malyshev [Wed, 5 Sep 2018 22:00:25 +0000 (15:00 -0700)]
Make assertFileContains not create files by default
This makes us miss test bugs like one in
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/458305
Change-Id: I2a96ed180be216aa615d8506999aa75f04c267bf
Depends-On: Ic85db75c2dba6c1c1fa6fd74dbea64f213609c0d
Fomafix [Tue, 4 Sep 2018 07:51:49 +0000 (09:51 +0200)]
Replace $.proxy by Function.prototype.bind
Also prevent further usage by an eslint rule.
jQuery.proxy is deprecated:
* https://github.com/jquery/jquery/issues/2958
Bug: T200877
Change-Id: I3a4977f9b90c2104db320d2d939a1cbaa1819de0
Translation updater bot [Wed, 5 Sep 2018 20:02:00 +0000 (22:02 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ib115cf8605089085e6b52836daca2e0ae4755642
jenkins-bot [Wed, 5 Sep 2018 19:34:05 +0000 (19:34 +0000)]
Merge "Don't wait for thumbnails that take long to render"
Gilles Dubuc [Mon, 3 Sep 2018 09:09:08 +0000 (11:09 +0200)]
Don't wait for thumbnails that take long to render
The prerendering job is an optimization, should
thumbnails fail to prerender, they will be reattempted
when a user views them again.
Bug: T203135
Change-Id: I2907bf10a2d22af9beffc530856f458a6adbfe45
jenkins-bot [Wed, 5 Sep 2018 16:22:57 +0000 (16:22 +0000)]
Merge "Selenium: Daily Jenkins job targeting beta cluster should run only tests that pass"
jenkins-bot [Wed, 5 Sep 2018 15:53:57 +0000 (15:53 +0000)]
Merge "ApiComparePages: Clean up handling of slot deletion"
Bartosz Dziewoński [Wed, 5 Sep 2018 14:39:27 +0000 (16:39 +0200)]
Linker: Remove outdated comment
This talks about references and values the way they worked in PHP 4.
Comment was added in r4927 (
b025ad54) in 2004.
Change-Id: I58a74219665bed9e804d7c01f271fd96fd889072
jenkins-bot [Wed, 5 Sep 2018 12:40:40 +0000 (12:40 +0000)]
Merge "[MCR] Move getSecondaryDataUpdates to the page level"
jenkins-bot [Wed, 5 Sep 2018 12:18:34 +0000 (12:18 +0000)]
Merge "DifferenceEngine: use a fake title when there's no real title"
jenkins-bot [Wed, 5 Sep 2018 05:15:34 +0000 (05:15 +0000)]
Merge "SpecialPageExecutor: Use `finally` now that we're in a PHP 5.5+ world"