Sam Reed [Sun, 8 May 2011 21:47:01 +0000 (21:47 +0000)]
Whitespace fixes
Addition/tweak of documentation
Krinkle [Sun, 8 May 2011 20:48:20 +0000 (20:48 +0000)]
Fix exception thrown in mw.util.addPortletLink
* As of jQuery 1.4.4, Sizzle's query must be a string (it does a query.replace call before everything else). It fails otherwise.
* In REL1_17 and 1.17wmf1 this isn't a problem since jQuery 1.4.2 is there, in which Sizzle didn't fail on non-strings yet.
* Nonetheless this is undocumented support, we should make sure that the variable passed is a string on our side
* Adding a check for it in mw.util.addPortletLink's nextnode argument.
* Adding a test to mw.util.test that calls addPortletLink with three arguments, making nextnode implied undefined/null. This test returned "ERROR" before I made the fix in mw.util.addPortletLink.
Exact error: TypeError: Result of expression 'query' [undefined] is not an object.
Origin: line 4085 of jQuery/mediaWiki module load.
Line 4081: Sizzle = function( query, context, extra, seed ) {
Line 4085: query = query.replace(/\=\s*([^'"\]]*)\s*\]/g, "='$1']");
Krinkle [Sun, 8 May 2011 20:30:29 +0000 (20:30 +0000)]
Remove second argument in str.substr() in $.ucFirst, not needed, defaults to full length of string
Raimond Spekking [Sun, 8 May 2011 19:45:53 +0000 (19:45 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-05-09 19:42:00 UTC)
Sam Reed [Sun, 8 May 2011 16:48:30 +0000 (16:48 +0000)]
Documentation
Remove long deprecated isBot()/isSysop() in ApiMain
Krinkle [Sun, 8 May 2011 13:22:42 +0000 (13:22 +0000)]
mw.util.test update
* Remove isMainPage() from test suite (r87360 r87586)
* Use mw.config for wgVars (follow-up r80792 CR)
* Rename skinLinksText variable to skinLinksHtml
* Wrap lines
* removing !important from addCSS test, instead using the same selector as the original background-color declaration and letting it cascade.
* Adding css('background-color') test to verify.
Alexandre Emsenhuber [Sun, 8 May 2011 08:50:11 +0000 (08:50 +0000)]
$wgOut can no longer be a stub since r85278, so there's no need to check this with StubObject::isRealObject()
Siebrand Mazeland [Sun, 8 May 2011 07:39:13 +0000 (07:39 +0000)]
Add placeholder for "bh" code. Falls back to "bho" per r87676.
Siebrand Mazeland [Sun, 8 May 2011 07:37:07 +0000 (07:37 +0000)]
Change language code from "bh" which is the code for the Bihari macro language to "bho", the correct code for Bhojpuri.
Daniel Friesen [Sun, 8 May 2011 00:10:31 +0000 (00:10 +0000)]
Change $text to $html. This has been bothering me for awhile. It's stupid, counterintuitive, we call it text making people think of it as text then note (oh, this isn't text, it's html, you'd better escape it yourself or you'll screw yourself over with an XSS vector).
Sam Reed [Sat, 7 May 2011 23:46:16 +0000 (23:46 +0000)]
* (bug 24711) MV_EditPageAjax.php uses deprecated LogReader and LogViewer
Not fixing usage, just SVN copy'd it from trunk into MetavidWiki extension as it's the only place still using it
Raimond Spekking [Sat, 7 May 2011 21:26:26 +0000 (21:26 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-05-07 20:56:00 UTC)
Raimond Spekking [Sat, 7 May 2011 19:42:47 +0000 (19:42 +0000)]
Follow-up r87651: PLURAL is needed for other languages with more than 1 plural forms
Brian Wolff [Sat, 7 May 2011 19:37:52 +0000 (19:37 +0000)]
(follow-up r87651) whoops, forgot release notes.
Brian Wolff [Sat, 7 May 2011 19:34:14 +0000 (19:34 +0000)]
(bug 28868) Include the number of pages in the default getLongDesc for multipaged documents
This will only include the number of pages if there is at least two pages.
If you have a pdf with a single page, it won't say 1 page. I modeled this
on how animated images will only say x frames if x > 1.
(For reference, this will affect extensions like pdfHandler, but it won't
affect extensions like PagedTiffHandler since that one totally overrides
the default method)
Niklas Laxström [Sat, 7 May 2011 17:04:00 +0000 (17:04 +0000)]
Followup r87578:
PHP Notice: Use of Linker::makeLinkObj is deprecated. [Called from call_user_func_array in (internal function)] for /w/i.php?title=Special:RecentChanges&translations=filter<ul>
<li>- line - calls Linker::makeLinkObj()</li>
<li>Skin.php line 1552 calls call_user_func_array()</li>
<li>- line - calls Skin::__call()</li>
<li>Renameuser.php line 58 calls SkinVector::makeLinkObj()</li>
<li>- line - calls wfRenameUserLogActionText()</li>
Niklas Laxström [Sat, 7 May 2011 16:50:36 +0000 (16:50 +0000)]
Sigh, syntax terror in r87640
Happy-melon [Sat, 7 May 2011 15:37:23 +0000 (15:37 +0000)]
Follow-up r87637: the terrors of copy-and-paste.
Happy-melon [Sat, 7 May 2011 15:30:46 +0000 (15:30 +0000)]
Autoloader entries for r86041.
Happy-melon [Sat, 7 May 2011 15:28:55 +0000 (15:28 +0000)]
Fix E_STRICT reported on r86273 CR.
Siebrand Mazeland [Sat, 7 May 2011 15:27:28 +0000 (15:27 +0000)]
Localisation updates for namespace names from translatewiki.net.
Happy-melon [Sat, 7 May 2011 15:25:27 +0000 (15:25 +0000)]
Move minimum database versions to Defines.php
Happy-melon [Sat, 7 May 2011 15:16:01 +0000 (15:16 +0000)]
Centralise the minimum-required-php-version in a MW_MIN_PHP_VERSION constant in Defines.php. This requires loading Defines.php before the PHP4 version checks, so include a big note reminding people not to include anything other than vanilla define() statements in there.
I have a sneaking suspicion that including Defines.php in the entry points might not play nicely with HipHop, but I can't test it (wrong OS).
Siebrand Mazeland [Sat, 7 May 2011 14:57:19 +0000 (14:57 +0000)]
Localisation updates for magic words from translatewiki.net.
Happy-melon [Sat, 7 May 2011 14:53:08 +0000 (14:53 +0000)]
* Implement MW_VERSION constant in Defines.php and use it in preference to $wgVersion. Defines.php will have been loaded anywhere that DefaultSettings.php has been loaded.
* Move the declaration of $wgFeedClasses from Defines.php to WebStart.php
Platonides [Sat, 7 May 2011 14:45:48 +0000 (14:45 +0000)]
Revert r87542 and rename RELEASE-NOTES to keep them both in trunk and branch
per http://thread.gmane.org/gmane.science.linguistics.wikipedia.technical/53208
Siebrand Mazeland [Sat, 7 May 2011 14:19:48 +0000 (14:19 +0000)]
Localisation updates for special page aliases from translatewiki.net.
This changeset contains both resorted arrays as well as updates. Unfortunately the resorting makes the diffs unreadable :(.
Sam Reed [Sat, 7 May 2011 14:02:22 +0000 (14:02 +0000)]
Followup r87261
Somewhat vague spec is somehwat vague
Happy-melon [Sat, 7 May 2011 14:01:49 +0000 (14:01 +0000)]
Follow-up r85918:
* Clean up the ugly adding-then-removing-then-readding HTML <head> and <body> tags in DBConnectionError, deprecates MWException::htmlBodyOnly()
* Also deprecates MWException::htmlHeader(), removes code duplication since MWException::reportHTML() can safely call wfDie() and get an output format appropriate for the entry point
* Copy a couple of HTML headers (Cache-control, Pragma and Content-type) to the wfDie() implementation.
Happy-melon [Sat, 7 May 2011 13:24:47 +0000 (13:24 +0000)]
(bug 28834) Restore nl2br() wrappers removed in r85918.
Happy-melon [Sat, 7 May 2011 13:05:22 +0000 (13:05 +0000)]
(bug 28797) Fix ApiBase::parseMsg() to properly handle nested error arrays.
Aaron Schulz [Sat, 7 May 2011 10:24:38 +0000 (10:24 +0000)]
(bug 28667) "old title gets two review log entries after move". Fixed this by firing the revisionfromedit hook on the new title, which makes a bit more sense.
Aaron Schulz [Sat, 7 May 2011 09:55:18 +0000 (09:55 +0000)]
Notice: Use of undefined constant GAID_FOR_UPDATE - assumed 'GAID_FOR_UPDATE' in D:\www\MW_trunk\phase3\includes\Title.php on line 3085
Sam Reed [Fri, 6 May 2011 23:39:04 +0000 (23:39 +0000)]
List all removed globals in my recent commits in RELEASE-NOTES
Sam Reed [Fri, 6 May 2011 23:31:59 +0000 (23:31 +0000)]
Remove another unused deprecated function
Update 1 inbound caller
Sam Reed [Fri, 6 May 2011 23:25:57 +0000 (23:25 +0000)]
Kill $wgExtraRandompageSQL
Rewrote extension using them to subclass SpecialRandompage
Sam Reed [Fri, 6 May 2011 23:18:11 +0000 (23:18 +0000)]
Kill $wgAllowUserSkin
Sam Reed [Fri, 6 May 2011 23:15:01 +0000 (23:15 +0000)]
HTMLCacheUpdate->invalidate() deprecated since 1.16, unused
Sam Reed [Fri, 6 May 2011 23:13:09 +0000 (23:13 +0000)]
Xml::hidden() --> Html::hidden()
Xml::hidden() killed
Sam Reed [Fri, 6 May 2011 23:07:20 +0000 (23:07 +0000)]
Remove addExtraSQL
Sam Reed [Fri, 6 May 2011 22:53:59 +0000 (22:53 +0000)]
Documentation
Remove some deprecated in 1.16 functions with no callers
Sam Reed [Fri, 6 May 2011 22:17:48 +0000 (22:17 +0000)]
Fix fail attempt at passing string by reference in r87589
Raimond Spekking [Fri, 6 May 2011 22:11:48 +0000 (22:11 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-05-06 22:02:00 UTC)
Sam Reed [Fri, 6 May 2011 22:09:47 +0000 (22:09 +0000)]
Kill off the long deprecated $wgInputEncoding and $wgOutputEncoding globals
Sam Reed [Fri, 6 May 2011 21:57:55 +0000 (21:57 +0000)]
Kill $wgRateLimitsExcludedGroups which was deprecated in 1.13
Krinkle [Fri, 6 May 2011 21:55:25 +0000 (21:55 +0000)]
mw.util.isMainPage(); Was never released, removing before release since it's deprecated: Use wgIsMainPage in mw.config instead.
Sam Reed [Fri, 6 May 2011 21:50:18 +0000 (21:50 +0000)]
More versions added to @deprecated tags
Couple of inbound calls fixed up
Some ancient code removed as it's been marked deprecated
Rotem Liss [Fri, 6 May 2011 21:26:29 +0000 (21:26 +0000)]
Localization update for he.
Sam Reed [Fri, 6 May 2011 21:09:34 +0000 (21:09 +0000)]
Kill some more long deprecated unused functions
Add more @deprecated since where appropriate
Sam Reed [Fri, 6 May 2011 20:59:58 +0000 (20:59 +0000)]
Remove some stuff marked as deprecated <= 1.16 unused
Stuff still used left for the moment
Added some since to @deprecated
Added wfDeprecated( __METHOD__ ); in one case
Sam Reed [Fri, 6 May 2011 20:50:16 +0000 (20:50 +0000)]
Couple more deprecated things removed
Sam Reed [Fri, 6 May 2011 20:46:13 +0000 (20:46 +0000)]
More __ for r87572
Sam Reed [Fri, 6 May 2011 20:43:32 +0000 (20:43 +0000)]
Add wfDeprecated( __METHOD ); to one method marked for 1.19
Sam Reed [Fri, 6 May 2011 20:36:58 +0000 (20:36 +0000)]
Bye bye config directory
Sam Reed [Fri, 6 May 2011 20:35:52 +0000 (20:35 +0000)]
Remove install-utils.inc marked for 1.19 removal
Alexandre Emsenhuber [Fri, 6 May 2011 18:22:37 +0000 (18:22 +0000)]
Removed more functions marked for removal in 1.19: wfParseCIDR(), wfRFC822Phrase() and userMailer().
Alexandre Emsenhuber [Fri, 6 May 2011 18:17:52 +0000 (18:17 +0000)]
Removed LogPageValidTypes, LogPageLogName, LogPageLogHeader and LogPageActionText hooks. They are deprecated since 1.6 or so.
Alexandre Emsenhuber [Fri, 6 May 2011 18:10:53 +0000 (18:10 +0000)]
Remove functions marked for removal in 1.19
Chad Horohoe [Fri, 6 May 2011 15:45:13 +0000 (15:45 +0000)]
(bug 10154) Don't allow user to specify days beyond $wgRCMaxAge
Chad Horohoe [Fri, 6 May 2011 14:57:05 +0000 (14:57 +0000)]
Fix for r80864, host not server. Like r87498
Sam Reed [Fri, 6 May 2011 14:52:12 +0000 (14:52 +0000)]
Fix 2 more 1.18's from RELEASE-NOTES in r87542
Sam Reed [Fri, 6 May 2011 14:48:00 +0000 (14:48 +0000)]
Followup r87541
Move RELEASE-NOTES to HISTORY
Chad Horohoe [Fri, 6 May 2011 14:45:25 +0000 (14:45 +0000)]
Bump trunk version since we've branched
Chad Horohoe [Thu, 5 May 2011 22:27:54 +0000 (22:27 +0000)]
5.2.3, like we do everywhere else
Chad Horohoe [Thu, 5 May 2011 21:28:26 +0000 (21:28 +0000)]
Fix for r87278: if we're installing with the same user we're going to use, skip creation && grants since there's no point.
Raimond Spekking [Thu, 5 May 2011 20:38:04 +0000 (20:38 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-05-05 20:28:00 UTC)
Chad Horohoe [Thu, 5 May 2011 18:55:10 +0000 (18:55 +0000)]
Followup r87487: drop unused message
Alexandre Emsenhuber [Thu, 5 May 2011 17:42:14 +0000 (17:42 +0000)]
Moved wfTimestampNow() near other wfTimestamp() functions
Merlijn S. van Deen [Thu, 5 May 2011 15:04:19 +0000 (15:04 +0000)]
Fixes ForeignDBRepo SQL server connection. Fixes bug #28836.
Roan Kattouw [Thu, 5 May 2011 13:46:47 +0000 (13:46 +0000)]
Per bug 28738 comment 4, pack ResourceLoader URLs by encoding foo.bar|foo.baz|bar.baz|bar.quux as foo.bar,baz|bar.baz,quux
* Expand these URLs in ResourceLoaderContext
* Build and emit these URLs in OutputPage::makeResourceLoaderLink() and in mw.loader
* Throw an exception in ResourceLoader::register() for module names that contain pipe characters or commas. Commas need to be forbidden for this packing feature to work. Pipes were already forbidden but weren't checked for
Roan Kattouw [Thu, 5 May 2011 11:52:23 +0000 (11:52 +0000)]
For bug 28738, have the installer check for the Suhosin GET variable length limit and set $wgResourceLoaderMaxQueryLength correspondingly in LocalSettings.php . Of course this only works for new installs, no idea if this can be handled cleanly for upgrades
Tim Starling [Thu, 5 May 2011 10:37:20 +0000 (10:37 +0000)]
UPGRADE updates:
* $wgDBadminuser is no longer required
* $wgUpgradeKey is no longer required
* The installer has moved to /mw-config
* You can't change the encoding any more so that's not a concern
* Moved the 1.16 info to its own section
* Cleaned up heading consistency and levels so that it looks nice in the table of contents in the new installer
* Removed duplicate backup section
Leo Koppelkamm [Thu, 5 May 2011 09:12:55 +0000 (09:12 +0000)]
Fix PHP notice in r85922. Sorry for the holdup, I kinda forgot about it
Max Semenik [Thu, 5 May 2011 08:20:15 +0000 (08:20 +0000)]
Bug 28822 - Upgrade from normal 1.16 wiki to 1.17 fails with fatal error
Chad Horohoe [Thu, 5 May 2011 06:29:33 +0000 (06:29 +0000)]
Kill $wgSkinExtensionFunctions. Way back in r4934 when it was introduced, it was near the beginning of Setup.php, and $wgExtensionFunctions was near the end. Thus, they served two different purposes for doing extension setup. Refactoring over time has brought these processes side-by-side and thus the unused (and less-featured) one is getting the axe.
-1 more awful global \o/
Tim Starling [Thu, 5 May 2011 05:29:50 +0000 (05:29 +0000)]
* Fix for bug 28534: IE 6 content type detection again
* Fix for bug 28639: user object instance cache pollution
* Release notes formatting tweak.
Chad Horohoe [Thu, 5 May 2011 05:26:27 +0000 (05:26 +0000)]
(bug 28641) Doc fix for wfEmptyMsg()
Chad Horohoe [Thu, 5 May 2011 05:11:50 +0000 (05:11 +0000)]
(bug 23495) Allow createAndPromote.php to create non-sysop users
Trevor Parscal [Wed, 4 May 2011 23:26:43 +0000 (23:26 +0000)]
Added jquery.appear, which adds a new event which fires the first time something comes into view. This is useful for lazy-loading data.
Russ Nelson [Wed, 4 May 2011 23:17:00 +0000 (23:17 +0000)]
Likely that nobody is calling getPath() on a ForeignAPI repo, but best to warn them anyway.
Chad Horohoe [Wed, 4 May 2011 23:09:18 +0000 (23:09 +0000)]
Various fixes for CleanUpTest
Chad Horohoe [Wed, 4 May 2011 23:05:25 +0000 (23:05 +0000)]
Move CleanUpTest, fixes in next commit
Russ Nelson [Wed, 4 May 2011 22:26:48 +0000 (22:26 +0000)]
This part of the API seems universally ignored. If anybody needs this, they're going to have to modify every caller anyway, so it serves no purpose by existing. There, now my commit message is longer than the code being changed. My work here is done.
Chad Horohoe [Wed, 4 May 2011 22:08:40 +0000 (22:08 +0000)]
Revert r81542 for now, too lazy to fix this properly
Sam Reed [Wed, 4 May 2011 21:23:25 +0000 (21:23 +0000)]
Documentation
Remove unused variables
Krinkle [Wed, 4 May 2011 20:58:14 +0000 (20:58 +0000)]
mw.loader fixes
* Renaming locally declared function "request" to "getScriptTag" to avoid confusion or conflict with the other local "request" function inside the mw.loader closure
* (bug 26804) Code clean up ($skin was generated locally already)
Raimond Spekking [Wed, 4 May 2011 20:09:49 +0000 (20:09 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-05-04 19:40:00 UTC)
Russ Nelson [Wed, 4 May 2011 18:34:50 +0000 (18:34 +0000)]
No current need for an alias to getPath()
Sam Reed [Wed, 4 May 2011 18:14:30 +0000 (18:14 +0000)]
* (bug 28812) API's parse module documentation should no longer include section tree warning
Remove wrong comment
Krinkle [Wed, 4 May 2011 17:23:17 +0000 (17:23 +0000)]
Partial revert of r87345. Causing unreadable buttons in ArticleFeedback (i.imgur.com/PyxOw.png ), likely breaks other things as well.
Raimond Spekking [Wed, 4 May 2011 17:23:14 +0000 (17:23 +0000)]
Follow-up r87411: Remove stray f
Paul Copperman [Wed, 4 May 2011 17:17:27 +0000 (17:17 +0000)]
Follow-up r87394: Add reference back to MediaWiki::performRequestForTitle per IAlex' comment.
Platonides [Wed, 4 May 2011 14:40:25 +0000 (14:40 +0000)]
Tag names can't contain template parameters (thanksfully)
Paul Copperman [Wed, 4 May 2011 11:51:38 +0000 (11:51 +0000)]
Follow-up r87326: Add regression test.
Paul Copperman [Wed, 4 May 2011 11:50:34 +0000 (11:50 +0000)]
Remove references from function parameters in Wiki.php. They aren't needed for objects and sometimes cause warnings when called with non-vars.
Paul Copperman [Wed, 4 May 2011 11:48:47 +0000 (11:48 +0000)]
Follow-up r87266: Fix parser test
Paul Copperman [Wed, 4 May 2011 11:46:28 +0000 (11:46 +0000)]
Follow-up r87210: Add MediaWikiLangTestCase to the autoloader and make the class abstract.
Daniel Friesen [Wed, 4 May 2011 10:43:40 +0000 (10:43 +0000)]
Drop the $out params I added before I added context to Skin, as well deprecate some of the $out params in other methods.
Jure Kajzer [Wed, 4 May 2011 10:43:34 +0000 (10:43 +0000)]
* fixed tableName handling for internal purposes (bug if using sharedDB as i need raw table name)
Tim Starling [Wed, 4 May 2011 02:09:16 +0000 (02:09 +0000)]
Some release notes updates:
* Removed the obsolete part about continuous integration models. I already removed it in the 1.16 branch and will shortly remove it from the 1.17 branch.
* Updated the information about supported databases.
* Removed the part about XHTML support since we target HTML 5 now.
* Say what mediawiki-l is instead of saying what it isn't.