From: Erik Bernhardson <ebernhardson@wikimedia.org>
Date: Mon, 20 Aug 2018 21:58:25 +0000 (-0700)
Subject: Resolve deprecation warnings in iw search widget
X-Git-Tag: 1.34.0-rc.0~4362^2
X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/comptes/ajouter.php?a=commitdiff_plain;h=f9e4244845c1914262a6f43f96116e84b7d6c424;p=lhc%2Fweb%2Fwiklou.git

Resolve deprecation warnings in iw search widget

The old iteration api has been deprecated, but looks like this
call wasn't caught in the patch that introduced it.

Change-Id: I435bacdb185e09127606217982ca70a1bec60301
---

diff --git a/includes/widget/search/InterwikiSearchResultSetWidget.php b/includes/widget/search/InterwikiSearchResultSetWidget.php
index b4e3414857..79380def75 100644
--- a/includes/widget/search/InterwikiSearchResultSetWidget.php
+++ b/includes/widget/search/InterwikiSearchResultSetWidget.php
@@ -65,12 +65,10 @@ class InterwikiSearchResultSetWidget implements SearchResultSetWidget {
 
 		$iwResults = [];
 		foreach ( $resultSets as $resultSet ) {
-			$result = $resultSet->next();
-			while ( $result ) {
+			foreach ( $resultSet as $result ) {
 				if ( !$result->isBrokenTitle() ) {
 					$iwResults[$result->getTitle()->getInterwiki()][] = $result;
 				}
-				$result = $resultSet->next();
 			}
 		}