From 583e3487b80c1802c78a70f36baabb04717346f6 Mon Sep 17 00:00:00 2001 From: Chad Horohoe Date: Fri, 1 Apr 2011 15:57:20 +0000 Subject: [PATCH] Revert r64853 (add $wgLogAutocreatedAccounts to enable/disable account autocreation logging, bug 19161). Per the *extremely lengthy* discussion that is still ongoing, this fails to solve the underlying problem and has undesired side-effects. I don't know what the proper solution is (other than introducing user preferences, like bug 28369 suggests, is not the answer)...but the status quo of what we had is better than this half-assed solution that *nobody* likes. --- HISTORY | 2 -- includes/DefaultSettings.php | 5 ----- includes/User.php | 4 ++-- 3 files changed, 2 insertions(+), 9 deletions(-) diff --git a/HISTORY b/HISTORY index 7dcd72896e..79b89e1f4e 100644 --- a/HISTORY +++ b/HISTORY @@ -19,8 +19,6 @@ are used instead. === Configuration changes in 1.17 === * DatabaseFunctions.php that was needed for compatibility with pre-1.3 extensions has been removed. -* $wgLogAutocreatedAccounts controls whether autocreation of accounts is logged - to new users log. * $wgAllowImageTag can be set to true to whitelist the tag in wikitext. * (bug 12797) Add $wgGalleryOptions for adjusting of default gallery display options. diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php index c7d287654d..36daef4b1d 100644 --- a/includes/DefaultSettings.php +++ b/includes/DefaultSettings.php @@ -4915,11 +4915,6 @@ $wgLogActionsHandlers = array(); */ $wgNewUserLog = true; -/** - * Log the automatic creations of new users accounts? - */ -$wgLogAutocreatedAccounts = false; - /** @} */ # end logging } /*************************************************************************//** diff --git a/includes/User.php b/includes/User.php index 06515cf72d..631babcf2b 100644 --- a/includes/User.php +++ b/includes/User.php @@ -3699,8 +3699,8 @@ class User { * Used by things like CentralAuth and perhaps other authplugins. */ public function addNewUserLogEntryAutoCreate() { - global $wgNewUserLog, $wgLogAutocreatedAccounts; - if( !$wgNewUserLog || !$wgLogAutocreatedAccounts ) { + global $wgNewUserLog; + if( !$wgNewUserLog ) { return true; // disabled } $log = new LogPage( 'newusers', false ); -- 2.20.1