From 423d655c6e6c1d2601d391c73c170b0d29f13419 Mon Sep 17 00:00:00 2001 From: Siebrand Mazeland Date: Mon, 25 Nov 2013 16:32:17 +0100 Subject: [PATCH] Set visibility on class properties of Job Change-Id: Ib8c85e8b1ca46855dfdb1678639d1d1b749d87a3 --- includes/job/Job.php | 27 +++++++++++++++++---------- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/includes/job/Job.php b/includes/job/Job.php index 0359540109..b1400de938 100644 --- a/includes/job/Job.php +++ b/includes/job/Job.php @@ -28,20 +28,27 @@ * @ingroup JobQueue */ abstract class Job { - /** - * @var Title - */ - var $title; + /** @var int Job identifier */ + public $id; + + /** @var string */ + public $command; - var $command, - $params, - $id, - $removeDuplicates, - $error; + /** @var array|bool Array of job parameters or false if none */ + public $params; - /** @var Array Additional queue metadata */ + /** @var array Additional queue metadata */ public $metadata = array(); + /** @var Title */ + protected $title; + + /** @var bool Expensive jobs may set this to true */ + protected $removeDuplicates; + + /** @var string Text for error that occurred last */ + protected $error; + /*------------------------------------------------------------------------- * Abstract functions *------------------------------------------------------------------------*/ -- 2.20.1