From 3f69f0eb8845fda3fd0c51ecae3c4bf8d2e8457b Mon Sep 17 00:00:00 2001 From: Dayllan Maza Date: Wed, 16 Jan 2019 13:20:51 -0500 Subject: [PATCH] Fix BlockList params for non-editing partial blocks When multiple blocks are listed, if there is a partial block with restrictions, any other partial block in the list will be shown as an editing block even if it isn't. Bug: T213952 Change-Id: Ieafb5f71c484d9f0551fa293f7c43e1a3a2e1f2a --- includes/specials/pagers/BlockListPager.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/includes/specials/pagers/BlockListPager.php b/includes/specials/pagers/BlockListPager.php index a0b14d2cdb..205ffbf8b0 100644 --- a/includes/specials/pagers/BlockListPager.php +++ b/includes/specials/pagers/BlockListPager.php @@ -199,7 +199,9 @@ class BlockListPager extends TablePager { if ( !$row->ipb_sitewide && $this->restrictions ) { $list = $this->getRestrictionListHTML( $this->restrictions, $row ); - $properties[] = htmlspecialchars( $msg['blocklist-editing'] ) . $list; + if ( $list ) { + $properties[] = htmlspecialchars( $msg['blocklist-editing'] ) . $list; + } } if ( $row->ipb_anon_only ) { -- 2.20.1