From 2240a3c4effe4d43a9f92c676b9a7e0f673b863f Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bartosz=20Dziewo=C5=84ski?= Date: Wed, 19 Sep 2018 20:00:28 +0200 Subject: [PATCH] Special:Preferences: Remove unnecessary OOUI styles override Since OOUI v0.24.4, menus/popups of infused PHP widgets are placed into the default overlay, so this workaround is not needed. Change-Id: I4f8a76cb258e44ed4f2fbba41425100d2e0e9b45 --- ...awiki.special.preferences.styles.ooui.less | 20 +++++-------------- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/resources/src/mediawiki.special.preferences.styles.ooui.less b/resources/src/mediawiki.special.preferences.styles.ooui.less index e20d24bcfc..baa9beb305 100644 --- a/resources/src/mediawiki.special.preferences.styles.ooui.less +++ b/resources/src/mediawiki.special.preferences.styles.ooui.less @@ -34,21 +34,11 @@ .mixin-screen-reader-text; } -/* Override OOUI styles so that dropdowns near the bottom of the form don't get clipped, - * e.g. 'Appearance' / 'Threshold for stub link formatting'. This is hacky and bad, it would be - * better solved by setting overlays for the widgets, but we can't do it from PHP… */ -#preferences .oo-ui-panelLayout { - position: static; - - overflow: visible; - .transform( none ); - - /* Most outer Panellayout: - * Decrease contrast of `border` slightly as padding/border combination is sufficient - * accessibility wise and focus of content is more important here. */ - &-framed { - border-color: #c8ccd1; - } +/* Most outer Panellayout: + * Decrease contrast of `border` slightly as padding/border combination is sufficient + * accessibility wise and focus of content is more important here. */ +#preferences .oo-ui-panelLayout-framed { + border-color: #c8ccd1; } #preferences .oo-ui-menuLayout .oo-ui-panelLayout-framed .oo-ui-panelLayout-framed { -- 2.20.1