From: Timo Tijhof <krinklemail@gmail.com>
Date: Fri, 15 Jun 2018 22:15:26 +0000 (+0100)
Subject: stats: Hard-deprecate BufferingStatsdDataFactory::getBuffer()
X-Git-Tag: 1.34.0-rc.0~5034^2
X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/banques/ajouter.php?a=commitdiff_plain;h=fad1d907606517e0e31ffbca69273d1351479031;p=lhc%2Fweb%2Fwiklou.git

stats: Hard-deprecate BufferingStatsdDataFactory::getBuffer()

Follows-up 7fdc3d09a3b6. Also document the getData method.

This method seems unused from a quick glance at Code Search, but
there's a lot of false positives from Monolog instances.

To play safe, rather than removing, add hard-deprecation for
a few days just in case we find another hit.

Change-Id: I8aab93744e66c1a583c67f0bbac27a45250a8fbb
---

diff --git a/includes/libs/stats/BufferingStatsdDataFactory.php b/includes/libs/stats/BufferingStatsdDataFactory.php
index 06915b2dd2..5ef01350d8 100644
--- a/includes/libs/stats/BufferingStatsdDataFactory.php
+++ b/includes/libs/stats/BufferingStatsdDataFactory.php
@@ -92,10 +92,11 @@ class BufferingStatsdDataFactory extends StatsdDataFactory implements IBuffering
 	}
 
 	/**
-	 * @deprecated Use getData()
+	 * @deprecated since 1.30 Use getData() instead
 	 * @return StatsdData[]
 	 */
 	public function getBuffer() {
+		wfDeprecated( __METHOD__, '1.30' );
 		return $this->buffer;
 	}
 
@@ -103,6 +104,10 @@ class BufferingStatsdDataFactory extends StatsdDataFactory implements IBuffering
 		return !empty( $this->buffer );
 	}
 
+	/**
+	 * @since 1.30
+	 * @return StatsdData[]
+	 */
 	public function getData() {
 		return $this->buffer;
 	}