dépôts
/
lhc
/
web
/
wiklou.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
fd9c94d
)
Use shell_exec instead of backtick
author
Matthew Flaschen
<mflaschen@wikimedia.org>
Thu, 6 Jul 2017 23:14:38 +0000
(19:14 -0400)
committer
Matthew Flaschen
<mflaschen@wikimedia.org>
Thu, 6 Jul 2017 23:14:38 +0000
(19:14 -0400)
They are exactly equivalent, but shell_exec is more readable.
We just imported a sniff to forbid backtick into mediawiki-codesniffer.
It's not deployed here yet, but this will facilitate it.
Change-Id: I4b58ed78e1792ff83e1bf99425f8f19123cfe911
maintenance/mwdocgen.php
patch
|
blob
|
history
diff --git
a/maintenance/mwdocgen.php
b/maintenance/mwdocgen.php
index
d005629
..
43041a4
100644
(file)
--- a/
maintenance/mwdocgen.php
+++ b/
maintenance/mwdocgen.php
@@
-105,7
+105,7
@@
class MWDocGen extends Maintenance {
$this->excludePatterns[] = 'extensions';
}
- $this->doDot =
`which dot`
;
+ $this->doDot =
shell_exec( 'which dot' )
;
$this->doMan = $this->hasOption( 'generate-man' );
}