Timo Tijhof [Mon, 20 Mar 2017 21:55:22 +0000 (14:55 -0700)]
phpunit: Fix RecentChangeTest failure when coverage is enabled
From <https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage/>
2) RecentChangeTest::testIsInRCLifespan with data set #0 (6000,
1490019080, 0, true)
Failed asserting that false matches expected true.
3) RecentChangeTest::testIsInRCLifespan with data set #3 (3000,
1490016080, 6000, true)
Failed asserting that false matches expected true.
Change-Id: I309bb229542f3af62e3e83025d88e77ecb55cd31
jenkins-bot [Mon, 20 Mar 2017 22:00:30 +0000 (22:00 +0000)]
Merge "Revert "RCFilters: Change reset button title when it changes state""
jenkins-bot [Mon, 20 Mar 2017 21:48:35 +0000 (21:48 +0000)]
Merge "Track usage of highlight feature"
Catrope [Mon, 20 Mar 2017 21:43:32 +0000 (21:43 +0000)]
Revert "RCFilters: Change reset button title when it changes state"
It makes no sense to add a tooltip to a button that already
has text, especially if the tooltip text is (almost)
the same as the button text.
This reverts commit
31047fb1bf03944158fe4f7da99686e7955a3b5c.
Change-Id: I2f9c819a85fc05f37c7c0c5acf2d72319bdb0d76
jenkins-bot [Mon, 20 Mar 2017 21:35:43 +0000 (21:35 +0000)]
Merge "mediawiki.widgets: Remove autoEllipsis() from TitleOptionWidget"
jenkins-bot [Mon, 20 Mar 2017 21:18:58 +0000 (21:18 +0000)]
Merge "Adjust message history-fieldset-title"
jenkins-bot [Mon, 20 Mar 2017 21:00:12 +0000 (21:00 +0000)]
Merge "RCFilters: Scroll popup up to top when it is reopened"
jenkins-bot [Mon, 20 Mar 2017 20:03:37 +0000 (20:03 +0000)]
Merge "Disable filter by redirect Special:AllPages and query=allpages in miser mode"
jenkins-bot [Mon, 20 Mar 2017 19:55:26 +0000 (19:55 +0000)]
Merge "RecentChanges: Correct 'no matches found' message"
jenkins-bot [Mon, 20 Mar 2017 19:50:54 +0000 (19:50 +0000)]
Merge "RCFilters: Change reset button title when it changes state"
jenkins-bot [Mon, 20 Mar 2017 19:36:53 +0000 (19:36 +0000)]
Merge "Use executeOpHandlesInternal() in SwiftFileBackend"
Reedy [Mon, 20 Mar 2017 17:54:40 +0000 (17:54 +0000)]
Disable filter by redirect Special:AllPages and query=allpages in miser mode
Bug: T160916
Change-Id: Ib9562b404731e1f621b9f07c33821d04cd2aa6ae
Moriel Schottlender [Mon, 20 Mar 2017 19:12:15 +0000 (12:12 -0700)]
RCFilters: Scroll popup up to top when it is reopened
Change-Id: I0cad078f2d6b3062189ca3aca0085e346667d1bf
Moriel Schottlender [Mon, 20 Mar 2017 18:57:42 +0000 (11:57 -0700)]
RecentChanges: Correct 'no matches found' message
Change-Id: Ic490fae5f3d7c474f368e981bfe9572108cf07e7
Moriel Schottlender [Mon, 20 Mar 2017 18:21:16 +0000 (11:21 -0700)]
RCFilters: Change reset button title when it changes state
The button changes state between 'restore default filters' and
the trash icon which is to remove all selected filters.
The title for the button should also change accordingly.
Change-Id: I9070f0c4959f5c7c97d57d943103ae2baf89d6d2
Aaron Schulz [Mon, 13 Mar 2017 21:26:56 +0000 (14:26 -0700)]
Use executeOpHandlesInternal() in SwiftFileBackend
Instead calling doExecuteOpHandlesInternal() directly, use the
wrapper parent class method instead so that closeResources() is
called on all of the handles.
Change-Id: Iab0d4f7c08d155639a44f48147b78283059a6d24
Timo Tijhof [Sat, 18 Mar 2017 00:04:12 +0000 (17:04 -0700)]
mediawiki.widgets: Remove autoEllipsis() from TitleOptionWidget
Redundant with CSS 'text-overflow: ellipsis', which is already applied.
Aside from ellipsis overflow, autoEllipsis() was also serving as indirect
caller of `highlightText( option.matchText )` and `attr('title')`,
which we want to keep, so leave that in its place.
Bug: T160804
Change-Id: I550183750d66d769cc9c960150a2349d1b9181aa
jenkins-bot [Mon, 20 Mar 2017 17:05:58 +0000 (17:05 +0000)]
Merge "Selenium tests in Node.js using WebdriverIO"
Umherirrender [Mon, 20 Mar 2017 15:55:58 +0000 (16:55 +0100)]
Adjust message history-fieldset-title
"Browse" could assume to browse the old wikitext of this page. Changed
it to "Search" similar to message sp-contributions-search, which is used
on Special:Contributions for a similar fieldset
Change-Id: I87b17d352999536c29df898c5822f61016bd7873
jenkins-bot [Mon, 20 Mar 2017 15:02:27 +0000 (15:02 +0000)]
Merge "RCFilters UI: Followup Ic97c7c6aae7: Only add state message if item is selected"
Stephane Bisson [Mon, 20 Mar 2017 10:54:35 +0000 (06:54 -0400)]
Track usage of highlight feature
Bug: T158344
Change-Id: I9a0c5e40b813e075ec33eea882b625dc43a15df6
jenkins-bot [Mon, 20 Mar 2017 09:32:47 +0000 (09:32 +0000)]
Merge "Replace deprecated Context::getStats() with MWServices::getStatsdDataFactory()"
jenkins-bot [Mon, 20 Mar 2017 07:32:56 +0000 (07:32 +0000)]
Merge "Avoid database connection in SpecialSearchTest data provider"
Translation updater bot [Sun, 19 Mar 2017 20:53:59 +0000 (21:53 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I8909bf70bc12c12dd42e318e70987b0597760b67
jenkins-bot [Sun, 19 Mar 2017 09:30:53 +0000 (09:30 +0000)]
Merge "Remove deprecated noop functions"
Translation updater bot [Sat, 18 Mar 2017 21:03:51 +0000 (22:03 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I525052178b2be3c22e4016cea54d96ea6e687a87
aude [Sat, 18 Mar 2017 19:42:09 +0000 (15:42 -0400)]
Avoid database connection in SpecialSearchTest data provider
SearchResult::newFromTitle involves database connnection,
thus better to avoid calling this in the data provider.
Change-Id: I891e97cf18ca1dd44abefe01731dfc5da51f1982
Moriel Schottlender [Sat, 18 Mar 2017 18:39:36 +0000 (11:39 -0700)]
RCFilters UI: Followup Ic97c7c6aae7: Only add state message if item is selected
Unselected items are highlighted, and hence are not in actual conflict
or coverage or inclusion states.
Bug: T156427
Change-Id: Ie8b6020e6dc93b46e94d2bc2bebb71b56f1e3645
jenkins-bot [Sat, 18 Mar 2017 09:50:32 +0000 (09:50 +0000)]
Merge "Replace deprecated jQuery.nodeName"
jenkins-bot [Sat, 18 Mar 2017 02:16:51 +0000 (02:16 +0000)]
Merge "resourceloader: Fix broken @coverage for ImageModuleTest"
jenkins-bot [Sat, 18 Mar 2017 02:16:46 +0000 (02:16 +0000)]
Merge "RCFilters: Update conflict messages"
jenkins-bot [Sat, 18 Mar 2017 02:01:52 +0000 (02:01 +0000)]
Merge "RCFilters UI: Implement conflict global result message"
Roan Kattouw [Sat, 18 Mar 2017 01:45:47 +0000 (18:45 -0700)]
RCFilters: Update conflict messages
Bug: T160803
Change-Id: I5c645ddce991f9352d779ba4d72d5171a948f836
Timo Tijhof [Sat, 18 Mar 2017 01:26:08 +0000 (18:26 -0700)]
resourceloader: Fix broken @coverage for ImageModuleTest
Follows-up
f4329ddbc8.
Change-Id: I7e1761295328af7ead42da4b722a2275b5c1ddb9
jenkins-bot [Sat, 18 Mar 2017 01:16:49 +0000 (01:16 +0000)]
Merge "Watchlist: Fix form and preference overriding"
Moriel Schottlender [Sat, 18 Mar 2017 00:29:07 +0000 (17:29 -0700)]
RCFilters UI: Implement conflict global result message
Bug: T156427
Change-Id: I7ae968477091db37e3e2d17fca6f212f919d90d8
jenkins-bot [Sat, 18 Mar 2017 01:05:29 +0000 (01:05 +0000)]
Merge "RCFilters UI: Create tooltips for filter states"
Matthew Flaschen [Fri, 17 Mar 2017 22:33:12 +0000 (18:33 -0400)]
Watchlist: Fix form and preference overriding
Fix a regression caused by
aa063f4c5a19. Restore the behavior
where:
* Without action=submit: Boolean preferences apply to the displayed form and its
results, but they can be overriden by the query string.
* With action=submit: Only boolean parameters in the query string apply;
preferences are not considered.
(However, boolean preferences not on the form, i.e. 'extended', still
always apply.)
This behavior is a consequence of how checkboxes work in HTML; only
checked boxes are sent to the server.
Bug: T160734
Change-Id: Ic050dd1445ade9449496bb051f04ca0a87b8b5d7
jenkins-bot [Sat, 18 Mar 2017 00:50:13 +0000 (00:50 +0000)]
Merge "Mark 'jquery.autoElllipsis' module as deprecated"
Roan Kattouw [Fri, 10 Mar 2017 03:47:34 +0000 (19:47 -0800)]
RCFilters UI: Create tooltips for filter states
Tooltips represent the state of the filter, whether it is
conflicted, included, or fully covered.
If none of the above, tooltip message falls back on displaying
the description of the filter.
Bug: T156864
Change-Id: Ic97c7c6aae78bb6ddf51f0294eeae4b7f86a1a1d
jenkins-bot [Sat, 18 Mar 2017 00:38:43 +0000 (00:38 +0000)]
Merge "resourceloader: Fix broken 'deprecated' string messages"
Timo Tijhof [Fri, 17 Mar 2017 23:57:36 +0000 (16:57 -0700)]
Mark 'jquery.autoElllipsis' module as deprecated
It was originally introduced for jquery.searchSuggest, which hasn't
used this since 2014 (
56a4aff8ca61106c) when it was removed for
performance reasons (T61172) in favour of CSS text-overflow.
Deprecation is done the same way as for 'jquery.arrowSteps'.
Bug: T160804
Change-Id: Ib7b37b94200a8802de9d98581d3cb42df6e5ba17
Timo Tijhof [Sat, 18 Mar 2017 00:22:34 +0000 (17:22 -0700)]
resourceloader: Fix broken 'deprecated' string messages
Some used a string value, others an array with 'message' property.
Standardise on the string value, which seems more intuitive.
Change-Id: I5caead7b7017d2bad660db02fb45a54a26bf3728
Timo Tijhof [Sat, 18 Mar 2017 00:11:53 +0000 (17:11 -0700)]
Remove unused 'jquery.arrowSteps' (deprecated in 1.28)
Was only used by UploadWizard, and no-where else in Wikimedia Git.
UploadWizard has its own copy as of last year. (T144974)
Change-Id: I3d426f67f8ba061d10434469f261cb725bd672d6
jenkins-bot [Fri, 17 Mar 2017 23:50:07 +0000 (23:50 +0000)]
Merge "RCFilters UI: Remove custom margin from capsule item widgets"
Moriel Schottlender [Fri, 17 Mar 2017 22:35:21 +0000 (15:35 -0700)]
RCFilters UI: Close gap between popup and input
Bug: T160213
Change-Id: I9a36be445c3203b599034f8c45297ecd635cbcaf
Moriel Schottlender [Fri, 17 Mar 2017 22:41:00 +0000 (15:41 -0700)]
RCFilters UI: Remove custom margin from capsule item widgets
Use the default margin for capsule item widget from OOUI so it
has proper distance in the second row as well.
Bug: T160784
Change-Id: Icba3f0fe532f473d066261405ddc04b8b6c6a31f
Translation updater bot [Fri, 17 Mar 2017 20:57:16 +0000 (21:57 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ibf1d7374533428a2024f5f252c6d91ecc866455d
jenkins-bot [Fri, 17 Mar 2017 20:21:42 +0000 (20:21 +0000)]
Merge "ResourceLoaderOOUIModule: Minor code quality fixes, and more comments"
jenkins-bot [Fri, 17 Mar 2017 20:05:21 +0000 (20:05 +0000)]
Merge "RCFilters UI: Add a 'what's this?' link to filter groups"
Moriel Schottlender [Fri, 17 Mar 2017 00:21:36 +0000 (17:21 -0700)]
RCFilters UI: Add a 'what's this?' link to filter groups
Bug: T159186
Change-Id: I347c23fdabab2a1e1c52f5b10995bcbb2a316875
Fomafix [Fri, 17 Mar 2017 14:42:20 +0000 (15:42 +0100)]
Replace deprecated jQuery.nodeName
jQuery.nodeName gets deprecated in jQuery 3.2.0. [1] [2]
[1] https://blog.jquery.com/2017/03/16/jquery-3-2-0-is-out/
[2] https://github.com/jquery/jquery/issues/3475
Change-Id: I7e6d5191e4db5117dbcfa89b07f25e672ed1e4d2
WMDE-Fisch [Fri, 17 Mar 2017 10:57:37 +0000 (11:57 +0100)]
Replace deprecated Context::getStats() with MWServices::getStatsdDataFactory()
Change-Id: I1756f69ca2ebd301a5049bf758d1a87c37771fe6
WMDE-Fisch [Fri, 17 Mar 2017 10:25:53 +0000 (11:25 +0100)]
Remove deprecated noop functions
Change-Id: Ia821d43e243b1ee146d3bc4ed35f6aff0bf17466
jenkins-bot [Fri, 17 Mar 2017 08:35:06 +0000 (08:35 +0000)]
Merge "Add password validation to Special:ChangeCredentials"
jenkins-bot [Fri, 17 Mar 2017 08:32:34 +0000 (08:32 +0000)]
Merge "Update account creation form validation"
jenkins-bot [Fri, 17 Mar 2017 06:33:31 +0000 (06:33 +0000)]
Merge "resourceloader: Use SVG url when ResourceLoaderImageModule can't embed"
Bartosz Dziewoński [Fri, 17 Mar 2017 01:03:04 +0000 (02:03 +0100)]
ResourceLoaderOOUIModule: Minor code quality fixes, and more comments
Change-Id: Ibc7195cc68e1a46062612635988bd16d8145ab63
jenkins-bot [Fri, 17 Mar 2017 00:54:52 +0000 (00:54 +0000)]
Merge "RCFilters UI: Separate name from paramName in filters"
Moriel Schottlender [Sat, 11 Mar 2017 02:10:26 +0000 (18:10 -0800)]
RCFilters UI: Separate name from paramName in filters
Represent filters, internally, with a unique name comprised
of their group and param name, and leave a reference to the
parameter (or value) they represent so the state can be
rebuilt.
Change-Id: I08b69a09463afa1cf08e1cdbf7aaec8dfc16fd2e
jenkins-bot [Thu, 16 Mar 2017 22:28:41 +0000 (22:28 +0000)]
Merge "Add support for PHP7 random_bytes in favor of mcrypt_create_iv"
WMDE-Fisch [Wed, 15 Mar 2017 19:09:17 +0000 (20:09 +0100)]
resourceloader: Use SVG url when ResourceLoaderImageModule can't embed
When the SVG is too big to be embeded it is now included via URL.
Previously it would produce an empty/broken 'url()' value.
Bug: T160532
Change-Id: I158781f9430cfa35737397ac7537a471634c4480
Moriel Schottlender [Thu, 16 Mar 2017 22:04:19 +0000 (15:04 -0700)]
RCfilters UI: Change mute display for included filters
Bug: T156861
Bug: T149452
Change-Id: I64d84f0d84ff5e79da34f4897670102625c667cc
jenkins-bot [Thu, 16 Mar 2017 21:41:38 +0000 (21:41 +0000)]
Merge "RCFilters UI: Rework conflicts to be objects in filter or group context"
Translation updater bot [Thu, 16 Mar 2017 21:30:12 +0000 (22:30 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ic6f9b78a996f4f9971ec99d48f1bca9e9ae69ebb
Moriel Schottlender [Fri, 10 Mar 2017 23:22:12 +0000 (15:22 -0800)]
RCFilters UI: Rework conflicts to be objects in filter or group context
Allow conflicts to be defined in either the filter or the group context
and represent a whole object rather than an array of filter names.
Bug: T160453
Bug: T152754
Bug: T156427
Change-Id: I2423eb2618aa64bf30395b1a1912589e0c71f283
jenkins-bot [Thu, 16 Mar 2017 19:11:23 +0000 (19:11 +0000)]
Merge "Show better error for anons on Special:EmailUser"
jenkins-bot [Thu, 16 Mar 2017 18:58:19 +0000 (18:58 +0000)]
Merge "RCFilters UI: Update fieldset as in load"
jenkins-bot [Thu, 16 Mar 2017 18:58:10 +0000 (18:58 +0000)]
Merge "RCFilters UI: Adjust filter list header elements' alignment"
jenkins-bot [Thu, 16 Mar 2017 18:58:04 +0000 (18:58 +0000)]
Merge "RCFilters UI: Style adjustments for the FilterCapsuleMultiselectWidget"
Moriel Schottlender [Thu, 16 Mar 2017 18:34:33 +0000 (11:34 -0700)]
RCFilters UI: Adjust filter list header elements' alignment
Bug: T160601
Change-Id: I89d3f9c59ef49e3c3dfdda1af8676855d3b9ac7b
Moriel Schottlender [Wed, 15 Mar 2017 21:31:23 +0000 (14:31 -0700)]
RCFilters UI: Update fieldset as in load
Duplicate the javascript used on load on the fieldset
to reproduce the collapse and namespace checkboxes/select
behavior.
Bug: T157594
Change-Id: I12946be6ed6cd7ef60e87fa3576fda42f7005fb6
Moriel Schottlender [Wed, 15 Mar 2017 23:28:04 +0000 (16:28 -0700)]
RCFilters UI: Style adjustments for the FilterCapsuleMultiselectWidget
Bug: T159966
Change-Id: I6864e22d7c628297d8cdf435b48e48fbab1a3f55
jenkins-bot [Thu, 16 Mar 2017 16:56:18 +0000 (16:56 +0000)]
Merge "RCFilters: Prevent duplicate filter names"
Brad Jorsch [Fri, 2 Dec 2016 18:50:01 +0000 (13:50 -0500)]
Add password validation to Special:ChangeCredentials
Change-Id: I70a99f4e742a2ba9ade0348001924fc5a50428d4
Brad Jorsch [Thu, 1 Dec 2016 23:04:21 +0000 (18:04 -0500)]
Update account creation form validation
Use the cancreateerror returned from list=users&usprop=cancreate for
username validation.
Use the new action=validatepassword to validate entered passwords.
This also injects the resulting errors in the style of HTMLForm's field
validation rather than at the top of the form.
Change-Id: Ie8c1270eb605367556fe36b0b2080eb3f957dc54
Eddie Greiner-Petter [Mon, 13 Mar 2017 17:33:35 +0000 (18:33 +0100)]
Show better error for anons on Special:EmailUser
When a anon user visits Special:EmailUser, the PermissionError message
is shown (as only members of the group "user" (all logged in users) are
allowed to do this). There is a better error message, which tells "You
must be logged in and have a valid email adress in your preferences."
available, but was only shown to users who are logged in but did not
have a valid mail adress in their settings, because the check for the
permission "emailuser" happened before the check for the valid mail
(which returns false for anon users). Exchanging the order of those
makes the right error message appear.
Bug: T160309
Change-Id: I26175df1f7577937d9781950058ca458984ce2cb
jenkins-bot [Thu, 16 Mar 2017 11:09:43 +0000 (11:09 +0000)]
Merge "Revert "[search] Remove more dead code""
jenkins-bot [Thu, 16 Mar 2017 08:04:41 +0000 (08:04 +0000)]
Merge "Revert "Default to CACHE_ACCEL if user skips advanced settings""
Matthew Flaschen [Thu, 16 Mar 2017 04:06:02 +0000 (00:06 -0400)]
RCFilters: Prevent duplicate filter names
Explicitly block two filters in the same group from having the same
name.
Before, it would be left to registerFilter, which would just cause
the second one to win.
Also, avoid a getFilter warning when the filter does not exist.
Do the same for getFilterGroup on ChangesListSpecialPage
Finally, a minor related doc fix.
Change-Id: I6b3880a5c7cc381c169bbd969cd4814559b49c91
Aleksey Bekh-Ivanov (WMDE) [Wed, 15 Mar 2017 19:26:55 +0000 (19:26 +0000)]
Revert "Default to CACHE_ACCEL if user skips advanced settings"
This reverts commit
1fec847c6b366ab21bb215b94837a186545096f4.
Bug: T160519
Change-Id: I3bbfb5c5b61b8587ddc4af4fa134de6c86f46d98
jenkins-bot [Thu, 16 Mar 2017 06:03:19 +0000 (06:03 +0000)]
Merge "RCFilters: Don't allow underscore in filter or group names"
jenkins-bot [Thu, 16 Mar 2017 06:00:19 +0000 (06:00 +0000)]
Merge "RCFilters: Test abstract class func directly, not in subclass tests"
Matthew Flaschen [Wed, 15 Mar 2017 04:23:29 +0000 (00:23 -0400)]
RCFilters: Don't allow underscore in filter or group names
This is reserved for the client-side which joins 'someGroup'
and 'somefilter' to make 'someGroup__somefilter' as an internal
ID.
Change-Id: I1b6ca9f337dd48e10705c46ef5027c3156254e01
Matthew Flaschen [Thu, 16 Mar 2017 00:15:16 +0000 (20:15 -0400)]
RCFilters: Test abstract class func directly, not in subclass tests
Change-Id: I8f526975bbf0a5392b69d239bc9db9771c99cdd9
jenkins-bot [Thu, 16 Mar 2017 00:15:18 +0000 (00:15 +0000)]
Merge "Mark WikiRevision methods as public"
jenkins-bot [Thu, 16 Mar 2017 00:05:54 +0000 (00:05 +0000)]
Merge "jquery.ui: Add previously undocumented changes in PATCHES"
Timo Tijhof [Wed, 15 Mar 2017 23:52:31 +0000 (16:52 -0700)]
jquery.ui: Add previously undocumented changes in PATCHES
Change-Id: I8d9561916820212842f87fa2306ff7474b268173
jenkins-bot [Wed, 15 Mar 2017 22:34:16 +0000 (22:34 +0000)]
Merge "Change 'history-show-deleted' message to 'Revision deleted only' for clarity"
Translation updater bot [Wed, 15 Mar 2017 20:55:50 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ie2f9d001e9396e7a28d4c83deeae9acef01b76c7
jenkins-bot [Wed, 15 Mar 2017 20:07:49 +0000 (20:07 +0000)]
Merge "Revert "Improve sorting on SpecialWanted*-Pages""
20after4 [Wed, 15 Mar 2017 19:29:04 +0000 (19:29 +0000)]
Revert "Improve sorting on SpecialWanted*-Pages"
This reverts commit
5b15728478f9b167389268fb988a7b9f9f78fcf5. The change causes db query errors:
DBQueryError: 1054 Unknown column qc_ra.rd_namespace in order clause
Change-Id: I068beeae70037c959d42419791911c54ca9908a1
jenkins-bot [Wed, 15 Mar 2017 19:26:10 +0000 (19:26 +0000)]
Merge "Make infused and non-infused DateInputWidget consistent"
jenkins-bot [Wed, 15 Mar 2017 17:58:03 +0000 (17:58 +0000)]
Merge "Skin: Only load jquery.makeCollapsible if needed"
jenkins-bot [Wed, 15 Mar 2017 17:57:59 +0000 (17:57 +0000)]
Merge "Skin: Preload jquery.tablesorter based on rough heuristics"
Brian Wolff [Mon, 13 Mar 2017 04:29:43 +0000 (04:29 +0000)]
Make selectRowCount() (hopefully) work in MSSQL.
Make table and column aliases be quoted identifiers. This
is needed for MSSQL (rowcount is a reserved word), and is
generally just a good idea.
I have tested this on MySql and SQLite. I don't have
MSSQL installed to test on.
Bug: T158766
Change-Id: Ic63f63d208ba6ad15e77eb634e94855ee2728d05
addshore [Wed, 15 Mar 2017 14:53:19 +0000 (14:53 +0000)]
Mark WikiRevision methods as public
Change-Id: If252103d4850d9c9f0607a225b7d345736658cc7
jenkins-bot [Wed, 15 Mar 2017 11:24:45 +0000 (11:24 +0000)]
Merge "RCFilters UI: Use data-feature-in-structured-ui in the frontend"
jenkins-bot [Wed, 15 Mar 2017 11:23:53 +0000 (11:23 +0000)]
Merge "RCFilters UI: Adjust popup positioning again"
jenkins-bot [Wed, 15 Mar 2017 08:22:01 +0000 (08:22 +0000)]
Merge "mw.loader: Add tests for mw.loader StringSet fallback"