# $res might contain the whole 1,000 rows, so we read up to
# $num [should update this to use a Pager]
- // @codingStandardsIgnoreStart Generic.CodeAnalysis.ForLoopWithTestFunctionCall.NotAllowed
- for ( $i = 0; $i < $num && $row = $dbr->fetchObject( $res ); $i++ ) {
- // @codingStandardsIgnoreEnd
+ $i = 0;
+ foreach ( $res as $row ) {
+ $i++;
$namespace = isset( $row->namespace ) ? $row->namespace : NS_FILE;
$title = Title::makeTitleSafe( $namespace, $row->title );
if ( $title instanceof Title && $title->getNamespace() == NS_FILE ) {
$gallery->add( $title, $this->getCellHtml( $row ) );
}
+ if ( $i === $num ) {
+ break;
+ }
}
$out->addHTML( $gallery->toHtml() );