From: Bartosz Dziewoński <matma.rex@gmail.com>
Date: Wed, 26 Sep 2018 13:14:05 +0000 (+0200)
Subject: Fix double-wrapped HtmlArmor causing fatals
X-Git-Tag: 1.34.0-rc.0~3980
X-Git-Url: https://git.cyclocoop.org/%7B%24www_url%7Dadmin/compta/banques/D%D1%83%D0%BD%D0%B0?a=commitdiff_plain;h=3f8d6fa8f5ccd3d4bbb3ae5d437298491cb9452d;p=lhc%2Fweb%2Fwiklou.git

Fix double-wrapped HtmlArmor causing fatals

Follow-up to a89ef9b3b9cc4702c0f23443ae51df4f3bed7ecb. I'm guessing
this is supposed to be htmlspecialchars() based on the changes to
other files in that patch (e.g. SpecialAncientpages.php).

Bug: T205469
Change-Id: I52e38a5754b339e1516498e6f0eb73fc8d8df59c
---

diff --git a/includes/specials/SpecialMostlinkedcategories.php b/includes/specials/SpecialMostlinkedcategories.php
index 52300f90eb..56a701a304 100644
--- a/includes/specials/SpecialMostlinkedcategories.php
+++ b/includes/specials/SpecialMostlinkedcategories.php
@@ -85,7 +85,7 @@ class MostlinkedCategoriesPage extends QueryPage {
 		}
 
 		$text = MediaWikiServices::getInstance()->getContentLanguage()
-			->convert( new HtmlArmor( $nt->getText() ) );
+			->convert( htmlspecialchars( $nt->getText() ) );
 		$plink = $this->getLinkRenderer()->makeLink( $nt, new HtmlArmor( $text ) );
 		$nlinks = $this->msg( 'nmembers' )->numParams( $result->value )->escaped();