From add9bd191fd4d16250b301208600854cb52f6b33 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Wed, 29 Aug 2018 05:46:30 +0100 Subject: [PATCH] resources: Strip '$' and 'mw' from file closures Follows-up Id6d13bbea6: - '$': mw.loader.implement does this already. - 'mw': Use the canonical name directly. This replaces the following patterns: File closures (common): - `( function ( $, mw ) {` => `( function () {` - `( function ( $ ) {` => `( function () {` - `( function ( mw ) {` => `( function () {` - `( function ( mw, $ ) {` => `( function () {` File closures (rare): - `( function ( mw, $, OO ) {` => `( function () {` - `( function ( mw, OO, $ ) {` => `( function () {` - `( function ( mw, document ) {` => `( function () {` Combined dom-ready and file closure (rare): - `jQuery( function ( $ ) {` => `$( function () { - `jQuery( function () {` => `$( function () { Remaining references in files without a closure, as found by the new ESLint setting (rare): - `jQuery` => `$` - `mediaWiki` => `mw` Change-Id: I7cf2426cde597259e8c6f3f6f615a1a81a0ca82b --- .eslintrc.json | 2 -- mw-config/config.js | 4 ++-- resources/src/jquery.spinner/spinner.js | 4 ++-- .../src/jquery.tablesorter/jquery.tablesorter.js | 4 ++-- resources/src/jquery.tipsy/jquery.tipsy.js | 4 ++-- resources/src/jquery/jquery.accessKeyLabel.js | 4 ++-- resources/src/jquery/jquery.byteLength.js | 2 +- resources/src/jquery/jquery.checkboxShiftClick.js | 4 ++-- resources/src/jquery/jquery.color.js | 4 ++-- resources/src/jquery/jquery.colorUtil.js | 4 ++-- resources/src/jquery/jquery.confirmable.js | 4 ++-- resources/src/jquery/jquery.confirmable.mediawiki.js | 4 ++-- resources/src/jquery/jquery.getAttrs.js | 4 ++-- resources/src/jquery/jquery.hidpi.js | 4 ++-- resources/src/jquery/jquery.highlightText.js | 4 ++-- resources/src/jquery/jquery.lengthLimit.js | 4 ++-- resources/src/jquery/jquery.localize.js | 4 ++-- resources/src/jquery/jquery.makeCollapsible.js | 4 ++-- resources/src/jquery/jquery.mw-jump.js | 2 +- resources/src/jquery/jquery.suggestions.js | 4 ++-- resources/src/jquery/jquery.tabIndex.js | 4 ++-- resources/src/jquery/jquery.textSelection.js | 4 ++-- resources/src/mediawiki.ForeignApi.core.js | 4 ++-- .../BookletLayout.js | 4 ++-- resources/src/mediawiki.ForeignStructuredUpload.js | 4 ++-- resources/src/mediawiki.ForeignUpload.js | 4 ++-- resources/src/mediawiki.RegExp.js | 4 ++-- resources/src/mediawiki.Title/Title.js | 4 ++-- resources/src/mediawiki.Title/phpCharToUpper.js | 4 ++-- .../mediawiki.Upload.BookletLayout/BookletLayout.js | 4 ++-- resources/src/mediawiki.Upload.Dialog.js | 4 ++-- resources/src/mediawiki.Upload.js | 4 ++-- resources/src/mediawiki.Uri/Uri.js | 4 ++-- .../mediawiki.action/mediawiki.action.delete.file.js | 4 ++-- .../src/mediawiki.action/mediawiki.action.delete.js | 4 ++-- .../mediawiki.action.edit.collapsibleFooter.js | 4 ++-- .../mediawiki.action.edit.editWarning.js | 4 ++-- .../src/mediawiki.action/mediawiki.action.edit.js | 4 ++-- .../mediawiki.action.edit.preview.js | 4 ++-- .../mediawiki.action/mediawiki.action.edit.stash.js | 4 ++-- .../src/mediawiki.action/mediawiki.action.history.js | 2 +- .../mediawiki.action.view.dblClickEdit.js | 4 ++-- .../mediawiki.action.view.metadata.js | 4 ++-- .../mediawiki.action.view.postEdit.js | 4 ++-- .../mediawiki.action.view.redirect.js | 4 ++-- .../mediawiki.action.view.rightClickEdit.js | 4 ++-- resources/src/mediawiki.api/category.js | 4 ++-- resources/src/mediawiki.api/edit.js | 4 ++-- resources/src/mediawiki.api/index.js | 4 ++-- resources/src/mediawiki.api/login.js | 4 ++-- resources/src/mediawiki.api/messages.js | 4 ++-- resources/src/mediawiki.api/options.js | 4 ++-- resources/src/mediawiki.api/parse.js | 4 ++-- resources/src/mediawiki.api/rollback.js | 4 ++-- resources/src/mediawiki.api/upload.js | 4 ++-- resources/src/mediawiki.api/user.js | 4 ++-- resources/src/mediawiki.api/watch.js | 4 ++-- resources/src/mediawiki.checkboxtoggle.js | 4 ++-- resources/src/mediawiki.confirmCloseWindow.js | 4 ++-- resources/src/mediawiki.cookie.js | 4 ++-- resources/src/mediawiki.debug/debug.js | 4 ++-- resources/src/mediawiki.debug/jquery.footHovzer.js | 4 ++-- resources/src/mediawiki.experiments.js | 4 ++-- resources/src/mediawiki.feedback/feedback.js | 4 ++-- resources/src/mediawiki.filewarning/filewarning.js | 6 +++--- resources/src/mediawiki.htmlform.checker.js | 4 ++-- resources/src/mediawiki.htmlform.ooui/Element.js | 4 ++-- resources/src/mediawiki.htmlform/autocomplete.js | 4 ++-- resources/src/mediawiki.htmlform/autoinfuse.js | 4 ++-- resources/src/mediawiki.htmlform/checkmatrix.js | 4 ++-- resources/src/mediawiki.htmlform/cloner.js | 4 ++-- resources/src/mediawiki.htmlform/hide-if.js | 8 ++++---- resources/src/mediawiki.htmlform/htmlform.js | 4 ++-- resources/src/mediawiki.htmlform/multiselect.js | 4 ++-- resources/src/mediawiki.htmlform/selectandother.js | 4 ++-- resources/src/mediawiki.htmlform/selectorother.js | 4 ++-- resources/src/mediawiki.inspect.js | 4 ++-- .../src/mediawiki.jqueryMsg/mediawiki.jqueryMsg.js | 12 ++++++------ resources/src/mediawiki.language/mediawiki.cldr.js | 4 ++-- .../mediawiki.language.fallback.js | 4 ++-- .../mediawiki.language/mediawiki.language.init.js | 4 ++-- .../src/mediawiki.language/mediawiki.language.js | 6 +++--- .../mediawiki.language/mediawiki.language.months.js | 4 ++-- .../mediawiki.language/mediawiki.language.numbers.js | 4 ++-- resources/src/mediawiki.legacy/protect.js | 4 ++-- resources/src/mediawiki.legacy/wikibits.js | 4 ++-- resources/src/mediawiki.libs.jpegmeta/export.js | 4 ++-- .../src/mediawiki.libs.pluralruleparser/export.js | 2 +- .../WikitextMessagePoster.js | 4 ++-- .../src/mediawiki.messagePoster/MessagePoster.js | 4 ++-- resources/src/mediawiki.messagePoster/factory.js | 4 ++-- .../src/mediawiki.notification.convertmessagebox.js | 4 ++-- resources/src/mediawiki.notification/notification.js | 4 ++-- resources/src/mediawiki.notify.js | 4 ++-- resources/src/mediawiki.page.gallery.js | 4 ++-- resources/src/mediawiki.page.gallery.slideshow.js | 4 ++-- resources/src/mediawiki.page.image.pagination.js | 4 ++-- resources/src/mediawiki.page.patrol.ajax.js | 4 ++-- resources/src/mediawiki.page.ready.js | 4 ++-- resources/src/mediawiki.page.rollback.js | 4 ++-- resources/src/mediawiki.page.startup.js | 4 ++-- resources/src/mediawiki.page.watch.ajax.js | 4 ++-- .../dm/mw.rcfilters.dm.ChangesListViewModel.js | 4 ++-- .../dm/mw.rcfilters.dm.FilterGroup.js | 4 ++-- .../dm/mw.rcfilters.dm.FilterItem.js | 4 ++-- .../dm/mw.rcfilters.dm.FiltersViewModel.js | 4 ++-- .../dm/mw.rcfilters.dm.ItemModel.js | 4 ++-- .../dm/mw.rcfilters.dm.SavedQueriesModel.js | 4 ++-- .../dm/mw.rcfilters.dm.SavedQueryItemModel.js | 4 ++-- .../mediawiki.rcfilters/mw.rcfilters.Controller.js | 4 ++-- .../mw.rcfilters.HighlightColors.js | 4 ++-- .../mediawiki.rcfilters/mw.rcfilters.UriProcessor.js | 4 ++-- .../src/mediawiki.rcfilters/mw.rcfilters.init.js | 4 ++-- resources/src/mediawiki.rcfilters/mw.rcfilters.js | 4 ++-- ...w.rcfilters.ui.ChangesLimitAndDateButtonWidget.js | 4 ++-- .../ui/mw.rcfilters.ui.ChangesLimitPopupWidget.js | 4 ++-- .../ui/mw.rcfilters.ui.ChangesListWrapperWidget.js | 4 ++-- .../ui/mw.rcfilters.ui.CheckboxInputWidget.js | 4 ++-- .../ui/mw.rcfilters.ui.DatePopupWidget.js | 4 ++-- .../ui/mw.rcfilters.ui.FilterItemHighlightButton.js | 4 ++-- .../ui/mw.rcfilters.ui.FilterMenuHeaderWidget.js | 4 ++-- .../ui/mw.rcfilters.ui.FilterMenuOptionWidget.js | 4 ++-- .../mw.rcfilters.ui.FilterMenuSectionOptionWidget.js | 4 ++-- .../ui/mw.rcfilters.ui.FilterTagItemWidget.js | 4 ++-- .../ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js | 4 ++-- .../ui/mw.rcfilters.ui.FilterWrapperWidget.js | 4 ++-- .../ui/mw.rcfilters.ui.FormWrapperWidget.js | 4 ++-- .../ui/mw.rcfilters.ui.GroupWidget.js | 4 ++-- .../ui/mw.rcfilters.ui.HighlightColorPickerWidget.js | 4 ++-- .../ui/mw.rcfilters.ui.HighlightPopupWidget.js | 4 ++-- .../ui/mw.rcfilters.ui.ItemMenuOptionWidget.js | 4 ++-- .../ui/mw.rcfilters.ui.LiveUpdateButtonWidget.js | 4 ++-- .../ui/mw.rcfilters.ui.MainWrapperWidget.js | 4 ++-- .../ui/mw.rcfilters.ui.MarkSeenButtonWidget.js | 4 ++-- .../ui/mw.rcfilters.ui.MenuSelectWidget.js | 4 ++-- .../ui/mw.rcfilters.ui.RcTopSectionWidget.js | 4 ++-- .../ui/mw.rcfilters.ui.RclTargetPageWidget.js | 4 ++-- .../ui/mw.rcfilters.ui.RclToOrFromWidget.js | 4 ++-- .../ui/mw.rcfilters.ui.RclTopSectionWidget.js | 4 ++-- .../mw.rcfilters.ui.SaveFiltersPopupButtonWidget.js | 4 ++-- .../ui/mw.rcfilters.ui.SavedLinksListItemWidget.js | 4 ++-- .../ui/mw.rcfilters.ui.SavedLinksListWidget.js | 4 ++-- .../ui/mw.rcfilters.ui.TagItemWidget.js | 4 ++-- .../ui/mw.rcfilters.ui.ValuePickerWidget.js | 4 ++-- .../ui/mw.rcfilters.ui.ViewSwitchWidget.js | 4 ++-- .../ui/mw.rcfilters.ui.WatchlistTopSectionWidget.js | 4 ++-- .../src/mediawiki.searchSuggest/searchSuggest.js | 4 ++-- .../src/mediawiki.special.apisandbox/apisandbox.js | 4 ++-- resources/src/mediawiki.special.block.js | 4 ++-- resources/src/mediawiki.special.changecredentials.js | 4 ++-- .../src/mediawiki.special.changeslist.legend.js | 4 ++-- resources/src/mediawiki.special.contributions.js | 4 ++-- resources/src/mediawiki.special.edittags.js | 4 ++-- resources/src/mediawiki.special.import.js | 4 ++-- resources/src/mediawiki.special.movePage.js | 4 ++-- resources/src/mediawiki.special.pageLanguage.js | 4 ++-- .../mediawiki.special.preferences.ooui/editfont.js | 4 ++-- .../src/mediawiki.special.preferences.ooui/tabs.js | 4 ++-- .../mediawiki.special.preferences/confirmClose.js | 4 ++-- .../convertmessagebox.js | 4 ++-- .../mediawiki.special.preferences/personalEmail.js | 4 ++-- .../src/mediawiki.special.preferences/tabs.legacy.js | 4 ++-- .../src/mediawiki.special.preferences/timezone.js | 4 ++-- resources/src/mediawiki.special.recentchanges.js | 4 ++-- resources/src/mediawiki.special.revisionDelete.js | 4 ++-- ...ediawiki.special.search.commonsInterwikiWidget.js | 4 ++-- resources/src/mediawiki.special.search/search.js | 4 ++-- resources/src/mediawiki.special.undelete.js | 4 ++-- .../unwatchedPages.js | 4 ++-- resources/src/mediawiki.special.upload/upload.js | 4 ++-- resources/src/mediawiki.special.userlogin.signup.js | 4 ++-- resources/src/mediawiki.special.userrights.js | 4 ++-- .../src/mediawiki.special.watchlist/visitedstatus.js | 4 ++-- .../src/mediawiki.special.watchlist/watchlist.js | 5 ++--- resources/src/mediawiki.storage.js | 4 ++-- resources/src/mediawiki.template.js | 4 ++-- resources/src/mediawiki.template.mustache.js | 4 ++-- resources/src/mediawiki.template.regexp.js | 2 +- resources/src/mediawiki.toc/toc.js | 4 ++-- resources/src/mediawiki.toolbar/toolbar.js | 4 ++-- resources/src/mediawiki.user.js | 4 ++-- resources/src/mediawiki.userSuggest.js | 4 ++-- resources/src/mediawiki.util.js | 4 ++-- resources/src/mediawiki.viewport.js | 4 ++-- resources/src/mediawiki.visibleTimeout.js | 5 +++-- .../src/mediawiki.widgets.datetime/CalendarWidget.js | 4 ++-- .../mediawiki.widgets.datetime/DateTimeFormatter.js | 4 ++-- .../DateTimeInputWidget.js | 4 ++-- .../DiscordianDateTimeFormatter.js | 4 ++-- .../ProlepticGregorianDateTimeFormatter.js | 4 ++-- .../mediawiki.widgets.datetime.js | 2 +- .../mediawiki.widgets.visibleLengthLimit.js | 4 ++-- .../MediaSearch/mw.widgets.APIResultsProvider.js | 4 ++-- .../MediaSearch/mw.widgets.APIResultsQueue.js | 4 ++-- .../MediaSearch/mw.widgets.MediaResourceProvider.js | 4 ++-- .../MediaSearch/mw.widgets.MediaResourceQueue.js | 4 ++-- .../MediaSearch/mw.widgets.MediaResultWidget.js | 4 ++-- .../MediaSearch/mw.widgets.MediaSearchProvider.js | 4 ++-- .../MediaSearch/mw.widgets.MediaSearchQueue.js | 4 ++-- .../MediaSearch/mw.widgets.MediaSearchWidget.js | 4 ++-- .../mediawiki.widgets/mw.widgets.CalendarWidget.js | 4 ++-- .../mw.widgets.CategoryMultiselectWidget.js | 4 ++-- .../mw.widgets.CategoryTagItemWidget.js | 4 ++-- .../mw.widgets.CheckMatrixWidget.js | 4 ++-- .../mw.widgets.ComplexNamespaceInputWidget.js | 4 ++-- .../mw.widgets.ComplexTitleInputWidget.js | 4 ++-- .../mediawiki.widgets/mw.widgets.DateInputWidget.js | 4 ++-- .../mw.widgets.ExpiryInputWidget.js | 4 ++-- .../mw.widgets.NamespaceInputWidget.js | 4 ++-- .../mw.widgets.SearchInputWidget.js | 4 ++-- .../mw.widgets.SelectWithInputWidget.js | 4 ++-- .../mediawiki.widgets/mw.widgets.SizeFilterWidget.js | 4 ++-- .../mw.widgets.StashedFileWidget.js | 4 ++-- .../mediawiki.widgets/mw.widgets.TitleInputWidget.js | 4 ++-- .../mw.widgets.TitleOptionWidget.js | 4 ++-- .../mw.widgets.TitleSearchWidget.js | 4 ++-- .../src/mediawiki.widgets/mw.widgets.TitleWidget.js | 4 ++-- .../mediawiki.widgets/mw.widgets.UserInputWidget.js | 4 ++-- .../mw.widgets.UsersMultiselectWidget.js | 4 ++-- resources/src/moment/moment-locale-overrides.js | 6 +++--- resources/src/ooui-local.js | 4 ++-- tests/qunit/data/mwLoaderTestCallback.js | 2 +- tests/qunit/data/testrunner.js | 4 ++-- .../resources/jquery/jquery.accessKeyLabel.test.js | 4 ++-- .../suites/resources/jquery/jquery.color.test.js | 4 ++-- .../suites/resources/jquery/jquery.colorUtil.test.js | 4 ++-- .../suites/resources/jquery/jquery.getAttrs.test.js | 4 ++-- .../suites/resources/jquery/jquery.hidpi.test.js | 4 ++-- .../resources/jquery/jquery.highlightText.test.js | 4 ++-- .../resources/jquery/jquery.lengthLimit.test.js | 4 ++-- .../suites/resources/jquery/jquery.localize.test.js | 4 ++-- .../resources/jquery/jquery.makeCollapsible.test.js | 4 ++-- .../suites/resources/jquery/jquery.tabIndex.test.js | 4 ++-- .../jquery/jquery.tablesorter.parsers.test.js | 4 ++-- .../resources/jquery/jquery.tablesorter.test.js | 4 ++-- .../resources/jquery/jquery.textSelection.test.js | 4 ++-- .../mediawiki.api/mediawiki.ForeignApi.test.js | 4 ++-- .../mediawiki.api/mediawiki.api.category.test.js | 4 ++-- .../mediawiki.api/mediawiki.api.edit.test.js | 4 ++-- .../mediawiki.api/mediawiki.api.messages.test.js | 4 ++-- .../mediawiki.api/mediawiki.api.options.test.js | 4 ++-- .../mediawiki.api/mediawiki.api.parse.test.js | 4 ++-- .../resources/mediawiki.api/mediawiki.api.test.js | 6 +++--- .../mediawiki.api/mediawiki.api.upload.test.js | 4 ++-- .../mediawiki.api/mediawiki.api.watch.test.js | 4 ++-- .../mediawiki.rcfilters/UriProcessor.test.js | 4 ++-- .../mediawiki.rcfilters/dm.FilterItem.test.js | 4 ++-- .../mediawiki.rcfilters/dm.FiltersViewModel.test.js | 4 ++-- .../mediawiki.rcfilters/dm.SavedQueriesModel.test.js | 4 ++-- .../dm.SavedQueryItemModel.test.js | 4 ++-- .../mediawiki.special.recentchanges.test.js | 4 ++-- .../mediawiki.widgets.APIResultsQueue.test.js | 4 ++-- .../resources/mediawiki/mediawiki.RegExp.test.js | 4 ++-- .../mediawiki.String.trimByteLength.test.js | 4 ++-- .../resources/mediawiki/mediawiki.Title.test.js | 4 ++-- .../suites/resources/mediawiki/mediawiki.Uri.test.js | 4 ++-- .../resources/mediawiki/mediawiki.base.test.js | 4 ++-- .../resources/mediawiki/mediawiki.cldr.test.js | 4 ++-- .../resources/mediawiki/mediawiki.cookie.test.js | 4 ++-- .../mediawiki/mediawiki.errorLogger.test.js | 4 ++-- .../mediawiki/mediawiki.experiments.test.js | 4 ++-- .../resources/mediawiki/mediawiki.html.test.js | 4 ++-- .../resources/mediawiki/mediawiki.inspect.test.js | 4 ++-- .../resources/mediawiki/mediawiki.jqueryMsg.test.js | 4 ++-- .../resources/mediawiki/mediawiki.jscompat.test.js | 4 ++-- .../resources/mediawiki/mediawiki.language.test.js | 4 ++-- .../resources/mediawiki/mediawiki.loader.test.js | 4 ++-- .../mediawiki.messagePoster.factory.test.js | 4 ++-- .../mediawiki/mediawiki.requestIdleCallback.test.js | 4 ++-- .../resources/mediawiki/mediawiki.storage.test.js | 4 ++-- .../mediawiki/mediawiki.template.mustache.test.js | 4 ++-- .../resources/mediawiki/mediawiki.template.test.js | 4 ++-- .../suites/resources/mediawiki/mediawiki.test.js | 4 ++-- .../suites/resources/mediawiki/mediawiki.toc.test.js | 4 ++-- .../resources/mediawiki/mediawiki.track.test.js | 4 ++-- .../resources/mediawiki/mediawiki.user.test.js | 4 ++-- .../resources/mediawiki/mediawiki.util.test.js | 6 +++--- .../resources/mediawiki/mediawiki.viewport.test.js | 4 ++-- .../mediawiki/mediawiki.visibleTimeout.test.js | 4 ++-- 279 files changed, 561 insertions(+), 563 deletions(-) diff --git a/.eslintrc.json b/.eslintrc.json index 4630e071e5..c0767517ea 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -8,8 +8,6 @@ "module": false, "mw": false, "$": false, - "mediaWiki": false, - "jQuery": false, "OO": false }, "rules": { diff --git a/mw-config/config.js b/mw-config/config.js index 99290f4453..74bdcf85b1 100644 --- a/mw-config/config.js +++ b/mw-config/config.js @@ -1,5 +1,5 @@ /* global extDependencyMap */ -( function ( $ ) { +( function () { $( function () { var $label, labelText; @@ -148,4 +148,4 @@ } ); } ); } ); -}( jQuery ) ); +}() ); diff --git a/resources/src/jquery.spinner/spinner.js b/resources/src/jquery.spinner/spinner.js index 9079cc09b7..5024688677 100644 --- a/resources/src/jquery.spinner/spinner.js +++ b/resources/src/jquery.spinner/spinner.js @@ -5,7 +5,7 @@ * * @class jQuery.plugin.spinner */ -( function ( $ ) { +( function () { // Default options for new spinners, // stored outside the function to share between calls. @@ -111,4 +111,4 @@ * @mixins jQuery.plugin.spinner */ -}( jQuery ) ); +}() ); diff --git a/resources/src/jquery.tablesorter/jquery.tablesorter.js b/resources/src/jquery.tablesorter/jquery.tablesorter.js index cbdc2fa9b3..a37bcf7b1d 100644 --- a/resources/src/jquery.tablesorter/jquery.tablesorter.js +++ b/resources/src/jquery.tablesorter/jquery.tablesorter.js @@ -43,7 +43,7 @@ * * @author Christian Bach/christian.bach@polyester.se */ -( function ( $, mw ) { +( function () { var ts, parsers = []; @@ -1281,4 +1281,4 @@ type: 'numeric' } ); -}( jQuery, mediaWiki ) ); +}() ); diff --git a/resources/src/jquery.tipsy/jquery.tipsy.js b/resources/src/jquery.tipsy/jquery.tipsy.js index ddda432f32..a5e51843de 100644 --- a/resources/src/jquery.tipsy/jquery.tipsy.js +++ b/resources/src/jquery.tipsy/jquery.tipsy.js @@ -6,7 +6,7 @@ // * This installation of tipsy includes several local modifications to both Javascript and CSS. // Please be careful when upgrading. -( function ( mw, $ ) { +( function () { function maybeCall(thing, ctx) { return (typeof thing == 'function') ? (thing.call(ctx)) : thing; @@ -278,4 +278,4 @@ } }; -}( mediaWiki, jQuery ) ); +}() ); diff --git a/resources/src/jquery/jquery.accessKeyLabel.js b/resources/src/jquery/jquery.accessKeyLabel.js index 674f62cd74..cdc5808ca7 100644 --- a/resources/src/jquery/jquery.accessKeyLabel.js +++ b/resources/src/jquery/jquery.accessKeyLabel.js @@ -3,7 +3,7 @@ * * @class jQuery.plugin.accessKeyLabel */ -( function ( $, mw ) { +( function () { // Cached access key modifiers for used browser var cachedAccessKeyModifiers, @@ -236,4 +236,4 @@ * @mixins jQuery.plugin.accessKeyLabel */ -}( jQuery, mediaWiki ) ); +}() ); diff --git a/resources/src/jquery/jquery.byteLength.js b/resources/src/jquery/jquery.byteLength.js index 5764ae90ad..2e1a338d56 100644 --- a/resources/src/jquery/jquery.byteLength.js +++ b/resources/src/jquery/jquery.byteLength.js @@ -12,7 +12,7 @@ * @param {string} str * @return {number} */ -mediaWiki.log.deprecate( jQuery, 'byteLength', require( 'mediawiki.String' ).byteLength, +mw.log.deprecate( $, 'byteLength', require( 'mediawiki.String' ).byteLength, 'Use require( \'mediawiki.String\' ).byteLength instead.', '$.byteLength' ); /** diff --git a/resources/src/jquery/jquery.checkboxShiftClick.js b/resources/src/jquery/jquery.checkboxShiftClick.js index d99e9f0a8b..63cf28c5b8 100644 --- a/resources/src/jquery/jquery.checkboxShiftClick.js +++ b/resources/src/jquery/jquery.checkboxShiftClick.js @@ -1,7 +1,7 @@ /** * @class jQuery.plugin.checkboxShiftClick */ -( function ( $ ) { +( function () { /** * Enable checkboxes to be checked or unchecked in a row by clicking one, @@ -40,4 +40,4 @@ * @mixins jQuery.plugin.checkboxShiftClick */ -}( jQuery ) ); +}() ); diff --git a/resources/src/jquery/jquery.color.js b/resources/src/jquery/jquery.color.js index 894cf863e8..6df02adf5b 100644 --- a/resources/src/jquery/jquery.color.js +++ b/resources/src/jquery/jquery.color.js @@ -7,7 +7,7 @@ * * - 2011-01-05: Forked for MediaWiki. See also jQuery.colorUtil plugin */ -( function ( $ ) { +( function () { function getColor( elem, attr ) { var color; @@ -52,4 +52,4 @@ }; } ); -}( jQuery ) ); +}() ); diff --git a/resources/src/jquery/jquery.colorUtil.js b/resources/src/jquery/jquery.colorUtil.js index d46d009909..009be1aa73 100644 --- a/resources/src/jquery/jquery.colorUtil.js +++ b/resources/src/jquery/jquery.colorUtil.js @@ -6,7 +6,7 @@ * Mostly based on other plugins and functions (linted and optimized a little). * Sources cited inline. */ -( function ( $ ) { +( function () { /** * @class jQuery.colorUtil * @singleton @@ -265,4 +265,4 @@ }; -}( jQuery ) ); +}() ); diff --git a/resources/src/jquery/jquery.confirmable.js b/resources/src/jquery/jquery.confirmable.js index 7931c8147f..028b4b9184 100644 --- a/resources/src/jquery/jquery.confirmable.js +++ b/resources/src/jquery/jquery.confirmable.js @@ -7,7 +7,7 @@ * * @class jQuery.plugin.confirmable */ -( function ( $ ) { +( function () { var identity = function ( data ) { return data; }; @@ -180,4 +180,4 @@ noTitle: undefined } }; -}( jQuery ) ); +}() ); diff --git a/resources/src/jquery/jquery.confirmable.mediawiki.js b/resources/src/jquery/jquery.confirmable.mediawiki.js index daf23a99c0..aa1e90e14c 100644 --- a/resources/src/jquery/jquery.confirmable.mediawiki.js +++ b/resources/src/jquery/jquery.confirmable.mediawiki.js @@ -4,7 +4,7 @@ * This file serves to inject our localised messages into it. */ -( function ( mw, $ ) { +( function () { $.fn.confirmable.defaultOptions.i18n = { space: mw.message( 'word-separator' ).text(), confirm: mw.message( 'confirmable-confirm', mw.user ).text(), @@ -13,4 +13,4 @@ yesTitle: undefined, noTitle: undefined }; -}( mediaWiki, jQuery ) ); +}() ); diff --git a/resources/src/jquery/jquery.getAttrs.js b/resources/src/jquery/jquery.getAttrs.js index e00298f406..e464c90bd1 100644 --- a/resources/src/jquery/jquery.getAttrs.js +++ b/resources/src/jquery/jquery.getAttrs.js @@ -1,7 +1,7 @@ /** * @class jQuery.plugin.getAttrs */ -( function ( $ ) { +( function () { function serializeControls( controls ) { var i, data = {}, @@ -34,4 +34,4 @@ $.fn.serializeObject = function () { return serializeControls( this.serializeArray() ); }; -}( jQuery ) ); +}() ); diff --git a/resources/src/jquery/jquery.hidpi.js b/resources/src/jquery/jquery.hidpi.js index 7a7109cbc3..025e6c23e1 100644 --- a/resources/src/jquery/jquery.hidpi.js +++ b/resources/src/jquery/jquery.hidpi.js @@ -9,7 +9,7 @@ * * @class jQuery.plugin.hidpi */ -( function ( $ ) { +( function () { /** * Get reported or approximate device pixel ratio. @@ -174,4 +174,4 @@ * @mixins jQuery.plugin.hidpi */ -}( jQuery ) ); +}() ); diff --git a/resources/src/jquery/jquery.highlightText.js b/resources/src/jquery/jquery.highlightText.js index a14e3ebd38..782d7118fd 100644 --- a/resources/src/jquery/jquery.highlightText.js +++ b/resources/src/jquery/jquery.highlightText.js @@ -3,7 +3,7 @@ * TODO: Add a function for restoring the previous text. * TODO: Accept mappings for converting shortcuts like WP: to Wikipedia:. */ -( function ( $, mw ) { +( function () { $.highlightText = { @@ -94,4 +94,4 @@ } ); }; -}( jQuery, mediaWiki ) ); +}() ); diff --git a/resources/src/jquery/jquery.lengthLimit.js b/resources/src/jquery/jquery.lengthLimit.js index 3823395c6b..26f8f9b1f3 100644 --- a/resources/src/jquery/jquery.lengthLimit.js +++ b/resources/src/jquery/jquery.lengthLimit.js @@ -1,7 +1,7 @@ /** * @class jQuery.plugin.lengthLimit */ -( function ( $, mw ) { +( function () { var eventKeys = [ @@ -211,4 +211,4 @@ * @class jQuery * @mixins jQuery.plugin.lengthLimit */ -}( jQuery, mediaWiki ) ); +}() ); diff --git a/resources/src/jquery/jquery.localize.js b/resources/src/jquery/jquery.localize.js index 20dc1b20fe..ab269f0cff 100644 --- a/resources/src/jquery/jquery.localize.js +++ b/resources/src/jquery/jquery.localize.js @@ -1,7 +1,7 @@ /** * @class jQuery.plugin.localize */ -( function ( $, mw ) { +( function () { /** * Gets a localized message, using parameters from options if present. @@ -177,4 +177,4 @@ * @mixins jQuery.plugin.localize */ -}( jQuery, mediaWiki ) ); +}() ); diff --git a/resources/src/jquery/jquery.makeCollapsible.js b/resources/src/jquery/jquery.makeCollapsible.js index 082603a5a0..43b8f0d667 100644 --- a/resources/src/jquery/jquery.makeCollapsible.js +++ b/resources/src/jquery/jquery.makeCollapsible.js @@ -10,7 +10,7 @@ * * @class jQuery.plugin.makeCollapsible */ -( function ( $, mw ) { +( function () { /** * Handler for a click on a collapsible toggler. * @@ -364,4 +364,4 @@ * @mixins jQuery.plugin.makeCollapsible */ -}( jQuery, mediaWiki ) ); +}() ); diff --git a/resources/src/jquery/jquery.mw-jump.js b/resources/src/jquery/jquery.mw-jump.js index 5eae0bec8d..ad1c96dba4 100644 --- a/resources/src/jquery/jquery.mw-jump.js +++ b/resources/src/jquery/jquery.mw-jump.js @@ -1,7 +1,7 @@ /** * JavaScript to show jump links to motor-impaired users when they are focused. */ -jQuery( function ( $ ) { +$( function () { $( '.mw-jump' ).on( 'focus blur', 'a', function ( e ) { // Confusingly jQuery leaves e.type as focusout for delegated blur events diff --git a/resources/src/jquery/jquery.suggestions.js b/resources/src/jquery/jquery.suggestions.js index 35c6a5dfb7..f2d6a044f1 100644 --- a/resources/src/jquery/jquery.suggestions.js +++ b/resources/src/jquery/jquery.suggestions.js @@ -90,7 +90,7 @@ * input or not. */ -( function ( $, mw ) { +( function () { var hasOwn = Object.hasOwnProperty; @@ -775,4 +775,4 @@ * @mixins jQuery.plugin.suggestions */ -}( jQuery, mediaWiki ) ); +}() ); diff --git a/resources/src/jquery/jquery.tabIndex.js b/resources/src/jquery/jquery.tabIndex.js index 5fb28aa34b..dab437d4f0 100644 --- a/resources/src/jquery/jquery.tabIndex.js +++ b/resources/src/jquery/jquery.tabIndex.js @@ -1,7 +1,7 @@ /** * @class jQuery.plugin.tabIndex */ -( function ( $ ) { +( function () { /** * Find the lowest tabindex in use within a selection. @@ -54,4 +54,4 @@ * @mixins jQuery.plugin.tabIndex */ -}( jQuery ) ); +}() ); diff --git a/resources/src/jquery/jquery.textSelection.js b/resources/src/jquery/jquery.textSelection.js index da882708b9..6b4ab979a1 100644 --- a/resources/src/jquery/jquery.textSelection.js +++ b/resources/src/jquery/jquery.textSelection.js @@ -19,7 +19,7 @@ * $textbox.textSelection( 'encapsulateSelection', { pre: '', post: '' } ); * // Result: Textbox contains 'This is bold!', with cursor before the '!' */ -( function ( $ ) { +( function () { /** * Do things to the selection in a `